rojo-rbx/rojo
1
0
Fork 1
mirror of https://github.com/rojo-rbx/rojo.git synced 2026-04-23 22:25:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Special-case Lighting.Technology in setCanonicalProperty, temporary fix

Browse Source
This commit is contained in:
Lucien Greathouse
2019-03-29 17:25:57 -07:00
parent 913ac7c9f5
commit 6db714a2b1
2 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@@ -13,6 +13,7 @@
* `Ref` * `Ref`
* Improved server instance ordering behavior when files are added during a live session ([#135](https://github.com/LPGhatguy/rojo/pull/135)) * Improved server instance ordering behavior when files are added during a live session ([#135](https://github.com/LPGhatguy/rojo/pull/135))
* Fixed error being thrown when trying to unload the Rojo plugin. * Fixed error being thrown when trying to unload the Rojo plugin.
* Added partial fix for [issue #141](https://github.com/LPGhatguy/rojo/issues/141) for `Lighting.Technology`, which should restore live sync functionality for the default project file.
## [0.5.0 Alpha 6](https://github.com/LPGhatguy/rojo/releases/tag/v0.5.0-alpha.6) (March 19, 2019) ## [0.5.0 Alpha 6](https://github.com/LPGhatguy/rojo/releases/tag/v0.5.0-alpha.6) (March 19, 2019)
* Fixed `rojo init` giving unexpected results by upgrading to `rbx_dom_weak` 1.1.0 * Fixed `rojo init` giving unexpected results by upgrading to `rbx_dom_weak` 1.1.0

5
plugin/src/setCanonicalProperty.lua
View File

@@ -19,6 +19,11 @@ local function setCanonicalProperty(instance, key, value)
return return
end end
-- Temporary workaround for fixing issue #141 in this specific case.
if instance.ClassName == "Lighting" and key == "Technology" then
return
end
-- If we don't have permissions to access this value at all, we can skip it. -- If we don't have permissions to access this value at all, we can skip it.
local readSuccess, existingValue = pcall(function() local readSuccess, existingValue = pcall(function()
return instance[key] return instance[key]