From 6db714a2b1bf8d78d799fb8e0aa16a36398f786c Mon Sep 17 00:00:00 2001 From: Lucien Greathouse Date: Fri, 29 Mar 2019 17:25:57 -0700 Subject: [PATCH] Special-case Lighting.Technology in setCanonicalProperty, temporary fix --- CHANGELOG.md | 1 + plugin/src/setCanonicalProperty.lua | 5 +++++ 2 files changed, 6 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index a33ea483..82e7ea27 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,7 @@ * `Ref` * Improved server instance ordering behavior when files are added during a live session ([#135](https://github.com/LPGhatguy/rojo/pull/135)) * Fixed error being thrown when trying to unload the Rojo plugin. +* Added partial fix for [issue #141](https://github.com/LPGhatguy/rojo/issues/141) for `Lighting.Technology`, which should restore live sync functionality for the default project file. ## [0.5.0 Alpha 6](https://github.com/LPGhatguy/rojo/releases/tag/v0.5.0-alpha.6) (March 19, 2019) * Fixed `rojo init` giving unexpected results by upgrading to `rbx_dom_weak` 1.1.0 diff --git a/plugin/src/setCanonicalProperty.lua b/plugin/src/setCanonicalProperty.lua index d7e1e7d8..6e5eacd6 100644 --- a/plugin/src/setCanonicalProperty.lua +++ b/plugin/src/setCanonicalProperty.lua @@ -19,6 +19,11 @@ local function setCanonicalProperty(instance, key, value) return end + -- Temporary workaround for fixing issue #141 in this specific case. + if instance.ClassName == "Lighting" and key == "Technology" then + return + end + -- If we don't have permissions to access this value at all, we can skip it. local readSuccess, existingValue = pcall(function() return instance[key]