ari-party/rojo
1
0
Fork 0
forked from rojo-rbx/rojo
Code Pull Requests Activity

Support changing ClassName in Reconciler.diff

Browse Source
This commit is contained in:
Lucien Greathouse
2021-01-16 18:26:30 -07:00
parent 5989ab3b85
commit cc4f4df4f9
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
plugin/src/Reconciler/diff.lua
View File

@@ -52,8 +52,9 @@ local function diff(instanceMap, virtualInstances, rootId)
invariant("Cannot diff an instance not present in InstanceMap\nID: {}", id)
end
local changedClassName = nil
if virtualInstance.ClassName ~= instance.ClassName then
error("unimplemented: support changing ClassName")
changedClassName = virtualInstance.ClassName
end
local changedName = nil
@@ -89,11 +90,11 @@ local function diff(instanceMap, virtualInstances, rootId)
end
end
if changedName ~= nil or not isEmpty(changedProperties) then
if changedName ~= nil or changedClassName ~= nil or not isEmpty(changedProperties) then
table.insert(patch.updated, {
id = id,
changedName = changedName,
changedClassName = nil,
changedClassName = changedClassName,
changedProperties = changedProperties,
changedMetadata = nil,
})