ari-party/rojo
1
0
Fork 0
forked from rojo-rbx/rojo
Code Pull Requests Activity

Fix clippy lint warnings (#1004)

Browse Source
This commit is contained in:
Jack T
2025-01-13 10:07:53 -08:00
committed by GitHub
parent f33d1f1cc4
commit 55a207a275
18 changed files with 69 additions and 76 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
crates/rojo-insta-ext/src/redaction_map.rs
View File

@@ -5,19 +5,13 @@ use serde::Serialize;
/// Enables redacting any value that serializes as a string.
///
/// Used for transforming Rojo instance IDs into something deterministic.
#[derive(Default)]
pub struct RedactionMap {
ids: HashMap<String, usize>,
last_id: usize,
}
impl RedactionMap {
pub fn new() -> Self {
Self {
ids: HashMap::new(),
last_id: 0,
}
}
pub fn get_redacted_value(&self, id: impl ToString) -> Option<String> {
let id = id.to_string();

1
src/lua_ast.rs
View File

@@ -22,6 +22,7 @@ trait FmtLua {
}
}
#[allow(dead_code)]
struct DisplayLua<T>(T);
impl<T> fmt::Display for DisplayLua<T>

4
src/multimap.rs
View File

@@ -19,10 +19,10 @@ impl<K: Hash + Eq, V: Eq> MultiMap<K, V> {
}
}
pub fn get<Q: ?Sized>(&self, k: &Q) -> &[V]
pub fn get<Q>(&self, k: &Q) -> &[V]
where
K: Borrow<Q>,
Q: Hash + Eq,
Q: Hash + Eq + ?Sized,
{
self.inner.get(k).map(Vec::as_slice).unwrap_or(&[])
}

4
src/project.rs
View File

@@ -230,7 +230,7 @@ impl Project {
io::ErrorKind::NotFound => Error::NoProjectFound {
path: project_path.to_path_buf(),
},
_ => return e.into(),
_ => e.into(),
})?;
Ok(Some(Self::load_from_slice(&contents, project_path, None)?))
@@ -250,7 +250,7 @@ impl Project {
io::ErrorKind::NotFound => Error::NoProjectFound {
path: project_path.to_path_buf(),
},
_ => return e.into(),
_ => e.into(),
})?;
Ok(Self::load_from_slice(

4
src/snapshot/patch_compute.rs
View File

@@ -313,7 +313,7 @@ mod test {
// addition of a prop named Self, which is a self-referential Ref.
let snapshot_id = Ref::new();
let snapshot = InstanceSnapshot {
snapshot_id: snapshot_id,
snapshot_id,
properties: [("Self".to_owned(), Variant::Ref(snapshot_id))].into(),
metadata: Default::default(),
@@ -351,7 +351,7 @@ mod test {
// This patch describes the existing instance with a new child added.
let snapshot_id = Ref::new();
let snapshot = InstanceSnapshot {
snapshot_id: snapshot_id,
snapshot_id,
children: vec![InstanceSnapshot {
properties: [("Self".to_owned(), Variant::Ref(snapshot_id))].into(),

8
src/snapshot/tests/apply.rs
View File

@@ -9,7 +9,7 @@ use crate::{
#[test]
fn set_name_and_class_name() {
let mut redactions = RedactionMap::new();
let mut redactions = RedactionMap::default();
let mut tree = empty_tree();
intern_tree(&tree, &mut redactions);
@@ -36,7 +36,7 @@ fn set_name_and_class_name() {
#[test]
fn add_property() {
let mut redactions = RedactionMap::new();
let mut redactions = RedactionMap::default();
let mut tree = empty_tree();
intern_tree(&tree, &mut redactions);
@@ -63,7 +63,7 @@ fn add_property() {
#[test]
fn remove_property() {
let mut redactions = RedactionMap::new();
let mut redactions = RedactionMap::default();
let mut tree = empty_tree();
intern_tree(&tree, &mut redactions);
@@ -85,7 +85,7 @@ fn remove_property() {
id: tree.get_root_id(),
changed_name: None,
changed_class_name: None,
changed_properties: [("Foo".to_owned(), None).into()].into(),
changed_properties: [("Foo".to_owned(), None)].into(),
changed_metadata: None,
}],
..Default::default()

10
src/snapshot/tests/compute.rs
View File

@@ -9,7 +9,7 @@ use crate::snapshot::{compute_patch_set, InstanceSnapshot, RojoTree};
#[test]
fn set_name_and_class_name() {
let mut redactions = RedactionMap::new();
let mut redactions = RedactionMap::default();
let tree = empty_tree();
redactions.intern(tree.get_root_id());
@@ -31,7 +31,7 @@ fn set_name_and_class_name() {
#[test]
fn set_property() {
let mut redactions = RedactionMap::new();
let mut redactions = RedactionMap::default();
let tree = empty_tree();
redactions.intern(tree.get_root_id());
@@ -53,7 +53,7 @@ fn set_property() {
#[test]
fn remove_property() {
let mut redactions = RedactionMap::new();
let mut redactions = RedactionMap::default();
let mut tree = empty_tree();
redactions.intern(tree.get_root_id());
@@ -84,7 +84,7 @@ fn remove_property() {
#[test]
fn add_child() {
let mut redactions = RedactionMap::new();
let mut redactions = RedactionMap::default();
let tree = empty_tree();
redactions.intern(tree.get_root_id());
@@ -113,7 +113,7 @@ fn add_child() {
#[test]
fn remove_child() {
let mut redactions = RedactionMap::new();
let mut redactions = RedactionMap::default();
let mut tree = empty_tree();
redactions.intern(tree.get_root_id());

4
src/snapshot/tree.rs
View File

@@ -148,7 +148,7 @@ impl RojoTree {
// We need to uphold the invariant that each ID can only map
// to one referent.
if let Some(new) = &metadata.specified_id {
if self.specified_id_to_refs.get(new).len() > 0 {
if !self.specified_id_to_refs.get(new).is_empty() {
log::error!("Duplicate user-specified referent '{new}'");
}
@@ -206,7 +206,7 @@ impl RojoTree {
}
if let Some(specified_id) = &metadata.specified_id {
if self.specified_id_to_refs.get(specified_id).len() > 0 {
if !self.specified_id_to_refs.get(specified_id).is_empty() {
log::error!("Duplicate user-specified referent '{specified_id}'");
}

8
src/snapshot_middleware/csv.rs
View File

@@ -177,11 +177,11 @@ Ack,Ack!,,An exclamation of despair,¡Ay!"#,
)
.unwrap();
let mut vfs = Vfs::new(imfs);
let vfs = Vfs::new(imfs);
let instance_snapshot = snapshot_csv(
&InstanceContext::default(),
&mut vfs,
&vfs,
Path::new("/foo.csv"),
"foo",
)
@@ -209,11 +209,11 @@ Ack,Ack!,,An exclamation of despair,¡Ay!"#,
)
.unwrap();
let mut vfs = Vfs::new(imfs);
let vfs = Vfs::new(imfs);
let instance_snapshot = snapshot_csv(
&InstanceContext::default(),
&mut vfs,
&vfs,
Path::new("/foo.csv"),
"foo",
)

18
src/snapshot_middleware/dir.rs
View File

@@ -116,12 +116,11 @@ mod test {
imfs.load_snapshot("/foo", VfsSnapshot::empty_dir())
.unwrap();
let mut vfs = Vfs::new(imfs);
let vfs = Vfs::new(imfs);
let instance_snapshot =
snapshot_dir(&InstanceContext::default(), &mut vfs, Path::new("/foo"))
.unwrap()
.unwrap();
let instance_snapshot = snapshot_dir(&InstanceContext::default(), &vfs, Path::new("/foo"))
.unwrap()
.unwrap();
insta::assert_yaml_snapshot!(instance_snapshot);
}
@@ -135,12 +134,11 @@ mod test {
)
.unwrap();
let mut vfs = Vfs::new(imfs);
let vfs = Vfs::new(imfs);
let instance_snapshot =
snapshot_dir(&InstanceContext::default(), &mut vfs, Path::new("/foo"))
.unwrap()
.unwrap();
let instance_snapshot = snapshot_dir(&InstanceContext::default(), &vfs, Path::new("/foo"))
.unwrap()
.unwrap();
insta::assert_yaml_snapshot!(instance_snapshot);
}

4
src/snapshot_middleware/json.rs
View File

@@ -98,11 +98,11 @@ mod test {
)
.unwrap();
let mut vfs = Vfs::new(imfs.clone());
let vfs = Vfs::new(imfs.clone());
let instance_snapshot = snapshot_json(
&InstanceContext::default(),
&mut vfs,
&vfs,
Path::new("/foo.json"),
"foo",
)

52
src/snapshot_middleware/lua.rs
View File

@@ -124,11 +124,11 @@ mod test {
imfs.load_snapshot("/foo.lua", VfsSnapshot::file("Hello there!"))
.unwrap();
let mut vfs = Vfs::new(imfs);
let vfs = Vfs::new(imfs);
let instance_snapshot = snapshot_lua(
&InstanceContext::with_emit_legacy_scripts(Some(true)),
&mut vfs,
&vfs,
Path::new("/foo.lua"),
"foo",
ScriptType::Module,
@@ -147,11 +147,11 @@ mod test {
imfs.load_snapshot("/foo.lua", VfsSnapshot::file("Hello there!"))
.unwrap();
let mut vfs = Vfs::new(imfs);
let vfs = Vfs::new(imfs);
let instance_snapshot = snapshot_lua(
&InstanceContext::with_emit_legacy_scripts(Some(false)),
&mut vfs,
&vfs,
Path::new("/foo.lua"),
"foo",
ScriptType::Module,
@@ -170,11 +170,11 @@ mod test {
imfs.load_snapshot("/foo.server.lua", VfsSnapshot::file("Hello there!"))
.unwrap();
let mut vfs = Vfs::new(imfs);
let vfs = Vfs::new(imfs);
let instance_snapshot = snapshot_lua(
&InstanceContext::with_emit_legacy_scripts(Some(true)),
&mut vfs,
&vfs,
Path::new("/foo.server.lua"),
"foo",
ScriptType::Server,
@@ -193,11 +193,11 @@ mod test {
imfs.load_snapshot("/foo.server.lua", VfsSnapshot::file("Hello there!"))
.unwrap();
let mut vfs = Vfs::new(imfs);
let vfs = Vfs::new(imfs);
let instance_snapshot = snapshot_lua(
&InstanceContext::with_emit_legacy_scripts(Some(false)),
&mut vfs,
&vfs,
Path::new("/foo.server.lua"),
"foo",
ScriptType::Server,
@@ -216,11 +216,11 @@ mod test {
imfs.load_snapshot("/foo.client.lua", VfsSnapshot::file("Hello there!"))
.unwrap();
let mut vfs = Vfs::new(imfs);
let vfs = Vfs::new(imfs);
let instance_snapshot = snapshot_lua(
&InstanceContext::with_emit_legacy_scripts(Some(true)),
&mut vfs,
&vfs,
Path::new("/foo.client.lua"),
"foo",
ScriptType::Client,
@@ -239,11 +239,11 @@ mod test {
imfs.load_snapshot("/foo.client.lua", VfsSnapshot::file("Hello there!"))
.unwrap();
let mut vfs = Vfs::new(imfs);
let vfs = Vfs::new(imfs);
let instance_snapshot = snapshot_lua(
&InstanceContext::with_emit_legacy_scripts(Some(false)),
&mut vfs,
&vfs,
Path::new("/foo.client.lua"),
"foo",
ScriptType::Client,
@@ -266,11 +266,11 @@ mod test {
)
.unwrap();
let mut vfs = Vfs::new(imfs);
let vfs = Vfs::new(imfs);
let instance_snapshot = snapshot_lua(
&InstanceContext::with_emit_legacy_scripts(Some(true)),
&mut vfs,
&vfs,
Path::new("/root"),
"root",
ScriptType::Module,
@@ -300,11 +300,11 @@ mod test {
)
.unwrap();
let mut vfs = Vfs::new(imfs);
let vfs = Vfs::new(imfs);
let instance_snapshot = snapshot_lua(
&InstanceContext::with_emit_legacy_scripts(Some(true)),
&mut vfs,
&vfs,
Path::new("/foo.lua"),
"foo",
ScriptType::Module,
@@ -334,11 +334,11 @@ mod test {
)
.unwrap();
let mut vfs = Vfs::new(imfs);
let vfs = Vfs::new(imfs);
let instance_snapshot = snapshot_lua(
&InstanceContext::with_emit_legacy_scripts(Some(false)),
&mut vfs,
&vfs,
Path::new("/foo.lua"),
"foo",
ScriptType::Module,
@@ -368,11 +368,11 @@ mod test {
)
.unwrap();
let mut vfs = Vfs::new(imfs);
let vfs = Vfs::new(imfs);
let instance_snapshot = snapshot_lua(
&InstanceContext::with_emit_legacy_scripts(Some(true)),
&mut vfs,
&vfs,
Path::new("/foo.server.lua"),
"foo",
ScriptType::Server,
@@ -402,11 +402,11 @@ mod test {
)
.unwrap();
let mut vfs = Vfs::new(imfs);
let vfs = Vfs::new(imfs);
let instance_snapshot = snapshot_lua(
&InstanceContext::with_emit_legacy_scripts(Some(false)),
&mut vfs,
&vfs,
Path::new("/foo.server.lua"),
"foo",
ScriptType::Server,
@@ -438,11 +438,11 @@ mod test {
)
.unwrap();
let mut vfs = Vfs::new(imfs);
let vfs = Vfs::new(imfs);
let instance_snapshot = snapshot_lua(
&InstanceContext::with_emit_legacy_scripts(Some(true)),
&mut vfs,
&vfs,
Path::new("/bar.server.lua"),
"bar",
ScriptType::Server,
@@ -474,11 +474,11 @@ mod test {
)
.unwrap();
let mut vfs = Vfs::new(imfs);
let vfs = Vfs::new(imfs);
let instance_snapshot = snapshot_lua(
&InstanceContext::with_emit_legacy_scripts(Some(false)),
&mut vfs,
&vfs,
Path::new("/bar.server.lua"),
"bar",
ScriptType::Server,

4
src/snapshot_middleware/rbxm.rs
View File

@@ -54,11 +54,11 @@ mod test {
)
.unwrap();
let mut vfs = Vfs::new(imfs);
let vfs = Vfs::new(imfs);
let instance_snapshot = snapshot_rbxm(
&InstanceContext::default(),
&mut vfs,
&vfs,
Path::new("/foo.rbxm"),
"foo",
)

4
src/snapshot_middleware/rbxmx.rs
View File

@@ -66,11 +66,11 @@ mod test {
)
.unwrap();
let mut vfs = Vfs::new(imfs);
let vfs = Vfs::new(imfs);
let instance_snapshot = snapshot_rbxmx(
&InstanceContext::default(),
&mut vfs,
&vfs,
Path::new("/foo.rbxmx"),
"foo",
)

4
src/snapshot_middleware/toml.rs
View File

@@ -105,11 +105,11 @@ mod test {
)
.unwrap();
let mut vfs = Vfs::new(imfs.clone());
let vfs = Vfs::new(imfs.clone());
let instance_snapshot = snapshot_toml(
&InstanceContext::default(),
&mut vfs,
&vfs,
Path::new("/foo.toml"),
"foo",
)

4
src/snapshot_middleware/txt.rs
View File

@@ -50,11 +50,11 @@ mod test {
imfs.load_snapshot("/foo.txt", VfsSnapshot::file("Hello there!"))
.unwrap();
let mut vfs = Vfs::new(imfs.clone());
let vfs = Vfs::new(imfs.clone());
let instance_snapshot = snapshot_txt(
&InstanceContext::default(),
&mut vfs,
&vfs,
Path::new("/foo.txt"),
"foo",
)

2
src/web/interface.rs
View File

@@ -119,7 +119,7 @@ pub struct Instance<'a> {
pub metadata: Option<InstanceMetadata>,
}
impl<'a> Instance<'a> {
impl Instance<'_> {
pub(crate) fn from_rojo_instance(source: InstanceWithMeta<'_>) -> Instance<'_> {
let properties = source
.properties()

2
tests/rojo_test/serve_util.rs
View File

@@ -28,7 +28,7 @@ use crate::rojo_test::io_util::{
pub fn run_serve_test(test_name: &str, callback: impl FnOnce(TestServeSession, RedactionMap)) {
let _ = env_logger::try_init();
let mut redactions = RedactionMap::new();
let mut redactions = RedactionMap::default();
let mut session = TestServeSession::new(test_name);
let info = session.wait_to_come_online();