Block usage of "Name" or "Parent" in $properties (#413)

* Ignore usage of "Name" or "Parent" in $properties

* Use match instead of array

* Add changelog entry

Co-authored-by: Lucien Greathouse <me@lpghatguy.com>
This commit is contained in:
Mixu78
2021-04-23 22:11:17 +03:00
committed by GitHub
parent 0849fab644
commit 0779baa0ac
2 changed files with 17 additions and 0 deletions

View File

@@ -4,6 +4,9 @@
* Added the `gameId` and `placeId` optional properties to project files.
* When connecting from the Rojo Roblox Studio plugin, Rojo will set the game and place ID of the current place to these values, if set.
* This is equivalent to running `game:SetUniverseId(...)` and `game:SetPlaceId(...)` from the command bar in Studio.
* Fixed `Name` and `Parent` properties being allowed in Rojo projects. ([#413](pr-413))
[pr-413]: https://github.com/rojo-rbx/rojo/pull/413
## [7.0.0-alpha.3][7.0.0-alpha.3] (February 19, 2021)
* Updated dependencies, fixing `OptionalCoordinateFrame`-related issues.

View File

@@ -182,6 +182,20 @@ pub fn snapshot_project_node(
)
})?;
match key.as_str() {
"Name" | "Parent" => {
log::warn!(
"Property '{}' cannot be set manually, ignoring. Attempted to set in '{}' at {}",
key,
instance_name,
project_path.display()
);
continue;
}
_ => {}
}
properties.insert(key.clone(), value);
}