mirror of
https://github.com/rojo-rbx/rojo.git
synced 2026-04-21 21:25:16 +00:00
Compare commits
1 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
8053909bd0
|
7
.github/workflows/release.yml
vendored
7
.github/workflows/release.yml
vendored
@@ -45,13 +45,6 @@ jobs:
|
|||||||
name: Rojo.rbxm
|
name: Rojo.rbxm
|
||||||
path: Rojo.rbxm
|
path: Rojo.rbxm
|
||||||
|
|
||||||
- name: Upload Plugin to Roblox
|
|
||||||
env:
|
|
||||||
RBX_API_KEY: ${{ secrets.PLUGIN_UPLOAD_TOKEN }}
|
|
||||||
RBX_UNIVERSE_ID: ${{ vars.PLUGIN_CI_PLACE_ID }}
|
|
||||||
RBX_PLACE_ID: ${{ vars.PLUGIN_CI_UNIVERSE_ID }}
|
|
||||||
run: lune run upload-plugin Rojo.rbxm
|
|
||||||
|
|
||||||
build:
|
build:
|
||||||
needs: ["create-release"]
|
needs: ["create-release"]
|
||||||
strategy:
|
strategy:
|
||||||
|
|||||||
3
.gitignore
vendored
3
.gitignore
vendored
@@ -23,6 +23,3 @@
|
|||||||
# Macos file system junk
|
# Macos file system junk
|
||||||
._*
|
._*
|
||||||
.DS_STORE
|
.DS_STORE
|
||||||
|
|
||||||
# JetBrains IDEs
|
|
||||||
/.idea/
|
|
||||||
|
|||||||
6
.gitmodules
vendored
6
.gitmodules
vendored
@@ -16,9 +16,3 @@
|
|||||||
[submodule "plugin/Packages/Highlighter"]
|
[submodule "plugin/Packages/Highlighter"]
|
||||||
path = plugin/Packages/Highlighter
|
path = plugin/Packages/Highlighter
|
||||||
url = https://github.com/boatbomber/highlighter.git
|
url = https://github.com/boatbomber/highlighter.git
|
||||||
[submodule "plugin/Packages/msgpack-luau"]
|
|
||||||
path = plugin/Packages/msgpack-luau
|
|
||||||
url = https://github.com/cipharius/msgpack-luau/
|
|
||||||
[submodule ".lune/opencloud-execute"]
|
|
||||||
path = .lune/opencloud-execute
|
|
||||||
url = https://github.com/Dekkonot/opencloud-luau-execute-lune.git
|
|
||||||
|
|||||||
@@ -1,8 +0,0 @@
|
|||||||
return {
|
|
||||||
luau = {
|
|
||||||
languagemode = "strict",
|
|
||||||
aliases = {
|
|
||||||
lune = "~/.lune/.typedefs/0.10.4/",
|
|
||||||
},
|
|
||||||
},
|
|
||||||
}
|
|
||||||
Submodule .lune/opencloud-execute deleted from 8ae86dd3ad
@@ -1,51 +0,0 @@
|
|||||||
local args: any = ...
|
|
||||||
assert(args, "no arguments passed to script")
|
|
||||||
|
|
||||||
local input: buffer = args.BinaryInput
|
|
||||||
|
|
||||||
local AssetService = game:GetService("AssetService")
|
|
||||||
local SerializationService = game:GetService("SerializationService")
|
|
||||||
local EncodingService = game:GetService("EncodingService")
|
|
||||||
|
|
||||||
local input_hash: buffer = EncodingService:ComputeBufferHash(input, Enum.HashAlgorithm.Sha256)
|
|
||||||
local hex_hash: { string } = table.create(buffer.len(input_hash))
|
|
||||||
for i = 0, buffer.len(input_hash) - 1 do
|
|
||||||
table.insert(hex_hash, string.format("%02x", buffer.readu8(input_hash, i)))
|
|
||||||
end
|
|
||||||
|
|
||||||
print(`Deserializing plugin file (size: {buffer.len(input)} bytes, hash: {table.concat(hex_hash, "")})`)
|
|
||||||
local plugin = SerializationService:DeserializeInstancesAsync(input)[1]
|
|
||||||
|
|
||||||
local UploadDetails = require(plugin.UploadDetails) :: any
|
|
||||||
local PLUGIN_ID = UploadDetails.assetId
|
|
||||||
local PLUGIN_NAME = UploadDetails.name
|
|
||||||
local PLUGIN_DESCRIPTION = UploadDetails.description
|
|
||||||
local PLUGIN_CREATOR_ID = UploadDetails.creatorId
|
|
||||||
local PLUGIN_CREATOR_TYPE = UploadDetails.creatorType
|
|
||||||
|
|
||||||
assert(typeof(PLUGIN_ID) == "number", "UploadDetails did not contain a number field 'assetId'")
|
|
||||||
assert(typeof(PLUGIN_NAME) == "string", "UploadDetails did not contain a string field 'name'")
|
|
||||||
assert(typeof(PLUGIN_DESCRIPTION) == "string", "UploadDetails did not contain a string field 'description'")
|
|
||||||
assert(typeof(PLUGIN_CREATOR_ID) == "number", "UploadDetails did not contain a number field 'creatorId'")
|
|
||||||
assert(typeof(PLUGIN_CREATOR_TYPE) == "string", "UploadDetails did not contain a string field 'creatorType'")
|
|
||||||
assert(
|
|
||||||
Enum.AssetCreatorType:FromName(PLUGIN_CREATOR_TYPE) ~= nil,
|
|
||||||
"UploadDetails field 'creatorType' was not a valid member of Enum.AssetCreatorType"
|
|
||||||
)
|
|
||||||
|
|
||||||
print(`Uploading to {PLUGIN_ID}`)
|
|
||||||
print(`Plugin Name: {PLUGIN_NAME}`)
|
|
||||||
print(`Plugin Description: {PLUGIN_DESCRIPTION}`)
|
|
||||||
|
|
||||||
local result, version_or_err = AssetService:CreateAssetVersionAsync(plugin, Enum.AssetType.Plugin, PLUGIN_ID, {
|
|
||||||
["Name"] = PLUGIN_NAME,
|
|
||||||
["Description"] = PLUGIN_DESCRIPTION,
|
|
||||||
["CreatorId"] = PLUGIN_CREATOR_ID,
|
|
||||||
["CreatorType"] = Enum.AssetCreatorType:FromName(PLUGIN_CREATOR_TYPE),
|
|
||||||
})
|
|
||||||
|
|
||||||
if result ~= Enum.CreateAssetResult.Success then
|
|
||||||
error(`Plugin failed to upload because: {result.Name} - {version_or_err}`)
|
|
||||||
end
|
|
||||||
|
|
||||||
print(`Plugin uploaded successfully. New version is {version_or_err}.`)
|
|
||||||
@@ -1,78 +0,0 @@
|
|||||||
local fs = require("@lune/fs")
|
|
||||||
local process = require("@lune/process")
|
|
||||||
local stdio = require("@lune/stdio")
|
|
||||||
|
|
||||||
local luau_execute = require("./opencloud-execute")
|
|
||||||
|
|
||||||
local UNIVERSE_ID = process.env["RBX_UNIVERSE_ID"]
|
|
||||||
local PLACE_ID = process.env["RBX_PLACE_ID"]
|
|
||||||
|
|
||||||
local version_string = fs.readFile("plugin/Version.txt")
|
|
||||||
local versions = { string.match(version_string, "^v?(%d+)%.(%d+)%.(%d+)(.*)$") }
|
|
||||||
if versions[4] ~= "" then
|
|
||||||
print("This release is a pre-release. Skipping uploading plugin.")
|
|
||||||
process.exit(0)
|
|
||||||
end
|
|
||||||
|
|
||||||
local plugin_path = process.args[1]
|
|
||||||
assert(
|
|
||||||
typeof(plugin_path) == "string",
|
|
||||||
"no plugin path provided, expected usage is `lune run upload-plugin [PATH TO RBXM]`."
|
|
||||||
)
|
|
||||||
|
|
||||||
-- For local testing
|
|
||||||
if process.env["CI"] ~= "true" then
|
|
||||||
local rojo = process.exec("rojo", { "build", "plugin.project.json", "--output", plugin_path })
|
|
||||||
if not rojo.ok then
|
|
||||||
stdio.ewrite("plugin upload failed because: could not build plugin.rbxm\n\n")
|
|
||||||
stdio.ewrite(rojo.stderr)
|
|
||||||
stdio.ewrite("\n")
|
|
||||||
process.exit(1)
|
|
||||||
end
|
|
||||||
else
|
|
||||||
assert(fs.isFile(plugin_path), `Plugin file did not exist at {plugin_path}`)
|
|
||||||
end
|
|
||||||
local plugin_content = fs.readFile(plugin_path)
|
|
||||||
|
|
||||||
local engine_script = fs.readFile(".lune/scripts/plugin-upload.luau")
|
|
||||||
|
|
||||||
print("Creating task to upload plugin")
|
|
||||||
local task = luau_execute.create_task_latest(UNIVERSE_ID, PLACE_ID, engine_script, 300, false, plugin_content)
|
|
||||||
|
|
||||||
print("Waiting for task to finish")
|
|
||||||
local success = luau_execute.await_finish(task)
|
|
||||||
if not success then
|
|
||||||
local error = luau_execute.get_error(task)
|
|
||||||
assert(error, "could not fetch error from task")
|
|
||||||
stdio.ewrite("plugin upload failed because: task did not finish successfully\n\n")
|
|
||||||
stdio.ewrite(error.code)
|
|
||||||
stdio.ewrite("\n")
|
|
||||||
stdio.ewrite(error.message)
|
|
||||||
stdio.ewrite("\n")
|
|
||||||
process.exit(1)
|
|
||||||
end
|
|
||||||
|
|
||||||
print("Output from task:\n")
|
|
||||||
for _, log in luau_execute.get_structured_logs(task) do
|
|
||||||
if log.messageType == "ERROR" then
|
|
||||||
stdio.write(stdio.color("red"))
|
|
||||||
stdio.write(log.message)
|
|
||||||
stdio.write("\n")
|
|
||||||
stdio.write(stdio.color("reset"))
|
|
||||||
elseif log.messageType == "INFO" then
|
|
||||||
stdio.write(stdio.color("cyan"))
|
|
||||||
stdio.write(log.message)
|
|
||||||
stdio.write("\n")
|
|
||||||
stdio.write(stdio.color("reset"))
|
|
||||||
elseif log.messageType == "WARNING" then
|
|
||||||
stdio.write(stdio.color("yellow"))
|
|
||||||
stdio.write(log.message)
|
|
||||||
stdio.write("\n")
|
|
||||||
stdio.write(stdio.color("reset"))
|
|
||||||
else
|
|
||||||
stdio.write(stdio.color("reset"))
|
|
||||||
stdio.write(log.message)
|
|
||||||
stdio.write("\n")
|
|
||||||
stdio.write(stdio.color("reset"))
|
|
||||||
end
|
|
||||||
end
|
|
||||||
15
CHANGELOG.md
15
CHANGELOG.md
@@ -30,24 +30,9 @@ Making a new release? Simply add the new header with the version and date undern
|
|||||||
-->
|
-->
|
||||||
|
|
||||||
## Unreleased
|
## Unreleased
|
||||||
|
|
||||||
* `inf` and `nan` values in properties are now synced ([#1176])
|
|
||||||
* Fixed a bug caused by having reference properties (such as `ObjectValue.Value`) that point to an Instance not included in syncback. ([#1179])
|
* Fixed a bug caused by having reference properties (such as `ObjectValue.Value`) that point to an Instance not included in syncback. ([#1179])
|
||||||
* Fixed instance replacement fallback failing when too many instances needed to be replaced. ([#1192])
|
|
||||||
* Added actors and bindable/remote event/function variants to be synced back as JSON files. ([#1199])
|
|
||||||
* Fixed a bug where MacOS paths weren't being handled correctly. ([#1201])
|
|
||||||
* Fixed a bug where the notification timeout thread would fail to cancel on unmount ([#1211])
|
|
||||||
* Added a "Forget" option to the sync reminder notification to avoid being reminded for that place in the future ([#1215])
|
|
||||||
* Improves relative path calculation for sourcemap generation to avoid issues with Windows UNC paths. ([#1217])
|
|
||||||
|
|
||||||
[#1176]: https://github.com/rojo-rbx/rojo/pull/1176
|
|
||||||
[#1179]: https://github.com/rojo-rbx/rojo/pull/1179
|
[#1179]: https://github.com/rojo-rbx/rojo/pull/1179
|
||||||
[#1192]: https://github.com/rojo-rbx/rojo/pull/1192
|
|
||||||
[#1199]: https://github.com/rojo-rbx/rojo/pull/1199
|
|
||||||
[#1201]: https://github.com/rojo-rbx/rojo/pull/1201
|
|
||||||
[#1211]: https://github.com/rojo-rbx/rojo/pull/1211
|
|
||||||
[#1215]: https://github.com/rojo-rbx/rojo/pull/1215
|
|
||||||
[#1217]: https://github.com/rojo-rbx/rojo/pull/1217
|
|
||||||
|
|
||||||
## [7.7.0-rc.1] (November 27th, 2025)
|
## [7.7.0-rc.1] (November 27th, 2025)
|
||||||
|
|
||||||
|
|||||||
@@ -14,7 +14,6 @@ Code contributions are welcome for features and bugs that have been reported in
|
|||||||
You'll want these tools to work on Rojo:
|
You'll want these tools to work on Rojo:
|
||||||
|
|
||||||
* Latest stable Rust compiler
|
* Latest stable Rust compiler
|
||||||
* Rustfmt and Clippy are used for code formatting and linting.
|
|
||||||
* Latest stable [Rojo](https://github.com/rojo-rbx/rojo)
|
* Latest stable [Rojo](https://github.com/rojo-rbx/rojo)
|
||||||
* [Rokit](https://github.com/rojo-rbx/rokit)
|
* [Rokit](https://github.com/rojo-rbx/rokit)
|
||||||
* [Luau Language Server](https://github.com/JohnnyMorganz/luau-lsp) (Only needed if working on the Studio plugin.)
|
* [Luau Language Server](https://github.com/JohnnyMorganz/luau-lsp) (Only needed if working on the Studio plugin.)
|
||||||
|
|||||||
20
Cargo.lock
generated
20
Cargo.lock
generated
@@ -1319,7 +1319,6 @@ dependencies = [
|
|||||||
"fs-err",
|
"fs-err",
|
||||||
"notify",
|
"notify",
|
||||||
"serde",
|
"serde",
|
||||||
"tempfile",
|
|
||||||
]
|
]
|
||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
@@ -1520,12 +1519,6 @@ version = "1.0.15"
|
|||||||
source = "registry+https://github.com/rust-lang/crates.io-index"
|
source = "registry+https://github.com/rust-lang/crates.io-index"
|
||||||
checksum = "57c0d7b74b563b49d38dae00a0c37d4d6de9b432382b2892f0574ddcae73fd0a"
|
checksum = "57c0d7b74b563b49d38dae00a0c37d4d6de9b432382b2892f0574ddcae73fd0a"
|
||||||
|
|
||||||
[[package]]
|
|
||||||
name = "pathdiff"
|
|
||||||
version = "0.2.3"
|
|
||||||
source = "registry+https://github.com/rust-lang/crates.io-index"
|
|
||||||
checksum = "df94ce210e5bc13cb6651479fa48d14f601d9858cfe0467f43ae157023b938d3"
|
|
||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "percent-encoding"
|
name = "percent-encoding"
|
||||||
version = "2.3.2"
|
version = "2.3.2"
|
||||||
@@ -2074,7 +2067,6 @@ dependencies = [
|
|||||||
"num_cpus",
|
"num_cpus",
|
||||||
"opener",
|
"opener",
|
||||||
"paste",
|
"paste",
|
||||||
"pathdiff",
|
|
||||||
"pretty_assertions",
|
"pretty_assertions",
|
||||||
"profiling",
|
"profiling",
|
||||||
"rayon",
|
"rayon",
|
||||||
@@ -2085,12 +2077,10 @@ dependencies = [
|
|||||||
"rbx_xml",
|
"rbx_xml",
|
||||||
"reqwest",
|
"reqwest",
|
||||||
"ritz",
|
"ritz",
|
||||||
"rmp-serde",
|
|
||||||
"roblox_install",
|
"roblox_install",
|
||||||
"rojo-insta-ext",
|
"rojo-insta-ext",
|
||||||
"semver",
|
"semver",
|
||||||
"serde",
|
"serde",
|
||||||
"serde_bytes",
|
|
||||||
"serde_json",
|
"serde_json",
|
||||||
"serde_yaml",
|
"serde_yaml",
|
||||||
"strum",
|
"strum",
|
||||||
@@ -2231,16 +2221,6 @@ dependencies = [
|
|||||||
"serde_derive",
|
"serde_derive",
|
||||||
]
|
]
|
||||||
|
|
||||||
[[package]]
|
|
||||||
name = "serde_bytes"
|
|
||||||
version = "0.11.19"
|
|
||||||
source = "registry+https://github.com/rust-lang/crates.io-index"
|
|
||||||
checksum = "a5d440709e79d88e51ac01c4b72fc6cb7314017bb7da9eeff678aa94c10e3ea8"
|
|
||||||
dependencies = [
|
|
||||||
"serde",
|
|
||||||
"serde_core",
|
|
||||||
]
|
|
||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "serde_cbor"
|
name = "serde_cbor"
|
||||||
version = "0.11.2"
|
version = "0.11.2"
|
||||||
|
|||||||
@@ -100,13 +100,10 @@ clap = { version = "3.2.25", features = ["derive"] }
|
|||||||
profiling = "1.0.15"
|
profiling = "1.0.15"
|
||||||
yaml-rust2 = "0.10.3"
|
yaml-rust2 = "0.10.3"
|
||||||
data-encoding = "2.8.0"
|
data-encoding = "2.8.0"
|
||||||
pathdiff = "0.2.3"
|
|
||||||
|
|
||||||
blake3 = "1.5.0"
|
blake3 = "1.5.0"
|
||||||
float-cmp = "0.9.0"
|
float-cmp = "0.9.0"
|
||||||
indexmap = { version = "2.10.0", features = ["serde"] }
|
indexmap = { version = "2.10.0", features = ["serde"] }
|
||||||
rmp-serde = "1.3.0"
|
|
||||||
serde_bytes = "0.11.19"
|
|
||||||
|
|
||||||
[target.'cfg(windows)'.dependencies]
|
[target.'cfg(windows)'.dependencies]
|
||||||
winreg = "0.10.1"
|
winreg = "0.10.1"
|
||||||
@@ -125,7 +122,7 @@ semver = "1.0.22"
|
|||||||
rojo-insta-ext = { path = "crates/rojo-insta-ext" }
|
rojo-insta-ext = { path = "crates/rojo-insta-ext" }
|
||||||
|
|
||||||
criterion = "0.3.6"
|
criterion = "0.3.6"
|
||||||
insta = { version = "1.36.1", features = ["redactions", "yaml", "json"] }
|
insta = { version = "1.36.1", features = ["redactions", "yaml"] }
|
||||||
paste = "1.0.14"
|
paste = "1.0.14"
|
||||||
pretty_assertions = "1.4.0"
|
pretty_assertions = "1.4.0"
|
||||||
serde_yaml = "0.8.26"
|
serde_yaml = "0.8.26"
|
||||||
|
|||||||
6
build.rs
6
build.rs
@@ -30,11 +30,6 @@ fn snapshot_from_fs_path(path: &Path) -> io::Result<VfsSnapshot> {
|
|||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
|
|
||||||
// Ignore images in msgpack-luau because they aren't UTF-8 encoded.
|
|
||||||
if file_name.ends_with(".png") {
|
|
||||||
continue;
|
|
||||||
}
|
|
||||||
|
|
||||||
let child_snapshot = snapshot_from_fs_path(&entry.path())?;
|
let child_snapshot = snapshot_from_fs_path(&entry.path())?;
|
||||||
children.push((file_name, child_snapshot));
|
children.push((file_name, child_snapshot));
|
||||||
}
|
}
|
||||||
@@ -75,7 +70,6 @@ fn main() -> Result<(), anyhow::Error> {
|
|||||||
"src" => snapshot_from_fs_path(&plugin_dir.join("src"))?,
|
"src" => snapshot_from_fs_path(&plugin_dir.join("src"))?,
|
||||||
"Packages" => snapshot_from_fs_path(&plugin_dir.join("Packages"))?,
|
"Packages" => snapshot_from_fs_path(&plugin_dir.join("Packages"))?,
|
||||||
"Version.txt" => snapshot_from_fs_path(&plugin_dir.join("Version.txt"))?,
|
"Version.txt" => snapshot_from_fs_path(&plugin_dir.join("Version.txt"))?,
|
||||||
"UploadDetails.json" => snapshot_from_fs_path(&plugin_dir.join("UploadDetails.json"))?,
|
|
||||||
}),
|
}),
|
||||||
});
|
});
|
||||||
|
|
||||||
|
|||||||
@@ -1,7 +1,6 @@
|
|||||||
# memofs Changelog
|
# memofs Changelog
|
||||||
|
|
||||||
## Unreleased Changes
|
## Unreleased Changes
|
||||||
* Added `Vfs::canonicalize`. [#1201]
|
|
||||||
|
|
||||||
## 0.3.1 (2025-11-27)
|
## 0.3.1 (2025-11-27)
|
||||||
* Added `Vfs::exists`. [#1169]
|
* Added `Vfs::exists`. [#1169]
|
||||||
|
|||||||
@@ -19,6 +19,3 @@ crossbeam-channel = "0.5.12"
|
|||||||
fs-err = "2.11.0"
|
fs-err = "2.11.0"
|
||||||
notify = "4.0.17"
|
notify = "4.0.17"
|
||||||
serde = { version = "1.0.197", features = ["derive"] }
|
serde = { version = "1.0.197", features = ["derive"] }
|
||||||
|
|
||||||
[dev-dependencies]
|
|
||||||
tempfile = "3.10.1"
|
|
||||||
|
|||||||
@@ -232,33 +232,6 @@ impl VfsBackend for InMemoryFs {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// TODO: We rely on Rojo to prepend cwd to any relative path before storing paths
|
|
||||||
// in MemoFS. The current implementation will error if no prepended absolute path
|
|
||||||
// is found. It really only normalizes paths within the provided path's context.
|
|
||||||
// Example: "/Users/username/project/../other/file.txt" ->
|
|
||||||
// "/Users/username/other/file.txt"
|
|
||||||
// Erroneous example: "/Users/../../other/file.txt" -> "/other/file.txt"
|
|
||||||
// This is not very robust. We should implement proper path normalization here or otherwise
|
|
||||||
// warn if we are missing context and can not fully canonicalize the path correctly.
|
|
||||||
fn canonicalize(&mut self, path: &Path) -> io::Result<PathBuf> {
|
|
||||||
let mut normalized = PathBuf::new();
|
|
||||||
for component in path.components() {
|
|
||||||
match component {
|
|
||||||
std::path::Component::ParentDir => {
|
|
||||||
normalized.pop();
|
|
||||||
}
|
|
||||||
std::path::Component::CurDir => {}
|
|
||||||
_ => normalized.push(component),
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
let inner = self.inner.lock().unwrap();
|
|
||||||
match inner.entries.get(&normalized) {
|
|
||||||
Some(_) => Ok(normalized),
|
|
||||||
None => not_found(&normalized),
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
fn event_receiver(&self) -> crossbeam_channel::Receiver<VfsEvent> {
|
fn event_receiver(&self) -> crossbeam_channel::Receiver<VfsEvent> {
|
||||||
let inner = self.inner.lock().unwrap();
|
let inner = self.inner.lock().unwrap();
|
||||||
|
|
||||||
|
|||||||
@@ -77,7 +77,6 @@ pub trait VfsBackend: sealed::Sealed + Send + 'static {
|
|||||||
fn metadata(&mut self, path: &Path) -> io::Result<Metadata>;
|
fn metadata(&mut self, path: &Path) -> io::Result<Metadata>;
|
||||||
fn remove_file(&mut self, path: &Path) -> io::Result<()>;
|
fn remove_file(&mut self, path: &Path) -> io::Result<()>;
|
||||||
fn remove_dir_all(&mut self, path: &Path) -> io::Result<()>;
|
fn remove_dir_all(&mut self, path: &Path) -> io::Result<()>;
|
||||||
fn canonicalize(&mut self, path: &Path) -> io::Result<PathBuf>;
|
|
||||||
|
|
||||||
fn event_receiver(&self) -> crossbeam_channel::Receiver<VfsEvent>;
|
fn event_receiver(&self) -> crossbeam_channel::Receiver<VfsEvent>;
|
||||||
fn watch(&mut self, path: &Path) -> io::Result<()>;
|
fn watch(&mut self, path: &Path) -> io::Result<()>;
|
||||||
@@ -226,11 +225,6 @@ impl VfsInner {
|
|||||||
self.backend.metadata(path)
|
self.backend.metadata(path)
|
||||||
}
|
}
|
||||||
|
|
||||||
fn canonicalize<P: AsRef<Path>>(&mut self, path: P) -> io::Result<PathBuf> {
|
|
||||||
let path = path.as_ref();
|
|
||||||
self.backend.canonicalize(path)
|
|
||||||
}
|
|
||||||
|
|
||||||
fn event_receiver(&self) -> crossbeam_channel::Receiver<VfsEvent> {
|
fn event_receiver(&self) -> crossbeam_channel::Receiver<VfsEvent> {
|
||||||
self.backend.event_receiver()
|
self.backend.event_receiver()
|
||||||
}
|
}
|
||||||
@@ -419,19 +413,6 @@ impl Vfs {
|
|||||||
self.inner.lock().unwrap().metadata(path)
|
self.inner.lock().unwrap().metadata(path)
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Normalize a path via the underlying backend.
|
|
||||||
///
|
|
||||||
/// Roughly equivalent to [`std::fs::canonicalize`][std::fs::canonicalize]. Relative paths are
|
|
||||||
/// resolved against the backend's current working directory (if applicable) and errors are
|
|
||||||
/// surfaced directly from the backend.
|
|
||||||
///
|
|
||||||
/// [std::fs::canonicalize]: https://doc.rust-lang.org/stable/std/fs/fn.canonicalize.html
|
|
||||||
#[inline]
|
|
||||||
pub fn canonicalize<P: AsRef<Path>>(&self, path: P) -> io::Result<PathBuf> {
|
|
||||||
let path = path.as_ref();
|
|
||||||
self.inner.lock().unwrap().canonicalize(path)
|
|
||||||
}
|
|
||||||
|
|
||||||
/// Retrieve a handle to the event receiver for this `Vfs`.
|
/// Retrieve a handle to the event receiver for this `Vfs`.
|
||||||
#[inline]
|
#[inline]
|
||||||
pub fn event_receiver(&self) -> crossbeam_channel::Receiver<VfsEvent> {
|
pub fn event_receiver(&self) -> crossbeam_channel::Receiver<VfsEvent> {
|
||||||
@@ -559,13 +540,6 @@ impl VfsLock<'_> {
|
|||||||
self.inner.metadata(path)
|
self.inner.metadata(path)
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Normalize a path via the underlying backend.
|
|
||||||
#[inline]
|
|
||||||
pub fn normalize<P: AsRef<Path>>(&mut self, path: P) -> io::Result<PathBuf> {
|
|
||||||
let path = path.as_ref();
|
|
||||||
self.inner.canonicalize(path)
|
|
||||||
}
|
|
||||||
|
|
||||||
/// Retrieve a handle to the event receiver for this `Vfs`.
|
/// Retrieve a handle to the event receiver for this `Vfs`.
|
||||||
#[inline]
|
#[inline]
|
||||||
pub fn event_receiver(&self) -> crossbeam_channel::Receiver<VfsEvent> {
|
pub fn event_receiver(&self) -> crossbeam_channel::Receiver<VfsEvent> {
|
||||||
@@ -581,9 +555,7 @@ impl VfsLock<'_> {
|
|||||||
|
|
||||||
#[cfg(test)]
|
#[cfg(test)]
|
||||||
mod test {
|
mod test {
|
||||||
use crate::{InMemoryFs, StdBackend, Vfs, VfsSnapshot};
|
use crate::{InMemoryFs, Vfs, VfsSnapshot};
|
||||||
use std::io;
|
|
||||||
use std::path::PathBuf;
|
|
||||||
|
|
||||||
/// https://github.com/rojo-rbx/rojo/issues/899
|
/// https://github.com/rojo-rbx/rojo/issues/899
|
||||||
#[test]
|
#[test]
|
||||||
@@ -599,62 +571,4 @@ mod test {
|
|||||||
"bar\nfoo\n\n"
|
"bar\nfoo\n\n"
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
/// https://github.com/rojo-rbx/rojo/issues/1200
|
|
||||||
#[test]
|
|
||||||
fn canonicalize_in_memory_success() {
|
|
||||||
let mut imfs = InMemoryFs::new();
|
|
||||||
let contents = "Lorem ipsum dolor sit amet.".to_string();
|
|
||||||
|
|
||||||
imfs.load_snapshot("/test/file.txt", VfsSnapshot::file(contents.to_string()))
|
|
||||||
.unwrap();
|
|
||||||
|
|
||||||
let vfs = Vfs::new(imfs);
|
|
||||||
|
|
||||||
assert_eq!(
|
|
||||||
vfs.canonicalize("/test/nested/../file.txt").unwrap(),
|
|
||||||
PathBuf::from("/test/file.txt")
|
|
||||||
);
|
|
||||||
assert_eq!(
|
|
||||||
vfs.read_to_string(vfs.canonicalize("/test/nested/../file.txt").unwrap())
|
|
||||||
.unwrap()
|
|
||||||
.to_string(),
|
|
||||||
contents.to_string()
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn canonicalize_in_memory_missing_errors() {
|
|
||||||
let imfs = InMemoryFs::new();
|
|
||||||
let vfs = Vfs::new(imfs);
|
|
||||||
|
|
||||||
let err = vfs.canonicalize("test").unwrap_err();
|
|
||||||
assert_eq!(err.kind(), io::ErrorKind::NotFound);
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn canonicalize_std_backend_success() {
|
|
||||||
let contents = "Lorem ipsum dolor sit amet.".to_string();
|
|
||||||
let dir = tempfile::tempdir().unwrap();
|
|
||||||
let file_path = dir.path().join("file.txt");
|
|
||||||
fs_err::write(&file_path, contents.to_string()).unwrap();
|
|
||||||
|
|
||||||
let vfs = Vfs::new(StdBackend::new());
|
|
||||||
let canonicalized = vfs.canonicalize(&file_path).unwrap();
|
|
||||||
assert_eq!(canonicalized, file_path.canonicalize().unwrap());
|
|
||||||
assert_eq!(
|
|
||||||
vfs.read_to_string(&canonicalized).unwrap().to_string(),
|
|
||||||
contents.to_string()
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn canonicalize_std_backend_missing_errors() {
|
|
||||||
let dir = tempfile::tempdir().unwrap();
|
|
||||||
let file_path = dir.path().join("test");
|
|
||||||
|
|
||||||
let vfs = Vfs::new(StdBackend::new());
|
|
||||||
let err = vfs.canonicalize(&file_path).unwrap_err();
|
|
||||||
assert_eq!(err.kind(), io::ErrorKind::NotFound);
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -1,5 +1,5 @@
|
|||||||
use std::io;
|
use std::io;
|
||||||
use std::path::{Path, PathBuf};
|
use std::path::Path;
|
||||||
|
|
||||||
use crate::{Metadata, ReadDir, VfsBackend, VfsEvent};
|
use crate::{Metadata, ReadDir, VfsBackend, VfsEvent};
|
||||||
|
|
||||||
@@ -50,10 +50,6 @@ impl VfsBackend for NoopBackend {
|
|||||||
Err(io::Error::other("NoopBackend doesn't do anything"))
|
Err(io::Error::other("NoopBackend doesn't do anything"))
|
||||||
}
|
}
|
||||||
|
|
||||||
fn canonicalize(&mut self, _path: &Path) -> io::Result<PathBuf> {
|
|
||||||
Err(io::Error::other("NoopBackend doesn't do anything"))
|
|
||||||
}
|
|
||||||
|
|
||||||
fn event_receiver(&self) -> crossbeam_channel::Receiver<VfsEvent> {
|
fn event_receiver(&self) -> crossbeam_channel::Receiver<VfsEvent> {
|
||||||
crossbeam_channel::never()
|
crossbeam_channel::never()
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -106,10 +106,6 @@ impl VfsBackend for StdBackend {
|
|||||||
})
|
})
|
||||||
}
|
}
|
||||||
|
|
||||||
fn canonicalize(&mut self, path: &Path) -> io::Result<PathBuf> {
|
|
||||||
fs_err::canonicalize(path)
|
|
||||||
}
|
|
||||||
|
|
||||||
fn event_receiver(&self) -> crossbeam_channel::Receiver<VfsEvent> {
|
fn event_receiver(&self) -> crossbeam_channel::Receiver<VfsEvent> {
|
||||||
self.watcher_receiver.clone()
|
self.watcher_receiver.clone()
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -22,9 +22,6 @@
|
|||||||
},
|
},
|
||||||
"Version": {
|
"Version": {
|
||||||
"$path": "plugin/Version.txt"
|
"$path": "plugin/Version.txt"
|
||||||
},
|
|
||||||
"UploadDetails": {
|
|
||||||
"$path": "plugin/UploadDetails.json"
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
Submodule plugin/Packages/msgpack-luau deleted from 40f67fc0f6
@@ -1,7 +0,0 @@
|
|||||||
{
|
|
||||||
"assetId": 13916111004,
|
|
||||||
"name": "Rojo",
|
|
||||||
"description": "The plugin portion of Rojo, a tool to enable professional tooling for Roblox developers.",
|
|
||||||
"creatorId": 32644114,
|
|
||||||
"creatorType": "Group"
|
|
||||||
}
|
|
||||||
@@ -1,7 +1,5 @@
|
|||||||
local HttpService = game:GetService("HttpService")
|
local HttpService = game:GetService("HttpService")
|
||||||
|
|
||||||
local msgpack = require(script.Parent.Parent.msgpack)
|
|
||||||
|
|
||||||
local stringTemplate = [[
|
local stringTemplate = [[
|
||||||
Http.Response {
|
Http.Response {
|
||||||
code: %d
|
code: %d
|
||||||
@@ -33,8 +31,4 @@ function Response:json()
|
|||||||
return HttpService:JSONDecode(self.body)
|
return HttpService:JSONDecode(self.body)
|
||||||
end
|
end
|
||||||
|
|
||||||
function Response:msgpack()
|
|
||||||
return msgpack.decode(self.body)
|
|
||||||
end
|
|
||||||
|
|
||||||
return Response
|
return Response
|
||||||
|
|||||||
@@ -1,8 +1,7 @@
|
|||||||
local HttpService = game:GetService("HttpService")
|
local HttpService = game:GetService("HttpService")
|
||||||
|
|
||||||
local Log = require(script.Parent.Log)
|
|
||||||
local msgpack = require(script.Parent.msgpack)
|
|
||||||
local Promise = require(script.Parent.Promise)
|
local Promise = require(script.Parent.Promise)
|
||||||
|
local Log = require(script.Parent.Log)
|
||||||
|
|
||||||
local HttpError = require(script.Error)
|
local HttpError = require(script.Error)
|
||||||
local HttpResponse = require(script.Response)
|
local HttpResponse = require(script.Response)
|
||||||
@@ -69,12 +68,4 @@ function Http.jsonDecode(source)
|
|||||||
return HttpService:JSONDecode(source)
|
return HttpService:JSONDecode(source)
|
||||||
end
|
end
|
||||||
|
|
||||||
function Http.msgpackEncode(object)
|
|
||||||
return msgpack.encode(object)
|
|
||||||
end
|
|
||||||
|
|
||||||
function Http.msgpackDecode(source)
|
|
||||||
return msgpack.decode(source)
|
|
||||||
end
|
|
||||||
|
|
||||||
return Http
|
return Http
|
||||||
|
|||||||
@@ -145,7 +145,7 @@ function ApiContext:connect()
|
|||||||
|
|
||||||
return Http.get(url)
|
return Http.get(url)
|
||||||
:andThen(rejectFailedRequests)
|
:andThen(rejectFailedRequests)
|
||||||
:andThen(Http.Response.msgpack)
|
:andThen(Http.Response.json)
|
||||||
:andThen(rejectWrongProtocolVersion)
|
:andThen(rejectWrongProtocolVersion)
|
||||||
:andThen(function(body)
|
:andThen(function(body)
|
||||||
assert(validateApiInfo(body))
|
assert(validateApiInfo(body))
|
||||||
@@ -163,7 +163,7 @@ end
|
|||||||
function ApiContext:read(ids)
|
function ApiContext:read(ids)
|
||||||
local url = ("%s/api/read/%s"):format(self.__baseUrl, table.concat(ids, ","))
|
local url = ("%s/api/read/%s"):format(self.__baseUrl, table.concat(ids, ","))
|
||||||
|
|
||||||
return Http.get(url):andThen(rejectFailedRequests):andThen(Http.Response.msgpack):andThen(function(body)
|
return Http.get(url):andThen(rejectFailedRequests):andThen(Http.Response.json):andThen(function(body)
|
||||||
if body.sessionId ~= self.__sessionId then
|
if body.sessionId ~= self.__sessionId then
|
||||||
return Promise.reject("Server changed ID")
|
return Promise.reject("Server changed ID")
|
||||||
end
|
end
|
||||||
@@ -191,9 +191,9 @@ function ApiContext:write(patch)
|
|||||||
table.insert(updated, fixedUpdate)
|
table.insert(updated, fixedUpdate)
|
||||||
end
|
end
|
||||||
|
|
||||||
-- Only add the 'added' field if the table is non-empty, or else the msgpack
|
-- Only add the 'added' field if the table is non-empty, or else Roblox's
|
||||||
-- encode implementation will turn the table into an array instead of a map,
|
-- JSON implementation will turn the table into an array instead of an
|
||||||
-- causing API validation to fail.
|
-- object, causing API validation to fail.
|
||||||
local added
|
local added
|
||||||
if next(patch.added) ~= nil then
|
if next(patch.added) ~= nil then
|
||||||
added = patch.added
|
added = patch.added
|
||||||
@@ -206,16 +206,13 @@ function ApiContext:write(patch)
|
|||||||
added = added,
|
added = added,
|
||||||
}
|
}
|
||||||
|
|
||||||
body = Http.msgpackEncode(body)
|
body = Http.jsonEncode(body)
|
||||||
|
|
||||||
return Http.post(url, body)
|
return Http.post(url, body):andThen(rejectFailedRequests):andThen(Http.Response.json):andThen(function(responseBody)
|
||||||
:andThen(rejectFailedRequests)
|
Log.info("Write response: {:?}", responseBody)
|
||||||
:andThen(Http.Response.msgpack)
|
|
||||||
:andThen(function(responseBody)
|
|
||||||
Log.info("Write response: {:?}", responseBody)
|
|
||||||
|
|
||||||
return responseBody
|
return responseBody
|
||||||
end)
|
end)
|
||||||
end
|
end
|
||||||
|
|
||||||
function ApiContext:connectWebSocket(packetHandlers)
|
function ApiContext:connectWebSocket(packetHandlers)
|
||||||
@@ -237,7 +234,7 @@ function ApiContext:connectWebSocket(packetHandlers)
|
|||||||
local closed, errored, received
|
local closed, errored, received
|
||||||
|
|
||||||
received = self.__wsClient.MessageReceived:Connect(function(msg)
|
received = self.__wsClient.MessageReceived:Connect(function(msg)
|
||||||
local data = Http.msgpackDecode(msg)
|
local data = Http.jsonDecode(msg)
|
||||||
if data.sessionId ~= self.__sessionId then
|
if data.sessionId ~= self.__sessionId then
|
||||||
Log.warn("Received message with wrong session ID; ignoring")
|
Log.warn("Received message with wrong session ID; ignoring")
|
||||||
return
|
return
|
||||||
@@ -283,7 +280,7 @@ end
|
|||||||
function ApiContext:open(id)
|
function ApiContext:open(id)
|
||||||
local url = ("%s/api/open/%s"):format(self.__baseUrl, id)
|
local url = ("%s/api/open/%s"):format(self.__baseUrl, id)
|
||||||
|
|
||||||
return Http.post(url, ""):andThen(rejectFailedRequests):andThen(Http.Response.msgpack):andThen(function(body)
|
return Http.post(url, ""):andThen(rejectFailedRequests):andThen(Http.Response.json):andThen(function(body)
|
||||||
if body.sessionId ~= self.__sessionId then
|
if body.sessionId ~= self.__sessionId then
|
||||||
return Promise.reject("Server changed ID")
|
return Promise.reject("Server changed ID")
|
||||||
end
|
end
|
||||||
@@ -293,39 +290,31 @@ function ApiContext:open(id)
|
|||||||
end
|
end
|
||||||
|
|
||||||
function ApiContext:serialize(ids: { string })
|
function ApiContext:serialize(ids: { string })
|
||||||
local url = ("%s/api/serialize"):format(self.__baseUrl)
|
local url = ("%s/api/serialize/%s"):format(self.__baseUrl, table.concat(ids, ","))
|
||||||
local request_body = Http.msgpackEncode({ sessionId = self.__sessionId, ids = ids })
|
|
||||||
|
|
||||||
return Http.post(url, request_body)
|
return Http.get(url):andThen(rejectFailedRequests):andThen(Http.Response.json):andThen(function(body)
|
||||||
:andThen(rejectFailedRequests)
|
if body.sessionId ~= self.__sessionId then
|
||||||
:andThen(Http.Response.msgpack)
|
return Promise.reject("Server changed ID")
|
||||||
:andThen(function(response_body)
|
end
|
||||||
if response_body.sessionId ~= self.__sessionId then
|
|
||||||
return Promise.reject("Server changed ID")
|
|
||||||
end
|
|
||||||
|
|
||||||
assert(validateApiSerialize(response_body))
|
assert(validateApiSerialize(body))
|
||||||
|
|
||||||
return response_body
|
return body
|
||||||
end)
|
end)
|
||||||
end
|
end
|
||||||
|
|
||||||
function ApiContext:refPatch(ids: { string })
|
function ApiContext:refPatch(ids: { string })
|
||||||
local url = ("%s/api/ref-patch"):format(self.__baseUrl)
|
local url = ("%s/api/ref-patch/%s"):format(self.__baseUrl, table.concat(ids, ","))
|
||||||
local request_body = Http.msgpackEncode({ sessionId = self.__sessionId, ids = ids })
|
|
||||||
|
|
||||||
return Http.post(url, request_body)
|
return Http.get(url):andThen(rejectFailedRequests):andThen(Http.Response.json):andThen(function(body)
|
||||||
:andThen(rejectFailedRequests)
|
if body.sessionId ~= self.__sessionId then
|
||||||
:andThen(Http.Response.msgpack)
|
return Promise.reject("Server changed ID")
|
||||||
:andThen(function(response_body)
|
end
|
||||||
if response_body.sessionId ~= self.__sessionId then
|
|
||||||
return Promise.reject("Server changed ID")
|
|
||||||
end
|
|
||||||
|
|
||||||
assert(validateApiRefPatch(response_body))
|
assert(validateApiRefPatch(body))
|
||||||
|
|
||||||
return response_body
|
return body
|
||||||
end)
|
end)
|
||||||
end
|
end
|
||||||
|
|
||||||
return ApiContext
|
return ApiContext
|
||||||
|
|||||||
@@ -19,15 +19,9 @@ local FullscreenNotification = Roact.Component:extend("FullscreeFullscreenNotifi
|
|||||||
function FullscreenNotification:init()
|
function FullscreenNotification:init()
|
||||||
self.transparency, self.setTransparency = Roact.createBinding(0)
|
self.transparency, self.setTransparency = Roact.createBinding(0)
|
||||||
self.lifetime = self.props.timeout
|
self.lifetime = self.props.timeout
|
||||||
self.dismissed = false
|
|
||||||
end
|
end
|
||||||
|
|
||||||
function FullscreenNotification:dismiss()
|
function FullscreenNotification:dismiss()
|
||||||
if self.dismissed then
|
|
||||||
return
|
|
||||||
end
|
|
||||||
self.dismissed = true
|
|
||||||
|
|
||||||
if self.props.onClose then
|
if self.props.onClose then
|
||||||
self.props.onClose()
|
self.props.onClose()
|
||||||
end
|
end
|
||||||
@@ -65,7 +59,7 @@ function FullscreenNotification:didMount()
|
|||||||
end
|
end
|
||||||
|
|
||||||
function FullscreenNotification:willUnmount()
|
function FullscreenNotification:willUnmount()
|
||||||
if self.timeout and coroutine.status(self.timeout) == "suspended" then
|
if self.timeout and coroutine.status(self.timeout) ~= "dead" then
|
||||||
task.cancel(self.timeout)
|
task.cancel(self.timeout)
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|||||||
@@ -25,7 +25,6 @@ function Notification:init()
|
|||||||
self.binding = bindingUtil.fromMotor(self.motor)
|
self.binding = bindingUtil.fromMotor(self.motor)
|
||||||
|
|
||||||
self.lifetime = self.props.timeout
|
self.lifetime = self.props.timeout
|
||||||
self.dismissed = false
|
|
||||||
|
|
||||||
self.motor:onStep(function(value)
|
self.motor:onStep(function(value)
|
||||||
if value <= 0 and self.props.onClose then
|
if value <= 0 and self.props.onClose then
|
||||||
@@ -35,11 +34,6 @@ function Notification:init()
|
|||||||
end
|
end
|
||||||
|
|
||||||
function Notification:dismiss()
|
function Notification:dismiss()
|
||||||
if self.dismissed then
|
|
||||||
return
|
|
||||||
end
|
|
||||||
self.dismissed = true
|
|
||||||
|
|
||||||
self.motor:setGoal(Flipper.Spring.new(0, {
|
self.motor:setGoal(Flipper.Spring.new(0, {
|
||||||
frequency = 5,
|
frequency = 5,
|
||||||
dampingRatio = 1,
|
dampingRatio = 1,
|
||||||
@@ -81,7 +75,7 @@ function Notification:didMount()
|
|||||||
end
|
end
|
||||||
|
|
||||||
function Notification:willUnmount()
|
function Notification:willUnmount()
|
||||||
if self.timeout and coroutine.status(self.timeout) == "suspended" then
|
if self.timeout and coroutine.status(self.timeout) ~= "dead" then
|
||||||
task.cancel(self.timeout)
|
task.cancel(self.timeout)
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|||||||
@@ -301,19 +301,6 @@ function App:setPriorSyncInfo(host: string, port: string, projectName: string)
|
|||||||
Settings:set("priorEndpoints", priorSyncInfos)
|
Settings:set("priorEndpoints", priorSyncInfos)
|
||||||
end
|
end
|
||||||
|
|
||||||
function App:forgetPriorSyncInfo()
|
|
||||||
local priorSyncInfos = Settings:get("priorEndpoints")
|
|
||||||
if not priorSyncInfos then
|
|
||||||
priorSyncInfos = {}
|
|
||||||
end
|
|
||||||
|
|
||||||
local id = tostring(game.PlaceId)
|
|
||||||
priorSyncInfos[id] = nil
|
|
||||||
Log.trace("Erased last used endpoint for {}", game.PlaceId)
|
|
||||||
|
|
||||||
Settings:set("priorEndpoints", priorSyncInfos)
|
|
||||||
end
|
|
||||||
|
|
||||||
function App:getHostAndPort()
|
function App:getHostAndPort()
|
||||||
local host = self.host:getValue()
|
local host = self.host:getValue()
|
||||||
local port = self.port:getValue()
|
local port = self.port:getValue()
|
||||||
@@ -448,8 +435,7 @@ function App:checkSyncReminder()
|
|||||||
self:findActiveServer()
|
self:findActiveServer()
|
||||||
:andThen(function(serverInfo, host, port)
|
:andThen(function(serverInfo, host, port)
|
||||||
self:sendSyncReminder(
|
self:sendSyncReminder(
|
||||||
`Project '{serverInfo.projectName}' is serving at {host}:{port}.\nWould you like to connect?`,
|
`Project '{serverInfo.projectName}' is serving at {host}:{port}.\nWould you like to connect?`
|
||||||
{ "Connect", "Dismiss" }
|
|
||||||
)
|
)
|
||||||
end)
|
end)
|
||||||
:catch(function()
|
:catch(function()
|
||||||
@@ -460,8 +446,7 @@ function App:checkSyncReminder()
|
|||||||
|
|
||||||
local timeSinceSync = timeUtil.elapsedToText(os.time() - priorSyncInfo.timestamp)
|
local timeSinceSync = timeUtil.elapsedToText(os.time() - priorSyncInfo.timestamp)
|
||||||
self:sendSyncReminder(
|
self:sendSyncReminder(
|
||||||
`You synced project '{priorSyncInfo.projectName}' to this place {timeSinceSync}.\nDid you mean to run 'rojo serve' and then connect?`,
|
`You synced project '{priorSyncInfo.projectName}' to this place {timeSinceSync}.\nDid you mean to run 'rojo serve' and then connect?`
|
||||||
{ "Connect", "Forget", "Dismiss" }
|
|
||||||
)
|
)
|
||||||
end
|
end
|
||||||
end)
|
end)
|
||||||
@@ -501,16 +486,12 @@ function App:stopSyncReminderPolling()
|
|||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
function App:sendSyncReminder(message: string, shownActions: { string })
|
function App:sendSyncReminder(message: string)
|
||||||
local syncReminderMode = Settings:get("syncReminderMode")
|
local syncReminderMode = Settings:get("syncReminderMode")
|
||||||
if syncReminderMode == "None" then
|
if syncReminderMode == "None" then
|
||||||
return
|
return
|
||||||
end
|
end
|
||||||
|
|
||||||
local connectIndex = table.find(shownActions, "Connect")
|
|
||||||
local forgetIndex = table.find(shownActions, "Forget")
|
|
||||||
local dismissIndex = table.find(shownActions, "Dismiss")
|
|
||||||
|
|
||||||
self.dismissSyncReminder = self:addNotification({
|
self.dismissSyncReminder = self:addNotification({
|
||||||
text = message,
|
text = message,
|
||||||
timeout = 120,
|
timeout = 120,
|
||||||
@@ -519,39 +500,24 @@ function App:sendSyncReminder(message: string, shownActions: { string })
|
|||||||
self.dismissSyncReminder = nil
|
self.dismissSyncReminder = nil
|
||||||
end,
|
end,
|
||||||
actions = {
|
actions = {
|
||||||
Connect = if connectIndex
|
Connect = {
|
||||||
then {
|
text = "Connect",
|
||||||
text = "Connect",
|
style = "Solid",
|
||||||
style = "Solid",
|
layoutOrder = 1,
|
||||||
layoutOrder = connectIndex,
|
onClick = function()
|
||||||
onClick = function()
|
self:startSession()
|
||||||
self:startSession()
|
end,
|
||||||
end,
|
},
|
||||||
}
|
Dismiss = {
|
||||||
else nil,
|
text = "Dismiss",
|
||||||
Forget = if forgetIndex
|
style = "Bordered",
|
||||||
then {
|
layoutOrder = 2,
|
||||||
text = "Forget",
|
onClick = function()
|
||||||
style = "Bordered",
|
-- If the user dismisses the reminder,
|
||||||
layoutOrder = forgetIndex,
|
-- then we don't need to remind them again
|
||||||
onClick = function()
|
self:stopSyncReminderPolling()
|
||||||
-- The user doesn't want to be reminded again about this sync
|
end,
|
||||||
self:forgetPriorSyncInfo()
|
},
|
||||||
end,
|
|
||||||
}
|
|
||||||
else nil,
|
|
||||||
Dismiss = if dismissIndex
|
|
||||||
then {
|
|
||||||
text = "Dismiss",
|
|
||||||
style = "Bordered",
|
|
||||||
layoutOrder = dismissIndex,
|
|
||||||
onClick = function()
|
|
||||||
-- If the user dismisses the reminder,
|
|
||||||
-- then we don't need to remind them again
|
|
||||||
self:stopSyncReminderPolling()
|
|
||||||
end,
|
|
||||||
}
|
|
||||||
else nil,
|
|
||||||
},
|
},
|
||||||
})
|
})
|
||||||
end
|
end
|
||||||
|
|||||||
@@ -54,10 +54,6 @@ local function trueEquals(a, b): boolean
|
|||||||
end
|
end
|
||||||
return true
|
return true
|
||||||
|
|
||||||
-- For NaN, check if both values are not equal to themselves
|
|
||||||
elseif a ~= a and b ~= b then
|
|
||||||
return true
|
|
||||||
|
|
||||||
-- For numbers, compare with epsilon of 0.0001 to avoid floating point inequality
|
-- For numbers, compare with epsilon of 0.0001 to avoid floating point inequality
|
||||||
elseif typeA == "number" and typeB == "number" then
|
elseif typeA == "number" and typeB == "number" then
|
||||||
return fuzzyEq(a, b, 0.0001)
|
return fuzzyEq(a, b, 0.0001)
|
||||||
|
|||||||
@@ -3,4 +3,3 @@ rojo = "rojo-rbx/rojo@7.5.1"
|
|||||||
selene = "Kampfkarren/selene@0.29.0"
|
selene = "Kampfkarren/selene@0.29.0"
|
||||||
stylua = "JohnnyMorganz/stylua@2.1.0"
|
stylua = "JohnnyMorganz/stylua@2.1.0"
|
||||||
run-in-roblox = "rojo-rbx/run-in-roblox@0.3.0"
|
run-in-roblox = "rojo-rbx/run-in-roblox@0.3.0"
|
||||||
lune = "lune-org/lune@0.10.4"
|
|
||||||
|
|||||||
@@ -1,14 +1,15 @@
|
|||||||
use crossbeam_channel::{select, Receiver, RecvError, Sender};
|
|
||||||
use jod_thread::JoinHandle;
|
|
||||||
use memofs::{IoResultExt, Vfs, VfsEvent};
|
|
||||||
use rbx_dom_weak::types::{Ref, Variant};
|
|
||||||
use std::path::PathBuf;
|
|
||||||
use std::{
|
use std::{
|
||||||
fs,
|
fs,
|
||||||
sync::{Arc, Mutex},
|
sync::{Arc, Mutex},
|
||||||
};
|
};
|
||||||
|
|
||||||
|
use crossbeam_channel::{select, Receiver, RecvError, Sender};
|
||||||
|
use jod_thread::JoinHandle;
|
||||||
|
use memofs::{IoResultExt, Vfs, VfsEvent};
|
||||||
|
use rbx_dom_weak::types::{Ref, Variant};
|
||||||
|
|
||||||
use crate::{
|
use crate::{
|
||||||
|
git::SharedGitFilter,
|
||||||
message_queue::MessageQueue,
|
message_queue::MessageQueue,
|
||||||
snapshot::{
|
snapshot::{
|
||||||
apply_patch_set, compute_patch_set, AppliedPatchSet, InstigatingSource, PatchSet, RojoTree,
|
apply_patch_set, compute_patch_set, AppliedPatchSet, InstigatingSource, PatchSet, RojoTree,
|
||||||
@@ -46,11 +47,15 @@ pub struct ChangeProcessor {
|
|||||||
impl ChangeProcessor {
|
impl ChangeProcessor {
|
||||||
/// Spin up the ChangeProcessor, connecting it to the given tree, VFS, and
|
/// Spin up the ChangeProcessor, connecting it to the given tree, VFS, and
|
||||||
/// outbound message queue.
|
/// outbound message queue.
|
||||||
|
///
|
||||||
|
/// If `git_filter` is provided, it will be refreshed on every VFS event
|
||||||
|
/// to ensure newly changed files are acknowledged.
|
||||||
pub fn start(
|
pub fn start(
|
||||||
tree: Arc<Mutex<RojoTree>>,
|
tree: Arc<Mutex<RojoTree>>,
|
||||||
vfs: Arc<Vfs>,
|
vfs: Arc<Vfs>,
|
||||||
message_queue: Arc<MessageQueue<AppliedPatchSet>>,
|
message_queue: Arc<MessageQueue<AppliedPatchSet>>,
|
||||||
tree_mutation_receiver: Receiver<PatchSet>,
|
tree_mutation_receiver: Receiver<PatchSet>,
|
||||||
|
git_filter: Option<SharedGitFilter>,
|
||||||
) -> Self {
|
) -> Self {
|
||||||
let (shutdown_sender, shutdown_receiver) = crossbeam_channel::bounded(1);
|
let (shutdown_sender, shutdown_receiver) = crossbeam_channel::bounded(1);
|
||||||
let vfs_receiver = vfs.event_receiver();
|
let vfs_receiver = vfs.event_receiver();
|
||||||
@@ -58,6 +63,7 @@ impl ChangeProcessor {
|
|||||||
tree,
|
tree,
|
||||||
vfs,
|
vfs,
|
||||||
message_queue,
|
message_queue,
|
||||||
|
git_filter,
|
||||||
};
|
};
|
||||||
|
|
||||||
let job_thread = jod_thread::Builder::new()
|
let job_thread = jod_thread::Builder::new()
|
||||||
@@ -111,55 +117,24 @@ struct JobThreadContext {
|
|||||||
/// Whenever changes are applied to the DOM, we should push those changes
|
/// Whenever changes are applied to the DOM, we should push those changes
|
||||||
/// into this message queue to inform any connected clients.
|
/// into this message queue to inform any connected clients.
|
||||||
message_queue: Arc<MessageQueue<AppliedPatchSet>>,
|
message_queue: Arc<MessageQueue<AppliedPatchSet>>,
|
||||||
|
|
||||||
|
/// Optional Git filter for --git-since mode. When set, will be refreshed
|
||||||
|
/// on every VFS event to ensure newly changed files are acknowledged.
|
||||||
|
git_filter: Option<SharedGitFilter>,
|
||||||
}
|
}
|
||||||
|
|
||||||
impl JobThreadContext {
|
impl JobThreadContext {
|
||||||
/// Computes and applies patches to the DOM for a given file path.
|
|
||||||
///
|
|
||||||
/// This function finds the nearest ancestor to the given path that has associated instances
|
|
||||||
/// in the tree.
|
|
||||||
/// It then computes and applies changes for each affected instance ID and
|
|
||||||
/// returns a vector of applied patch sets.
|
|
||||||
fn apply_patches(&self, path: PathBuf) -> Vec<AppliedPatchSet> {
|
|
||||||
let mut tree = self.tree.lock().unwrap();
|
|
||||||
let mut applied_patches = Vec::new();
|
|
||||||
|
|
||||||
// Find the nearest ancestor to this path that has
|
|
||||||
// associated instances in the tree. This helps make sure
|
|
||||||
// that we handle additions correctly, especially if we
|
|
||||||
// receive events for descendants of a large tree being
|
|
||||||
// created all at once.
|
|
||||||
let mut current_path = path.as_path();
|
|
||||||
let affected_ids = loop {
|
|
||||||
let ids = tree.get_ids_at_path(current_path);
|
|
||||||
|
|
||||||
log::trace!("Path {} affects IDs {:?}", current_path.display(), ids);
|
|
||||||
|
|
||||||
if !ids.is_empty() {
|
|
||||||
break ids.to_vec();
|
|
||||||
}
|
|
||||||
|
|
||||||
log::trace!("Trying parent path...");
|
|
||||||
match current_path.parent() {
|
|
||||||
Some(parent) => current_path = parent,
|
|
||||||
None => break Vec::new(),
|
|
||||||
}
|
|
||||||
};
|
|
||||||
|
|
||||||
for id in affected_ids {
|
|
||||||
if let Some(patch) = compute_and_apply_changes(&mut tree, &self.vfs, id) {
|
|
||||||
if !patch.is_empty() {
|
|
||||||
applied_patches.push(patch);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
applied_patches
|
|
||||||
}
|
|
||||||
|
|
||||||
fn handle_vfs_event(&self, event: VfsEvent) {
|
fn handle_vfs_event(&self, event: VfsEvent) {
|
||||||
log::trace!("Vfs event: {:?}", event);
|
log::trace!("Vfs event: {:?}", event);
|
||||||
|
|
||||||
|
// If we have a git filter, refresh it to pick up any new changes.
|
||||||
|
// This ensures that files modified during the session will be acknowledged.
|
||||||
|
if let Some(ref git_filter) = self.git_filter {
|
||||||
|
if let Err(err) = git_filter.refresh() {
|
||||||
|
log::warn!("Failed to refresh git filter: {:?}", err);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
// Update the VFS immediately with the event.
|
// Update the VFS immediately with the event.
|
||||||
self.vfs
|
self.vfs
|
||||||
.commit_event(&event)
|
.commit_event(&event)
|
||||||
@@ -168,16 +143,54 @@ impl JobThreadContext {
|
|||||||
// For a given VFS event, we might have many changes to different parts
|
// For a given VFS event, we might have many changes to different parts
|
||||||
// of the tree. Calculate and apply all of these changes.
|
// of the tree. Calculate and apply all of these changes.
|
||||||
let applied_patches = match event {
|
let applied_patches = match event {
|
||||||
VfsEvent::Create(path) | VfsEvent::Write(path) => {
|
VfsEvent::Create(path) | VfsEvent::Remove(path) | VfsEvent::Write(path) => {
|
||||||
self.apply_patches(self.vfs.canonicalize(&path).unwrap())
|
let mut tree = self.tree.lock().unwrap();
|
||||||
}
|
let mut applied_patches = Vec::new();
|
||||||
VfsEvent::Remove(path) => {
|
|
||||||
// MemoFS does not track parent removals yet, so we can canonicalize
|
// Find the nearest ancestor to this path that has
|
||||||
// the parent path safely and then append the removed path's file name.
|
// associated instances in the tree. This helps make sure
|
||||||
let parent = path.parent().unwrap();
|
// that we handle additions correctly, especially if we
|
||||||
let file_name = path.file_name().unwrap();
|
// receive events for descendants of a large tree being
|
||||||
let parent_normalized = self.vfs.canonicalize(parent).unwrap();
|
// created all at once.
|
||||||
self.apply_patches(parent_normalized.join(file_name))
|
let mut current_path = path.as_path();
|
||||||
|
let affected_ids = loop {
|
||||||
|
let ids = tree.get_ids_at_path(current_path);
|
||||||
|
|
||||||
|
log::trace!("Path {} affects IDs {:?}", current_path.display(), ids);
|
||||||
|
|
||||||
|
if !ids.is_empty() {
|
||||||
|
break ids.to_vec();
|
||||||
|
}
|
||||||
|
|
||||||
|
log::trace!("Trying parent path...");
|
||||||
|
match current_path.parent() {
|
||||||
|
Some(parent) => current_path = parent,
|
||||||
|
None => break Vec::new(),
|
||||||
|
}
|
||||||
|
};
|
||||||
|
|
||||||
|
if affected_ids.is_empty() {
|
||||||
|
log::debug!(
|
||||||
|
"No instances found for path {} or any of its ancestors",
|
||||||
|
path.display()
|
||||||
|
);
|
||||||
|
} else {
|
||||||
|
log::debug!(
|
||||||
|
"Found {} affected instances for path {}",
|
||||||
|
affected_ids.len(),
|
||||||
|
path.display()
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
for id in affected_ids {
|
||||||
|
if let Some(patch) = compute_and_apply_changes(&mut tree, &self.vfs, id) {
|
||||||
|
if !patch.is_empty() {
|
||||||
|
applied_patches.push(patch);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
applied_patches
|
||||||
}
|
}
|
||||||
_ => {
|
_ => {
|
||||||
log::warn!("Unhandled VFS event: {:?}", event);
|
log::warn!("Unhandled VFS event: {:?}", event);
|
||||||
|
|||||||
@@ -81,7 +81,7 @@ impl BuildCommand {
|
|||||||
let vfs = Vfs::new_default();
|
let vfs = Vfs::new_default();
|
||||||
vfs.set_watch_enabled(self.watch);
|
vfs.set_watch_enabled(self.watch);
|
||||||
|
|
||||||
let session = ServeSession::new(vfs, project_path)?;
|
let session = ServeSession::new(vfs, project_path, None)?;
|
||||||
let mut cursor = session.message_queue().cursor();
|
let mut cursor = session.message_queue().cursor();
|
||||||
|
|
||||||
write_model(&session, &output_path, output_kind)?;
|
write_model(&session, &output_path, output_kind)?;
|
||||||
|
|||||||
@@ -54,7 +54,7 @@ fn initialize_plugin() -> anyhow::Result<ServeSession> {
|
|||||||
in_memory_fs.load_snapshot("/plugin", plugin_snapshot)?;
|
in_memory_fs.load_snapshot("/plugin", plugin_snapshot)?;
|
||||||
|
|
||||||
let vfs = Vfs::new(in_memory_fs);
|
let vfs = Vfs::new(in_memory_fs);
|
||||||
Ok(ServeSession::new(vfs, "/plugin")?)
|
Ok(ServeSession::new(vfs, "/plugin", None)?)
|
||||||
}
|
}
|
||||||
|
|
||||||
fn install_plugin() -> anyhow::Result<()> {
|
fn install_plugin() -> anyhow::Result<()> {
|
||||||
@@ -98,5 +98,5 @@ fn uninstall_plugin() -> anyhow::Result<()> {
|
|||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn plugin_initialize() {
|
fn plugin_initialize() {
|
||||||
let _ = initialize_plugin().unwrap();
|
assert!(initialize_plugin().is_ok())
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -9,7 +9,7 @@ use clap::Parser;
|
|||||||
use memofs::Vfs;
|
use memofs::Vfs;
|
||||||
use termcolor::{BufferWriter, Color, ColorChoice, ColorSpec, WriteColor};
|
use termcolor::{BufferWriter, Color, ColorChoice, ColorSpec, WriteColor};
|
||||||
|
|
||||||
use crate::{serve_session::ServeSession, web::LiveServer};
|
use crate::{git::GitFilter, serve_session::ServeSession, web::LiveServer};
|
||||||
|
|
||||||
use super::{resolve_path, GlobalOptions};
|
use super::{resolve_path, GlobalOptions};
|
||||||
|
|
||||||
@@ -31,6 +31,19 @@ pub struct ServeCommand {
|
|||||||
/// it has none.
|
/// it has none.
|
||||||
#[clap(long)]
|
#[clap(long)]
|
||||||
pub port: Option<u16>,
|
pub port: Option<u16>,
|
||||||
|
|
||||||
|
/// Only sync files that have changed since the given Git reference.
|
||||||
|
///
|
||||||
|
/// When this option is set, Rojo will only include files that have been
|
||||||
|
/// modified, added, or are untracked since the specified Git reference
|
||||||
|
/// (e.g., "HEAD", "main", a commit hash). This is useful for working with
|
||||||
|
/// large projects where you only want to sync your local changes.
|
||||||
|
///
|
||||||
|
/// Scripts that have not changed will still be acknowledged if modified
|
||||||
|
/// during the session, and all synced instances will have
|
||||||
|
/// ignoreUnknownInstances set to true to preserve descendants in Studio.
|
||||||
|
#[clap(long, value_name = "REF")]
|
||||||
|
pub git_since: Option<String>,
|
||||||
}
|
}
|
||||||
|
|
||||||
impl ServeCommand {
|
impl ServeCommand {
|
||||||
@@ -39,7 +52,19 @@ impl ServeCommand {
|
|||||||
|
|
||||||
let vfs = Vfs::new_default();
|
let vfs = Vfs::new_default();
|
||||||
|
|
||||||
let session = Arc::new(ServeSession::new(vfs, project_path)?);
|
// Set up Git filter if --git-since was specified
|
||||||
|
let git_filter = if let Some(ref base_ref) = self.git_since {
|
||||||
|
let repo_root = GitFilter::find_repo_root(&project_path)?;
|
||||||
|
log::info!(
|
||||||
|
"Git filter enabled: only syncing files changed since '{}'",
|
||||||
|
base_ref
|
||||||
|
);
|
||||||
|
Some(Arc::new(GitFilter::new(repo_root, base_ref.clone(), &project_path)?))
|
||||||
|
} else {
|
||||||
|
None
|
||||||
|
};
|
||||||
|
|
||||||
|
let session = Arc::new(ServeSession::new(vfs, project_path, git_filter)?);
|
||||||
|
|
||||||
let ip = self
|
let ip = self
|
||||||
.address
|
.address
|
||||||
@@ -53,17 +78,25 @@ impl ServeCommand {
|
|||||||
|
|
||||||
let server = LiveServer::new(session);
|
let server = LiveServer::new(session);
|
||||||
|
|
||||||
let _ = show_start_message(ip, port, global.color.into());
|
let _ = show_start_message(ip, port, self.git_since.as_deref(), global.color.into());
|
||||||
server.start((ip, port).into());
|
server.start((ip, port).into());
|
||||||
|
|
||||||
Ok(())
|
Ok(())
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
fn show_start_message(bind_address: IpAddr, port: u16, color: ColorChoice) -> io::Result<()> {
|
fn show_start_message(
|
||||||
|
bind_address: IpAddr,
|
||||||
|
port: u16,
|
||||||
|
git_since: Option<&str>,
|
||||||
|
color: ColorChoice,
|
||||||
|
) -> io::Result<()> {
|
||||||
let mut green = ColorSpec::new();
|
let mut green = ColorSpec::new();
|
||||||
green.set_fg(Some(Color::Green)).set_bold(true);
|
green.set_fg(Some(Color::Green)).set_bold(true);
|
||||||
|
|
||||||
|
let mut yellow = ColorSpec::new();
|
||||||
|
yellow.set_fg(Some(Color::Yellow)).set_bold(true);
|
||||||
|
|
||||||
let writer = BufferWriter::stdout(color);
|
let writer = BufferWriter::stdout(color);
|
||||||
let mut buffer = writer.buffer();
|
let mut buffer = writer.buffer();
|
||||||
|
|
||||||
@@ -84,6 +117,13 @@ fn show_start_message(bind_address: IpAddr, port: u16, color: ColorChoice) -> io
|
|||||||
buffer.set_color(&green)?;
|
buffer.set_color(&green)?;
|
||||||
writeln!(&mut buffer, "{}", port)?;
|
writeln!(&mut buffer, "{}", port)?;
|
||||||
|
|
||||||
|
if let Some(base_ref) = git_since {
|
||||||
|
buffer.set_color(&ColorSpec::new())?;
|
||||||
|
write!(&mut buffer, " Mode: ")?;
|
||||||
|
buffer.set_color(&yellow)?;
|
||||||
|
writeln!(&mut buffer, "git-since ({})", base_ref)?;
|
||||||
|
}
|
||||||
|
|
||||||
writeln!(&mut buffer)?;
|
writeln!(&mut buffer)?;
|
||||||
|
|
||||||
buffer.set_color(&ColorSpec::new())?;
|
buffer.set_color(&ColorSpec::new())?;
|
||||||
|
|||||||
@@ -1,35 +0,0 @@
|
|||||||
---
|
|
||||||
source: src/cli/sourcemap.rs
|
|
||||||
expression: sourcemap_contents
|
|
||||||
---
|
|
||||||
{
|
|
||||||
"name": "default",
|
|
||||||
"className": "DataModel",
|
|
||||||
"filePaths": "[...1 path omitted...]",
|
|
||||||
"children": [
|
|
||||||
{
|
|
||||||
"name": "ReplicatedStorage",
|
|
||||||
"className": "ReplicatedStorage",
|
|
||||||
"children": [
|
|
||||||
{
|
|
||||||
"name": "Project",
|
|
||||||
"className": "ModuleScript",
|
|
||||||
"filePaths": "[...1 path omitted...]",
|
|
||||||
"children": [
|
|
||||||
{
|
|
||||||
"name": "Module",
|
|
||||||
"className": "Folder",
|
|
||||||
"children": [
|
|
||||||
{
|
|
||||||
"name": "module",
|
|
||||||
"className": "ModuleScript",
|
|
||||||
"filePaths": "[...1 path omitted...]"
|
|
||||||
}
|
|
||||||
]
|
|
||||||
}
|
|
||||||
]
|
|
||||||
}
|
|
||||||
]
|
|
||||||
}
|
|
||||||
]
|
|
||||||
}
|
|
||||||
@@ -1,41 +0,0 @@
|
|||||||
---
|
|
||||||
source: src/cli/sourcemap.rs
|
|
||||||
expression: sourcemap_contents
|
|
||||||
---
|
|
||||||
{
|
|
||||||
"name": "default",
|
|
||||||
"className": "DataModel",
|
|
||||||
"filePaths": [
|
|
||||||
"default.project.json"
|
|
||||||
],
|
|
||||||
"children": [
|
|
||||||
{
|
|
||||||
"name": "ReplicatedStorage",
|
|
||||||
"className": "ReplicatedStorage",
|
|
||||||
"children": [
|
|
||||||
{
|
|
||||||
"name": "Project",
|
|
||||||
"className": "ModuleScript",
|
|
||||||
"filePaths": [
|
|
||||||
"src/init.luau"
|
|
||||||
],
|
|
||||||
"children": [
|
|
||||||
{
|
|
||||||
"name": "Module",
|
|
||||||
"className": "Folder",
|
|
||||||
"children": [
|
|
||||||
{
|
|
||||||
"name": "module",
|
|
||||||
"className": "ModuleScript",
|
|
||||||
"filePaths": [
|
|
||||||
"../module/module.luau"
|
|
||||||
]
|
|
||||||
}
|
|
||||||
]
|
|
||||||
}
|
|
||||||
]
|
|
||||||
}
|
|
||||||
]
|
|
||||||
}
|
|
||||||
]
|
|
||||||
}
|
|
||||||
@@ -10,7 +10,7 @@ use fs_err::File;
|
|||||||
use memofs::Vfs;
|
use memofs::Vfs;
|
||||||
use rayon::prelude::*;
|
use rayon::prelude::*;
|
||||||
use rbx_dom_weak::{types::Ref, Ustr};
|
use rbx_dom_weak::{types::Ref, Ustr};
|
||||||
use serde::{Deserialize, Serialize};
|
use serde::Serialize;
|
||||||
use tokio::runtime::Runtime;
|
use tokio::runtime::Runtime;
|
||||||
|
|
||||||
use crate::{
|
use crate::{
|
||||||
@@ -24,20 +24,19 @@ const PATH_STRIP_FAILED_ERR: &str = "Failed to create relative paths for project
|
|||||||
const ABSOLUTE_PATH_FAILED_ERR: &str = "Failed to turn relative path into absolute path!";
|
const ABSOLUTE_PATH_FAILED_ERR: &str = "Failed to turn relative path into absolute path!";
|
||||||
|
|
||||||
/// Representation of a node in the generated sourcemap tree.
|
/// Representation of a node in the generated sourcemap tree.
|
||||||
#[derive(Serialize, Deserialize)]
|
#[derive(Serialize)]
|
||||||
#[serde(rename_all = "camelCase")]
|
#[serde(rename_all = "camelCase")]
|
||||||
struct SourcemapNode<'a> {
|
struct SourcemapNode<'a> {
|
||||||
name: &'a str,
|
name: &'a str,
|
||||||
class_name: Ustr,
|
class_name: Ustr,
|
||||||
|
|
||||||
#[serde(
|
#[serde(
|
||||||
default,
|
|
||||||
skip_serializing_if = "Vec::is_empty",
|
skip_serializing_if = "Vec::is_empty",
|
||||||
serialize_with = "crate::path_serializer::serialize_vec_absolute"
|
serialize_with = "crate::path_serializer::serialize_vec_absolute"
|
||||||
)]
|
)]
|
||||||
file_paths: Vec<Cow<'a, Path>>,
|
file_paths: Vec<Cow<'a, Path>>,
|
||||||
|
|
||||||
#[serde(default, skip_serializing_if = "Vec::is_empty")]
|
#[serde(skip_serializing_if = "Vec::is_empty")]
|
||||||
children: Vec<SourcemapNode<'a>>,
|
children: Vec<SourcemapNode<'a>>,
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -71,14 +70,13 @@ pub struct SourcemapCommand {
|
|||||||
|
|
||||||
impl SourcemapCommand {
|
impl SourcemapCommand {
|
||||||
pub fn run(self) -> anyhow::Result<()> {
|
pub fn run(self) -> anyhow::Result<()> {
|
||||||
let project_path = fs_err::canonicalize(resolve_path(&self.project))?;
|
let project_path = resolve_path(&self.project);
|
||||||
|
|
||||||
log::trace!("Constructing filesystem with StdBackend");
|
log::trace!("Constructing in-memory filesystem");
|
||||||
let vfs = Vfs::new_default();
|
let vfs = Vfs::new_default();
|
||||||
vfs.set_watch_enabled(self.watch);
|
vfs.set_watch_enabled(self.watch);
|
||||||
|
|
||||||
log::trace!("Setting up session for sourcemap generation");
|
let session = ServeSession::new(vfs, project_path, None)?;
|
||||||
let session = ServeSession::new(vfs, project_path)?;
|
|
||||||
let mut cursor = session.message_queue().cursor();
|
let mut cursor = session.message_queue().cursor();
|
||||||
|
|
||||||
let filter = if self.include_non_scripts {
|
let filter = if self.include_non_scripts {
|
||||||
@@ -89,17 +87,14 @@ impl SourcemapCommand {
|
|||||||
|
|
||||||
// Pre-build a rayon threadpool with a low number of threads to avoid
|
// Pre-build a rayon threadpool with a low number of threads to avoid
|
||||||
// dynamic creation overhead on systems with a high number of cpus.
|
// dynamic creation overhead on systems with a high number of cpus.
|
||||||
log::trace!("Setting rayon global threadpool");
|
|
||||||
rayon::ThreadPoolBuilder::new()
|
rayon::ThreadPoolBuilder::new()
|
||||||
.num_threads(num_cpus::get().min(6))
|
.num_threads(num_cpus::get().min(6))
|
||||||
.build_global()
|
.build_global()
|
||||||
.ok();
|
.unwrap();
|
||||||
|
|
||||||
log::trace!("Writing initial sourcemap");
|
|
||||||
write_sourcemap(&session, self.output.as_deref(), filter, self.absolute)?;
|
write_sourcemap(&session, self.output.as_deref(), filter, self.absolute)?;
|
||||||
|
|
||||||
if self.watch {
|
if self.watch {
|
||||||
log::trace!("Setting up runtime for watch mode");
|
|
||||||
let rt = Runtime::new().unwrap();
|
let rt = Runtime::new().unwrap();
|
||||||
|
|
||||||
loop {
|
loop {
|
||||||
@@ -213,7 +208,7 @@ fn recurse_create_node<'a>(
|
|||||||
} else {
|
} else {
|
||||||
for val in file_paths {
|
for val in file_paths {
|
||||||
output_file_paths.push(Cow::from(
|
output_file_paths.push(Cow::from(
|
||||||
pathdiff::diff_paths(val, project_dir).expect(PATH_STRIP_FAILED_ERR),
|
val.strip_prefix(project_dir).expect(PATH_STRIP_FAILED_ERR),
|
||||||
));
|
));
|
||||||
}
|
}
|
||||||
};
|
};
|
||||||
@@ -255,80 +250,3 @@ fn write_sourcemap(
|
|||||||
|
|
||||||
Ok(())
|
Ok(())
|
||||||
}
|
}
|
||||||
|
|
||||||
#[cfg(test)]
|
|
||||||
mod test {
|
|
||||||
use crate::cli::sourcemap::SourcemapNode;
|
|
||||||
use crate::cli::SourcemapCommand;
|
|
||||||
use insta::internals::Content;
|
|
||||||
use std::path::Path;
|
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn maps_relative_paths() {
|
|
||||||
let sourcemap_dir = tempfile::tempdir().unwrap();
|
|
||||||
let sourcemap_output = sourcemap_dir.path().join("sourcemap.json");
|
|
||||||
let project_path = fs_err::canonicalize(
|
|
||||||
Path::new(env!("CARGO_MANIFEST_DIR"))
|
|
||||||
.join("test-projects")
|
|
||||||
.join("relative_paths")
|
|
||||||
.join("project"),
|
|
||||||
)
|
|
||||||
.unwrap();
|
|
||||||
let sourcemap_command = SourcemapCommand {
|
|
||||||
project: project_path,
|
|
||||||
output: Some(sourcemap_output.clone()),
|
|
||||||
include_non_scripts: false,
|
|
||||||
watch: false,
|
|
||||||
absolute: false,
|
|
||||||
};
|
|
||||||
assert!(sourcemap_command.run().is_ok());
|
|
||||||
|
|
||||||
let raw_sourcemap_contents = fs_err::read_to_string(sourcemap_output.as_path()).unwrap();
|
|
||||||
let sourcemap_contents =
|
|
||||||
serde_json::from_str::<SourcemapNode>(&raw_sourcemap_contents).unwrap();
|
|
||||||
insta::assert_json_snapshot!(sourcemap_contents);
|
|
||||||
}
|
|
||||||
|
|
||||||
#[test]
|
|
||||||
fn maps_absolute_paths() {
|
|
||||||
let sourcemap_dir = tempfile::tempdir().unwrap();
|
|
||||||
let sourcemap_output = sourcemap_dir.path().join("sourcemap.json");
|
|
||||||
let project_path = fs_err::canonicalize(
|
|
||||||
Path::new(env!("CARGO_MANIFEST_DIR"))
|
|
||||||
.join("test-projects")
|
|
||||||
.join("relative_paths")
|
|
||||||
.join("project"),
|
|
||||||
)
|
|
||||||
.unwrap();
|
|
||||||
let sourcemap_command = SourcemapCommand {
|
|
||||||
project: project_path,
|
|
||||||
output: Some(sourcemap_output.clone()),
|
|
||||||
include_non_scripts: false,
|
|
||||||
watch: false,
|
|
||||||
absolute: true,
|
|
||||||
};
|
|
||||||
assert!(sourcemap_command.run().is_ok());
|
|
||||||
|
|
||||||
let raw_sourcemap_contents = fs_err::read_to_string(sourcemap_output.as_path()).unwrap();
|
|
||||||
let sourcemap_contents =
|
|
||||||
serde_json::from_str::<SourcemapNode>(&raw_sourcemap_contents).unwrap();
|
|
||||||
insta::assert_json_snapshot!(sourcemap_contents, {
|
|
||||||
".**.filePaths" => insta::dynamic_redaction(|mut value, _path| {
|
|
||||||
let mut paths_count = 0;
|
|
||||||
|
|
||||||
match value {
|
|
||||||
Content::Seq(ref mut vec) => {
|
|
||||||
for path in vec.iter().map(|i| i.as_str().unwrap()) {
|
|
||||||
assert_eq!(fs_err::canonicalize(path).is_ok(), true, "path was not valid");
|
|
||||||
assert_eq!(Path::new(path).is_absolute(), true, "path was not absolute");
|
|
||||||
|
|
||||||
paths_count += 1;
|
|
||||||
}
|
|
||||||
}
|
|
||||||
_ => panic!("Expected filePaths to be a sequence"),
|
|
||||||
}
|
|
||||||
format!("[...{} path{} omitted...]", paths_count, if paths_count != 1 { "s" } else { "" } )
|
|
||||||
})
|
|
||||||
});
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|||||||
@@ -73,7 +73,7 @@ impl SyncbackCommand {
|
|||||||
vfs.set_watch_enabled(false);
|
vfs.set_watch_enabled(false);
|
||||||
|
|
||||||
let project_start_timer = Instant::now();
|
let project_start_timer = Instant::now();
|
||||||
let session_old = ServeSession::new(vfs, path_old.clone())?;
|
let session_old = ServeSession::new(vfs, path_old.clone(), None)?;
|
||||||
log::debug!(
|
log::debug!(
|
||||||
"Finished opening project in {:0.02}s",
|
"Finished opening project in {:0.02}s",
|
||||||
project_start_timer.elapsed().as_secs_f32()
|
project_start_timer.elapsed().as_secs_f32()
|
||||||
|
|||||||
@@ -42,7 +42,7 @@ impl UploadCommand {
|
|||||||
|
|
||||||
let vfs = Vfs::new_default();
|
let vfs = Vfs::new_default();
|
||||||
|
|
||||||
let session = ServeSession::new(vfs, project_path)?;
|
let session = ServeSession::new(vfs, project_path, None)?;
|
||||||
|
|
||||||
let tree = session.tree();
|
let tree = session.tree();
|
||||||
let inner_tree = tree.inner();
|
let inner_tree = tree.inner();
|
||||||
|
|||||||
380
src/git.rs
Normal file
380
src/git.rs
Normal file
@@ -0,0 +1,380 @@
|
|||||||
|
//! Git integration for filtering files based on changes since a reference.
|
||||||
|
|
||||||
|
use std::{
|
||||||
|
collections::HashSet,
|
||||||
|
path::{Path, PathBuf},
|
||||||
|
process::Command,
|
||||||
|
sync::{Arc, RwLock},
|
||||||
|
};
|
||||||
|
|
||||||
|
use anyhow::{bail, Context};
|
||||||
|
|
||||||
|
/// A filter that tracks which files have been changed since a Git reference.
|
||||||
|
///
|
||||||
|
/// When active, only files that have been modified, added, or deleted according
|
||||||
|
/// to Git will be "acknowledged" and synced to Studio. This allows users to
|
||||||
|
/// work with large projects where they only want to sync their local changes.
|
||||||
|
///
|
||||||
|
/// Once a file is acknowledged (either initially or during the session), it
|
||||||
|
/// stays acknowledged for the entire session. This prevents files from being
|
||||||
|
/// deleted in Studio if their content is reverted to match the git reference.
|
||||||
|
#[derive(Debug)]
|
||||||
|
pub struct GitFilter {
|
||||||
|
/// The Git repository root directory.
|
||||||
|
repo_root: PathBuf,
|
||||||
|
|
||||||
|
/// The Git reference to compare against (e.g., "HEAD", "main", a commit hash).
|
||||||
|
base_ref: String,
|
||||||
|
|
||||||
|
/// Cache of paths that are currently different from the base ref according to git.
|
||||||
|
/// This is refreshed on every VFS event.
|
||||||
|
git_changed_paths: RwLock<HashSet<PathBuf>>,
|
||||||
|
|
||||||
|
/// Paths that have been acknowledged at any point during this session.
|
||||||
|
/// Once a path is added here, it stays acknowledged forever (for this session).
|
||||||
|
/// This prevents files from being deleted if their content is reverted.
|
||||||
|
session_acknowledged_paths: RwLock<HashSet<PathBuf>>,
|
||||||
|
}
|
||||||
|
|
||||||
|
impl GitFilter {
|
||||||
|
/// Creates a new GitFilter for the given repository root and base reference.
|
||||||
|
///
|
||||||
|
/// The `repo_root` should be the root of the Git repository (where .git is located).
|
||||||
|
/// The `base_ref` is the Git reference to compare against (e.g., "HEAD", "main").
|
||||||
|
/// The `project_path` is the path to the project being served - it will always be
|
||||||
|
/// acknowledged regardless of git status to ensure the project structure exists.
|
||||||
|
pub fn new(repo_root: PathBuf, base_ref: String, project_path: &Path) -> anyhow::Result<Self> {
|
||||||
|
let filter = Self {
|
||||||
|
repo_root,
|
||||||
|
base_ref,
|
||||||
|
git_changed_paths: RwLock::new(HashSet::new()),
|
||||||
|
session_acknowledged_paths: RwLock::new(HashSet::new()),
|
||||||
|
};
|
||||||
|
|
||||||
|
// Always acknowledge the project path and its directory so the project
|
||||||
|
// structure exists even when there are no git changes
|
||||||
|
filter.acknowledge_project_path(project_path);
|
||||||
|
|
||||||
|
// Initial refresh to populate the cache with git changes
|
||||||
|
filter.refresh()?;
|
||||||
|
|
||||||
|
Ok(filter)
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Acknowledges the project path and its containing directory.
|
||||||
|
/// This ensures the project structure always exists regardless of git status.
|
||||||
|
fn acknowledge_project_path(&self, project_path: &Path) {
|
||||||
|
let mut session = self.session_acknowledged_paths.write().unwrap();
|
||||||
|
|
||||||
|
// Acknowledge the project path itself (might be a directory or .project.json file)
|
||||||
|
let canonical = project_path.canonicalize().unwrap_or_else(|_| project_path.to_path_buf());
|
||||||
|
session.insert(canonical.clone());
|
||||||
|
|
||||||
|
// Acknowledge all ancestor directories
|
||||||
|
let mut current = canonical.parent();
|
||||||
|
while let Some(parent) = current {
|
||||||
|
session.insert(parent.to_path_buf());
|
||||||
|
current = parent.parent();
|
||||||
|
}
|
||||||
|
|
||||||
|
// If it's a directory, also acknowledge default.project.json inside it
|
||||||
|
if project_path.is_dir() {
|
||||||
|
for name in &["default.project.json", "default.project.jsonc"] {
|
||||||
|
let project_file = project_path.join(name);
|
||||||
|
if let Ok(canonical_file) = project_file.canonicalize() {
|
||||||
|
session.insert(canonical_file);
|
||||||
|
} else {
|
||||||
|
session.insert(project_file);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// If it's a .project.json file, also acknowledge its parent directory
|
||||||
|
if let Some(parent) = project_path.parent() {
|
||||||
|
let parent_canonical = parent.canonicalize().unwrap_or_else(|_| parent.to_path_buf());
|
||||||
|
session.insert(parent_canonical);
|
||||||
|
}
|
||||||
|
|
||||||
|
log::debug!(
|
||||||
|
"GitFilter: acknowledged project path {} ({} paths total)",
|
||||||
|
project_path.display(),
|
||||||
|
session.len()
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Finds the Git repository root for the given path.
|
||||||
|
pub fn find_repo_root(path: &Path) -> anyhow::Result<PathBuf> {
|
||||||
|
let output = Command::new("git")
|
||||||
|
.args(["rev-parse", "--show-toplevel"])
|
||||||
|
.current_dir(path)
|
||||||
|
.output()
|
||||||
|
.context("Failed to execute git rev-parse")?;
|
||||||
|
|
||||||
|
if !output.status.success() {
|
||||||
|
let stderr = String::from_utf8_lossy(&output.stderr);
|
||||||
|
bail!("Failed to find Git repository root: {}", stderr.trim());
|
||||||
|
}
|
||||||
|
|
||||||
|
let root = String::from_utf8_lossy(&output.stdout)
|
||||||
|
.trim()
|
||||||
|
.to_string();
|
||||||
|
|
||||||
|
Ok(PathBuf::from(root))
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Refreshes the cache of acknowledged paths by querying Git.
|
||||||
|
///
|
||||||
|
/// This should be called when files change to ensure newly modified files
|
||||||
|
/// are properly acknowledged. Once a path is acknowledged, it stays
|
||||||
|
/// acknowledged for the entire session (even if the file is reverted).
|
||||||
|
pub fn refresh(&self) -> anyhow::Result<()> {
|
||||||
|
let mut git_changed = HashSet::new();
|
||||||
|
|
||||||
|
// Get files changed since the base ref (modified, added, deleted)
|
||||||
|
let diff_output = Command::new("git")
|
||||||
|
.args(["diff", "--name-only", &self.base_ref])
|
||||||
|
.current_dir(&self.repo_root)
|
||||||
|
.output()
|
||||||
|
.context("Failed to execute git diff")?;
|
||||||
|
|
||||||
|
if !diff_output.status.success() {
|
||||||
|
let stderr = String::from_utf8_lossy(&diff_output.stderr);
|
||||||
|
bail!("git diff failed: {}", stderr.trim());
|
||||||
|
}
|
||||||
|
|
||||||
|
let diff_files = String::from_utf8_lossy(&diff_output.stdout);
|
||||||
|
let diff_count = diff_files.lines().filter(|l| !l.is_empty()).count();
|
||||||
|
if diff_count > 0 {
|
||||||
|
log::debug!("git diff found {} changed files", diff_count);
|
||||||
|
}
|
||||||
|
for line in diff_files.lines() {
|
||||||
|
if !line.is_empty() {
|
||||||
|
let path = self.repo_root.join(line);
|
||||||
|
log::trace!("git diff: acknowledging {}", path.display());
|
||||||
|
self.acknowledge_path(&path, &mut git_changed);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// Get untracked files (new files not yet committed)
|
||||||
|
let untracked_output = Command::new("git")
|
||||||
|
.args(["ls-files", "--others", "--exclude-standard"])
|
||||||
|
.current_dir(&self.repo_root)
|
||||||
|
.output()
|
||||||
|
.context("Failed to execute git ls-files")?;
|
||||||
|
|
||||||
|
if !untracked_output.status.success() {
|
||||||
|
let stderr = String::from_utf8_lossy(&untracked_output.stderr);
|
||||||
|
bail!("git ls-files failed: {}", stderr.trim());
|
||||||
|
}
|
||||||
|
|
||||||
|
let untracked_files = String::from_utf8_lossy(&untracked_output.stdout);
|
||||||
|
for line in untracked_files.lines() {
|
||||||
|
if !line.is_empty() {
|
||||||
|
let path = self.repo_root.join(line);
|
||||||
|
self.acknowledge_path(&path, &mut git_changed);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// Get staged files (files added to index but not yet committed)
|
||||||
|
let staged_output = Command::new("git")
|
||||||
|
.args(["diff", "--name-only", "--cached", &self.base_ref])
|
||||||
|
.current_dir(&self.repo_root)
|
||||||
|
.output()
|
||||||
|
.context("Failed to execute git diff --cached")?;
|
||||||
|
|
||||||
|
if staged_output.status.success() {
|
||||||
|
let staged_files = String::from_utf8_lossy(&staged_output.stdout);
|
||||||
|
for line in staged_files.lines() {
|
||||||
|
if !line.is_empty() {
|
||||||
|
let path = self.repo_root.join(line);
|
||||||
|
self.acknowledge_path(&path, &mut git_changed);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// Update the git changed paths cache
|
||||||
|
{
|
||||||
|
let mut cache = self.git_changed_paths.write().unwrap();
|
||||||
|
*cache = git_changed.clone();
|
||||||
|
}
|
||||||
|
|
||||||
|
// Merge newly changed paths into session acknowledged paths
|
||||||
|
// Once acknowledged, a path stays acknowledged for the entire session
|
||||||
|
{
|
||||||
|
let mut session = self.session_acknowledged_paths.write().unwrap();
|
||||||
|
for path in git_changed {
|
||||||
|
session.insert(path);
|
||||||
|
}
|
||||||
|
log::debug!(
|
||||||
|
"GitFilter refreshed: {} paths acknowledged in session",
|
||||||
|
session.len()
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
Ok(())
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Acknowledges a path and all its ancestors, plus associated meta files.
|
||||||
|
fn acknowledge_path(&self, path: &Path, acknowledged: &mut HashSet<PathBuf>) {
|
||||||
|
// Canonicalize the path if possible, otherwise use as-is
|
||||||
|
let path = path.canonicalize().unwrap_or_else(|_| path.to_path_buf());
|
||||||
|
|
||||||
|
// Add the path itself
|
||||||
|
acknowledged.insert(path.clone());
|
||||||
|
|
||||||
|
// Add all ancestor directories
|
||||||
|
let mut current = path.parent();
|
||||||
|
while let Some(parent) = current {
|
||||||
|
acknowledged.insert(parent.to_path_buf());
|
||||||
|
current = parent.parent();
|
||||||
|
}
|
||||||
|
|
||||||
|
// Add associated meta files
|
||||||
|
self.acknowledge_meta_files(&path, acknowledged);
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Acknowledges associated meta files for a given path.
|
||||||
|
fn acknowledge_meta_files(&self, path: &Path, acknowledged: &mut HashSet<PathBuf>) {
|
||||||
|
if let Some(file_name) = path.file_name().and_then(|n| n.to_str()) {
|
||||||
|
if let Some(parent) = path.parent() {
|
||||||
|
// For a file like "foo.lua", also acknowledge "foo.meta.json"
|
||||||
|
// Strip known extensions to get the base name
|
||||||
|
let base_name = strip_lua_extension(file_name);
|
||||||
|
|
||||||
|
let meta_path = parent.join(format!("{}.meta.json", base_name));
|
||||||
|
if let Ok(canonical) = meta_path.canonicalize() {
|
||||||
|
acknowledged.insert(canonical);
|
||||||
|
} else {
|
||||||
|
acknowledged.insert(meta_path);
|
||||||
|
}
|
||||||
|
|
||||||
|
// For init files, also acknowledge "init.meta.json" in the same directory
|
||||||
|
if file_name.starts_with("init.") {
|
||||||
|
let init_meta = parent.join("init.meta.json");
|
||||||
|
if let Ok(canonical) = init_meta.canonicalize() {
|
||||||
|
acknowledged.insert(canonical);
|
||||||
|
} else {
|
||||||
|
acknowledged.insert(init_meta);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Checks if a path is acknowledged (should be synced).
|
||||||
|
///
|
||||||
|
/// Returns `true` if the path or any of its descendants have been changed
|
||||||
|
/// at any point during this session. Once a file is acknowledged, it stays
|
||||||
|
/// acknowledged even if its content is reverted to match the git reference.
|
||||||
|
pub fn is_acknowledged(&self, path: &Path) -> bool {
|
||||||
|
let session = self.session_acknowledged_paths.read().unwrap();
|
||||||
|
|
||||||
|
// Try to canonicalize the path
|
||||||
|
let canonical = path.canonicalize().unwrap_or_else(|_| path.to_path_buf());
|
||||||
|
|
||||||
|
// Check if this exact path is acknowledged
|
||||||
|
if session.contains(&canonical) {
|
||||||
|
log::trace!("Path {} is directly acknowledged", path.display());
|
||||||
|
return true;
|
||||||
|
}
|
||||||
|
|
||||||
|
// Also check without canonicalization in case of path differences
|
||||||
|
if session.contains(path) {
|
||||||
|
log::trace!("Path {} is acknowledged (non-canonical)", path.display());
|
||||||
|
return true;
|
||||||
|
}
|
||||||
|
|
||||||
|
// For directories, check if any descendant is acknowledged
|
||||||
|
// This is done by checking if any acknowledged path starts with this path
|
||||||
|
for acknowledged in session.iter() {
|
||||||
|
if acknowledged.starts_with(&canonical) {
|
||||||
|
log::trace!(
|
||||||
|
"Path {} has acknowledged descendant {}",
|
||||||
|
path.display(),
|
||||||
|
acknowledged.display()
|
||||||
|
);
|
||||||
|
return true;
|
||||||
|
}
|
||||||
|
// Also check non-canonical
|
||||||
|
if acknowledged.starts_with(path) {
|
||||||
|
log::trace!(
|
||||||
|
"Path {} has acknowledged descendant {} (non-canonical)",
|
||||||
|
path.display(),
|
||||||
|
acknowledged.display()
|
||||||
|
);
|
||||||
|
return true;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
log::trace!(
|
||||||
|
"Path {} is NOT acknowledged (canonical: {})",
|
||||||
|
path.display(),
|
||||||
|
canonical.display()
|
||||||
|
);
|
||||||
|
false
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Returns the base reference being compared against.
|
||||||
|
pub fn base_ref(&self) -> &str {
|
||||||
|
&self.base_ref
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Returns the repository root path.
|
||||||
|
pub fn repo_root(&self) -> &Path {
|
||||||
|
&self.repo_root
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Explicitly acknowledges a path and all its ancestors.
|
||||||
|
/// This is useful for ensuring certain paths are always synced regardless of git status.
|
||||||
|
pub fn force_acknowledge(&self, path: &Path) {
|
||||||
|
let mut acknowledged = HashSet::new();
|
||||||
|
self.acknowledge_path(path, &mut acknowledged);
|
||||||
|
|
||||||
|
let mut session = self.session_acknowledged_paths.write().unwrap();
|
||||||
|
for p in acknowledged {
|
||||||
|
session.insert(p);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Strips Lua-related extensions from a file name to get the base name.
|
||||||
|
fn strip_lua_extension(file_name: &str) -> &str {
|
||||||
|
const EXTENSIONS: &[&str] = &[
|
||||||
|
".server.luau",
|
||||||
|
".server.lua",
|
||||||
|
".client.luau",
|
||||||
|
".client.lua",
|
||||||
|
".luau",
|
||||||
|
".lua",
|
||||||
|
];
|
||||||
|
|
||||||
|
for ext in EXTENSIONS {
|
||||||
|
if let Some(base) = file_name.strip_suffix(ext) {
|
||||||
|
return base;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// If no Lua extension, try to strip the regular extension
|
||||||
|
file_name
|
||||||
|
.rsplit_once('.')
|
||||||
|
.map(|(base, _)| base)
|
||||||
|
.unwrap_or(file_name)
|
||||||
|
}
|
||||||
|
|
||||||
|
/// A wrapper around GitFilter that can be shared across threads.
|
||||||
|
pub type SharedGitFilter = Arc<GitFilter>;
|
||||||
|
|
||||||
|
#[cfg(test)]
|
||||||
|
mod tests {
|
||||||
|
use super::*;
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn test_strip_lua_extension() {
|
||||||
|
assert_eq!(strip_lua_extension("foo.server.lua"), "foo");
|
||||||
|
assert_eq!(strip_lua_extension("foo.client.luau"), "foo");
|
||||||
|
assert_eq!(strip_lua_extension("foo.lua"), "foo");
|
||||||
|
assert_eq!(strip_lua_extension("init.server.lua"), "init");
|
||||||
|
assert_eq!(strip_lua_extension("bar.txt"), "bar");
|
||||||
|
assert_eq!(strip_lua_extension("noextension"), "noextension");
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -9,6 +9,7 @@ mod tree_view;
|
|||||||
|
|
||||||
mod auth_cookie;
|
mod auth_cookie;
|
||||||
mod change_processor;
|
mod change_processor;
|
||||||
|
mod git;
|
||||||
mod glob;
|
mod glob;
|
||||||
mod json;
|
mod json;
|
||||||
mod lua_ast;
|
mod lua_ast;
|
||||||
@@ -28,6 +29,7 @@ mod web;
|
|||||||
|
|
||||||
// TODO: Work out what we should expose publicly
|
// TODO: Work out what we should expose publicly
|
||||||
|
|
||||||
|
pub use git::{GitFilter, SharedGitFilter};
|
||||||
pub use project::*;
|
pub use project::*;
|
||||||
pub use rojo_ref::*;
|
pub use rojo_ref::*;
|
||||||
pub use session_id::SessionId;
|
pub use session_id::SessionId;
|
||||||
|
|||||||
@@ -13,6 +13,7 @@ use thiserror::Error;
|
|||||||
|
|
||||||
use crate::{
|
use crate::{
|
||||||
change_processor::ChangeProcessor,
|
change_processor::ChangeProcessor,
|
||||||
|
git::SharedGitFilter,
|
||||||
message_queue::MessageQueue,
|
message_queue::MessageQueue,
|
||||||
project::{Project, ProjectError},
|
project::{Project, ProjectError},
|
||||||
session_id::SessionId,
|
session_id::SessionId,
|
||||||
@@ -94,7 +95,14 @@ impl ServeSession {
|
|||||||
/// The project file is expected to be loaded out-of-band since it's
|
/// The project file is expected to be loaded out-of-band since it's
|
||||||
/// currently loaded from the filesystem directly instead of through the
|
/// currently loaded from the filesystem directly instead of through the
|
||||||
/// in-memory filesystem layer.
|
/// in-memory filesystem layer.
|
||||||
pub fn new<P: AsRef<Path>>(vfs: Vfs, start_path: P) -> Result<Self, ServeSessionError> {
|
///
|
||||||
|
/// If `git_filter` is provided, only files that have changed since the
|
||||||
|
/// specified Git reference will be synced.
|
||||||
|
pub fn new<P: AsRef<Path>>(
|
||||||
|
vfs: Vfs,
|
||||||
|
start_path: P,
|
||||||
|
git_filter: Option<SharedGitFilter>,
|
||||||
|
) -> Result<Self, ServeSessionError> {
|
||||||
let start_path = start_path.as_ref();
|
let start_path = start_path.as_ref();
|
||||||
let start_time = Instant::now();
|
let start_time = Instant::now();
|
||||||
|
|
||||||
@@ -102,12 +110,28 @@ impl ServeSession {
|
|||||||
|
|
||||||
let root_project = Project::load_initial_project(&vfs, start_path)?;
|
let root_project = Project::load_initial_project(&vfs, start_path)?;
|
||||||
|
|
||||||
|
// If git filter is active, ensure the project file location is acknowledged
|
||||||
|
// This is necessary so the project structure exists even with no git changes
|
||||||
|
if let Some(ref filter) = git_filter {
|
||||||
|
filter.force_acknowledge(start_path);
|
||||||
|
filter.force_acknowledge(&root_project.file_location);
|
||||||
|
filter.force_acknowledge(root_project.folder_location());
|
||||||
|
log::debug!(
|
||||||
|
"Force acknowledged project at {}",
|
||||||
|
root_project.file_location.display()
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
let mut tree = RojoTree::new(InstanceSnapshot::new());
|
let mut tree = RojoTree::new(InstanceSnapshot::new());
|
||||||
|
|
||||||
let root_id = tree.get_root_id();
|
let root_id = tree.get_root_id();
|
||||||
|
|
||||||
let instance_context =
|
let instance_context = match &git_filter {
|
||||||
InstanceContext::with_emit_legacy_scripts(root_project.emit_legacy_scripts);
|
Some(filter) => {
|
||||||
|
InstanceContext::with_git_filter(root_project.emit_legacy_scripts, Arc::clone(filter))
|
||||||
|
}
|
||||||
|
None => InstanceContext::with_emit_legacy_scripts(root_project.emit_legacy_scripts),
|
||||||
|
};
|
||||||
|
|
||||||
log::trace!("Generating snapshot of instances from VFS");
|
log::trace!("Generating snapshot of instances from VFS");
|
||||||
let snapshot = snapshot_from_vfs(&instance_context, &vfs, start_path)?;
|
let snapshot = snapshot_from_vfs(&instance_context, &vfs, start_path)?;
|
||||||
@@ -133,6 +157,7 @@ impl ServeSession {
|
|||||||
Arc::clone(&vfs),
|
Arc::clone(&vfs),
|
||||||
Arc::clone(&message_queue),
|
Arc::clone(&message_queue),
|
||||||
tree_mutation_receiver,
|
tree_mutation_receiver,
|
||||||
|
git_filter,
|
||||||
);
|
);
|
||||||
|
|
||||||
Ok(Self {
|
Ok(Self {
|
||||||
|
|||||||
@@ -8,6 +8,7 @@ use anyhow::Context;
|
|||||||
use serde::{Deserialize, Serialize};
|
use serde::{Deserialize, Serialize};
|
||||||
|
|
||||||
use crate::{
|
use crate::{
|
||||||
|
git::SharedGitFilter,
|
||||||
glob::Glob,
|
glob::Glob,
|
||||||
path_serializer,
|
path_serializer,
|
||||||
project::ProjectNode,
|
project::ProjectNode,
|
||||||
@@ -138,13 +139,27 @@ impl Default for InstanceMetadata {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
#[derive(Debug, Clone, PartialEq, Serialize, Deserialize)]
|
#[derive(Debug, Clone, Serialize, Deserialize)]
|
||||||
pub struct InstanceContext {
|
pub struct InstanceContext {
|
||||||
#[serde(skip_serializing_if = "Vec::is_empty")]
|
#[serde(skip_serializing_if = "Vec::is_empty")]
|
||||||
pub path_ignore_rules: Arc<Vec<PathIgnoreRule>>,
|
pub path_ignore_rules: Arc<Vec<PathIgnoreRule>>,
|
||||||
pub emit_legacy_scripts: bool,
|
pub emit_legacy_scripts: bool,
|
||||||
#[serde(skip_serializing_if = "Vec::is_empty")]
|
#[serde(skip_serializing_if = "Vec::is_empty")]
|
||||||
pub sync_rules: Vec<SyncRule>,
|
pub sync_rules: Vec<SyncRule>,
|
||||||
|
/// Optional Git filter for --git-since mode. When set, only files that have
|
||||||
|
/// changed since the specified Git reference will be synced.
|
||||||
|
#[serde(skip)]
|
||||||
|
pub git_filter: Option<SharedGitFilter>,
|
||||||
|
}
|
||||||
|
|
||||||
|
impl PartialEq for InstanceContext {
|
||||||
|
fn eq(&self, other: &Self) -> bool {
|
||||||
|
// Note: git_filter is intentionally excluded from comparison
|
||||||
|
// since it's runtime state, not configuration
|
||||||
|
self.path_ignore_rules == other.path_ignore_rules
|
||||||
|
&& self.emit_legacy_scripts == other.emit_legacy_scripts
|
||||||
|
&& self.sync_rules == other.sync_rules
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
impl InstanceContext {
|
impl InstanceContext {
|
||||||
@@ -153,6 +168,7 @@ impl InstanceContext {
|
|||||||
path_ignore_rules: Arc::new(Vec::new()),
|
path_ignore_rules: Arc::new(Vec::new()),
|
||||||
emit_legacy_scripts: emit_legacy_scripts_default().unwrap(),
|
emit_legacy_scripts: emit_legacy_scripts_default().unwrap(),
|
||||||
sync_rules: Vec::new(),
|
sync_rules: Vec::new(),
|
||||||
|
git_filter: None,
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -165,6 +181,36 @@ impl InstanceContext {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// Creates a new InstanceContext with a Git filter for --git-since mode.
|
||||||
|
pub fn with_git_filter(
|
||||||
|
emit_legacy_scripts: Option<bool>,
|
||||||
|
git_filter: SharedGitFilter,
|
||||||
|
) -> Self {
|
||||||
|
Self {
|
||||||
|
git_filter: Some(git_filter),
|
||||||
|
..Self::with_emit_legacy_scripts(emit_legacy_scripts)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Sets the Git filter for this context.
|
||||||
|
pub fn set_git_filter(&mut self, git_filter: Option<SharedGitFilter>) {
|
||||||
|
self.git_filter = git_filter;
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Returns true if the given path should be acknowledged (synced).
|
||||||
|
/// If no git filter is set, all paths are acknowledged.
|
||||||
|
pub fn is_path_acknowledged(&self, path: &Path) -> bool {
|
||||||
|
match &self.git_filter {
|
||||||
|
Some(filter) => filter.is_acknowledged(path),
|
||||||
|
None => true,
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Returns true if a git filter is active.
|
||||||
|
pub fn has_git_filter(&self) -> bool {
|
||||||
|
self.git_filter.is_some()
|
||||||
|
}
|
||||||
|
|
||||||
/// Extend the list of ignore rules in the context with the given new rules.
|
/// Extend the list of ignore rules in the context with the given new rules.
|
||||||
pub fn add_path_ignore_rules<I>(&mut self, new_rules: I)
|
pub fn add_path_ignore_rules<I>(&mut self, new_rules: I)
|
||||||
where
|
where
|
||||||
|
|||||||
@@ -8,7 +8,7 @@ use rbx_dom_weak::{
|
|||||||
ustr, HashMapExt as _, UstrMap, UstrSet,
|
ustr, HashMapExt as _, UstrMap, UstrSet,
|
||||||
};
|
};
|
||||||
|
|
||||||
use crate::{variant_eq::variant_eq, RojoRef, REF_POINTER_ATTRIBUTE_PREFIX};
|
use crate::{RojoRef, REF_POINTER_ATTRIBUTE_PREFIX};
|
||||||
|
|
||||||
use super::{
|
use super::{
|
||||||
patch::{PatchAdd, PatchSet, PatchUpdate},
|
patch::{PatchAdd, PatchSet, PatchUpdate},
|
||||||
@@ -127,7 +127,7 @@ fn compute_property_patches(
|
|||||||
|
|
||||||
match instance.properties().get(&name) {
|
match instance.properties().get(&name) {
|
||||||
Some(instance_value) => {
|
Some(instance_value) => {
|
||||||
if !variant_eq(&snapshot_value, instance_value) {
|
if &snapshot_value != instance_value {
|
||||||
changed_properties.insert(name, Some(snapshot_value));
|
changed_properties.insert(name, Some(snapshot_value));
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -42,7 +42,7 @@ pub fn snapshot_csv(
|
|||||||
.metadata(
|
.metadata(
|
||||||
InstanceMetadata::new()
|
InstanceMetadata::new()
|
||||||
.instigating_source(path)
|
.instigating_source(path)
|
||||||
.relevant_paths(vec![vfs.canonicalize(path)?]),
|
.relevant_paths(vec![path.to_path_buf()]),
|
||||||
);
|
);
|
||||||
|
|
||||||
AdjacentMetadata::read_and_apply_all(vfs, path, name, &mut snapshot)?;
|
AdjacentMetadata::read_and_apply_all(vfs, path, name, &mut snapshot)?;
|
||||||
|
|||||||
@@ -62,19 +62,18 @@ pub fn snapshot_dir_no_meta(
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
let normalized_path = vfs.canonicalize(path)?;
|
|
||||||
let relevant_paths = vec![
|
let relevant_paths = vec![
|
||||||
normalized_path.clone(),
|
path.to_path_buf(),
|
||||||
// TODO: We shouldn't need to know about Lua existing in this
|
// TODO: We shouldn't need to know about Lua existing in this
|
||||||
// middleware. Should we figure out a way for that function to add
|
// middleware. Should we figure out a way for that function to add
|
||||||
// relevant paths to this middleware?
|
// relevant paths to this middleware?
|
||||||
normalized_path.join("init.lua"),
|
path.join("init.lua"),
|
||||||
normalized_path.join("init.luau"),
|
path.join("init.luau"),
|
||||||
normalized_path.join("init.server.lua"),
|
path.join("init.server.lua"),
|
||||||
normalized_path.join("init.server.luau"),
|
path.join("init.server.luau"),
|
||||||
normalized_path.join("init.client.lua"),
|
path.join("init.client.lua"),
|
||||||
normalized_path.join("init.client.luau"),
|
path.join("init.client.luau"),
|
||||||
normalized_path.join("init.csv"),
|
path.join("init.csv"),
|
||||||
];
|
];
|
||||||
|
|
||||||
let snapshot = InstanceSnapshot::new()
|
let snapshot = InstanceSnapshot::new()
|
||||||
|
|||||||
@@ -32,7 +32,7 @@ pub fn snapshot_json(
|
|||||||
.metadata(
|
.metadata(
|
||||||
InstanceMetadata::new()
|
InstanceMetadata::new()
|
||||||
.instigating_source(path)
|
.instigating_source(path)
|
||||||
.relevant_paths(vec![vfs.canonicalize(path)?])
|
.relevant_paths(vec![path.to_path_buf()])
|
||||||
.context(context),
|
.context(context),
|
||||||
);
|
);
|
||||||
|
|
||||||
|
|||||||
@@ -59,7 +59,7 @@ pub fn snapshot_json_model(
|
|||||||
snapshot.metadata = snapshot
|
snapshot.metadata = snapshot
|
||||||
.metadata
|
.metadata
|
||||||
.instigating_source(path)
|
.instigating_source(path)
|
||||||
.relevant_paths(vec![vfs.canonicalize(path)?])
|
.relevant_paths(vec![path.to_path_buf()])
|
||||||
.context(context)
|
.context(context)
|
||||||
.specified_id(id)
|
.specified_id(id)
|
||||||
.schema(schema);
|
.schema(schema);
|
||||||
|
|||||||
@@ -88,7 +88,7 @@ pub fn snapshot_lua(
|
|||||||
.metadata(
|
.metadata(
|
||||||
InstanceMetadata::new()
|
InstanceMetadata::new()
|
||||||
.instigating_source(path)
|
.instigating_source(path)
|
||||||
.relevant_paths(vec![vfs.canonicalize(path)?])
|
.relevant_paths(vec![path.to_path_buf()])
|
||||||
.context(context),
|
.context(context),
|
||||||
);
|
);
|
||||||
|
|
||||||
|
|||||||
@@ -61,6 +61,10 @@ pub use self::{
|
|||||||
/// This will inspect the path and find the appropriate middleware for it,
|
/// This will inspect the path and find the appropriate middleware for it,
|
||||||
/// taking user-written rules into account. Then, it will attempt to convert
|
/// taking user-written rules into account. Then, it will attempt to convert
|
||||||
/// the path into an InstanceSnapshot using that middleware.
|
/// the path into an InstanceSnapshot using that middleware.
|
||||||
|
///
|
||||||
|
/// If a git filter is active in the context and the path is not acknowledged
|
||||||
|
/// (i.e., the file hasn't changed since the base git reference), this function
|
||||||
|
/// returns `Ok(None)` to skip syncing that file.
|
||||||
#[profiling::function]
|
#[profiling::function]
|
||||||
pub fn snapshot_from_vfs(
|
pub fn snapshot_from_vfs(
|
||||||
context: &InstanceContext,
|
context: &InstanceContext,
|
||||||
@@ -72,6 +76,16 @@ pub fn snapshot_from_vfs(
|
|||||||
None => return Ok(None),
|
None => return Ok(None),
|
||||||
};
|
};
|
||||||
|
|
||||||
|
// Check if this path is acknowledged by the git filter.
|
||||||
|
// If not, skip this path entirely.
|
||||||
|
if !context.is_path_acknowledged(path) {
|
||||||
|
log::trace!(
|
||||||
|
"Skipping path {} (not acknowledged by git filter)",
|
||||||
|
path.display()
|
||||||
|
);
|
||||||
|
return Ok(None);
|
||||||
|
}
|
||||||
|
|
||||||
if meta.is_dir() {
|
if meta.is_dir() {
|
||||||
let (middleware, dir_name, init_path) = get_dir_middleware(vfs, path)?;
|
let (middleware, dir_name, init_path) = get_dir_middleware(vfs, path)?;
|
||||||
// TODO: Support user defined init paths
|
// TODO: Support user defined init paths
|
||||||
@@ -213,6 +227,10 @@ pub enum Middleware {
|
|||||||
impl Middleware {
|
impl Middleware {
|
||||||
/// Creates a snapshot for the given path from the Middleware with
|
/// Creates a snapshot for the given path from the Middleware with
|
||||||
/// the provided name.
|
/// the provided name.
|
||||||
|
///
|
||||||
|
/// When a git filter is active in the context, `ignore_unknown_instances`
|
||||||
|
/// will be set to `true` on all generated snapshots to preserve descendants
|
||||||
|
/// in Studio that are not tracked by Rojo.
|
||||||
fn snapshot(
|
fn snapshot(
|
||||||
&self,
|
&self,
|
||||||
context: &InstanceContext,
|
context: &InstanceContext,
|
||||||
@@ -262,6 +280,14 @@ impl Middleware {
|
|||||||
};
|
};
|
||||||
if let Ok(Some(ref mut snapshot)) = output {
|
if let Ok(Some(ref mut snapshot)) = output {
|
||||||
snapshot.metadata.middleware = Some(*self);
|
snapshot.metadata.middleware = Some(*self);
|
||||||
|
|
||||||
|
// When git filter is active, force ignore_unknown_instances to true
|
||||||
|
// so that we don't delete children in Studio that aren't tracked.
|
||||||
|
if context.has_git_filter() {
|
||||||
|
snapshot.metadata.ignore_unknown_instances = true;
|
||||||
|
// Also apply this recursively to all children
|
||||||
|
set_ignore_unknown_instances_recursive(&mut snapshot.children);
|
||||||
|
}
|
||||||
}
|
}
|
||||||
output
|
output
|
||||||
}
|
}
|
||||||
@@ -365,6 +391,16 @@ impl Middleware {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// Recursively sets `ignore_unknown_instances` to `true` on all children.
|
||||||
|
/// This is used when git filter is active to ensure we don't delete
|
||||||
|
/// children in Studio that aren't tracked by Rojo.
|
||||||
|
fn set_ignore_unknown_instances_recursive(children: &mut [InstanceSnapshot]) {
|
||||||
|
for child in children {
|
||||||
|
child.metadata.ignore_unknown_instances = true;
|
||||||
|
set_ignore_unknown_instances_recursive(&mut child.children);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
/// A helper for easily defining a SyncRule. Arguments are passed literally
|
/// A helper for easily defining a SyncRule. Arguments are passed literally
|
||||||
/// to this macro in the order `include`, `middleware`, `suffix`,
|
/// to this macro in the order `include`, `middleware`, `suffix`,
|
||||||
/// and `exclude`. Both `suffix` and `exclude` are optional.
|
/// and `exclude`. Both `suffix` and `exclude` are optional.
|
||||||
|
|||||||
@@ -192,6 +192,17 @@ pub fn snapshot_project_node(
|
|||||||
}
|
}
|
||||||
|
|
||||||
(_, None, _, Some(PathNode::Required(path))) => {
|
(_, None, _, Some(PathNode::Required(path))) => {
|
||||||
|
// If git filter is active and the path was filtered out, treat it
|
||||||
|
// as if the path was optional and skip this node.
|
||||||
|
if context.has_git_filter() {
|
||||||
|
log::trace!(
|
||||||
|
"Skipping project node '{}' because its path was filtered by git filter: {}",
|
||||||
|
instance_name,
|
||||||
|
path.display()
|
||||||
|
);
|
||||||
|
return Ok(None);
|
||||||
|
}
|
||||||
|
|
||||||
anyhow::bail!(
|
anyhow::bail!(
|
||||||
"Rojo project referred to a file using $path that could not be turned into a Roblox Instance by Rojo.\n\
|
"Rojo project referred to a file using $path that could not be turned into a Roblox Instance by Rojo.\n\
|
||||||
Check that the file exists and is a file type known by Rojo.\n\
|
Check that the file exists and is a file type known by Rojo.\n\
|
||||||
@@ -282,7 +293,12 @@ pub fn snapshot_project_node(
|
|||||||
// If the user didn't specify it AND $path was not specified (meaning
|
// If the user didn't specify it AND $path was not specified (meaning
|
||||||
// there's no existing value we'd be stepping on from a project file or meta
|
// there's no existing value we'd be stepping on from a project file or meta
|
||||||
// file), set it to true.
|
// file), set it to true.
|
||||||
if let Some(ignore) = node.ignore_unknown_instances {
|
//
|
||||||
|
// When git filter is active, always set to true to preserve descendants
|
||||||
|
// in Studio that are not tracked by Rojo.
|
||||||
|
if context.has_git_filter() {
|
||||||
|
metadata.ignore_unknown_instances = true;
|
||||||
|
} else if let Some(ignore) = node.ignore_unknown_instances {
|
||||||
metadata.ignore_unknown_instances = ignore;
|
metadata.ignore_unknown_instances = ignore;
|
||||||
} else if node.path.is_none() {
|
} else if node.path.is_none() {
|
||||||
// TODO: Introduce a strict mode where $ignoreUnknownInstances is never
|
// TODO: Introduce a strict mode where $ignoreUnknownInstances is never
|
||||||
|
|||||||
@@ -28,7 +28,7 @@ pub fn snapshot_rbxm(
|
|||||||
.metadata(
|
.metadata(
|
||||||
InstanceMetadata::new()
|
InstanceMetadata::new()
|
||||||
.instigating_source(path)
|
.instigating_source(path)
|
||||||
.relevant_paths(vec![vfs.canonicalize(path)?])
|
.relevant_paths(vec![path.to_path_buf()])
|
||||||
.context(context),
|
.context(context),
|
||||||
);
|
);
|
||||||
|
|
||||||
|
|||||||
@@ -31,7 +31,7 @@ pub fn snapshot_rbxmx(
|
|||||||
.metadata(
|
.metadata(
|
||||||
InstanceMetadata::new()
|
InstanceMetadata::new()
|
||||||
.instigating_source(path)
|
.instigating_source(path)
|
||||||
.relevant_paths(vec![vfs.canonicalize(path)?])
|
.relevant_paths(vec![path.to_path_buf()])
|
||||||
.context(context),
|
.context(context),
|
||||||
);
|
);
|
||||||
|
|
||||||
|
|||||||
@@ -31,7 +31,7 @@ pub fn snapshot_toml(
|
|||||||
.metadata(
|
.metadata(
|
||||||
InstanceMetadata::new()
|
InstanceMetadata::new()
|
||||||
.instigating_source(path)
|
.instigating_source(path)
|
||||||
.relevant_paths(vec![vfs.canonicalize(path)?])
|
.relevant_paths(vec![path.to_path_buf()])
|
||||||
.context(context),
|
.context(context),
|
||||||
);
|
);
|
||||||
|
|
||||||
|
|||||||
@@ -28,7 +28,7 @@ pub fn snapshot_txt(
|
|||||||
.metadata(
|
.metadata(
|
||||||
InstanceMetadata::new()
|
InstanceMetadata::new()
|
||||||
.instigating_source(path)
|
.instigating_source(path)
|
||||||
.relevant_paths(vec![vfs.canonicalize(path)?])
|
.relevant_paths(vec![path.to_path_buf()])
|
||||||
.context(context),
|
.context(context),
|
||||||
);
|
);
|
||||||
|
|
||||||
|
|||||||
@@ -37,7 +37,7 @@ pub fn snapshot_yaml(
|
|||||||
.metadata(
|
.metadata(
|
||||||
InstanceMetadata::new()
|
InstanceMetadata::new()
|
||||||
.instigating_source(path)
|
.instigating_source(path)
|
||||||
.relevant_paths(vec![vfs.canonicalize(path)?])
|
.relevant_paths(vec![path.to_path_buf()])
|
||||||
.context(context),
|
.context(context),
|
||||||
);
|
);
|
||||||
|
|
||||||
|
|||||||
@@ -301,7 +301,6 @@ pub fn get_best_middleware(snapshot: &SyncbackSnapshot) -> Middleware {
|
|||||||
static JSON_MODEL_CLASSES: OnceLock<HashSet<&str>> = OnceLock::new();
|
static JSON_MODEL_CLASSES: OnceLock<HashSet<&str>> = OnceLock::new();
|
||||||
let json_model_classes = JSON_MODEL_CLASSES.get_or_init(|| {
|
let json_model_classes = JSON_MODEL_CLASSES.get_or_init(|| {
|
||||||
[
|
[
|
||||||
"Actor",
|
|
||||||
"Sound",
|
"Sound",
|
||||||
"SoundGroup",
|
"SoundGroup",
|
||||||
"Sky",
|
"Sky",
|
||||||
@@ -319,11 +318,6 @@ pub fn get_best_middleware(snapshot: &SyncbackSnapshot) -> Middleware {
|
|||||||
"ChatInputBarConfiguration",
|
"ChatInputBarConfiguration",
|
||||||
"BubbleChatConfiguration",
|
"BubbleChatConfiguration",
|
||||||
"ChannelTabsConfiguration",
|
"ChannelTabsConfiguration",
|
||||||
"RemoteEvent",
|
|
||||||
"UnreliableRemoteEvent",
|
|
||||||
"RemoteFunction",
|
|
||||||
"BindableEvent",
|
|
||||||
"BindableFunction",
|
|
||||||
]
|
]
|
||||||
.into()
|
.into()
|
||||||
});
|
});
|
||||||
|
|||||||
119
src/web/api.rs
119
src/web/api.rs
@@ -1,7 +1,13 @@
|
|||||||
//! Defines Rojo's HTTP API, all under /api. These endpoints generally return
|
//! Defines Rojo's HTTP API, all under /api. These endpoints generally return
|
||||||
//! JSON.
|
//! JSON.
|
||||||
|
|
||||||
use std::{collections::HashMap, fs, path::PathBuf, str::FromStr, sync::Arc};
|
use std::{
|
||||||
|
collections::{HashMap, HashSet},
|
||||||
|
fs,
|
||||||
|
path::PathBuf,
|
||||||
|
str::FromStr,
|
||||||
|
sync::Arc,
|
||||||
|
};
|
||||||
|
|
||||||
use futures::{sink::SinkExt, stream::StreamExt};
|
use futures::{sink::SinkExt, stream::StreamExt};
|
||||||
use hyper::{body, Body, Method, Request, Response, StatusCode};
|
use hyper::{body, Body, Method, Request, Response, StatusCode};
|
||||||
@@ -13,6 +19,7 @@ use rbx_dom_weak::{
|
|||||||
};
|
};
|
||||||
|
|
||||||
use crate::{
|
use crate::{
|
||||||
|
json,
|
||||||
serve_session::ServeSession,
|
serve_session::ServeSession,
|
||||||
snapshot::{InstanceWithMeta, PatchSet, PatchUpdate},
|
snapshot::{InstanceWithMeta, PatchSet, PatchUpdate},
|
||||||
web::{
|
web::{
|
||||||
@@ -21,11 +28,9 @@ use crate::{
|
|||||||
ServerInfoResponse, SocketPacket, SocketPacketBody, SocketPacketType, SubscribeMessage,
|
ServerInfoResponse, SocketPacket, SocketPacketBody, SocketPacketType, SubscribeMessage,
|
||||||
WriteRequest, WriteResponse, PROTOCOL_VERSION, SERVER_VERSION,
|
WriteRequest, WriteResponse, PROTOCOL_VERSION, SERVER_VERSION,
|
||||||
},
|
},
|
||||||
util::{deserialize_msgpack, msgpack, msgpack_ok, serialize_msgpack},
|
util::{json, json_ok},
|
||||||
},
|
|
||||||
web_api::{
|
|
||||||
InstanceUpdate, RefPatchRequest, RefPatchResponse, SerializeRequest, SerializeResponse,
|
|
||||||
},
|
},
|
||||||
|
web_api::{BufferEncode, InstanceUpdate, RefPatchResponse, SerializeResponse},
|
||||||
};
|
};
|
||||||
|
|
||||||
pub async fn call(serve_session: Arc<ServeSession>, mut request: Request<Body>) -> Response<Body> {
|
pub async fn call(serve_session: Arc<ServeSession>, mut request: Request<Body>) -> Response<Body> {
|
||||||
@@ -40,7 +45,7 @@ pub async fn call(serve_session: Arc<ServeSession>, mut request: Request<Body>)
|
|||||||
if is_upgrade_request(&request) {
|
if is_upgrade_request(&request) {
|
||||||
service.handle_api_socket(&mut request).await
|
service.handle_api_socket(&mut request).await
|
||||||
} else {
|
} else {
|
||||||
msgpack(
|
json(
|
||||||
ErrorResponse::bad_request(
|
ErrorResponse::bad_request(
|
||||||
"/api/socket must be called as a websocket upgrade request",
|
"/api/socket must be called as a websocket upgrade request",
|
||||||
),
|
),
|
||||||
@@ -48,15 +53,19 @@ pub async fn call(serve_session: Arc<ServeSession>, mut request: Request<Body>)
|
|||||||
)
|
)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
(&Method::POST, "/api/serialize") => service.handle_api_serialize(request).await,
|
(&Method::GET, path) if path.starts_with("/api/serialize/") => {
|
||||||
(&Method::POST, "/api/ref-patch") => service.handle_api_ref_patch(request).await,
|
service.handle_api_serialize(request).await
|
||||||
|
}
|
||||||
|
(&Method::GET, path) if path.starts_with("/api/ref-patch/") => {
|
||||||
|
service.handle_api_ref_patch(request).await
|
||||||
|
}
|
||||||
|
|
||||||
(&Method::POST, path) if path.starts_with("/api/open/") => {
|
(&Method::POST, path) if path.starts_with("/api/open/") => {
|
||||||
service.handle_api_open(request).await
|
service.handle_api_open(request).await
|
||||||
}
|
}
|
||||||
(&Method::POST, "/api/write") => service.handle_api_write(request).await,
|
(&Method::POST, "/api/write") => service.handle_api_write(request).await,
|
||||||
|
|
||||||
(_method, path) => msgpack(
|
(_method, path) => json(
|
||||||
ErrorResponse::not_found(format!("Route not found: {}", path)),
|
ErrorResponse::not_found(format!("Route not found: {}", path)),
|
||||||
StatusCode::NOT_FOUND,
|
StatusCode::NOT_FOUND,
|
||||||
),
|
),
|
||||||
@@ -77,7 +86,7 @@ impl ApiService {
|
|||||||
let tree = self.serve_session.tree();
|
let tree = self.serve_session.tree();
|
||||||
let root_instance_id = tree.get_root_id();
|
let root_instance_id = tree.get_root_id();
|
||||||
|
|
||||||
msgpack_ok(&ServerInfoResponse {
|
json_ok(&ServerInfoResponse {
|
||||||
server_version: SERVER_VERSION.to_owned(),
|
server_version: SERVER_VERSION.to_owned(),
|
||||||
protocol_version: PROTOCOL_VERSION,
|
protocol_version: PROTOCOL_VERSION,
|
||||||
session_id: self.serve_session.session_id(),
|
session_id: self.serve_session.session_id(),
|
||||||
@@ -96,7 +105,7 @@ impl ApiService {
|
|||||||
let input_cursor: u32 = match argument.parse() {
|
let input_cursor: u32 = match argument.parse() {
|
||||||
Ok(v) => v,
|
Ok(v) => v,
|
||||||
Err(err) => {
|
Err(err) => {
|
||||||
return msgpack(
|
return json(
|
||||||
ErrorResponse::bad_request(format!("Malformed message cursor: {}", err)),
|
ErrorResponse::bad_request(format!("Malformed message cursor: {}", err)),
|
||||||
StatusCode::BAD_REQUEST,
|
StatusCode::BAD_REQUEST,
|
||||||
);
|
);
|
||||||
@@ -107,7 +116,7 @@ impl ApiService {
|
|||||||
let (response, websocket) = match upgrade(request, None) {
|
let (response, websocket) = match upgrade(request, None) {
|
||||||
Ok(result) => result,
|
Ok(result) => result,
|
||||||
Err(err) => {
|
Err(err) => {
|
||||||
return msgpack(
|
return json(
|
||||||
ErrorResponse::internal_error(format!("WebSocket upgrade failed: {}", err)),
|
ErrorResponse::internal_error(format!("WebSocket upgrade failed: {}", err)),
|
||||||
StatusCode::INTERNAL_SERVER_ERROR,
|
StatusCode::INTERNAL_SERVER_ERROR,
|
||||||
);
|
);
|
||||||
@@ -134,10 +143,10 @@ impl ApiService {
|
|||||||
|
|
||||||
let body = body::to_bytes(request.into_body()).await.unwrap();
|
let body = body::to_bytes(request.into_body()).await.unwrap();
|
||||||
|
|
||||||
let request: WriteRequest = match deserialize_msgpack(&body) {
|
let request: WriteRequest = match json::from_slice(&body) {
|
||||||
Ok(request) => request,
|
Ok(request) => request,
|
||||||
Err(err) => {
|
Err(err) => {
|
||||||
return msgpack(
|
return json(
|
||||||
ErrorResponse::bad_request(format!("Invalid body: {}", err)),
|
ErrorResponse::bad_request(format!("Invalid body: {}", err)),
|
||||||
StatusCode::BAD_REQUEST,
|
StatusCode::BAD_REQUEST,
|
||||||
);
|
);
|
||||||
@@ -145,7 +154,7 @@ impl ApiService {
|
|||||||
};
|
};
|
||||||
|
|
||||||
if request.session_id != session_id {
|
if request.session_id != session_id {
|
||||||
return msgpack(
|
return json(
|
||||||
ErrorResponse::bad_request("Wrong session ID"),
|
ErrorResponse::bad_request("Wrong session ID"),
|
||||||
StatusCode::BAD_REQUEST,
|
StatusCode::BAD_REQUEST,
|
||||||
);
|
);
|
||||||
@@ -171,7 +180,7 @@ impl ApiService {
|
|||||||
})
|
})
|
||||||
.unwrap();
|
.unwrap();
|
||||||
|
|
||||||
msgpack_ok(WriteResponse { session_id })
|
json_ok(WriteResponse { session_id })
|
||||||
}
|
}
|
||||||
|
|
||||||
async fn handle_api_read(&self, request: Request<Body>) -> Response<Body> {
|
async fn handle_api_read(&self, request: Request<Body>) -> Response<Body> {
|
||||||
@@ -181,7 +190,7 @@ impl ApiService {
|
|||||||
let requested_ids = match requested_ids {
|
let requested_ids = match requested_ids {
|
||||||
Ok(ids) => ids,
|
Ok(ids) => ids,
|
||||||
Err(_) => {
|
Err(_) => {
|
||||||
return msgpack(
|
return json(
|
||||||
ErrorResponse::bad_request("Malformed ID list"),
|
ErrorResponse::bad_request("Malformed ID list"),
|
||||||
StatusCode::BAD_REQUEST,
|
StatusCode::BAD_REQUEST,
|
||||||
);
|
);
|
||||||
@@ -205,7 +214,7 @@ impl ApiService {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
msgpack_ok(ReadResponse {
|
json_ok(ReadResponse {
|
||||||
session_id: self.serve_session.session_id(),
|
session_id: self.serve_session.session_id(),
|
||||||
message_cursor,
|
message_cursor,
|
||||||
instances,
|
instances,
|
||||||
@@ -220,30 +229,22 @@ impl ApiService {
|
|||||||
/// that correspond to the requested Instances. These values have their
|
/// that correspond to the requested Instances. These values have their
|
||||||
/// `Value` property set to point to the requested Instance.
|
/// `Value` property set to point to the requested Instance.
|
||||||
async fn handle_api_serialize(&self, request: Request<Body>) -> Response<Body> {
|
async fn handle_api_serialize(&self, request: Request<Body>) -> Response<Body> {
|
||||||
let session_id = self.serve_session.session_id();
|
let argument = &request.uri().path()["/api/serialize/".len()..];
|
||||||
let body = body::to_bytes(request.into_body()).await.unwrap();
|
let requested_ids: Result<Vec<Ref>, _> = argument.split(',').map(Ref::from_str).collect();
|
||||||
|
|
||||||
let request: SerializeRequest = match deserialize_msgpack(&body) {
|
let requested_ids = match requested_ids {
|
||||||
Ok(request) => request,
|
Ok(ids) => ids,
|
||||||
Err(err) => {
|
Err(_) => {
|
||||||
return msgpack(
|
return json(
|
||||||
ErrorResponse::bad_request(format!("Invalid body: {}", err)),
|
ErrorResponse::bad_request("Malformed ID list"),
|
||||||
StatusCode::BAD_REQUEST,
|
StatusCode::BAD_REQUEST,
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
if request.session_id != session_id {
|
|
||||||
return msgpack(
|
|
||||||
ErrorResponse::bad_request("Wrong session ID"),
|
|
||||||
StatusCode::BAD_REQUEST,
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
let mut response_dom = WeakDom::new(InstanceBuilder::new("Folder"));
|
let mut response_dom = WeakDom::new(InstanceBuilder::new("Folder"));
|
||||||
|
|
||||||
let tree = self.serve_session.tree();
|
let tree = self.serve_session.tree();
|
||||||
for id in &request.ids {
|
for id in &requested_ids {
|
||||||
if let Some(instance) = tree.get_instance(*id) {
|
if let Some(instance) = tree.get_instance(*id) {
|
||||||
let clone = response_dom.insert(
|
let clone = response_dom.insert(
|
||||||
Ref::none(),
|
Ref::none(),
|
||||||
@@ -267,7 +268,7 @@ impl ApiService {
|
|||||||
|
|
||||||
response_dom.transfer_within(child_ref, object_value);
|
response_dom.transfer_within(child_ref, object_value);
|
||||||
} else {
|
} else {
|
||||||
msgpack(
|
json(
|
||||||
ErrorResponse::bad_request(format!("provided id {id} is not in the tree")),
|
ErrorResponse::bad_request(format!("provided id {id} is not in the tree")),
|
||||||
StatusCode::BAD_REQUEST,
|
StatusCode::BAD_REQUEST,
|
||||||
);
|
);
|
||||||
@@ -278,9 +279,9 @@ impl ApiService {
|
|||||||
let mut source = Vec::new();
|
let mut source = Vec::new();
|
||||||
rbx_binary::to_writer(&mut source, &response_dom, &[response_dom.root_ref()]).unwrap();
|
rbx_binary::to_writer(&mut source, &response_dom, &[response_dom.root_ref()]).unwrap();
|
||||||
|
|
||||||
msgpack_ok(SerializeResponse {
|
json_ok(SerializeResponse {
|
||||||
session_id: self.serve_session.session_id(),
|
session_id: self.serve_session.session_id(),
|
||||||
model_contents: source,
|
model_contents: BufferEncode::new(source),
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -289,26 +290,20 @@ impl ApiService {
|
|||||||
/// and referent properties need to be updated after the serialize
|
/// and referent properties need to be updated after the serialize
|
||||||
/// endpoint is used.
|
/// endpoint is used.
|
||||||
async fn handle_api_ref_patch(self, request: Request<Body>) -> Response<Body> {
|
async fn handle_api_ref_patch(self, request: Request<Body>) -> Response<Body> {
|
||||||
let session_id = self.serve_session.session_id();
|
let argument = &request.uri().path()["/api/ref-patch/".len()..];
|
||||||
let body = body::to_bytes(request.into_body()).await.unwrap();
|
let requested_ids: Result<HashSet<Ref>, _> =
|
||||||
|
argument.split(',').map(Ref::from_str).collect();
|
||||||
|
|
||||||
let request: RefPatchRequest = match deserialize_msgpack(&body) {
|
let requested_ids = match requested_ids {
|
||||||
Ok(request) => request,
|
Ok(ids) => ids,
|
||||||
Err(err) => {
|
Err(_) => {
|
||||||
return msgpack(
|
return json(
|
||||||
ErrorResponse::bad_request(format!("Invalid body: {}", err)),
|
ErrorResponse::bad_request("Malformed ID list"),
|
||||||
StatusCode::BAD_REQUEST,
|
StatusCode::BAD_REQUEST,
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
if request.session_id != session_id {
|
|
||||||
return msgpack(
|
|
||||||
ErrorResponse::bad_request("Wrong session ID"),
|
|
||||||
StatusCode::BAD_REQUEST,
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
let mut instance_updates: HashMap<Ref, InstanceUpdate> = HashMap::new();
|
let mut instance_updates: HashMap<Ref, InstanceUpdate> = HashMap::new();
|
||||||
|
|
||||||
let tree = self.serve_session.tree();
|
let tree = self.serve_session.tree();
|
||||||
@@ -317,7 +312,7 @@ impl ApiService {
|
|||||||
let Variant::Ref(prop_value) = prop_value else {
|
let Variant::Ref(prop_value) = prop_value else {
|
||||||
continue;
|
continue;
|
||||||
};
|
};
|
||||||
if let Some(target_id) = request.ids.get(prop_value) {
|
if let Some(target_id) = requested_ids.get(prop_value) {
|
||||||
let instance_id = instance.id();
|
let instance_id = instance.id();
|
||||||
let update =
|
let update =
|
||||||
instance_updates
|
instance_updates
|
||||||
@@ -336,7 +331,7 @@ impl ApiService {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
msgpack_ok(RefPatchResponse {
|
json_ok(RefPatchResponse {
|
||||||
session_id: self.serve_session.session_id(),
|
session_id: self.serve_session.session_id(),
|
||||||
patch: SubscribeMessage {
|
patch: SubscribeMessage {
|
||||||
added: HashMap::new(),
|
added: HashMap::new(),
|
||||||
@@ -352,7 +347,7 @@ impl ApiService {
|
|||||||
let requested_id = match Ref::from_str(argument) {
|
let requested_id = match Ref::from_str(argument) {
|
||||||
Ok(id) => id,
|
Ok(id) => id,
|
||||||
Err(_) => {
|
Err(_) => {
|
||||||
return msgpack(
|
return json(
|
||||||
ErrorResponse::bad_request("Invalid instance ID"),
|
ErrorResponse::bad_request("Invalid instance ID"),
|
||||||
StatusCode::BAD_REQUEST,
|
StatusCode::BAD_REQUEST,
|
||||||
);
|
);
|
||||||
@@ -364,7 +359,7 @@ impl ApiService {
|
|||||||
let instance = match tree.get_instance(requested_id) {
|
let instance = match tree.get_instance(requested_id) {
|
||||||
Some(instance) => instance,
|
Some(instance) => instance,
|
||||||
None => {
|
None => {
|
||||||
return msgpack(
|
return json(
|
||||||
ErrorResponse::bad_request("Instance not found"),
|
ErrorResponse::bad_request("Instance not found"),
|
||||||
StatusCode::NOT_FOUND,
|
StatusCode::NOT_FOUND,
|
||||||
);
|
);
|
||||||
@@ -374,7 +369,7 @@ impl ApiService {
|
|||||||
let script_path = match pick_script_path(instance) {
|
let script_path = match pick_script_path(instance) {
|
||||||
Some(path) => path,
|
Some(path) => path,
|
||||||
None => {
|
None => {
|
||||||
return msgpack(
|
return json(
|
||||||
ErrorResponse::bad_request(
|
ErrorResponse::bad_request(
|
||||||
"No appropriate file could be found to open this script",
|
"No appropriate file could be found to open this script",
|
||||||
),
|
),
|
||||||
@@ -387,7 +382,7 @@ impl ApiService {
|
|||||||
Ok(()) => {}
|
Ok(()) => {}
|
||||||
Err(error) => match error {
|
Err(error) => match error {
|
||||||
OpenError::Io(io_error) => {
|
OpenError::Io(io_error) => {
|
||||||
return msgpack(
|
return json(
|
||||||
ErrorResponse::internal_error(format!(
|
ErrorResponse::internal_error(format!(
|
||||||
"Attempting to open {} failed because of the following io error: {}",
|
"Attempting to open {} failed because of the following io error: {}",
|
||||||
script_path.display(),
|
script_path.display(),
|
||||||
@@ -401,7 +396,7 @@ impl ApiService {
|
|||||||
status,
|
status,
|
||||||
stderr,
|
stderr,
|
||||||
} => {
|
} => {
|
||||||
return msgpack(
|
return json(
|
||||||
ErrorResponse::internal_error(format!(
|
ErrorResponse::internal_error(format!(
|
||||||
r#"The command '{}' to open '{}' failed with the error code '{}'.
|
r#"The command '{}' to open '{}' failed with the error code '{}'.
|
||||||
Error logs:
|
Error logs:
|
||||||
@@ -417,7 +412,7 @@ impl ApiService {
|
|||||||
},
|
},
|
||||||
};
|
};
|
||||||
|
|
||||||
msgpack_ok(OpenResponse {
|
json_ok(OpenResponse {
|
||||||
session_id: self.serve_session.session_id(),
|
session_id: self.serve_session.session_id(),
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
@@ -481,7 +476,7 @@ async fn handle_websocket_subscription(
|
|||||||
match result {
|
match result {
|
||||||
Ok((new_cursor, messages)) => {
|
Ok((new_cursor, messages)) => {
|
||||||
if !messages.is_empty() {
|
if !messages.is_empty() {
|
||||||
let msgpack_message = {
|
let json_message = {
|
||||||
let tree = tree_handle.lock().unwrap();
|
let tree = tree_handle.lock().unwrap();
|
||||||
let api_messages = messages
|
let api_messages = messages
|
||||||
.into_iter()
|
.into_iter()
|
||||||
@@ -497,12 +492,12 @@ async fn handle_websocket_subscription(
|
|||||||
}),
|
}),
|
||||||
};
|
};
|
||||||
|
|
||||||
serialize_msgpack(response)?
|
serde_json::to_string(&response)?
|
||||||
};
|
};
|
||||||
|
|
||||||
log::debug!("Sending batch of messages over WebSocket subscription");
|
log::debug!("Sending batch of messages over WebSocket subscription");
|
||||||
|
|
||||||
if websocket.send(Message::Binary(msgpack_message)).await.is_err() {
|
if websocket.send(Message::Text(json_message)).await.is_err() {
|
||||||
// Client disconnected
|
// Client disconnected
|
||||||
log::debug!("WebSocket subscription closed by client");
|
log::debug!("WebSocket subscription closed by client");
|
||||||
break;
|
break;
|
||||||
|
|||||||
@@ -238,26 +238,35 @@ pub struct OpenResponse {
|
|||||||
pub session_id: SessionId,
|
pub session_id: SessionId,
|
||||||
}
|
}
|
||||||
|
|
||||||
#[derive(Debug, Serialize, Deserialize)]
|
|
||||||
#[serde(rename_all = "camelCase")]
|
|
||||||
pub struct SerializeRequest {
|
|
||||||
pub session_id: SessionId,
|
|
||||||
pub ids: Vec<Ref>,
|
|
||||||
}
|
|
||||||
|
|
||||||
#[derive(Debug, Serialize, Deserialize)]
|
#[derive(Debug, Serialize, Deserialize)]
|
||||||
#[serde(rename_all = "camelCase")]
|
#[serde(rename_all = "camelCase")]
|
||||||
pub struct SerializeResponse {
|
pub struct SerializeResponse {
|
||||||
pub session_id: SessionId,
|
pub session_id: SessionId,
|
||||||
#[serde(with = "serde_bytes")]
|
pub model_contents: BufferEncode,
|
||||||
pub model_contents: Vec<u8>,
|
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// Using this struct we can force Roblox to JSONDecode this as a buffer.
|
||||||
|
/// This is what Roblox's serde APIs use, so it saves a step in the plugin.
|
||||||
#[derive(Debug, Serialize, Deserialize)]
|
#[derive(Debug, Serialize, Deserialize)]
|
||||||
#[serde(rename_all = "camelCase")]
|
pub struct BufferEncode {
|
||||||
pub struct RefPatchRequest {
|
m: (),
|
||||||
pub session_id: SessionId,
|
t: Cow<'static, str>,
|
||||||
pub ids: HashSet<Ref>,
|
base64: String,
|
||||||
|
}
|
||||||
|
|
||||||
|
impl BufferEncode {
|
||||||
|
pub fn new(content: Vec<u8>) -> Self {
|
||||||
|
let base64 = data_encoding::BASE64.encode(&content);
|
||||||
|
Self {
|
||||||
|
m: (),
|
||||||
|
t: Cow::Borrowed("buffer"),
|
||||||
|
base64,
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
pub fn model(&self) -> &str {
|
||||||
|
&self.base64
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
#[derive(Debug, Serialize, Deserialize)]
|
#[derive(Debug, Serialize, Deserialize)]
|
||||||
|
|||||||
@@ -1,48 +1,8 @@
|
|||||||
use hyper::{header::CONTENT_TYPE, Body, Response, StatusCode};
|
use hyper::{header::CONTENT_TYPE, Body, Response, StatusCode};
|
||||||
use serde::{Deserialize, Serialize};
|
use serde::Serialize;
|
||||||
|
|
||||||
pub fn msgpack_ok<T: Serialize>(value: T) -> Response<Body> {
|
pub fn json_ok<T: Serialize>(value: T) -> Response<Body> {
|
||||||
msgpack(value, StatusCode::OK)
|
json(value, StatusCode::OK)
|
||||||
}
|
|
||||||
|
|
||||||
pub fn msgpack<T: Serialize>(value: T, code: StatusCode) -> Response<Body> {
|
|
||||||
let mut serialized = Vec::new();
|
|
||||||
let mut serializer = rmp_serde::Serializer::new(&mut serialized)
|
|
||||||
.with_human_readable()
|
|
||||||
.with_struct_map();
|
|
||||||
|
|
||||||
if let Err(err) = value.serialize(&mut serializer) {
|
|
||||||
return Response::builder()
|
|
||||||
.status(StatusCode::INTERNAL_SERVER_ERROR)
|
|
||||||
.header(CONTENT_TYPE, "text/plain")
|
|
||||||
.body(Body::from(err.to_string()))
|
|
||||||
.unwrap();
|
|
||||||
};
|
|
||||||
|
|
||||||
Response::builder()
|
|
||||||
.status(code)
|
|
||||||
.header(CONTENT_TYPE, "application/msgpack")
|
|
||||||
.body(Body::from(serialized))
|
|
||||||
.unwrap()
|
|
||||||
}
|
|
||||||
|
|
||||||
pub fn serialize_msgpack<T: Serialize>(value: T) -> anyhow::Result<Vec<u8>> {
|
|
||||||
let mut serialized = Vec::new();
|
|
||||||
let mut serializer = rmp_serde::Serializer::new(&mut serialized)
|
|
||||||
.with_human_readable()
|
|
||||||
.with_struct_map();
|
|
||||||
|
|
||||||
value.serialize(&mut serializer)?;
|
|
||||||
|
|
||||||
Ok(serialized)
|
|
||||||
}
|
|
||||||
|
|
||||||
pub fn deserialize_msgpack<'a, T: Deserialize<'a>>(
|
|
||||||
input: &'a [u8],
|
|
||||||
) -> Result<T, rmp_serde::decode::Error> {
|
|
||||||
let mut deserializer = rmp_serde::Deserializer::new(input).with_human_readable();
|
|
||||||
|
|
||||||
T::deserialize(&mut deserializer)
|
|
||||||
}
|
}
|
||||||
|
|
||||||
pub fn json<T: Serialize>(value: T, code: StatusCode) -> Response<Body> {
|
pub fn json<T: Serialize>(value: T, code: StatusCode) -> Response<Body> {
|
||||||
|
|||||||
@@ -1,14 +0,0 @@
|
|||||||
{
|
|
||||||
"name": "default",
|
|
||||||
"tree": {
|
|
||||||
"$className": "DataModel",
|
|
||||||
"ReplicatedStorage": {
|
|
||||||
"Project": {
|
|
||||||
"$path": "project/src",
|
|
||||||
"Module": {
|
|
||||||
"$path": "module"
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
@@ -1 +0,0 @@
|
|||||||
return nil
|
|
||||||
@@ -1,14 +0,0 @@
|
|||||||
{
|
|
||||||
"name": "default",
|
|
||||||
"tree": {
|
|
||||||
"$className": "DataModel",
|
|
||||||
"ReplicatedStorage": {
|
|
||||||
"Project": {
|
|
||||||
"$path": "src/",
|
|
||||||
"Module": {
|
|
||||||
"$path": "../module"
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
@@ -1 +0,0 @@
|
|||||||
return nil
|
|
||||||
@@ -1,4 +1,5 @@
|
|||||||
use std::{
|
use std::{
|
||||||
|
fmt::Write as _,
|
||||||
fs,
|
fs,
|
||||||
path::{Path, PathBuf},
|
path::{Path, PathBuf},
|
||||||
process::Command,
|
process::Command,
|
||||||
@@ -10,15 +11,10 @@ use std::{
|
|||||||
use hyper_tungstenite::tungstenite::{connect, Message};
|
use hyper_tungstenite::tungstenite::{connect, Message};
|
||||||
use rbx_dom_weak::types::Ref;
|
use rbx_dom_weak::types::Ref;
|
||||||
|
|
||||||
use serde::{Deserialize, Serialize};
|
|
||||||
use tempfile::{tempdir, TempDir};
|
use tempfile::{tempdir, TempDir};
|
||||||
|
|
||||||
use librojo::{
|
use librojo::web_api::{
|
||||||
web_api::{
|
ReadResponse, SerializeResponse, ServerInfoResponse, SocketPacket, SocketPacketType,
|
||||||
ReadResponse, SerializeRequest, SerializeResponse, ServerInfoResponse, SocketPacket,
|
|
||||||
SocketPacketType,
|
|
||||||
},
|
|
||||||
SessionId,
|
|
||||||
};
|
};
|
||||||
use rojo_insta_ext::RedactionMap;
|
use rojo_insta_ext::RedactionMap;
|
||||||
|
|
||||||
@@ -162,16 +158,22 @@ impl TestServeSession {
|
|||||||
|
|
||||||
pub fn get_api_rojo(&self) -> Result<ServerInfoResponse, reqwest::Error> {
|
pub fn get_api_rojo(&self) -> Result<ServerInfoResponse, reqwest::Error> {
|
||||||
let url = format!("http://localhost:{}/api/rojo", self.port);
|
let url = format!("http://localhost:{}/api/rojo", self.port);
|
||||||
let body = reqwest::blocking::get(url)?.bytes()?;
|
let body = reqwest::blocking::get(url)?.text()?;
|
||||||
|
|
||||||
Ok(deserialize_msgpack(&body).expect("Server returned malformed response"))
|
let value = jsonc_parser::parse_to_serde_value(&body, &Default::default())
|
||||||
|
.expect("Failed to parse JSON")
|
||||||
|
.expect("No JSON value");
|
||||||
|
Ok(serde_json::from_value(value).expect("Server returned malformed response"))
|
||||||
}
|
}
|
||||||
|
|
||||||
pub fn get_api_read(&self, id: Ref) -> Result<ReadResponse<'_>, reqwest::Error> {
|
pub fn get_api_read(&self, id: Ref) -> Result<ReadResponse<'_>, reqwest::Error> {
|
||||||
let url = format!("http://localhost:{}/api/read/{}", self.port, id);
|
let url = format!("http://localhost:{}/api/read/{}", self.port, id);
|
||||||
let body = reqwest::blocking::get(url)?.bytes()?;
|
let body = reqwest::blocking::get(url)?.text()?;
|
||||||
|
|
||||||
Ok(deserialize_msgpack(&body).expect("Server returned malformed response"))
|
let value = jsonc_parser::parse_to_serde_value(&body, &Default::default())
|
||||||
|
.expect("Failed to parse JSON")
|
||||||
|
.expect("No JSON value");
|
||||||
|
Ok(serde_json::from_value(value).expect("Server returned malformed response"))
|
||||||
}
|
}
|
||||||
|
|
||||||
pub fn get_api_socket_packet(
|
pub fn get_api_socket_packet(
|
||||||
@@ -193,8 +195,8 @@ impl TestServeSession {
|
|||||||
}
|
}
|
||||||
|
|
||||||
match socket.read() {
|
match socket.read() {
|
||||||
Ok(Message::Binary(binary)) => {
|
Ok(Message::Text(text)) => {
|
||||||
let packet: SocketPacket = deserialize_msgpack(&binary)?;
|
let packet: SocketPacket = serde_json::from_str(&text)?;
|
||||||
if packet.packet_type != packet_type {
|
if packet.packet_type != packet_type {
|
||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
@@ -207,7 +209,7 @@ impl TestServeSession {
|
|||||||
return Err("WebSocket closed before receiving messages".into());
|
return Err("WebSocket closed before receiving messages".into());
|
||||||
}
|
}
|
||||||
Ok(_) => {
|
Ok(_) => {
|
||||||
// Ignore other message types (ping, pong, text)
|
// Ignore other message types (ping, pong, binary)
|
||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
Err(hyper_tungstenite::tungstenite::Error::Io(e))
|
Err(hyper_tungstenite::tungstenite::Error::Io(e))
|
||||||
@@ -224,44 +226,19 @@ impl TestServeSession {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
pub fn get_api_serialize(
|
pub fn get_api_serialize(&self, ids: &[Ref]) -> Result<SerializeResponse, reqwest::Error> {
|
||||||
&self,
|
let mut id_list = String::with_capacity(ids.len() * 33);
|
||||||
ids: &[Ref],
|
for id in ids {
|
||||||
session_id: SessionId,
|
write!(id_list, "{id},").unwrap();
|
||||||
) -> Result<SerializeResponse, reqwest::Error> {
|
}
|
||||||
let client = reqwest::blocking::Client::new();
|
id_list.pop();
|
||||||
let url = format!("http://localhost:{}/api/serialize", self.port);
|
|
||||||
let body = serialize_msgpack(&SerializeRequest {
|
|
||||||
session_id,
|
|
||||||
ids: ids.to_vec(),
|
|
||||||
})
|
|
||||||
.unwrap();
|
|
||||||
|
|
||||||
let body = client.post(url).body(body).send()?.bytes()?;
|
let url = format!("http://localhost:{}/api/serialize/{}", self.port, id_list);
|
||||||
|
|
||||||
Ok(deserialize_msgpack(&body).expect("Server returned malformed response"))
|
reqwest::blocking::get(url)?.json()
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
fn serialize_msgpack<T: Serialize>(value: T) -> Result<Vec<u8>, rmp_serde::encode::Error> {
|
|
||||||
let mut serialized = Vec::new();
|
|
||||||
let mut serializer = rmp_serde::Serializer::new(&mut serialized)
|
|
||||||
.with_human_readable()
|
|
||||||
.with_struct_map();
|
|
||||||
|
|
||||||
value.serialize(&mut serializer)?;
|
|
||||||
|
|
||||||
Ok(serialized)
|
|
||||||
}
|
|
||||||
|
|
||||||
fn deserialize_msgpack<'a, T: Deserialize<'a>>(
|
|
||||||
input: &'a [u8],
|
|
||||||
) -> Result<T, rmp_serde::decode::Error> {
|
|
||||||
let mut deserializer = rmp_serde::Deserializer::new(input).with_human_readable();
|
|
||||||
|
|
||||||
T::deserialize(&mut deserializer)
|
|
||||||
}
|
|
||||||
|
|
||||||
/// Probably-okay way to generate random enough port numbers for running the
|
/// Probably-okay way to generate random enough port numbers for running the
|
||||||
/// Rojo live server.
|
/// Rojo live server.
|
||||||
///
|
///
|
||||||
@@ -279,7 +256,11 @@ fn get_port_number() -> usize {
|
|||||||
/// Since the provided structure intentionally includes unredacted referents,
|
/// Since the provided structure intentionally includes unredacted referents,
|
||||||
/// some post-processing is done to ensure they don't show up in the model.
|
/// some post-processing is done to ensure they don't show up in the model.
|
||||||
pub fn serialize_to_xml_model(response: &SerializeResponse, redactions: &RedactionMap) -> String {
|
pub fn serialize_to_xml_model(response: &SerializeResponse, redactions: &RedactionMap) -> String {
|
||||||
let mut dom = rbx_binary::from_reader(response.model_contents.as_slice()).unwrap();
|
let model_content = data_encoding::BASE64
|
||||||
|
.decode(response.model_contents.model().as_bytes())
|
||||||
|
.unwrap();
|
||||||
|
|
||||||
|
let mut dom = rbx_binary::from_reader(model_content.as_slice()).unwrap();
|
||||||
// This makes me realize that maybe we need a `descendants_mut` iter.
|
// This makes me realize that maybe we need a `descendants_mut` iter.
|
||||||
let ref_list: Vec<Ref> = dom.descendants().map(|inst| inst.referent()).collect();
|
let ref_list: Vec<Ref> = dom.descendants().map(|inst| inst.referent()).collect();
|
||||||
for referent in ref_list {
|
for referent in ref_list {
|
||||||
|
|||||||
@@ -646,7 +646,7 @@ fn meshpart_with_id() {
|
|||||||
.unwrap();
|
.unwrap();
|
||||||
|
|
||||||
let serialize_response = session
|
let serialize_response = session
|
||||||
.get_api_serialize(&[*meshpart, *objectvalue], info.session_id)
|
.get_api_serialize(&[*meshpart, *objectvalue])
|
||||||
.unwrap();
|
.unwrap();
|
||||||
|
|
||||||
// We don't assert a snapshot on the SerializeResponse because the model includes the
|
// We don't assert a snapshot on the SerializeResponse because the model includes the
|
||||||
@@ -673,9 +673,7 @@ fn forced_parent() {
|
|||||||
read_response.intern_and_redact(&mut redactions, root_id)
|
read_response.intern_and_redact(&mut redactions, root_id)
|
||||||
);
|
);
|
||||||
|
|
||||||
let serialize_response = session
|
let serialize_response = session.get_api_serialize(&[root_id]).unwrap();
|
||||||
.get_api_serialize(&[root_id], info.session_id)
|
|
||||||
.unwrap();
|
|
||||||
|
|
||||||
assert_eq!(serialize_response.session_id, info.session_id);
|
assert_eq!(serialize_response.session_id, info.session_id);
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user