Reorganize and clean up plugin

plugin/http/Error.lua

@@ -0,0 +1,66 @@
+local Error = {}
+Error.__index = Error
+
+Error.Kind = {
+	HttpNotEnabled = {
+		message = "Rojo requires HTTP access, which is not enabled.\n" ..
+			"Check your game settings, located in the 'Home' tab of Studio.",
+	},
+	ConnectFailed = {
+		message = "Couldn't connect to the Rojo server.\n" ..
+			"Make sure the server is running -- use 'rojo serve' to run it!",
+	},
+	Timeout = {
+		message = "Request timed out.",
+	},
+	Unknown = {
+		message = "Unknown error: {{message}}",
+	},
+}
+
+setmetatable(Error.Kind, {
+	__index = function(_, key)
+		error(("%q is not a valid member of Http.Error.Kind"):format(tostring(key)), 2)
+	end,
+})
+
+function Error.new(type, extraMessage)
+	extraMessage = extraMessage or ""
+	local message = type.message:gsub("{{message}}", extraMessage)
+
+	local err = {
+		type = type,
+		message = message,
+	}
+
+	setmetatable(err, Error)
+
+	return err
+end
+
+function Error:__tostring()
+	return self.message
+end
+
+--[[
+	This method shouldn't have to exist. Ugh.
+]]
+function Error.fromErrorString(message)
+	local lower = message:lower()
+
+	if lower:find("^http requests are not enabled") then
+		return Error.new(Error.Kind.HttpNotEnabled)
+	end
+
+	if lower:find("^httperror: timedout") then
+		return Error.new(Error.Kind.Timeout)
+	end
+
+	if lower:find("^httperror: connectfail") then
+		return Error.new(Error.Kind.ConnectFailed)
+	end
+
+	return Error.new(Error.Kind.Unknown, message)
+end
+
+return Error

plugin/http/Response.lua

@@ -0,0 +1,34 @@
+local HttpService = game:GetService("HttpService")
+
+local stringTemplate = [[
+Http.Response {
+	code: %d
+	body: %s
+}]]
+
+local Response = {}
+Response.__index = Response
+
+function Response:__tostring()
+	return stringTemplate:format(self.code, self.body)
+end
+
+function Response.fromRobloxResponse(response)
+	local self = {
+		body = response.Body,
+		code = response.StatusCode,
+		headers = response.Headers,
+	}
+
+	return setmetatable(self, Response)
+end
+
+function Response:isSuccess()
+	return self.code >= 200 and self.code < 300
+end
+
+function Response:json()
+	return HttpService:JSONDecode(self.body)
+end
+
+return Response

plugin/http/init.lua

@@ -0,0 +1,77 @@
+local HttpService = game:GetService("HttpService")
+
+local Promise = require(script.Parent.Promise)
+local Log = require(script.Parent.Log)
+
+local HttpError = require(script.Error)
+local HttpResponse = require(script.Response)
+
+local lastRequestId = 0
+
+local Http = {}
+
+Http.Error = HttpError
+Http.Response = HttpResponse
+
+function Http.get(url)
+	local requestId = lastRequestId + 1
+	lastRequestId = requestId
+
+	Log.trace("GET(%d) %s", requestId, url)
+
+	return Promise.new(function(resolve, reject)
+		coroutine.wrap(function()
+			local success, response = pcall(function()
+				return HttpService:RequestAsync({
+					Url = url,
+					Method = "GET",
+				})
+			end)
+
+			if success then
+				Log.trace("Request %d success: status code %s", requestId, response.StatusCode)
+				resolve(HttpResponse.fromRobloxResponse(response))
+			else
+				Log.trace("Request %d failure: %s", requestId, response)
+				reject(HttpError.fromErrorString(response))
+			end
+		end)()
+	end)
+end
+
+function Http.post(url, body)
+	local requestId = lastRequestId + 1
+	lastRequestId = requestId
+
+	Log.trace("POST(%d) %s\n%s", requestId, url, body)
+
+	return Promise.new(function(resolve, reject)
+		coroutine.wrap(function()
+			local success, response = pcall(function()
+				return HttpService:RequestAsync({
+					Url = url,
+					Method = "POST",
+					Body = body,
+				})
+			end)
+
+			if success then
+				Log.trace("Request %d success: status code %s", requestId, response.StatusCode)
+				resolve(HttpResponse.fromRobloxResponse(response))
+			else
+				Log.trace("Request %d failure: %s", requestId, response)
+				reject(HttpError.fromErrorString(response))
+			end
+		end)()
+	end)
+end
+
+function Http.jsonEncode(object)
+	return HttpService:JSONEncode(object)
+end
+
+function Http.jsonDecode(source)
+	return HttpService:JSONDecode(source)
+end
+
+return Http

plugin/http/init.spec.lua

@@ -0,0 +1,5 @@
+return function()
+	it("should load", function()
+		require(script.Parent)
+	end)
+end