diff --git a/src/snapshot_middleware/csv.rs b/src/snapshot_middleware/csv.rs index 1734fc07..b505e793 100644 --- a/src/snapshot_middleware/csv.rs +++ b/src/snapshot_middleware/csv.rs @@ -7,14 +7,14 @@ use serde::Serialize; use crate::snapshot::{InstanceContext, InstanceMetadata, InstanceSnapshot}; -use super::{meta_file::AdjacentMetadata, middleware::SnapshotInstanceResult}; +use super::meta_file::AdjacentMetadata; pub fn snapshot_csv( _context: &InstanceContext, vfs: &Vfs, path: &Path, instance_name: &str, -) -> SnapshotInstanceResult { +) -> anyhow::Result> { let meta_path = path.with_file_name(format!("{}.meta.json", instance_name)); let contents = vfs.read(path)?; diff --git a/src/snapshot_middleware/dir.rs b/src/snapshot_middleware/dir.rs index e4b47ffc..bad35c81 100644 --- a/src/snapshot_middleware/dir.rs +++ b/src/snapshot_middleware/dir.rs @@ -4,9 +4,13 @@ use memofs::{DirEntry, IoResultExt, Vfs}; use crate::snapshot::{InstanceContext, InstanceMetadata, InstanceSnapshot}; -use super::{meta_file::DirectoryMetadata, middleware::SnapshotInstanceResult, snapshot_from_vfs}; +use super::{meta_file::DirectoryMetadata, snapshot_from_vfs}; -pub fn snapshot_dir(context: &InstanceContext, vfs: &Vfs, path: &Path) -> SnapshotInstanceResult { +pub fn snapshot_dir( + context: &InstanceContext, + vfs: &Vfs, + path: &Path, +) -> anyhow::Result> { let passes_filter_rules = |child: &DirEntry| { context .path_ignore_rules diff --git a/src/snapshot_middleware/json.rs b/src/snapshot_middleware/json.rs index 2e5c53fc..7530812d 100644 --- a/src/snapshot_middleware/json.rs +++ b/src/snapshot_middleware/json.rs @@ -9,14 +9,14 @@ use crate::{ snapshot::{InstanceContext, InstanceMetadata, InstanceSnapshot}, }; -use super::{meta_file::AdjacentMetadata, middleware::SnapshotInstanceResult}; +use super::meta_file::AdjacentMetadata; pub fn snapshot_json( context: &InstanceContext, vfs: &Vfs, path: &Path, instance_name: &str, -) -> SnapshotInstanceResult { +) -> anyhow::Result> { let contents = vfs.read(path)?; let value: serde_json::Value = serde_json::from_slice(&contents) diff --git a/src/snapshot_middleware/json_model.rs b/src/snapshot_middleware/json_model.rs index 653cc86d..89b274d4 100644 --- a/src/snapshot_middleware/json_model.rs +++ b/src/snapshot_middleware/json_model.rs @@ -9,14 +9,12 @@ use crate::{ snapshot::{InstanceContext, InstanceSnapshot}, }; -use super::middleware::SnapshotInstanceResult; - pub fn snapshot_json_model( context: &InstanceContext, vfs: &Vfs, path: &Path, instance_name: &str, -) -> SnapshotInstanceResult { +) -> anyhow::Result> { let contents = vfs.read(path)?; let contents_str = str::from_utf8(&contents) .with_context(|| format!("File was not valid UTF-8: {}", path.display()))?; diff --git a/src/snapshot_middleware/lua.rs b/src/snapshot_middleware/lua.rs index cc443084..d11e72c6 100644 --- a/src/snapshot_middleware/lua.rs +++ b/src/snapshot_middleware/lua.rs @@ -6,13 +6,14 @@ use memofs::{IoResultExt, Vfs}; use crate::snapshot::{InstanceContext, InstanceMetadata, InstanceSnapshot}; -use super::{ - dir::snapshot_dir, meta_file::AdjacentMetadata, middleware::SnapshotInstanceResult, - util::match_trailing, -}; +use super::{dir::snapshot_dir, meta_file::AdjacentMetadata, util::match_trailing}; /// Core routine for turning Lua files into snapshots. -pub fn snapshot_lua(context: &InstanceContext, vfs: &Vfs, path: &Path) -> SnapshotInstanceResult { +pub fn snapshot_lua( + context: &InstanceContext, + vfs: &Vfs, + path: &Path, +) -> anyhow::Result> { let file_name = path.file_name().unwrap().to_string_lossy(); let (class_name, instance_name) = if let Some(name) = match_trailing(&file_name, ".server.lua") @@ -63,7 +64,7 @@ pub fn snapshot_lua_init( context: &InstanceContext, vfs: &Vfs, init_path: &Path, -) -> SnapshotInstanceResult { +) -> anyhow::Result> { let folder_path = init_path.parent().unwrap(); let dir_snapshot = snapshot_dir(context, vfs, folder_path)?.unwrap(); diff --git a/src/snapshot_middleware/middleware.rs b/src/snapshot_middleware/middleware.rs deleted file mode 100644 index f576ede8..00000000 --- a/src/snapshot_middleware/middleware.rs +++ /dev/null @@ -1,3 +0,0 @@ -use crate::snapshot::InstanceSnapshot; - -pub type SnapshotInstanceResult = anyhow::Result>; diff --git a/src/snapshot_middleware/mod.rs b/src/snapshot_middleware/mod.rs index b6bbb432..9ce40c95 100644 --- a/src/snapshot_middleware/mod.rs +++ b/src/snapshot_middleware/mod.rs @@ -11,7 +11,6 @@ mod json; mod json_model; mod lua; mod meta_file; -mod middleware; mod project; mod rbxm; mod rbxmx; @@ -22,7 +21,7 @@ use std::path::Path; use memofs::{IoResultExt, Vfs}; -use crate::snapshot::InstanceContext; +use crate::snapshot::{InstanceContext, InstanceSnapshot}; use self::{ csv::snapshot_csv, @@ -30,7 +29,6 @@ use self::{ json::snapshot_json, json_model::snapshot_json_model, lua::{snapshot_lua, snapshot_lua_init}, - middleware::SnapshotInstanceResult, project::snapshot_project, rbxm::snapshot_rbxm, rbxmx::snapshot_rbxmx, @@ -46,7 +44,7 @@ pub fn snapshot_from_vfs( context: &InstanceContext, vfs: &Vfs, path: &Path, -) -> SnapshotInstanceResult { +) -> anyhow::Result> { let meta = match vfs.metadata(path).with_not_found()? { Some(meta) => meta, None => return Ok(None), diff --git a/src/snapshot_middleware/project.rs b/src/snapshot_middleware/project.rs index 2ee55bc2..673def0f 100644 --- a/src/snapshot_middleware/project.rs +++ b/src/snapshot_middleware/project.rs @@ -11,13 +11,13 @@ use crate::{ }, }; -use super::{middleware::SnapshotInstanceResult, snapshot_from_vfs}; +use super::snapshot_from_vfs; pub fn snapshot_project( context: &InstanceContext, vfs: &Vfs, path: &Path, -) -> SnapshotInstanceResult { +) -> anyhow::Result> { let project = Project::load_from_slice(&vfs.read(path)?, path) .with_context(|| format!("File was not a valid Rojo project: {}", path.display()))?; @@ -63,7 +63,7 @@ pub fn snapshot_project_node( node: &ProjectNode, vfs: &Vfs, parent_class: Option<&str>, -) -> SnapshotInstanceResult { +) -> anyhow::Result> { let project_folder = project_path.parent().unwrap(); let class_name_from_project = node diff --git a/src/snapshot_middleware/rbxm.rs b/src/snapshot_middleware/rbxm.rs index 868f863e..8ec551d2 100644 --- a/src/snapshot_middleware/rbxm.rs +++ b/src/snapshot_middleware/rbxm.rs @@ -5,14 +5,12 @@ use memofs::Vfs; use crate::snapshot::{InstanceContext, InstanceMetadata, InstanceSnapshot}; -use super::middleware::SnapshotInstanceResult; - pub fn snapshot_rbxm( context: &InstanceContext, vfs: &Vfs, path: &Path, instance_name: &str, -) -> SnapshotInstanceResult { +) -> anyhow::Result> { let temp_tree = rbx_binary::from_reader(vfs.read(path)?.as_slice()) .with_context(|| format!("Malformed rbxm file: {}", path.display()))?; diff --git a/src/snapshot_middleware/rbxmx.rs b/src/snapshot_middleware/rbxmx.rs index d89ad87d..c37d3ddf 100644 --- a/src/snapshot_middleware/rbxmx.rs +++ b/src/snapshot_middleware/rbxmx.rs @@ -5,14 +5,12 @@ use memofs::Vfs; use crate::snapshot::{InstanceContext, InstanceMetadata, InstanceSnapshot}; -use super::middleware::SnapshotInstanceResult; - pub fn snapshot_rbxmx( context: &InstanceContext, vfs: &Vfs, path: &Path, instance_name: &str, -) -> SnapshotInstanceResult { +) -> anyhow::Result> { let options = rbx_xml::DecodeOptions::new() .property_behavior(rbx_xml::DecodePropertyBehavior::ReadUnknown); diff --git a/src/snapshot_middleware/txt.rs b/src/snapshot_middleware/txt.rs index 4cbf0c3d..fbc42dd6 100644 --- a/src/snapshot_middleware/txt.rs +++ b/src/snapshot_middleware/txt.rs @@ -6,14 +6,14 @@ use memofs::{IoResultExt, Vfs}; use crate::snapshot::{InstanceContext, InstanceMetadata, InstanceSnapshot}; -use super::{meta_file::AdjacentMetadata, middleware::SnapshotInstanceResult}; +use super::meta_file::AdjacentMetadata; pub fn snapshot_txt( context: &InstanceContext, vfs: &Vfs, path: &Path, instance_name: &str, -) -> SnapshotInstanceResult { +) -> anyhow::Result> { let contents = vfs.read(path)?; let contents_str = str::from_utf8(&contents) .with_context(|| format!("File was not valid UTF-8: {}", path.display()))?