From b448e8007eedba785379729547bce858cb6c9c28 Mon Sep 17 00:00:00 2001 From: Lucien Greathouse Date: Wed, 4 Apr 2018 23:05:01 -0700 Subject: [PATCH] Fix duplication 0.4.x duplication bug for good --- CHANGES.md | 3 ++- plugin/src/Reconciler.lua | 4 ++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/CHANGES.md b/CHANGES.md index 71b6728f..ab681518 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -1,7 +1,8 @@ # Rojo Change Log ## Current Master -*No changes* +* Fixed instances that were reconciled not being inserted into the RouteMap. + * The reconciler is still not a perfect solution, especially if script instances get moved around without being destroyed. I don't think this can be fixed before a big refactor. ## 0.4.1 (April 1, 2018) * Merged plugin repository into main Rojo repository for easier tracking. diff --git a/plugin/src/Reconciler.lua b/plugin/src/Reconciler.lua index 22d7968d..33f1119f 100644 --- a/plugin/src/Reconciler.lua +++ b/plugin/src/Reconciler.lua @@ -161,6 +161,10 @@ function Reconciler:reconcile(rbx, item) -- Use a dumb algorithm for reconciling children self:_reconcileChildren(rbx, item) + if item.Route then + self._routeMap:insert(item.Route, rbx) + end + return rbx end