mirror of
https://github.com/rojo-rbx/rojo.git
synced 2026-04-23 22:25:26 +00:00
Patch visualizer redesign (#883)
This commit is contained in:
@@ -4,6 +4,7 @@
|
|||||||
* Added Never option to Confirmation ([#893])
|
* Added Never option to Confirmation ([#893])
|
||||||
* Added popout diff visualizer for table properties like Attributes and Tags ([#834])
|
* Added popout diff visualizer for table properties like Attributes and Tags ([#834])
|
||||||
* Updated Theme to use Studio colors ([#838])
|
* Updated Theme to use Studio colors ([#838])
|
||||||
|
* Improved patch visualizer UX ([#883])
|
||||||
* Added experimental setting for Auto Connect in playtests ([#840])
|
* Added experimental setting for Auto Connect in playtests ([#840])
|
||||||
* Projects may now specify rules for syncing files as if they had a different file extension. ([#813])
|
* Projects may now specify rules for syncing files as if they had a different file extension. ([#813])
|
||||||
This is specified via a new field on project files, `syncRules`:
|
This is specified via a new field on project files, `syncRules`:
|
||||||
@@ -56,6 +57,7 @@
|
|||||||
[#834]: https://github.com/rojo-rbx/rojo/pull/834
|
[#834]: https://github.com/rojo-rbx/rojo/pull/834
|
||||||
[#838]: https://github.com/rojo-rbx/rojo/pull/838
|
[#838]: https://github.com/rojo-rbx/rojo/pull/838
|
||||||
[#840]: https://github.com/rojo-rbx/rojo/pull/840
|
[#840]: https://github.com/rojo-rbx/rojo/pull/840
|
||||||
|
[#883]: https://github.com/rojo-rbx/rojo/pull/883
|
||||||
[#893]: https://github.com/rojo-rbx/rojo/pull/893
|
[#893]: https://github.com/rojo-rbx/rojo/pull/893
|
||||||
|
|
||||||
## [7.4.1] - February 20, 2024
|
## [7.4.1] - February 20, 2024
|
||||||
|
|||||||
BIN
assets/images/syncsuccess.png
Normal file
BIN
assets/images/syncsuccess.png
Normal file
Binary file not shown.
|
After Width: | Height: | Size: 574 B |
BIN
assets/images/syncwarning.png
Normal file
BIN
assets/images/syncwarning.png
Normal file
Binary file not shown.
|
After Width: | Height: | Size: 607 B |
126
plugin/src/App/Components/ClassIcon.lua
Normal file
126
plugin/src/App/Components/ClassIcon.lua
Normal file
@@ -0,0 +1,126 @@
|
|||||||
|
local StudioService = game:GetService("StudioService")
|
||||||
|
local AssetService = game:GetService("AssetService")
|
||||||
|
|
||||||
|
local Rojo = script:FindFirstAncestor("Rojo")
|
||||||
|
local Plugin = Rojo.Plugin
|
||||||
|
local Packages = Rojo.Packages
|
||||||
|
|
||||||
|
local Roact = require(Packages.Roact)
|
||||||
|
|
||||||
|
local e = Roact.createElement
|
||||||
|
|
||||||
|
local EditableImage = require(Plugin.App.Components.EditableImage)
|
||||||
|
|
||||||
|
local imageCache = {}
|
||||||
|
local function getImageSizeAndPixels(image)
|
||||||
|
if not imageCache[image] then
|
||||||
|
local editableImage = AssetService:CreateEditableImageAsync(image)
|
||||||
|
imageCache[image] = {
|
||||||
|
Size = editableImage.Size,
|
||||||
|
Pixels = editableImage:ReadPixels(Vector2.zero, editableImage.Size),
|
||||||
|
}
|
||||||
|
end
|
||||||
|
|
||||||
|
return imageCache[image].Size, table.clone(imageCache[image].Pixels)
|
||||||
|
end
|
||||||
|
|
||||||
|
local function getRecoloredClassIcon(className, color)
|
||||||
|
local iconProps = StudioService:GetClassIcon(className)
|
||||||
|
|
||||||
|
if iconProps and color then
|
||||||
|
local success, editableImageSize, editableImagePixels = pcall(function()
|
||||||
|
local size, pixels = getImageSizeAndPixels(iconProps.Image)
|
||||||
|
|
||||||
|
local minVal, maxVal = math.huge, -math.huge
|
||||||
|
for i = 1, #pixels, 4 do
|
||||||
|
if pixels[i + 3] == 0 then
|
||||||
|
continue
|
||||||
|
end
|
||||||
|
local pixelVal = math.max(pixels[i], pixels[i + 1], pixels[i + 2])
|
||||||
|
|
||||||
|
minVal = math.min(minVal, pixelVal)
|
||||||
|
maxVal = math.max(maxVal, pixelVal)
|
||||||
|
end
|
||||||
|
|
||||||
|
local hue, sat, val = color:ToHSV()
|
||||||
|
for i = 1, #pixels, 4 do
|
||||||
|
if pixels[i + 3] == 0 then
|
||||||
|
continue
|
||||||
|
end
|
||||||
|
|
||||||
|
local pixelVal = math.max(pixels[i], pixels[i + 1], pixels[i + 2])
|
||||||
|
local newVal = val
|
||||||
|
if minVal < maxVal then
|
||||||
|
-- Remap minVal - maxVal to val*0.9 - val
|
||||||
|
newVal = val * (0.9 + 0.1 * (pixelVal - minVal) / (maxVal - minVal))
|
||||||
|
end
|
||||||
|
|
||||||
|
local newPixelColor = Color3.fromHSV(hue, sat, newVal)
|
||||||
|
pixels[i], pixels[i + 1], pixels[i + 2] = newPixelColor.R, newPixelColor.G, newPixelColor.B
|
||||||
|
end
|
||||||
|
return size, pixels
|
||||||
|
end)
|
||||||
|
if success then
|
||||||
|
iconProps.EditableImagePixels = editableImagePixels
|
||||||
|
iconProps.EditableImageSize = editableImageSize
|
||||||
|
end
|
||||||
|
end
|
||||||
|
|
||||||
|
return iconProps
|
||||||
|
end
|
||||||
|
|
||||||
|
local ClassIcon = Roact.PureComponent:extend("ClassIcon")
|
||||||
|
|
||||||
|
function ClassIcon:init()
|
||||||
|
self.state = {
|
||||||
|
iconProps = nil,
|
||||||
|
}
|
||||||
|
end
|
||||||
|
|
||||||
|
function ClassIcon:updateIcon()
|
||||||
|
local props = self.props
|
||||||
|
local iconProps = getRecoloredClassIcon(props.className, props.color)
|
||||||
|
self:setState({
|
||||||
|
iconProps = iconProps,
|
||||||
|
})
|
||||||
|
end
|
||||||
|
|
||||||
|
function ClassIcon:didMount()
|
||||||
|
self:updateIcon()
|
||||||
|
end
|
||||||
|
|
||||||
|
function ClassIcon:didUpdate(lastProps)
|
||||||
|
if lastProps.className ~= self.props.className or lastProps.color ~= self.props.color then
|
||||||
|
self:updateIcon()
|
||||||
|
end
|
||||||
|
end
|
||||||
|
|
||||||
|
function ClassIcon:render()
|
||||||
|
local iconProps = self.state.iconProps
|
||||||
|
if not iconProps then
|
||||||
|
return nil
|
||||||
|
end
|
||||||
|
|
||||||
|
return e(
|
||||||
|
"ImageLabel",
|
||||||
|
{
|
||||||
|
Size = self.props.size,
|
||||||
|
Position = self.props.position,
|
||||||
|
LayoutOrder = self.props.layoutOrder,
|
||||||
|
AnchorPoint = self.props.anchorPoint,
|
||||||
|
ImageTransparency = self.props.transparency,
|
||||||
|
Image = iconProps.Image,
|
||||||
|
ImageRectOffset = iconProps.ImageRectOffset,
|
||||||
|
ImageRectSize = iconProps.ImageRectSize,
|
||||||
|
BackgroundTransparency = 1,
|
||||||
|
},
|
||||||
|
if iconProps.EditableImagePixels
|
||||||
|
then e(EditableImage, {
|
||||||
|
size = iconProps.EditableImageSize,
|
||||||
|
pixels = iconProps.EditableImagePixels,
|
||||||
|
})
|
||||||
|
else nil
|
||||||
|
)
|
||||||
|
end
|
||||||
|
|
||||||
|
return ClassIcon
|
||||||
41
plugin/src/App/Components/EditableImage.lua
Normal file
41
plugin/src/App/Components/EditableImage.lua
Normal file
@@ -0,0 +1,41 @@
|
|||||||
|
local Rojo = script:FindFirstAncestor("Rojo")
|
||||||
|
local Packages = Rojo.Packages
|
||||||
|
|
||||||
|
local Roact = require(Packages.Roact)
|
||||||
|
|
||||||
|
local e = Roact.createElement
|
||||||
|
|
||||||
|
local EditableImage = Roact.PureComponent:extend("EditableImage")
|
||||||
|
|
||||||
|
function EditableImage:init()
|
||||||
|
self.ref = Roact.createRef()
|
||||||
|
end
|
||||||
|
|
||||||
|
function EditableImage:writePixels()
|
||||||
|
local image = self.ref.current
|
||||||
|
if not image then
|
||||||
|
return
|
||||||
|
end
|
||||||
|
if not self.props.pixels then
|
||||||
|
return
|
||||||
|
end
|
||||||
|
|
||||||
|
image:WritePixels(Vector2.zero, self.props.size, self.props.pixels)
|
||||||
|
end
|
||||||
|
|
||||||
|
function EditableImage:render()
|
||||||
|
return e("EditableImage", {
|
||||||
|
Size = self.props.size,
|
||||||
|
[Roact.Ref] = self.ref,
|
||||||
|
})
|
||||||
|
end
|
||||||
|
|
||||||
|
function EditableImage:didMount()
|
||||||
|
self:writePixels()
|
||||||
|
end
|
||||||
|
|
||||||
|
function EditableImage:didUpdate()
|
||||||
|
self:writePixels()
|
||||||
|
end
|
||||||
|
|
||||||
|
return EditableImage
|
||||||
@@ -155,7 +155,7 @@ function ChangeList:render()
|
|||||||
|
|
||||||
local headerRow = changes[1]
|
local headerRow = changes[1]
|
||||||
local headers = e("Frame", {
|
local headers = e("Frame", {
|
||||||
Size = UDim2.new(1, 0, 0, 30),
|
Size = UDim2.new(1, 0, 0, 24),
|
||||||
BackgroundTransparency = rowTransparency,
|
BackgroundTransparency = rowTransparency,
|
||||||
BackgroundColor3 = theme.Diff.Row,
|
BackgroundColor3 = theme.Diff.Row,
|
||||||
LayoutOrder = 0,
|
LayoutOrder = 0,
|
||||||
@@ -214,7 +214,7 @@ function ChangeList:render()
|
|||||||
local isWarning = metadata.isWarning
|
local isWarning = metadata.isWarning
|
||||||
|
|
||||||
rows[row] = e("Frame", {
|
rows[row] = e("Frame", {
|
||||||
Size = UDim2.new(1, 0, 0, 30),
|
Size = UDim2.new(1, 0, 0, 24),
|
||||||
BackgroundTransparency = row % 2 ~= 0 and rowTransparency or 1,
|
BackgroundTransparency = row % 2 ~= 0 and rowTransparency or 1,
|
||||||
BackgroundColor3 = theme.Diff.Row,
|
BackgroundColor3 = theme.Diff.Row,
|
||||||
BorderSizePixel = 0,
|
BorderSizePixel = 0,
|
||||||
@@ -269,8 +269,8 @@ function ChangeList:render()
|
|||||||
}, {
|
}, {
|
||||||
Headers = headers,
|
Headers = headers,
|
||||||
Values = e(ScrollingFrame, {
|
Values = e(ScrollingFrame, {
|
||||||
size = UDim2.new(1, 0, 1, -30),
|
size = UDim2.new(1, 0, 1, -24),
|
||||||
position = UDim2.new(0, 0, 0, 30),
|
position = UDim2.new(0, 0, 0, 24),
|
||||||
contentSize = self.contentSize,
|
contentSize = self.contentSize,
|
||||||
transparency = props.transparency,
|
transparency = props.transparency,
|
||||||
}, rows),
|
}, rows),
|
||||||
|
|||||||
@@ -1,5 +1,4 @@
|
|||||||
local SelectionService = game:GetService("Selection")
|
local SelectionService = game:GetService("Selection")
|
||||||
local StudioService = game:GetService("StudioService")
|
|
||||||
|
|
||||||
local Rojo = script:FindFirstAncestor("Rojo")
|
local Rojo = script:FindFirstAncestor("Rojo")
|
||||||
local Plugin = Rojo.Plugin
|
local Plugin = Rojo.Plugin
|
||||||
@@ -15,7 +14,8 @@ local bindingUtil = require(Plugin.App.bindingUtil)
|
|||||||
local e = Roact.createElement
|
local e = Roact.createElement
|
||||||
|
|
||||||
local ChangeList = require(script.Parent.ChangeList)
|
local ChangeList = require(script.Parent.ChangeList)
|
||||||
local Tooltip = require(script.Parent.Parent.Tooltip)
|
local Tooltip = require(Plugin.App.Components.Tooltip)
|
||||||
|
local ClassIcon = require(Plugin.App.Components.ClassIcon)
|
||||||
|
|
||||||
local Expansion = Roact.Component:extend("Expansion")
|
local Expansion = Roact.Component:extend("Expansion")
|
||||||
|
|
||||||
@@ -28,8 +28,8 @@ function Expansion:render()
|
|||||||
|
|
||||||
return e("Frame", {
|
return e("Frame", {
|
||||||
BackgroundTransparency = 1,
|
BackgroundTransparency = 1,
|
||||||
Size = UDim2.new(1, -props.indent, 1, -30),
|
Size = UDim2.new(1, -props.indent, 1, -24),
|
||||||
Position = UDim2.new(0, props.indent, 0, 30),
|
Position = UDim2.new(0, props.indent, 0, 24),
|
||||||
}, {
|
}, {
|
||||||
ChangeList = e(ChangeList, {
|
ChangeList = e(ChangeList, {
|
||||||
changes = props.changeList,
|
changes = props.changeList,
|
||||||
@@ -44,7 +44,7 @@ local DomLabel = Roact.Component:extend("DomLabel")
|
|||||||
|
|
||||||
function DomLabel:init()
|
function DomLabel:init()
|
||||||
local initHeight = self.props.elementHeight:getValue()
|
local initHeight = self.props.elementHeight:getValue()
|
||||||
self.expanded = initHeight > 30
|
self.expanded = initHeight > 24
|
||||||
|
|
||||||
self.motor = Flipper.SingleMotor.new(initHeight)
|
self.motor = Flipper.SingleMotor.new(initHeight)
|
||||||
self.binding = bindingUtil.fromMotor(self.motor)
|
self.binding = bindingUtil.fromMotor(self.motor)
|
||||||
@@ -53,7 +53,7 @@ function DomLabel:init()
|
|||||||
renderExpansion = self.expanded,
|
renderExpansion = self.expanded,
|
||||||
})
|
})
|
||||||
self.motor:onStep(function(value)
|
self.motor:onStep(function(value)
|
||||||
local renderExpansion = value > 30
|
local renderExpansion = value > 24
|
||||||
|
|
||||||
self.props.setElementHeight(value)
|
self.props.setElementHeight(value)
|
||||||
if self.props.updateEvent then
|
if self.props.updateEvent then
|
||||||
@@ -81,7 +81,7 @@ function DomLabel:didUpdate(prevProps)
|
|||||||
then
|
then
|
||||||
-- Close the expansion when the domlabel is changed to a different thing
|
-- Close the expansion when the domlabel is changed to a different thing
|
||||||
self.expanded = false
|
self.expanded = false
|
||||||
self.motor:setGoal(Flipper.Spring.new(30, {
|
self.motor:setGoal(Flipper.Spring.new(24, {
|
||||||
frequency = 5,
|
frequency = 5,
|
||||||
dampingRatio = 1,
|
dampingRatio = 1,
|
||||||
}))
|
}))
|
||||||
@@ -90,17 +90,49 @@ end
|
|||||||
|
|
||||||
function DomLabel:render()
|
function DomLabel:render()
|
||||||
local props = self.props
|
local props = self.props
|
||||||
|
local depth = props.depth or 1
|
||||||
|
|
||||||
return Theme.with(function(theme)
|
return Theme.with(function(theme)
|
||||||
local iconProps = StudioService:GetClassIcon(props.className)
|
local color = if props.isWarning
|
||||||
local indent = (props.depth or 0) * 20 + 25
|
then theme.Diff.Warning
|
||||||
|
elseif props.patchType then theme.Diff[props.patchType]
|
||||||
|
else theme.TextColor
|
||||||
|
|
||||||
|
local indent = (depth - 1) * 12 + 15
|
||||||
|
|
||||||
-- Line guides help indent depth remain readable
|
-- Line guides help indent depth remain readable
|
||||||
local lineGuides = {}
|
local lineGuides = {}
|
||||||
for i = 1, props.depth or 0 do
|
for i = 2, depth do
|
||||||
lineGuides["Line_" .. i] = e("Frame", {
|
if props.depthsComplete[i] then
|
||||||
Size = UDim2.new(0, 2, 1, 2),
|
continue
|
||||||
Position = UDim2.new(0, (20 * i) + 15, 0, -1),
|
end
|
||||||
|
if props.isFinalChild and i == depth then
|
||||||
|
-- This line stops halfway down to merge with our connector for the right angle
|
||||||
|
lineGuides["Line_" .. i] = e("Frame", {
|
||||||
|
Size = UDim2.new(0, 2, 0, 15),
|
||||||
|
Position = UDim2.new(0, (12 * (i - 1)) + 6, 0, -1),
|
||||||
|
BorderSizePixel = 0,
|
||||||
|
BackgroundTransparency = props.transparency,
|
||||||
|
BackgroundColor3 = theme.BorderedContainer.BorderColor,
|
||||||
|
})
|
||||||
|
else
|
||||||
|
-- All other lines go all the way
|
||||||
|
-- with the exception of the final element, which stops halfway down
|
||||||
|
lineGuides["Line_" .. i] = e("Frame", {
|
||||||
|
Size = UDim2.new(0, 2, 1, if props.isFinalElement then -9 else 2),
|
||||||
|
Position = UDim2.new(0, (12 * (i - 1)) + 6, 0, -1),
|
||||||
|
BorderSizePixel = 0,
|
||||||
|
BackgroundTransparency = props.transparency,
|
||||||
|
BackgroundColor3 = theme.BorderedContainer.BorderColor,
|
||||||
|
})
|
||||||
|
end
|
||||||
|
end
|
||||||
|
|
||||||
|
if depth ~= 1 then
|
||||||
|
lineGuides["Connector"] = e("Frame", {
|
||||||
|
Size = UDim2.new(0, 8, 0, 2),
|
||||||
|
Position = UDim2.new(0, 2 + (12 * props.depth), 0, 12),
|
||||||
|
AnchorPoint = Vector2.xAxis,
|
||||||
BorderSizePixel = 0,
|
BorderSizePixel = 0,
|
||||||
BackgroundTransparency = props.transparency,
|
BackgroundTransparency = props.transparency,
|
||||||
BackgroundColor3 = theme.BorderedContainer.BorderColor,
|
BackgroundColor3 = theme.BorderedContainer.BorderColor,
|
||||||
@@ -109,9 +141,8 @@ function DomLabel:render()
|
|||||||
|
|
||||||
return e("Frame", {
|
return e("Frame", {
|
||||||
ClipsDescendants = true,
|
ClipsDescendants = true,
|
||||||
BackgroundColor3 = if props.patchType then theme.Diff[props.patchType] else nil,
|
BackgroundTransparency = if props.elementIndex % 2 == 0 then 0.985 else 1,
|
||||||
BorderSizePixel = 0,
|
BackgroundColor3 = theme.Diff.Row,
|
||||||
BackgroundTransparency = props.patchType and props.transparency or 1,
|
|
||||||
Size = self.binding:map(function(expand)
|
Size = self.binding:map(function(expand)
|
||||||
return UDim2.new(1, 0, 0, expand)
|
return UDim2.new(1, 0, 0, expand)
|
||||||
end),
|
end),
|
||||||
@@ -141,8 +172,8 @@ function DomLabel:render()
|
|||||||
|
|
||||||
if props.changeList then
|
if props.changeList then
|
||||||
self.expanded = not self.expanded
|
self.expanded = not self.expanded
|
||||||
local goalHeight = 30
|
local goalHeight = 24
|
||||||
+ (if self.expanded then math.clamp(#props.changeList * 30, 30, 30 * 6) else 0)
|
+ (if self.expanded then math.clamp(#props.changeList * 24, 24, 24 * 6) else 0)
|
||||||
self.motor:setGoal(Flipper.Spring.new(goalHeight, {
|
self.motor:setGoal(Flipper.Spring.new(goalHeight, {
|
||||||
frequency = 5,
|
frequency = 5,
|
||||||
dampingRatio = 1,
|
dampingRatio = 1,
|
||||||
@@ -174,40 +205,74 @@ function DomLabel:render()
|
|||||||
DiffIcon = if props.patchType
|
DiffIcon = if props.patchType
|
||||||
then e("ImageLabel", {
|
then e("ImageLabel", {
|
||||||
Image = Assets.Images.Diff[props.patchType],
|
Image = Assets.Images.Diff[props.patchType],
|
||||||
ImageColor3 = theme.AddressEntry.PlaceholderColor,
|
ImageColor3 = color,
|
||||||
ImageTransparency = props.transparency,
|
ImageTransparency = props.transparency,
|
||||||
BackgroundTransparency = 1,
|
BackgroundTransparency = 1,
|
||||||
Size = UDim2.new(0, 20, 0, 20),
|
Size = UDim2.new(0, 14, 0, 14),
|
||||||
Position = UDim2.new(0, 0, 0, 15),
|
Position = UDim2.new(0, 0, 0, 12),
|
||||||
AnchorPoint = Vector2.new(0, 0.5),
|
AnchorPoint = Vector2.new(0, 0.5),
|
||||||
})
|
})
|
||||||
else nil,
|
else nil,
|
||||||
ClassIcon = e("ImageLabel", {
|
ClassIcon = e(ClassIcon, {
|
||||||
Image = iconProps.Image,
|
className = props.className,
|
||||||
ImageTransparency = props.transparency,
|
color = color,
|
||||||
ImageRectOffset = iconProps.ImageRectOffset,
|
transparency = props.transparency,
|
||||||
ImageRectSize = iconProps.ImageRectSize,
|
size = UDim2.new(0, 16, 0, 16),
|
||||||
BackgroundTransparency = 1,
|
position = UDim2.new(0, indent + 2, 0, 12),
|
||||||
Size = UDim2.new(0, 20, 0, 20),
|
anchorPoint = Vector2.new(0, 0.5),
|
||||||
Position = UDim2.new(0, indent, 0, 15),
|
|
||||||
AnchorPoint = Vector2.new(0, 0.5),
|
|
||||||
}),
|
}),
|
||||||
InstanceName = e("TextLabel", {
|
InstanceName = e("TextLabel", {
|
||||||
Text = (if props.isWarning then "⚠ " else "") .. props.name .. (props.hint and string.format(
|
Text = (if props.isWarning then "⚠ " else "") .. props.name,
|
||||||
' <font color="#%s">%s</font>',
|
|
||||||
theme.AddressEntry.PlaceholderColor:ToHex(),
|
|
||||||
props.hint
|
|
||||||
) or ""),
|
|
||||||
RichText = true,
|
RichText = true,
|
||||||
BackgroundTransparency = 1,
|
BackgroundTransparency = 1,
|
||||||
Font = Enum.Font.GothamMedium,
|
Font = if props.patchType then Enum.Font.GothamBold else Enum.Font.GothamMedium,
|
||||||
TextSize = 14,
|
TextSize = 14,
|
||||||
TextColor3 = if props.isWarning then theme.Diff.Warning else theme.TextColor,
|
TextColor3 = color,
|
||||||
TextXAlignment = Enum.TextXAlignment.Left,
|
TextXAlignment = Enum.TextXAlignment.Left,
|
||||||
TextTransparency = props.transparency,
|
TextTransparency = props.transparency,
|
||||||
TextTruncate = Enum.TextTruncate.AtEnd,
|
TextTruncate = Enum.TextTruncate.AtEnd,
|
||||||
Size = UDim2.new(1, -indent - 50, 0, 30),
|
Size = UDim2.new(1, -indent - 50, 0, 24),
|
||||||
Position = UDim2.new(0, indent + 30, 0, 0),
|
Position = UDim2.new(0, indent + 22, 0, 0),
|
||||||
|
}),
|
||||||
|
ChangeInfo = e("Frame", {
|
||||||
|
BackgroundTransparency = 1,
|
||||||
|
Size = UDim2.new(1, -indent - 80, 0, 24),
|
||||||
|
Position = UDim2.new(1, -2, 0, 0),
|
||||||
|
AnchorPoint = Vector2.new(1, 0),
|
||||||
|
}, {
|
||||||
|
Layout = e("UIListLayout", {
|
||||||
|
FillDirection = Enum.FillDirection.Horizontal,
|
||||||
|
HorizontalAlignment = Enum.HorizontalAlignment.Right,
|
||||||
|
VerticalAlignment = Enum.VerticalAlignment.Center,
|
||||||
|
SortOrder = Enum.SortOrder.LayoutOrder,
|
||||||
|
Padding = UDim.new(0, 4),
|
||||||
|
}),
|
||||||
|
Edits = if props.changeInfo and props.changeInfo.edits
|
||||||
|
then e("TextLabel", {
|
||||||
|
Text = props.changeInfo.edits .. if props.changeInfo.failed then "," else "",
|
||||||
|
BackgroundTransparency = 1,
|
||||||
|
Font = Enum.Font.Gotham,
|
||||||
|
TextSize = 14,
|
||||||
|
TextColor3 = theme.SubTextColor,
|
||||||
|
TextTransparency = props.transparency,
|
||||||
|
Size = UDim2.new(0, 0, 0, 16),
|
||||||
|
AutomaticSize = Enum.AutomaticSize.X,
|
||||||
|
LayoutOrder = 2,
|
||||||
|
})
|
||||||
|
else nil,
|
||||||
|
Failed = if props.changeInfo and props.changeInfo.failed
|
||||||
|
then e("TextLabel", {
|
||||||
|
Text = props.changeInfo.failed,
|
||||||
|
BackgroundTransparency = 1,
|
||||||
|
Font = Enum.Font.Gotham,
|
||||||
|
TextSize = 14,
|
||||||
|
TextColor3 = theme.Diff.Warning,
|
||||||
|
TextTransparency = props.transparency,
|
||||||
|
Size = UDim2.new(0, 0, 0, 16),
|
||||||
|
AutomaticSize = Enum.AutomaticSize.X,
|
||||||
|
LayoutOrder = 6,
|
||||||
|
})
|
||||||
|
else nil,
|
||||||
}),
|
}),
|
||||||
LineGuides = e("Folder", nil, lineGuides),
|
LineGuides = e("Folder", nil, lineGuides),
|
||||||
})
|
})
|
||||||
|
|||||||
@@ -8,8 +8,8 @@ local PatchTree = require(Plugin.PatchTree)
|
|||||||
local PatchSet = require(Plugin.PatchSet)
|
local PatchSet = require(Plugin.PatchSet)
|
||||||
|
|
||||||
local Theme = require(Plugin.App.Theme)
|
local Theme = require(Plugin.App.Theme)
|
||||||
local BorderedContainer = require(Plugin.App.Components.BorderedContainer)
|
|
||||||
local VirtualScroller = require(Plugin.App.Components.VirtualScroller)
|
local VirtualScroller = require(Plugin.App.Components.VirtualScroller)
|
||||||
|
local BorderedContainer = require(Plugin.App.Components.BorderedContainer)
|
||||||
|
|
||||||
local e = Roact.createElement
|
local e = Roact.createElement
|
||||||
|
|
||||||
@@ -55,34 +55,60 @@ function PatchVisualizer:render()
|
|||||||
end
|
end
|
||||||
|
|
||||||
-- Recusively draw tree
|
-- Recusively draw tree
|
||||||
local scrollElements, elementHeights = {}, {}
|
local scrollElements, elementHeights, elementIndex = {}, {}, 0
|
||||||
|
|
||||||
if patchTree then
|
if patchTree then
|
||||||
|
local elementTotal = patchTree:getCount()
|
||||||
|
local depthsComplete = {}
|
||||||
local function drawNode(node, depth)
|
local function drawNode(node, depth)
|
||||||
local elementHeight, setElementHeight = Roact.createBinding(30)
|
elementIndex += 1
|
||||||
table.insert(elementHeights, elementHeight)
|
|
||||||
table.insert(
|
local parentNode = patchTree:getNode(node.parentId)
|
||||||
scrollElements,
|
local isFinalChild = true
|
||||||
e(DomLabel, {
|
if parentNode then
|
||||||
updateEvent = self.updateEvent,
|
for _id, sibling in parentNode.children do
|
||||||
elementHeight = elementHeight,
|
if type(sibling) == "table" and sibling.name and sibling.name > node.name then
|
||||||
setElementHeight = setElementHeight,
|
isFinalChild = false
|
||||||
patchType = node.patchType,
|
break
|
||||||
className = node.className,
|
end
|
||||||
isWarning = node.isWarning,
|
end
|
||||||
instance = node.instance,
|
end
|
||||||
name = node.name,
|
|
||||||
hint = node.hint,
|
local elementHeight, setElementHeight = Roact.createBinding(24)
|
||||||
changeList = node.changeList,
|
elementHeights[elementIndex] = elementHeight
|
||||||
depth = depth,
|
scrollElements[elementIndex] = e(DomLabel, {
|
||||||
transparency = self.props.transparency,
|
transparency = self.props.transparency,
|
||||||
showStringDiff = self.props.showStringDiff,
|
showStringDiff = self.props.showStringDiff,
|
||||||
showTableDiff = self.props.showTableDiff,
|
showTableDiff = self.props.showTableDiff,
|
||||||
})
|
updateEvent = self.updateEvent,
|
||||||
)
|
elementHeight = elementHeight,
|
||||||
|
setElementHeight = setElementHeight,
|
||||||
|
elementIndex = elementIndex,
|
||||||
|
isFinalElement = elementIndex == elementTotal,
|
||||||
|
depth = depth,
|
||||||
|
depthsComplete = table.clone(depthsComplete),
|
||||||
|
hasChildren = (node.children ~= nil and next(node.children) ~= nil),
|
||||||
|
isFinalChild = isFinalChild,
|
||||||
|
patchType = node.patchType,
|
||||||
|
className = node.className,
|
||||||
|
isWarning = node.isWarning,
|
||||||
|
instance = node.instance,
|
||||||
|
name = node.name,
|
||||||
|
changeInfo = node.changeInfo,
|
||||||
|
changeList = node.changeList,
|
||||||
|
})
|
||||||
|
|
||||||
|
if isFinalChild then
|
||||||
|
depthsComplete[depth] = true
|
||||||
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
patchTree:forEach(function(node, depth)
|
patchTree:forEach(function(node, depth)
|
||||||
|
depthsComplete[depth] = false
|
||||||
|
for i = depth + 1, #depthsComplete do
|
||||||
|
depthsComplete[i] = nil
|
||||||
|
end
|
||||||
|
|
||||||
drawNode(node, depth)
|
drawNode(node, depth)
|
||||||
end)
|
end)
|
||||||
end
|
end
|
||||||
@@ -92,6 +118,7 @@ function PatchVisualizer:render()
|
|||||||
transparency = self.props.transparency,
|
transparency = self.props.transparency,
|
||||||
size = self.props.size,
|
size = self.props.size,
|
||||||
position = self.props.position,
|
position = self.props.position,
|
||||||
|
anchorPoint = self.props.anchorPoint,
|
||||||
layoutOrder = self.props.layoutOrder,
|
layoutOrder = self.props.layoutOrder,
|
||||||
}, {
|
}, {
|
||||||
CleanMerge = e("TextLabel", {
|
CleanMerge = e("TextLabel", {
|
||||||
@@ -106,7 +133,8 @@ function PatchVisualizer:render()
|
|||||||
}),
|
}),
|
||||||
|
|
||||||
VirtualScroller = e(VirtualScroller, {
|
VirtualScroller = e(VirtualScroller, {
|
||||||
size = UDim2.new(1, 0, 1, 0),
|
size = UDim2.new(1, 0, 1, -2),
|
||||||
|
position = UDim2.new(0, 0, 0, 2),
|
||||||
transparency = self.props.transparency,
|
transparency = self.props.transparency,
|
||||||
count = #scrollElements,
|
count = #scrollElements,
|
||||||
updateEvent = self.updateEvent.Event,
|
updateEvent = self.updateEvent.Event,
|
||||||
|
|||||||
@@ -131,8 +131,8 @@ function VirtualScroller:render()
|
|||||||
Position = props.position,
|
Position = props.position,
|
||||||
AnchorPoint = props.anchorPoint,
|
AnchorPoint = props.anchorPoint,
|
||||||
BackgroundTransparency = props.backgroundTransparency or 1,
|
BackgroundTransparency = props.backgroundTransparency or 1,
|
||||||
BackgroundColor3 = props.backgroundColor3,
|
BackgroundColor3 = props.backgroundColor3 or theme.BorderedContainer.BackgroundColor,
|
||||||
BorderColor3 = props.borderColor3,
|
BorderColor3 = props.borderColor3 or theme.BorderedContainer.BorderColor,
|
||||||
CanvasSize = self.totalCanvas:map(function(s)
|
CanvasSize = self.totalCanvas:map(function(s)
|
||||||
return UDim2.fromOffset(0, s)
|
return UDim2.fromOffset(0, s)
|
||||||
end),
|
end),
|
||||||
|
|||||||
@@ -9,7 +9,6 @@ local PatchTree = require(Plugin.PatchTree)
|
|||||||
local Settings = require(Plugin.Settings)
|
local Settings = require(Plugin.Settings)
|
||||||
local Theme = require(Plugin.App.Theme)
|
local Theme = require(Plugin.App.Theme)
|
||||||
local TextButton = require(Plugin.App.Components.TextButton)
|
local TextButton = require(Plugin.App.Components.TextButton)
|
||||||
local Header = require(Plugin.App.Components.Header)
|
|
||||||
local StudioPluginGui = require(Plugin.App.Components.Studio.StudioPluginGui)
|
local StudioPluginGui = require(Plugin.App.Components.Studio.StudioPluginGui)
|
||||||
local Tooltip = require(Plugin.App.Components.Tooltip)
|
local Tooltip = require(Plugin.App.Components.Tooltip)
|
||||||
local PatchVisualizer = require(Plugin.App.Components.PatchVisualizer)
|
local PatchVisualizer = require(Plugin.App.Components.PatchVisualizer)
|
||||||
@@ -60,17 +59,11 @@ end
|
|||||||
function ConfirmingPage:render()
|
function ConfirmingPage:render()
|
||||||
return Theme.with(function(theme)
|
return Theme.with(function(theme)
|
||||||
local pageContent = Roact.createFragment({
|
local pageContent = Roact.createFragment({
|
||||||
Header = e(Header, {
|
|
||||||
transparency = self.props.transparency,
|
|
||||||
layoutOrder = 1,
|
|
||||||
}),
|
|
||||||
|
|
||||||
Title = e("TextLabel", {
|
Title = e("TextLabel", {
|
||||||
Text = string.format(
|
Text = string.format(
|
||||||
"Sync changes for project '%s':",
|
"Sync changes for project '%s':",
|
||||||
self.props.confirmData.serverInfo.projectName or "UNKNOWN"
|
self.props.confirmData.serverInfo.projectName or "UNKNOWN"
|
||||||
),
|
),
|
||||||
LayoutOrder = 2,
|
|
||||||
Font = Enum.Font.Gotham,
|
Font = Enum.Font.Gotham,
|
||||||
LineHeight = 1.2,
|
LineHeight = 1.2,
|
||||||
TextSize = 14,
|
TextSize = 14,
|
||||||
@@ -82,7 +75,7 @@ function ConfirmingPage:render()
|
|||||||
}),
|
}),
|
||||||
|
|
||||||
PatchVisualizer = e(PatchVisualizer, {
|
PatchVisualizer = e(PatchVisualizer, {
|
||||||
size = UDim2.new(1, 0, 1, -150),
|
size = UDim2.new(1, 0, 1, -100),
|
||||||
transparency = self.props.transparency,
|
transparency = self.props.transparency,
|
||||||
layoutOrder = 3,
|
layoutOrder = 3,
|
||||||
|
|
||||||
@@ -155,6 +148,11 @@ function ConfirmingPage:render()
|
|||||||
}),
|
}),
|
||||||
}),
|
}),
|
||||||
|
|
||||||
|
Padding = e("UIPadding", {
|
||||||
|
PaddingLeft = UDim.new(0, 8),
|
||||||
|
PaddingRight = UDim.new(0, 8),
|
||||||
|
}),
|
||||||
|
|
||||||
Layout = e("UIListLayout", {
|
Layout = e("UIListLayout", {
|
||||||
HorizontalAlignment = Enum.HorizontalAlignment.Center,
|
HorizontalAlignment = Enum.HorizontalAlignment.Center,
|
||||||
VerticalAlignment = Enum.VerticalAlignment.Center,
|
VerticalAlignment = Enum.VerticalAlignment.Center,
|
||||||
@@ -163,11 +161,6 @@ function ConfirmingPage:render()
|
|||||||
Padding = UDim.new(0, 10),
|
Padding = UDim.new(0, 10),
|
||||||
}),
|
}),
|
||||||
|
|
||||||
Padding = e("UIPadding", {
|
|
||||||
PaddingLeft = UDim.new(0, 20),
|
|
||||||
PaddingRight = UDim.new(0, 20),
|
|
||||||
}),
|
|
||||||
|
|
||||||
StringDiff = e(StudioPluginGui, {
|
StringDiff = e(StudioPluginGui, {
|
||||||
id = "Rojo_ConfirmingStringDiff",
|
id = "Rojo_ConfirmingStringDiff",
|
||||||
title = "String diff",
|
title = "String diff",
|
||||||
|
|||||||
@@ -3,9 +3,7 @@ local Plugin = Rojo.Plugin
|
|||||||
local Packages = Rojo.Packages
|
local Packages = Rojo.Packages
|
||||||
|
|
||||||
local Roact = require(Packages.Roact)
|
local Roact = require(Packages.Roact)
|
||||||
local Flipper = require(Packages.Flipper)
|
|
||||||
|
|
||||||
local bindingUtil = require(Plugin.App.bindingUtil)
|
|
||||||
local Theme = require(Plugin.App.Theme)
|
local Theme = require(Plugin.App.Theme)
|
||||||
local Assets = require(Plugin.Assets)
|
local Assets = require(Plugin.Assets)
|
||||||
local PatchSet = require(Plugin.PatchSet)
|
local PatchSet = require(Plugin.PatchSet)
|
||||||
@@ -23,28 +21,20 @@ local TableDiffVisualizer = require(Plugin.App.Components.TableDiffVisualizer)
|
|||||||
local e = Roact.createElement
|
local e = Roact.createElement
|
||||||
|
|
||||||
local AGE_UNITS = {
|
local AGE_UNITS = {
|
||||||
{ 31556909, "year" },
|
{ 31556909, "y" },
|
||||||
{ 2629743, "month" },
|
{ 2629743, "mon" },
|
||||||
{ 604800, "week" },
|
{ 604800, "w" },
|
||||||
{ 86400, "day" },
|
{ 86400, "d" },
|
||||||
{ 3600, "hour" },
|
{ 3600, "h" },
|
||||||
{
|
{ 60, "m" },
|
||||||
60,
|
|
||||||
"minute",
|
|
||||||
},
|
|
||||||
}
|
}
|
||||||
function timeSinceText(elapsed: number): string
|
function timeSinceText(elapsed: number): string
|
||||||
if elapsed < 3 then
|
local ageText = string.format("%ds", elapsed)
|
||||||
return "just now"
|
|
||||||
end
|
|
||||||
|
|
||||||
local ageText = string.format("%d seconds ago", elapsed)
|
|
||||||
|
|
||||||
for _, UnitData in ipairs(AGE_UNITS) do
|
for _, UnitData in ipairs(AGE_UNITS) do
|
||||||
local UnitSeconds, UnitName = UnitData[1], UnitData[2]
|
local UnitSeconds, UnitName = UnitData[1], UnitData[2]
|
||||||
if elapsed > UnitSeconds then
|
if elapsed > UnitSeconds then
|
||||||
local c = math.floor(elapsed / UnitSeconds)
|
ageText = elapsed // UnitSeconds .. UnitName
|
||||||
ageText = string.format("%d %s%s ago", c, UnitName, c > 1 and "s" or "")
|
|
||||||
break
|
break
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
@@ -52,49 +42,179 @@ function timeSinceText(elapsed: number): string
|
|||||||
return ageText
|
return ageText
|
||||||
end
|
end
|
||||||
|
|
||||||
local ChangesDrawer = Roact.Component:extend("ChangesDrawer")
|
local ChangesViewer = Roact.Component:extend("ChangesViewer")
|
||||||
|
|
||||||
function ChangesDrawer:init()
|
function ChangesViewer:init()
|
||||||
-- Hold onto the serve session during the lifecycle of this component
|
-- Hold onto the serve session during the lifecycle of this component
|
||||||
-- so that it can still render during the fade out after disconnecting
|
-- so that it can still render during the fade out after disconnecting
|
||||||
self.serveSession = self.props.serveSession
|
self.serveSession = self.props.serveSession
|
||||||
end
|
end
|
||||||
|
|
||||||
function ChangesDrawer:render()
|
function ChangesViewer:render()
|
||||||
if self.props.rendered == false or self.serveSession == nil then
|
if self.props.rendered == false or self.serveSession == nil or self.props.patchData == nil then
|
||||||
return nil
|
return nil
|
||||||
end
|
end
|
||||||
|
|
||||||
|
local unapplied = PatchSet.countChanges(self.props.patchData.unapplied)
|
||||||
|
local applied = PatchSet.countChanges(self.props.patchData.patch) - unapplied
|
||||||
|
|
||||||
return Theme.with(function(theme)
|
return Theme.with(function(theme)
|
||||||
return e(BorderedContainer, {
|
return Roact.createFragment({
|
||||||
transparency = self.props.transparency,
|
Navbar = e("Frame", {
|
||||||
size = self.props.height:map(function(y)
|
Size = UDim2.new(1, 0, 0, 40),
|
||||||
return UDim2.new(1, 0, y, -220 * y)
|
BackgroundTransparency = 1,
|
||||||
end),
|
|
||||||
position = UDim2.new(0, 0, 1, 0),
|
|
||||||
anchorPoint = Vector2.new(0, 1),
|
|
||||||
layoutOrder = self.props.layoutOrder,
|
|
||||||
}, {
|
|
||||||
Close = e(IconButton, {
|
|
||||||
icon = Assets.Images.Icons.Close,
|
|
||||||
iconSize = 24,
|
|
||||||
color = theme.ConnectionDetails.DisconnectColor,
|
|
||||||
transparency = self.props.transparency,
|
|
||||||
|
|
||||||
position = UDim2.new(1, 0, 0, 0),
|
|
||||||
anchorPoint = Vector2.new(1, 0),
|
|
||||||
|
|
||||||
onClick = self.props.onClose,
|
|
||||||
}, {
|
}, {
|
||||||
Tip = e(Tooltip.Trigger, {
|
Close = e(IconButton, {
|
||||||
text = "Close the patch visualizer",
|
icon = Assets.Images.Icons.Close,
|
||||||
|
iconSize = 24,
|
||||||
|
color = theme.Settings.Navbar.BackButtonColor,
|
||||||
|
transparency = self.props.transparency,
|
||||||
|
|
||||||
|
position = UDim2.new(0, 0, 0.5, 0),
|
||||||
|
anchorPoint = Vector2.new(0, 0.5),
|
||||||
|
|
||||||
|
onClick = self.props.onBack,
|
||||||
|
}, {
|
||||||
|
Tip = e(Tooltip.Trigger, {
|
||||||
|
text = "Close",
|
||||||
|
}),
|
||||||
|
}),
|
||||||
|
|
||||||
|
Title = e("TextLabel", {
|
||||||
|
Text = "Sync",
|
||||||
|
Font = Enum.Font.GothamMedium,
|
||||||
|
TextSize = 17,
|
||||||
|
TextXAlignment = Enum.TextXAlignment.Left,
|
||||||
|
TextColor3 = theme.TextColor,
|
||||||
|
TextTransparency = self.props.transparency,
|
||||||
|
Size = UDim2.new(1, -40, 0, 20),
|
||||||
|
Position = UDim2.new(0, 40, 0, 0),
|
||||||
|
BackgroundTransparency = 1,
|
||||||
|
}),
|
||||||
|
|
||||||
|
Subtitle = e("TextLabel", {
|
||||||
|
Text = DateTime.fromUnixTimestamp(self.props.patchData.timestamp):FormatLocalTime("LTS", "en-us"),
|
||||||
|
TextXAlignment = Enum.TextXAlignment.Left,
|
||||||
|
Font = Enum.Font.Gotham,
|
||||||
|
TextSize = 15,
|
||||||
|
TextColor3 = theme.SubTextColor,
|
||||||
|
TextTruncate = Enum.TextTruncate.AtEnd,
|
||||||
|
TextTransparency = self.props.transparency,
|
||||||
|
Size = UDim2.new(1, -40, 0, 16),
|
||||||
|
Position = UDim2.new(0, 40, 0, 20),
|
||||||
|
BackgroundTransparency = 1,
|
||||||
|
}),
|
||||||
|
|
||||||
|
Info = e("Frame", {
|
||||||
|
BackgroundTransparency = 1,
|
||||||
|
Size = UDim2.new(0, 10, 0, 24),
|
||||||
|
AutomaticSize = Enum.AutomaticSize.X,
|
||||||
|
Position = UDim2.new(1, -5, 0.5, 0),
|
||||||
|
AnchorPoint = Vector2.new(1, 0.5),
|
||||||
|
}, {
|
||||||
|
Tooltip = e(Tooltip.Trigger, {
|
||||||
|
text = `{applied} changes applied`
|
||||||
|
.. (if unapplied > 0 then `, {unapplied} changes failed` else ""),
|
||||||
|
}),
|
||||||
|
Content = e("Frame", {
|
||||||
|
BackgroundTransparency = 1,
|
||||||
|
Size = UDim2.new(0, 0, 1, 0),
|
||||||
|
AutomaticSize = Enum.AutomaticSize.X,
|
||||||
|
}, {
|
||||||
|
Layout = e("UIListLayout", {
|
||||||
|
FillDirection = Enum.FillDirection.Horizontal,
|
||||||
|
HorizontalAlignment = Enum.HorizontalAlignment.Right,
|
||||||
|
VerticalAlignment = Enum.VerticalAlignment.Center,
|
||||||
|
SortOrder = Enum.SortOrder.LayoutOrder,
|
||||||
|
Padding = UDim.new(0, 4),
|
||||||
|
}),
|
||||||
|
|
||||||
|
StatusIcon = e("ImageLabel", {
|
||||||
|
BackgroundTransparency = 1,
|
||||||
|
Image = if unapplied > 0
|
||||||
|
then Assets.Images.Icons.SyncWarning
|
||||||
|
else Assets.Images.Icons.SyncSuccess,
|
||||||
|
ImageColor3 = if unapplied > 0 then theme.Diff.Warning else theme.TextColor,
|
||||||
|
Size = UDim2.new(0, 24, 0, 24),
|
||||||
|
LayoutOrder = 10,
|
||||||
|
}),
|
||||||
|
StatusSpacer = e("Frame", {
|
||||||
|
BackgroundTransparency = 1,
|
||||||
|
Size = UDim2.new(0, 6, 0, 4),
|
||||||
|
LayoutOrder = 9,
|
||||||
|
}),
|
||||||
|
AppliedIcon = e("ImageLabel", {
|
||||||
|
BackgroundTransparency = 1,
|
||||||
|
Image = Assets.Images.Icons.Checkmark,
|
||||||
|
ImageColor3 = theme.TextColor,
|
||||||
|
Size = UDim2.new(0, 16, 0, 16),
|
||||||
|
LayoutOrder = 1,
|
||||||
|
}),
|
||||||
|
AppliedText = e("TextLabel", {
|
||||||
|
Text = applied,
|
||||||
|
Font = Enum.Font.Gotham,
|
||||||
|
TextSize = 15,
|
||||||
|
TextColor3 = theme.TextColor,
|
||||||
|
TextTransparency = self.props.transparency,
|
||||||
|
Size = UDim2.new(0, 0, 1, 0),
|
||||||
|
AutomaticSize = Enum.AutomaticSize.X,
|
||||||
|
BackgroundTransparency = 1,
|
||||||
|
LayoutOrder = 2,
|
||||||
|
}),
|
||||||
|
Warnings = if unapplied > 0
|
||||||
|
then Roact.createFragment({
|
||||||
|
WarningsSpacer = e("Frame", {
|
||||||
|
BackgroundTransparency = 1,
|
||||||
|
Size = UDim2.new(0, 4, 0, 4),
|
||||||
|
LayoutOrder = 3,
|
||||||
|
}),
|
||||||
|
UnappliedIcon = e("ImageLabel", {
|
||||||
|
BackgroundTransparency = 1,
|
||||||
|
Image = Assets.Images.Icons.Exclamation,
|
||||||
|
ImageColor3 = theme.Diff.Warning,
|
||||||
|
Size = UDim2.new(0, 4, 0, 16),
|
||||||
|
LayoutOrder = 4,
|
||||||
|
}),
|
||||||
|
UnappliedText = e("TextLabel", {
|
||||||
|
Text = unapplied,
|
||||||
|
Font = Enum.Font.Gotham,
|
||||||
|
TextSize = 15,
|
||||||
|
TextColor3 = theme.Diff.Warning,
|
||||||
|
TextTransparency = self.props.transparency,
|
||||||
|
Size = UDim2.new(0, 0, 1, 0),
|
||||||
|
AutomaticSize = Enum.AutomaticSize.X,
|
||||||
|
BackgroundTransparency = 1,
|
||||||
|
LayoutOrder = 5,
|
||||||
|
}),
|
||||||
|
})
|
||||||
|
else nil,
|
||||||
|
}),
|
||||||
|
}),
|
||||||
|
|
||||||
|
Divider = e("Frame", {
|
||||||
|
BackgroundColor3 = theme.Settings.DividerColor,
|
||||||
|
BackgroundTransparency = self.props.transparency,
|
||||||
|
Size = UDim2.new(1, 0, 0, 1),
|
||||||
|
Position = UDim2.new(0, 0, 1, 0),
|
||||||
|
BorderSizePixel = 0,
|
||||||
|
}, {
|
||||||
|
Gradient = e("UIGradient", {
|
||||||
|
Transparency = NumberSequence.new({
|
||||||
|
NumberSequenceKeypoint.new(0, 1),
|
||||||
|
NumberSequenceKeypoint.new(0.1, 0),
|
||||||
|
NumberSequenceKeypoint.new(0.9, 0),
|
||||||
|
NumberSequenceKeypoint.new(1, 1),
|
||||||
|
}),
|
||||||
|
}),
|
||||||
}),
|
}),
|
||||||
}),
|
}),
|
||||||
|
|
||||||
PatchVisualizer = e(PatchVisualizer, {
|
Patch = e(PatchVisualizer, {
|
||||||
size = UDim2.new(1, 0, 1, 0),
|
size = UDim2.new(1, -10, 1, -65),
|
||||||
|
position = UDim2.new(0, 5, 1, -5),
|
||||||
|
anchorPoint = Vector2.new(0, 1),
|
||||||
transparency = self.props.transparency,
|
transparency = self.props.transparency,
|
||||||
layoutOrder = 3,
|
layoutOrder = self.props.layoutOrder,
|
||||||
|
|
||||||
patchTree = self.props.patchTree,
|
patchTree = self.props.patchTree,
|
||||||
|
|
||||||
@@ -167,20 +287,7 @@ function ConnectedPage:getChangeInfoText()
|
|||||||
if patchData == nil then
|
if patchData == nil then
|
||||||
return ""
|
return ""
|
||||||
end
|
end
|
||||||
|
return timeSinceText(DateTime.now().UnixTimestamp - patchData.timestamp)
|
||||||
local elapsed = os.time() - patchData.timestamp
|
|
||||||
local unapplied = PatchSet.countChanges(patchData.unapplied)
|
|
||||||
|
|
||||||
return "<i>Synced "
|
|
||||||
.. timeSinceText(elapsed)
|
|
||||||
.. (if unapplied > 0
|
|
||||||
then string.format(
|
|
||||||
', <font color="#FF8E3C">but %d change%s failed to apply</font>',
|
|
||||||
unapplied,
|
|
||||||
unapplied == 1 and "" or "s"
|
|
||||||
)
|
|
||||||
else "")
|
|
||||||
.. "</i>"
|
|
||||||
end
|
end
|
||||||
|
|
||||||
function ConnectedPage:startChangeInfoTextUpdater()
|
function ConnectedPage:startChangeInfoTextUpdater()
|
||||||
@@ -190,13 +297,9 @@ function ConnectedPage:startChangeInfoTextUpdater()
|
|||||||
-- Start a new updater
|
-- Start a new updater
|
||||||
self.changeInfoTextUpdater = task.defer(function()
|
self.changeInfoTextUpdater = task.defer(function()
|
||||||
while true do
|
while true do
|
||||||
if self.state.hoveringChangeInfo then
|
self.setChangeInfoText(self:getChangeInfoText())
|
||||||
self.setChangeInfoText("<u>" .. self:getChangeInfoText() .. "</u>")
|
|
||||||
else
|
|
||||||
self.setChangeInfoText(self:getChangeInfoText())
|
|
||||||
end
|
|
||||||
|
|
||||||
local elapsed = os.time() - self.props.patchData.timestamp
|
local elapsed = DateTime.now().UnixTimestamp - self.props.patchData.timestamp
|
||||||
local updateInterval = 1
|
local updateInterval = 1
|
||||||
|
|
||||||
-- Update timestamp text as frequently as currently needed
|
-- Update timestamp text as frequently as currently needed
|
||||||
@@ -221,23 +324,6 @@ function ConnectedPage:stopChangeInfoTextUpdater()
|
|||||||
end
|
end
|
||||||
|
|
||||||
function ConnectedPage:init()
|
function ConnectedPage:init()
|
||||||
self.changeDrawerMotor = Flipper.SingleMotor.new(0)
|
|
||||||
self.changeDrawerHeight = bindingUtil.fromMotor(self.changeDrawerMotor)
|
|
||||||
|
|
||||||
self.changeDrawerMotor:onStep(function(value)
|
|
||||||
local renderChanges = value > 0.05
|
|
||||||
|
|
||||||
self:setState(function(state)
|
|
||||||
if state.renderChanges == renderChanges then
|
|
||||||
return nil
|
|
||||||
end
|
|
||||||
|
|
||||||
return {
|
|
||||||
renderChanges = renderChanges,
|
|
||||||
}
|
|
||||||
end)
|
|
||||||
end)
|
|
||||||
|
|
||||||
self:setState({
|
self:setState({
|
||||||
renderChanges = false,
|
renderChanges = false,
|
||||||
hoveringChangeInfo = false,
|
hoveringChangeInfo = false,
|
||||||
@@ -266,6 +352,10 @@ function ConnectedPage:didUpdate(previousProps)
|
|||||||
end
|
end
|
||||||
|
|
||||||
function ConnectedPage:render()
|
function ConnectedPage:render()
|
||||||
|
local syncWarning = self.props.patchData
|
||||||
|
and self.props.patchData.unapplied
|
||||||
|
and PatchSet.countChanges(self.props.patchData.unapplied) > 0
|
||||||
|
|
||||||
return Theme.with(function(theme)
|
return Theme.with(function(theme)
|
||||||
return Roact.createFragment({
|
return Roact.createFragment({
|
||||||
Padding = e("UIPadding", {
|
Padding = e("UIPadding", {
|
||||||
@@ -280,9 +370,88 @@ function ConnectedPage:render()
|
|||||||
Padding = UDim.new(0, 10),
|
Padding = UDim.new(0, 10),
|
||||||
}),
|
}),
|
||||||
|
|
||||||
Header = e(Header, {
|
Heading = e("Frame", {
|
||||||
transparency = self.props.transparency,
|
BackgroundTransparency = 1,
|
||||||
layoutOrder = 1,
|
Size = UDim2.new(1, 0, 0, 32),
|
||||||
|
}, {
|
||||||
|
Header = e(Header, {
|
||||||
|
transparency = self.props.transparency,
|
||||||
|
}),
|
||||||
|
|
||||||
|
ChangeInfo = e("TextButton", {
|
||||||
|
Text = "",
|
||||||
|
Size = UDim2.new(0, 0, 1, 0),
|
||||||
|
AutomaticSize = Enum.AutomaticSize.X,
|
||||||
|
BackgroundColor3 = theme.BorderedContainer.BorderedColor,
|
||||||
|
BackgroundTransparency = if self.state.hoveringChangeInfo then 0.7 else 1,
|
||||||
|
BorderSizePixel = 0,
|
||||||
|
Position = UDim2.new(1, -5, 0.5, 0),
|
||||||
|
AnchorPoint = Vector2.new(1, 0.5),
|
||||||
|
[Roact.Event.MouseEnter] = function()
|
||||||
|
self:setState({
|
||||||
|
hoveringChangeInfo = true,
|
||||||
|
})
|
||||||
|
end,
|
||||||
|
[Roact.Event.MouseLeave] = function()
|
||||||
|
self:setState({
|
||||||
|
hoveringChangeInfo = false,
|
||||||
|
})
|
||||||
|
end,
|
||||||
|
[Roact.Event.Activated] = function()
|
||||||
|
self:setState(function(prevState)
|
||||||
|
prevState = prevState or {}
|
||||||
|
return {
|
||||||
|
renderChanges = not prevState.renderChanges,
|
||||||
|
}
|
||||||
|
end)
|
||||||
|
end,
|
||||||
|
}, {
|
||||||
|
Corner = e("UICorner", {
|
||||||
|
CornerRadius = UDim.new(0, 5),
|
||||||
|
}),
|
||||||
|
Tooltip = e(Tooltip.Trigger, {
|
||||||
|
text = if self.state.renderChanges then "Hide changes" else "View changes",
|
||||||
|
}),
|
||||||
|
Content = e("Frame", {
|
||||||
|
BackgroundTransparency = 1,
|
||||||
|
Size = UDim2.new(0, 0, 1, 0),
|
||||||
|
AutomaticSize = Enum.AutomaticSize.X,
|
||||||
|
}, {
|
||||||
|
Layout = e("UIListLayout", {
|
||||||
|
FillDirection = Enum.FillDirection.Horizontal,
|
||||||
|
HorizontalAlignment = Enum.HorizontalAlignment.Center,
|
||||||
|
VerticalAlignment = Enum.VerticalAlignment.Center,
|
||||||
|
SortOrder = Enum.SortOrder.LayoutOrder,
|
||||||
|
Padding = UDim.new(0, 5),
|
||||||
|
}),
|
||||||
|
Padding = e("UIPadding", {
|
||||||
|
PaddingLeft = UDim.new(0, 5),
|
||||||
|
PaddingRight = UDim.new(0, 5),
|
||||||
|
}),
|
||||||
|
Text = e("TextLabel", {
|
||||||
|
BackgroundTransparency = 1,
|
||||||
|
Text = self.changeInfoText,
|
||||||
|
Font = Enum.Font.Gotham,
|
||||||
|
TextSize = 15,
|
||||||
|
TextColor3 = if syncWarning then theme.Diff.Warning else theme.Header.VersionColor,
|
||||||
|
TextTransparency = self.props.transparency,
|
||||||
|
TextXAlignment = Enum.TextXAlignment.Right,
|
||||||
|
Size = UDim2.new(0, 0, 1, 0),
|
||||||
|
AutomaticSize = Enum.AutomaticSize.X,
|
||||||
|
LayoutOrder = 1,
|
||||||
|
}),
|
||||||
|
Icon = e("ImageLabel", {
|
||||||
|
BackgroundTransparency = 1,
|
||||||
|
Image = if syncWarning
|
||||||
|
then Assets.Images.Icons.SyncWarning
|
||||||
|
else Assets.Images.Icons.SyncSuccess,
|
||||||
|
ImageColor3 = if syncWarning then theme.Diff.Warning else theme.Header.VersionColor,
|
||||||
|
ImageTransparency = self.props.transparency,
|
||||||
|
Size = UDim2.new(0, 24, 0, 24),
|
||||||
|
LayoutOrder = 2,
|
||||||
|
}),
|
||||||
|
}),
|
||||||
|
}),
|
||||||
}),
|
}),
|
||||||
|
|
||||||
ConnectionDetails = e(ConnectionDetails, {
|
ConnectionDetails = e(ConnectionDetails, {
|
||||||
@@ -332,84 +501,59 @@ function ConnectedPage:render()
|
|||||||
}),
|
}),
|
||||||
}),
|
}),
|
||||||
|
|
||||||
ChangeInfo = e("TextButton", {
|
ChangesViewer = e(StudioPluginGui, {
|
||||||
Text = self.changeInfoText,
|
id = "Rojo_ChangesViewer",
|
||||||
Font = Enum.Font.Gotham,
|
title = "View changes",
|
||||||
TextSize = 14,
|
active = self.state.renderChanges,
|
||||||
TextWrapped = true,
|
isEphemeral = true,
|
||||||
RichText = true,
|
|
||||||
TextColor3 = theme.Header.VersionColor,
|
|
||||||
TextXAlignment = Enum.TextXAlignment.Left,
|
|
||||||
TextYAlignment = Enum.TextYAlignment.Top,
|
|
||||||
TextTransparency = self.props.transparency,
|
|
||||||
|
|
||||||
Size = UDim2.new(1, 0, 0, 28),
|
initDockState = Enum.InitialDockState.Float,
|
||||||
|
overridePreviousState = true,
|
||||||
|
floatingSize = Vector2.new(400, 500),
|
||||||
|
minimumSize = Vector2.new(300, 300),
|
||||||
|
|
||||||
LayoutOrder = 4,
|
zIndexBehavior = Enum.ZIndexBehavior.Sibling,
|
||||||
BackgroundTransparency = 1,
|
|
||||||
|
|
||||||
[Roact.Event.MouseEnter] = function()
|
|
||||||
self:setState({
|
|
||||||
hoveringChangeInfo = true,
|
|
||||||
})
|
|
||||||
self.setChangeInfoText("<u>" .. self:getChangeInfoText() .. "</u>")
|
|
||||||
end,
|
|
||||||
|
|
||||||
[Roact.Event.MouseLeave] = function()
|
|
||||||
self:setState({
|
|
||||||
hoveringChangeInfo = false,
|
|
||||||
})
|
|
||||||
self.setChangeInfoText(self:getChangeInfoText())
|
|
||||||
end,
|
|
||||||
|
|
||||||
[Roact.Event.Activated] = function()
|
|
||||||
if self.state.renderChanges then
|
|
||||||
self.changeDrawerMotor:setGoal(Flipper.Spring.new(0, {
|
|
||||||
frequency = 4,
|
|
||||||
dampingRatio = 1,
|
|
||||||
}))
|
|
||||||
else
|
|
||||||
self.changeDrawerMotor:setGoal(Flipper.Spring.new(1, {
|
|
||||||
frequency = 3,
|
|
||||||
dampingRatio = 1,
|
|
||||||
}))
|
|
||||||
end
|
|
||||||
end,
|
|
||||||
}, {
|
|
||||||
Tooltip = e(Tooltip.Trigger, {
|
|
||||||
text = if self.state.renderChanges then "Hide the changes" else "View the changes",
|
|
||||||
}),
|
|
||||||
}),
|
|
||||||
|
|
||||||
ChangesDrawer = e(ChangesDrawer, {
|
|
||||||
rendered = self.state.renderChanges,
|
|
||||||
transparency = self.props.transparency,
|
|
||||||
patchTree = self.props.patchTree,
|
|
||||||
serveSession = self.props.serveSession,
|
|
||||||
height = self.changeDrawerHeight,
|
|
||||||
layoutOrder = 5,
|
|
||||||
|
|
||||||
showStringDiff = function(oldString: string, newString: string)
|
|
||||||
self:setState({
|
|
||||||
showingStringDiff = true,
|
|
||||||
oldString = oldString,
|
|
||||||
newString = newString,
|
|
||||||
})
|
|
||||||
end,
|
|
||||||
showTableDiff = function(oldTable: { [any]: any? }, newTable: { [any]: any? })
|
|
||||||
self:setState({
|
|
||||||
showingTableDiff = true,
|
|
||||||
oldTable = oldTable,
|
|
||||||
newTable = newTable,
|
|
||||||
})
|
|
||||||
end,
|
|
||||||
|
|
||||||
onClose = function()
|
onClose = function()
|
||||||
self.changeDrawerMotor:setGoal(Flipper.Spring.new(0, {
|
self:setState({
|
||||||
frequency = 4,
|
renderChanges = false,
|
||||||
dampingRatio = 1,
|
})
|
||||||
}))
|
|
||||||
end,
|
end,
|
||||||
|
}, {
|
||||||
|
TooltipsProvider = e(Tooltip.Provider, nil, {
|
||||||
|
Tooltips = e(Tooltip.Container, nil),
|
||||||
|
Content = e("Frame", {
|
||||||
|
Size = UDim2.fromScale(1, 1),
|
||||||
|
BackgroundTransparency = 1,
|
||||||
|
}, {
|
||||||
|
Changes = e(ChangesViewer, {
|
||||||
|
transparency = self.props.transparency,
|
||||||
|
rendered = self.state.renderChanges,
|
||||||
|
patchData = self.props.patchData,
|
||||||
|
patchTree = self.props.patchTree,
|
||||||
|
serveSession = self.props.serveSession,
|
||||||
|
showStringDiff = function(oldString: string, newString: string)
|
||||||
|
self:setState({
|
||||||
|
showingStringDiff = true,
|
||||||
|
oldString = oldString,
|
||||||
|
newString = newString,
|
||||||
|
})
|
||||||
|
end,
|
||||||
|
showTableDiff = function(oldTable: { [any]: any? }, newTable: { [any]: any? })
|
||||||
|
self:setState({
|
||||||
|
showingTableDiff = true,
|
||||||
|
oldTable = oldTable,
|
||||||
|
newTable = newTable,
|
||||||
|
})
|
||||||
|
end,
|
||||||
|
onBack = function()
|
||||||
|
self:setState({
|
||||||
|
renderChanges = false,
|
||||||
|
})
|
||||||
|
end,
|
||||||
|
}),
|
||||||
|
}),
|
||||||
|
}),
|
||||||
}),
|
}),
|
||||||
|
|
||||||
StringDiff = e(StudioPluginGui, {
|
StringDiff = e(StudioPluginGui, {
|
||||||
|
|||||||
@@ -32,9 +32,12 @@ local StudioProvider = Roact.Component:extend("StudioProvider")
|
|||||||
function StudioProvider:updateTheme()
|
function StudioProvider:updateTheme()
|
||||||
local studioTheme = getStudio().Theme
|
local studioTheme = getStudio().Theme
|
||||||
|
|
||||||
|
local isDark = studioTheme.Name == "Dark"
|
||||||
|
|
||||||
local theme = strict(studioTheme.Name .. "Theme", {
|
local theme = strict(studioTheme.Name .. "Theme", {
|
||||||
BackgroundColor = studioTheme:GetColor(Enum.StudioStyleGuideColor.MainBackground),
|
BackgroundColor = studioTheme:GetColor(Enum.StudioStyleGuideColor.MainBackground),
|
||||||
TextColor = studioTheme:GetColor(Enum.StudioStyleGuideColor.MainText),
|
TextColor = studioTheme:GetColor(Enum.StudioStyleGuideColor.MainText),
|
||||||
|
SubTextColor = studioTheme:GetColor(Enum.StudioStyleGuideColor.SubText),
|
||||||
Button = {
|
Button = {
|
||||||
Solid = {
|
Solid = {
|
||||||
-- Solid uses brand theming, not Studio theming.
|
-- Solid uses brand theming, not Studio theming.
|
||||||
@@ -139,9 +142,10 @@ function StudioProvider:updateTheme()
|
|||||||
BackgroundColor = studioTheme:GetColor(Enum.StudioStyleGuideColor.InputFieldBackground),
|
BackgroundColor = studioTheme:GetColor(Enum.StudioStyleGuideColor.InputFieldBackground),
|
||||||
},
|
},
|
||||||
Diff = {
|
Diff = {
|
||||||
Add = studioTheme:GetColor(Enum.StudioStyleGuideColor.DiffTextAdditionBackground),
|
-- Studio doesn't have good colors since their diffs use backgrounds, not text
|
||||||
Remove = studioTheme:GetColor(Enum.StudioStyleGuideColor.DiffTextDeletionBackground),
|
Add = if isDark then Color3.fromRGB(143, 227, 154) else Color3.fromRGB(41, 164, 45),
|
||||||
Edit = studioTheme:GetColor(Enum.StudioStyleGuideColor.DiffLineNumSeparatorBackground),
|
Remove = if isDark then Color3.fromRGB(242, 125, 125) else Color3.fromRGB(150, 29, 29),
|
||||||
|
Edit = if isDark then Color3.fromRGB(120, 154, 248) else Color3.fromRGB(0, 70, 160),
|
||||||
Row = studioTheme:GetColor(Enum.StudioStyleGuideColor.BrightText),
|
Row = studioTheme:GetColor(Enum.StudioStyleGuideColor.BrightText),
|
||||||
Warning = studioTheme:GetColor(Enum.StudioStyleGuideColor.WarningText),
|
Warning = studioTheme:GetColor(Enum.StudioStyleGuideColor.WarningText),
|
||||||
},
|
},
|
||||||
|
|||||||
@@ -457,7 +457,7 @@ function App:startSession()
|
|||||||
end)
|
end)
|
||||||
|
|
||||||
serveSession:hookPostcommit(function(patch, _instanceMap, unapplied)
|
serveSession:hookPostcommit(function(patch, _instanceMap, unapplied)
|
||||||
local now = os.time()
|
local now = DateTime.now().UnixTimestamp
|
||||||
local old = self.state.patchData
|
local old = self.state.patchData
|
||||||
|
|
||||||
if PatchSet.isEmpty(patch) then
|
if PatchSet.isEmpty(patch) then
|
||||||
|
|||||||
@@ -25,6 +25,10 @@ local Assets = {
|
|||||||
Back = "rbxassetid://6017213752",
|
Back = "rbxassetid://6017213752",
|
||||||
Reset = "rbxassetid://10142422327",
|
Reset = "rbxassetid://10142422327",
|
||||||
Expand = "rbxassetid://12045401097",
|
Expand = "rbxassetid://12045401097",
|
||||||
|
Checkmark = "rbxassetid://16571012729",
|
||||||
|
Exclamation = "rbxassetid://16571172190",
|
||||||
|
SyncSuccess = "rbxassetid://16565035221",
|
||||||
|
SyncWarning = "rbxassetid://16565325171",
|
||||||
},
|
},
|
||||||
Diff = {
|
Diff = {
|
||||||
Add = "rbxassetid://10434145835",
|
Add = "rbxassetid://10434145835",
|
||||||
|
|||||||
@@ -211,9 +211,11 @@ end
|
|||||||
function PatchSet.countChanges(patch)
|
function PatchSet.countChanges(patch)
|
||||||
local count = 0
|
local count = 0
|
||||||
|
|
||||||
for _ in patch.added do
|
for _, add in patch.added do
|
||||||
-- Adding an instance is 1 change
|
-- Adding an instance is 1 change per property
|
||||||
count += 1
|
for _ in add.Properties do
|
||||||
|
count += 1
|
||||||
|
end
|
||||||
end
|
end
|
||||||
for _ in patch.removed do
|
for _ in patch.removed do
|
||||||
-- Removing an instance is 1 change
|
-- Removing an instance is 1 change
|
||||||
|
|||||||
@@ -79,6 +79,15 @@ function Tree.new()
|
|||||||
return setmetatable(tree, Tree)
|
return setmetatable(tree, Tree)
|
||||||
end
|
end
|
||||||
|
|
||||||
|
-- Iterates over all nodes and counts them up
|
||||||
|
function Tree:getCount()
|
||||||
|
local count = 0
|
||||||
|
self:forEach(function()
|
||||||
|
count += 1
|
||||||
|
end)
|
||||||
|
return count
|
||||||
|
end
|
||||||
|
|
||||||
-- Iterates over all sub-nodes, depth first
|
-- Iterates over all sub-nodes, depth first
|
||||||
-- node is where to start from, defaults to root
|
-- node is where to start from, defaults to root
|
||||||
-- depth is used for recursion but can be used to set the starting depth
|
-- depth is used for recursion but can be used to set the starting depth
|
||||||
@@ -219,42 +228,14 @@ function PatchTree.build(patch, instanceMap, changeListHeaders)
|
|||||||
tree:buildAncestryNodes(previousId, ancestryIds, patch, instanceMap)
|
tree:buildAncestryNodes(previousId, ancestryIds, patch, instanceMap)
|
||||||
|
|
||||||
-- Gather detail text
|
-- Gather detail text
|
||||||
local changeList, hint = nil, nil
|
local changeList, changeInfo = nil, nil
|
||||||
if next(change.changedProperties) or change.changedName then
|
if next(change.changedProperties) or change.changedName then
|
||||||
changeList = {}
|
changeList = {}
|
||||||
|
|
||||||
local hintBuffer, hintBufferSize, hintOverflow = table.create(3), 0, 0
|
|
||||||
local changeIndex = 0
|
local changeIndex = 0
|
||||||
local function addProp(prop: string, current: any?, incoming: any?, metadata: any?)
|
local function addProp(prop: string, current: any?, incoming: any?, metadata: any?)
|
||||||
changeIndex += 1
|
changeIndex += 1
|
||||||
changeList[changeIndex] = { prop, current, incoming, metadata }
|
changeList[changeIndex] = { prop, current, incoming, metadata }
|
||||||
|
|
||||||
if hintBufferSize < 3 then
|
|
||||||
hintBufferSize += 1
|
|
||||||
hintBuffer[hintBufferSize] = prop
|
|
||||||
return
|
|
||||||
end
|
|
||||||
|
|
||||||
-- We only want to have 3 hints
|
|
||||||
-- to keep it deterministic, we sort them alphabetically
|
|
||||||
|
|
||||||
-- Either this prop overflows, or it makes another one move to overflow
|
|
||||||
hintOverflow += 1
|
|
||||||
|
|
||||||
-- Shortcut for the common case
|
|
||||||
if hintBuffer[3] <= prop then
|
|
||||||
-- This prop is below the last hint, no need to insert
|
|
||||||
return
|
|
||||||
end
|
|
||||||
|
|
||||||
-- Find the first available spot
|
|
||||||
for i, hintItem in hintBuffer do
|
|
||||||
if prop < hintItem then
|
|
||||||
-- This prop is before the currently selected hint,
|
|
||||||
-- so take its place and then continue to find a spot for the old hint
|
|
||||||
hintBuffer[i], prop = prop, hintBuffer[i]
|
|
||||||
end
|
|
||||||
end
|
|
||||||
end
|
end
|
||||||
|
|
||||||
-- Gather the changes
|
-- Gather the changes
|
||||||
@@ -274,8 +255,9 @@ function PatchTree.build(patch, instanceMap, changeListHeaders)
|
|||||||
)
|
)
|
||||||
end
|
end
|
||||||
|
|
||||||
-- Finalize detail values
|
changeInfo = {
|
||||||
hint = table.concat(hintBuffer, ", ") .. (if hintOverflow == 0 then "" else ", " .. hintOverflow .. " more")
|
edits = changeIndex,
|
||||||
|
}
|
||||||
|
|
||||||
-- Sort changes and add header
|
-- Sort changes and add header
|
||||||
table.sort(changeList, function(a, b)
|
table.sort(changeList, function(a, b)
|
||||||
@@ -291,7 +273,7 @@ function PatchTree.build(patch, instanceMap, changeListHeaders)
|
|||||||
className = instance.ClassName,
|
className = instance.ClassName,
|
||||||
name = instance.Name,
|
name = instance.Name,
|
||||||
instance = instance,
|
instance = instance,
|
||||||
hint = hint,
|
changeInfo = changeInfo,
|
||||||
changeList = changeList,
|
changeList = changeList,
|
||||||
})
|
})
|
||||||
end
|
end
|
||||||
@@ -376,42 +358,14 @@ function PatchTree.build(patch, instanceMap, changeListHeaders)
|
|||||||
tree:buildAncestryNodes(previousId, ancestryIds, patch, instanceMap)
|
tree:buildAncestryNodes(previousId, ancestryIds, patch, instanceMap)
|
||||||
|
|
||||||
-- Gather detail text
|
-- Gather detail text
|
||||||
local changeList, hint = nil, nil
|
local changeList, changeInfo = nil, nil
|
||||||
if next(change.Properties) then
|
if next(change.Properties) then
|
||||||
changeList = {}
|
changeList = {}
|
||||||
|
|
||||||
local hintBuffer, hintBufferSize, hintOverflow = table.create(3), 0, 0
|
|
||||||
local changeIndex = 0
|
local changeIndex = 0
|
||||||
local function addProp(prop: string, incoming: any)
|
local function addProp(prop: string, incoming: any)
|
||||||
changeIndex += 1
|
changeIndex += 1
|
||||||
changeList[changeIndex] = { prop, "N/A", incoming }
|
changeList[changeIndex] = { prop, "N/A", incoming }
|
||||||
|
|
||||||
if hintBufferSize < 3 then
|
|
||||||
hintBufferSize += 1
|
|
||||||
hintBuffer[hintBufferSize] = prop
|
|
||||||
return
|
|
||||||
end
|
|
||||||
|
|
||||||
-- We only want to have 3 hints
|
|
||||||
-- to keep it deterministic, we sort them alphabetically
|
|
||||||
|
|
||||||
-- Either this prop overflows, or it makes another one move to overflow
|
|
||||||
hintOverflow += 1
|
|
||||||
|
|
||||||
-- Shortcut for the common case
|
|
||||||
if hintBuffer[3] <= prop then
|
|
||||||
-- This prop is below the last hint, no need to insert
|
|
||||||
return
|
|
||||||
end
|
|
||||||
|
|
||||||
-- Find the first available spot
|
|
||||||
for i, hintItem in hintBuffer do
|
|
||||||
if prop < hintItem then
|
|
||||||
-- This prop is before the currently selected hint,
|
|
||||||
-- so take its place and then continue to find a spot for the old hint
|
|
||||||
hintBuffer[i], prop = prop, hintBuffer[i]
|
|
||||||
end
|
|
||||||
end
|
|
||||||
end
|
end
|
||||||
|
|
||||||
for prop, incoming in change.Properties do
|
for prop, incoming in change.Properties do
|
||||||
@@ -419,8 +373,9 @@ function PatchTree.build(patch, instanceMap, changeListHeaders)
|
|||||||
addProp(prop, if success then incomingValue else select(2, next(incoming)))
|
addProp(prop, if success then incomingValue else select(2, next(incoming)))
|
||||||
end
|
end
|
||||||
|
|
||||||
-- Finalize detail values
|
changeInfo = {
|
||||||
hint = table.concat(hintBuffer, ", ") .. (if hintOverflow == 0 then "" else ", " .. hintOverflow .. " more")
|
edits = changeIndex,
|
||||||
|
}
|
||||||
|
|
||||||
-- Sort changes and add header
|
-- Sort changes and add header
|
||||||
table.sort(changeList, function(a, b)
|
table.sort(changeList, function(a, b)
|
||||||
@@ -435,7 +390,7 @@ function PatchTree.build(patch, instanceMap, changeListHeaders)
|
|||||||
patchType = "Add",
|
patchType = "Add",
|
||||||
className = change.ClassName,
|
className = change.ClassName,
|
||||||
name = change.Name,
|
name = change.Name,
|
||||||
hint = hint,
|
changeInfo = changeInfo,
|
||||||
changeList = changeList,
|
changeList = changeList,
|
||||||
instance = instanceMap.fromIds[id],
|
instance = instanceMap.fromIds[id],
|
||||||
})
|
})
|
||||||
@@ -473,6 +428,8 @@ function PatchTree.updateMetadata(tree, patch, instanceMap, unappliedPatch)
|
|||||||
if not node.changeList then
|
if not node.changeList then
|
||||||
continue
|
continue
|
||||||
end
|
end
|
||||||
|
|
||||||
|
local warnings = 0
|
||||||
for _, change in node.changeList do
|
for _, change in node.changeList do
|
||||||
local property = change[1]
|
local property = change[1]
|
||||||
local propertyFailedToApply = if property == "Name"
|
local propertyFailedToApply = if property == "Name"
|
||||||
@@ -483,6 +440,8 @@ function PatchTree.updateMetadata(tree, patch, instanceMap, unappliedPatch)
|
|||||||
-- This change didn't fail, no need to mark
|
-- This change didn't fail, no need to mark
|
||||||
continue
|
continue
|
||||||
end
|
end
|
||||||
|
|
||||||
|
warnings += 1
|
||||||
if change[4] == nil then
|
if change[4] == nil then
|
||||||
change[4] = { isWarning = true }
|
change[4] = { isWarning = true }
|
||||||
else
|
else
|
||||||
@@ -490,6 +449,11 @@ function PatchTree.updateMetadata(tree, patch, instanceMap, unappliedPatch)
|
|||||||
end
|
end
|
||||||
Log.trace(" Marked property as warning: {}.{}", node.name, property)
|
Log.trace(" Marked property as warning: {}.{}", node.name, property)
|
||||||
end
|
end
|
||||||
|
|
||||||
|
node.changeInfo = {
|
||||||
|
edits = (node.changeInfo.edits or (#node.changeList - 1)) - warnings,
|
||||||
|
failed = if warnings > 0 then warnings else nil,
|
||||||
|
}
|
||||||
end
|
end
|
||||||
for failedAdditionId in unappliedPatch.added do
|
for failedAdditionId in unappliedPatch.added do
|
||||||
local node = tree:getNode(failedAdditionId)
|
local node = tree:getNode(failedAdditionId)
|
||||||
@@ -503,6 +467,7 @@ function PatchTree.updateMetadata(tree, patch, instanceMap, unappliedPatch)
|
|||||||
if not node.changeList then
|
if not node.changeList then
|
||||||
continue
|
continue
|
||||||
end
|
end
|
||||||
|
|
||||||
for _, change in node.changeList do
|
for _, change in node.changeList do
|
||||||
-- Failed addition means that all properties failed to be added
|
-- Failed addition means that all properties failed to be added
|
||||||
if change[4] == nil then
|
if change[4] == nil then
|
||||||
@@ -512,6 +477,10 @@ function PatchTree.updateMetadata(tree, patch, instanceMap, unappliedPatch)
|
|||||||
end
|
end
|
||||||
Log.trace(" Marked property as warning: {}.{}", node.name, change[1])
|
Log.trace(" Marked property as warning: {}.{}", node.name, change[1])
|
||||||
end
|
end
|
||||||
|
|
||||||
|
node.changeInfo = {
|
||||||
|
failed = node.changeInfo.edits or (#node.changeList - 1),
|
||||||
|
}
|
||||||
end
|
end
|
||||||
for _, failedRemovalIdOrInstance in unappliedPatch.removed do
|
for _, failedRemovalIdOrInstance in unappliedPatch.removed do
|
||||||
local failedRemovalId = if Types.RbxId(failedRemovalIdOrInstance)
|
local failedRemovalId = if Types.RbxId(failedRemovalIdOrInstance)
|
||||||
|
|||||||
Reference in New Issue
Block a user