rojo-rbx/rojo
1
0
Fork 1
mirror of https://github.com/rojo-rbx/rojo.git synced 2026-04-25 07:06:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix request timeout in long polling causing error to bubble to console

Browse Source
This commit is contained in:
Lucien Greathouse
2019-11-15 15:54:58 -08:00
parent 2493c70241
commit af866f0665
1 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
plugin/src/ApiContext.lua
View File

@@ -9,6 +9,13 @@ local validateApiInfo = Types.ifEnabled(Types.ApiInfoResponse)
local validateApiRead = Types.ifEnabled(Types.ApiReadResponse) local validateApiRead = Types.ifEnabled(Types.ApiReadResponse)
local validateApiSubscribe = Types.ifEnabled(Types.ApiSubscribeResponse) local validateApiSubscribe = Types.ifEnabled(Types.ApiSubscribeResponse)
--[[
Returns a promise that will never resolve nor reject.
]]
local function hangingPromise()
return Promise.new(function() end)
end
local function rejectFailedRequests(response) local function rejectFailedRequests(response)
if response.code >= 400 then if response.code >= 400 then
-- TODO: Nicer error types for responses, using response JSON if valid. -- TODO: Nicer error types for responses, using response JSON if valid.
@@ -139,8 +146,12 @@ function ApiContext:retrieveMessages()
local function sendRequest() local function sendRequest()
return Http.get(url) return Http.get(url)
:catch(function(err) :catch(function(err)
if err.type == Http.Error.Kind.Timeout and self.__connected then if err.type == Http.Error.Kind.Timeout then
return sendRequest() if self.__connected then
return sendRequest()
else
return hangingPromise()
end
end end
return Promise.reject(err) return Promise.reject(err)