From a587ba45589de88c061a6bf9cee70265948760eb Mon Sep 17 00:00:00 2001 From: Lucien Greathouse Date: Thu, 30 May 2019 23:57:35 -0700 Subject: [PATCH] Add warning for rojo build to rbxl --- CHANGELOG.md | 1 + server/src/commands/build.rs | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3ec32f81..33245fa2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,7 @@ # Rojo Changelog ## [Unreleased] +* Added a warning when building binary place files, since they're still experimental. ## [0.5.0 Alpha 11](https://github.com/LPGhatguy/rojo/releases/tag/v0.5.0-alpha.11) (May 29, 2019) * Added support for implicit property values in JSON model files ([#154](https://github.com/LPGhatguy/rojo/pull/154)) diff --git a/server/src/commands/build.rs b/server/src/commands/build.rs index 716ed717..ab353662 100644 --- a/server/src/commands/build.rs +++ b/server/src/commands/build.rs @@ -120,6 +120,10 @@ pub fn build(options: &BuildOptions) -> Result<(), BuildError> { rbx_binary::encode(&tree, &[root_id], &mut file)?; }, OutputKind::Rbxl => { + log::warn!("Support for building binary places (rbxl) is still experimental."); + log::warn!("Using the XML place format (rbxlx) is recommended instead."); + log::warn!("For more info, see https://github.com/LPGhatguy/rojo/issues/180"); + let root_id = tree.get_root_id(); let top_level_ids = tree.get_instance(root_id).unwrap().get_children_ids(); rbx_binary::encode(&tree, top_level_ids, &mut file)?;