Upgrade to rbx_dom_weak 2.0 (#377)

* Mostly mechanical port bits

* Almost there

* It builds again!

* Turn on all the code again

* Tests compiling but not passing

* Stub work for value resolution

* Implement resolution minus enums and derived properties

* Implement property descriptor resolution

* Update referent snapshots

* Update unions test project

Using a place file instead of a model yields better
error messages in Roblox Studio.

* Add easy shortcut to testing with local rbx-dom

* Update rbx-dom

* Add enum resolution

* Update init.meta.json to use UnresolvedValue

* Expand value resolution support, add test

* Filter SharedString values from web API

* Add 'property' builder method to InstanceSnapshot

* Change InstanceSnapshot/InstanceBuilder boundary

* Fix remove_file crash

* rustfmt

* Update to latest rbx_dom_lua

* Update dependencies, including rbx_dom_weak

* Update to latest rbx-dom

* Update dependencies

* Update rbx-dom, fixing more bugs

* Remove experimental warning on binary place builds

* Remove unused imports

src/snapshot/patch_compute.rs

@@ -3,14 +3,14 @@
 
 use std::collections::{HashMap, HashSet};
 
-use rbx_dom_weak::{RbxId, RbxValue};
+use rbx_dom_weak::types::{Ref, Variant};
 
 use super::{
     patch::{PatchAdd, PatchSet, PatchUpdate},
     InstanceSnapshot, InstanceWithMeta, RojoTree,
 };
 
-pub fn compute_patch_set(snapshot: &InstanceSnapshot, tree: &RojoTree, id: RbxId) -> PatchSet {
+pub fn compute_patch_set(snapshot: &InstanceSnapshot, tree: &RojoTree, id: Ref) -> PatchSet {
     let mut patch_set = PatchSet::new();
     let mut context = ComputePatchContext::default();
 
@@ -26,17 +26,15 @@ pub fn compute_patch_set(snapshot: &InstanceSnapshot, tree: &RojoTree, id: RbxId
 
 #[derive(Default)]
 struct ComputePatchContext {
-    snapshot_id_to_instance_id: HashMap<RbxId, RbxId>,
+    snapshot_id_to_instance_id: HashMap<Ref, Ref>,
 }
 
 fn rewrite_refs_in_updates(context: &ComputePatchContext, updates: &mut [PatchUpdate]) {
     for update in updates {
         for property_value in update.changed_properties.values_mut() {
-            if let Some(RbxValue::Ref { value: Some(id) }) = property_value {
-                if let Some(&instance_id) = context.snapshot_id_to_instance_id.get(id) {
-                    *property_value = Some(RbxValue::Ref {
-                        value: Some(instance_id),
-                    });
+            if let Some(Variant::Ref(referent)) = property_value {
+                if let Some(&instance_ref) = context.snapshot_id_to_instance_id.get(referent) {
+                    *property_value = Some(Variant::Ref(instance_ref));
                 }
             }
         }
@@ -51,11 +49,9 @@ fn rewrite_refs_in_additions(context: &ComputePatchContext, additions: &mut [Pat
 
 fn rewrite_refs_in_snapshot(context: &ComputePatchContext, snapshot: &mut InstanceSnapshot) {
     for property_value in snapshot.properties.values_mut() {
-        if let RbxValue::Ref { value: Some(id) } = property_value {
-            if let Some(&instance_id) = context.snapshot_id_to_instance_id.get(id) {
-                *property_value = RbxValue::Ref {
-                    value: Some(instance_id),
-                };
+        if let Variant::Ref(referent) = property_value {
+            if let Some(&instance_referent) = context.snapshot_id_to_instance_id.get(referent) {
+                *property_value = Variant::Ref(instance_referent);
             }
         }
     }
@@ -69,7 +65,7 @@ fn compute_patch_set_internal(
     context: &mut ComputePatchContext,
     snapshot: &InstanceSnapshot,
     tree: &RojoTree,
-    id: RbxId,
+    id: Ref,
     patch_set: &mut PatchSet,
 ) {
     if let Some(snapshot_id) = snapshot.snapshot_id {
@@ -154,7 +150,7 @@ fn compute_children_patches(
     context: &mut ComputePatchContext,
     snapshot: &InstanceSnapshot,
     tree: &RojoTree,
-    id: RbxId,
+    id: Ref,
     patch_set: &mut PatchSet,
 ) {
     let instance = tree
@@ -224,9 +220,6 @@ mod test {
     use std::borrow::Cow;
 
     use maplit::hashmap;
-    use rbx_dom_weak::RbxInstanceProperties;
-
-    use super::super::InstancePropertiesWithMeta;
 
     /// This test makes sure that rewriting refs in instance update patches to
     /// instances that already exists works. We should be able to correlate the
@@ -234,26 +227,17 @@ mod test {
     /// value before returning from compute_patch_set.
     #[test]
     fn rewrite_ref_existing_instance_update() {
-        let tree = RojoTree::new(InstancePropertiesWithMeta {
-            properties: RbxInstanceProperties {
-                name: "foo".to_owned(),
-                class_name: "foo".to_owned(),
-                properties: HashMap::new(),
-            },
-            metadata: Default::default(),
-        });
+        let tree = RojoTree::new(InstanceSnapshot::new().name("foo").class_name("foo"));
 
         let root_id = tree.get_root_id();
 
         // This snapshot should be identical to the existing tree except for the
         // addition of a prop named Self, which is a self-referential Ref.
-        let snapshot_id = RbxId::new();
+        let snapshot_id = Ref::new();
         let snapshot = InstanceSnapshot {
             snapshot_id: Some(snapshot_id),
             properties: hashmap! {
-                "Self".to_owned() => RbxValue::Ref {
-                    value: Some(snapshot_id),
-                }
+                "Self".to_owned() => Variant::Ref(snapshot_id),
             },
 
             metadata: Default::default(),
@@ -270,9 +254,7 @@ mod test {
                 changed_name: None,
                 changed_class_name: None,
                 changed_properties: hashmap! {
-                    "Self".to_owned() => Some(RbxValue::Ref {
-                        value: Some(root_id),
-                    }),
+                    "Self".to_owned() => Some(Variant::Ref(root_id)),
                 },
                 changed_metadata: None,
             }],
@@ -288,26 +270,17 @@ mod test {
     /// one.
     #[test]
     fn rewrite_ref_existing_instance_addition() {
-        let tree = RojoTree::new(InstancePropertiesWithMeta {
-            properties: RbxInstanceProperties {
-                name: "foo".to_owned(),
-                class_name: "foo".to_owned(),
-                properties: HashMap::new(),
-            },
-            metadata: Default::default(),
-        });
+        let tree = RojoTree::new(InstanceSnapshot::new().name("foo").class_name("foo"));
 
         let root_id = tree.get_root_id();
 
         // This patch describes the existing instance with a new child added.
-        let snapshot_id = RbxId::new();
+        let snapshot_id = Ref::new();
         let snapshot = InstanceSnapshot {
             snapshot_id: Some(snapshot_id),
             children: vec![InstanceSnapshot {
                 properties: hashmap! {
-                    "Self".to_owned() => RbxValue::Ref {
-                        value: Some(snapshot_id),
-                    },
+                    "Self".to_owned() => Variant::Ref(snapshot_id),
                 },
 
                 snapshot_id: None,
@@ -332,9 +305,7 @@ mod test {
                     snapshot_id: None,
                     metadata: Default::default(),
                     properties: hashmap! {
-                        "Self".to_owned() => RbxValue::Ref {
-                            value: Some(root_id),
-                        },
+                        "Self".to_owned() => Variant::Ref(root_id),
                     },
                     name: Cow::Borrowed("child"),
                     class_name: Cow::Borrowed("child"),