Rename 'contributing paths' to 'relevant paths'

This commit is contained in:
Lucien Greathouse
2019-10-04 17:36:26 -07:00
parent 052ca52cc3
commit 530a7aa834
34 changed files with 73 additions and 73 deletions

View File

@@ -40,7 +40,7 @@ impl SnapshotMiddleware for SnapshotCsv {
Ok(Some(InstanceSnapshot {
snapshot_id: None,
metadata: InstanceMetadata {
contributing_paths: vec![entry.path().to_path_buf()],
relevant_paths: vec![entry.path().to_path_buf()],
..Default::default()
},
name: Cow::Owned(instance_name),

View File

@@ -44,7 +44,7 @@ impl SnapshotMiddleware for SnapshotDir {
Ok(Some(InstanceSnapshot {
snapshot_id: None,
metadata: InstanceMetadata {
contributing_paths: vec![entry.path().to_path_buf()],
relevant_paths: vec![entry.path().to_path_buf()],
..Default::default()
},
name: Cow::Owned(instance_name),

View File

@@ -52,7 +52,7 @@ impl SnapshotMiddleware for SnapshotJsonModel {
let mut snapshot = instance.core.into_snapshot(instance_name);
snapshot.metadata.contributing_paths = vec![entry.path().to_path_buf()];
snapshot.metadata.relevant_paths = vec![entry.path().to_path_buf()];
Ok(Some(snapshot))
}

View File

@@ -91,7 +91,7 @@ fn snapshot_lua_file<F: ImfsFetcher>(
Ok(Some(InstanceSnapshot {
snapshot_id: None,
metadata: InstanceMetadata {
contributing_paths: vec![entry.path().to_path_buf()],
relevant_paths: vec![entry.path().to_path_buf()],
..Default::default()
},
name: Cow::Owned(instance_name.to_owned()),

View File

@@ -31,9 +31,9 @@ impl SnapshotMiddleware for SnapshotProject {
Err(ref err) if err.kind() == FsErrorKind::NotFound => {}
Err(err) => return Err(err),
// TODO: Do we need to muck with the contributing paths if we're
// a project file within a folder? Should the folder path be the
// contributing path instead of the project file path?
// TODO: Do we need to muck with the relevant paths if we're a
// project file within a folder? Should the folder path be the
// relevant path instead of the project file path?
Ok(entry) => return SnapshotProject::from_imfs(imfs, &entry),
}
}
@@ -57,12 +57,12 @@ impl SnapshotMiddleware for SnapshotProject {
// file and not the snapshot's original instigating path, or else we
// won't pick up new changes from the project file.
//
// We SHOULD NOT mark the project file as a contributing path for any
// We SHOULD NOT mark the project file as a relevant path for any
// nodes that aren't roots. They'll be updated as part of the project
// file being updated.
snapshot
.metadata
.contributing_paths
.relevant_paths
.push(entry.path().to_path_buf());
Ok(Some(snapshot))

View File

@@ -43,7 +43,7 @@ impl SnapshotMiddleware for SnapshotRbxlx {
let mut snapshot = InstanceSnapshot::from_tree(&temp_tree, root_id);
snapshot.name = Cow::Owned(instance_name);
snapshot.metadata.contributing_paths = vec![entry.path().to_path_buf()];
snapshot.metadata.relevant_paths = vec![entry.path().to_path_buf()];
Ok(Some(snapshot))
}

View File

@@ -49,7 +49,7 @@ impl SnapshotMiddleware for SnapshotRbxm {
if children.len() == 1 {
let mut snapshot = InstanceSnapshot::from_tree(&temp_tree, children[0]);
snapshot.name = Cow::Owned(instance_name);
snapshot.metadata.contributing_paths = vec![entry.path().to_path_buf()];
snapshot.metadata.relevant_paths = vec![entry.path().to_path_buf()];
Ok(Some(snapshot))
} else {

View File

@@ -45,7 +45,7 @@ impl SnapshotMiddleware for SnapshotRbxmx {
if children.len() == 1 {
let mut snapshot = InstanceSnapshot::from_tree(&temp_tree, children[0]);
snapshot.name = Cow::Owned(instance_name);
snapshot.metadata.contributing_paths = vec![entry.path().to_path_buf()];
snapshot.metadata.relevant_paths = vec![entry.path().to_path_buf()];
Ok(Some(snapshot))
} else {

View File

@@ -5,7 +5,7 @@ expression: instance_snapshot
snapshot_id: ~
metadata:
ignore_unknown_instances: false
contributing_paths:
relevant_paths:
- /foo.client.lua
name: foo
class_name: LocalScript
@@ -13,4 +13,4 @@ properties:
Source:
Type: String
Value: Hello there!
children: []
children: []

View File

@@ -5,7 +5,7 @@ expression: instance_snapshot
snapshot_id: ~
metadata:
ignore_unknown_instances: false
contributing_paths:
relevant_paths:
- /foo.csv
name: foo
class_name: LocalizationTable
@@ -13,4 +13,4 @@ properties:
Contents:
Type: String
Value: "[{\"key\":\"Ack\",\"example\":\"An exclamation of despair\",\"source\":\"Ack!\",\"values\":{\"es\":\"¡Ay!\"}}]"
children: []
children: []

View File

@@ -5,9 +5,9 @@ expression: instance_snapshot
snapshot_id: ~
metadata:
ignore_unknown_instances: false
contributing_paths:
relevant_paths:
- /foo
name: foo
class_name: Folder
properties: {}
children: []
children: []

View File

@@ -5,7 +5,7 @@ expression: instance_snapshot
snapshot_id: ~
metadata:
ignore_unknown_instances: false
contributing_paths:
relevant_paths:
- /foo
name: foo
class_name: Folder
@@ -14,9 +14,9 @@ children:
- snapshot_id: ~
metadata:
ignore_unknown_instances: false
contributing_paths:
relevant_paths:
- /foo/Child
name: Child
class_name: Folder
properties: {}
children: []
children: []

View File

@@ -5,7 +5,7 @@ expression: instance_snapshot
snapshot_id: ~
metadata:
ignore_unknown_instances: false
contributing_paths:
relevant_paths:
- /foo.txt
name: foo
class_name: StringValue
@@ -13,4 +13,4 @@ properties:
Value:
Type: String
Value: Hello there!
children: []
children: []

View File

@@ -5,7 +5,7 @@ expression: instance_snapshot
snapshot_id: ~
metadata:
ignore_unknown_instances: false
contributing_paths:
relevant_paths:
- /foo.model.json
name: foo
class_name: IntValue
@@ -17,8 +17,8 @@ children:
- snapshot_id: ~
metadata:
ignore_unknown_instances: false
contributing_paths: []
relevant_paths: []
name: The Child
class_name: StringValue
properties: {}
children: []
children: []

View File

@@ -5,7 +5,7 @@ expression: instance_snapshot
snapshot_id: ~
metadata:
ignore_unknown_instances: false
contributing_paths:
relevant_paths:
- /foo.lua
name: foo
class_name: ModuleScript
@@ -13,4 +13,4 @@ properties:
Source:
Type: String
Value: Hello there!
children: []
children: []

View File

@@ -5,9 +5,9 @@ expression: instance_snapshot
snapshot_id: ~
metadata:
ignore_unknown_instances: true
contributing_paths:
relevant_paths:
- /foo/hello.project.json
name: direct-project
class_name: Model
properties: {}
children: []
children: []

View File

@@ -5,9 +5,9 @@ expression: instance_snapshot
snapshot_id: ~
metadata:
ignore_unknown_instances: true
contributing_paths:
relevant_paths:
- /foo/default.project.json
name: indirect-project
class_name: Folder
properties: {}
children: []
children: []

View File

@@ -5,7 +5,7 @@ expression: instance_snapshot
snapshot_id: ~
metadata:
ignore_unknown_instances: true
contributing_paths:
relevant_paths:
- /foo/other.project.json
- /foo/default.project.json
name: path-property-override
@@ -14,4 +14,4 @@ properties:
Value:
Type: String
Value: Changed
children: []
children: []

View File

@@ -5,7 +5,7 @@ expression: instance_snapshot
snapshot_id: ~
metadata:
ignore_unknown_instances: true
contributing_paths:
relevant_paths:
- /foo/default.project.json
name: children
class_name: Folder
@@ -14,8 +14,8 @@ children:
- snapshot_id: ~
metadata:
ignore_unknown_instances: true
contributing_paths: []
relevant_paths: []
name: Child
class_name: Model
properties: {}
children: []
children: []

View File

@@ -5,10 +5,10 @@ expression: instance_snapshot
snapshot_id: ~
metadata:
ignore_unknown_instances: true
contributing_paths:
relevant_paths:
- /foo/other.project.json
- /foo/default.project.json
name: path-project
class_name: Model
properties: {}
children: []
children: []

View File

@@ -5,7 +5,7 @@ expression: instance_snapshot
snapshot_id: ~
metadata:
ignore_unknown_instances: true
contributing_paths:
relevant_paths:
- /foo/other.project.json
- /foo/default.project.json
name: path-child-project
@@ -15,8 +15,8 @@ children:
- snapshot_id: ~
metadata:
ignore_unknown_instances: true
contributing_paths: []
relevant_paths: []
name: SomeChild
class_name: Model
properties: {}
children: []
children: []

View File

@@ -5,7 +5,7 @@ expression: instance_snapshot
snapshot_id: ~
metadata:
ignore_unknown_instances: false
contributing_paths:
relevant_paths:
- /foo/other.txt
- /foo/default.project.json
name: path-project
@@ -14,4 +14,4 @@ properties:
Value:
Type: String
Value: "Hello, world!"
children: []
children: []

View File

@@ -5,7 +5,7 @@ expression: instance_snapshot
snapshot_id: ~
metadata:
ignore_unknown_instances: true
contributing_paths:
relevant_paths:
- /foo/default.project.json
name: resolved-properties
class_name: StringValue
@@ -13,4 +13,4 @@ properties:
Value:
Type: String
Value: "Hello, world!"
children: []
children: []

View File

@@ -5,7 +5,7 @@ expression: instance_snapshot
snapshot_id: ~
metadata:
ignore_unknown_instances: true
contributing_paths:
relevant_paths:
- /foo/default.project.json
name: unresolved-properties
class_name: StringValue
@@ -13,4 +13,4 @@ properties:
Value:
Type: String
Value: Hi!
children: []
children: []

View File

@@ -5,7 +5,7 @@ expression: instance_snapshot
snapshot_id: ~
metadata:
ignore_unknown_instances: false
contributing_paths:
relevant_paths:
- /foo.server.lua
name: foo
class_name: Script
@@ -13,4 +13,4 @@ properties:
Source:
Type: String
Value: Hello there!
children: []
children: []

View File

@@ -52,7 +52,7 @@ impl SnapshotMiddleware for SnapshotTxt {
Ok(Some(InstanceSnapshot {
snapshot_id: None,
metadata: InstanceMetadata {
contributing_paths: vec![entry.path().to_path_buf()],
relevant_paths: vec![entry.path().to_path_buf()],
..Default::default()
},
name: Cow::Owned(instance_name),