rojo-rbx/rojo
1
0
Fork 1
mirror of https://github.com/rojo-rbx/rojo.git synced 2026-04-25 15:16:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix 'Open Scripts Externally' crashing studio.

Browse Source 
Closes #369.
This commit is contained in:
Lucien Greathouse
2021-04-23 16:59:59 -04:00
parent f1c4102d7f
commit 0f7c9493d2
2 changed files with 17 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
CHANGELOG.md
View File

@@ -2,9 +2,13 @@
## Unreleased Changes ## Unreleased Changes
* Added "EXPERIMENTAL!" label to two-way sync toggle in Rojo's Roblox Studio plugin. * Added "EXPERIMENTAL!" label to two-way sync toggle in Rojo's Roblox Studio plugin.
* Fixed "Open Scripts Externally" feature crashing Studio ([#369][issue-369])
[issue-369]: https://github.com/rojo-rbx/rojo/issues/369
## [6.1.0][6.1.0] (April 12, 2021) ## [6.1.0][6.1.0] (April 12, 2021)
* Updated dependencies, fixing OptionalCoordinateFrame-related issues. * Updated dependencies, fixing OptionalCoordinateFrame-related issues.
* Added `--address` flag to `rojo serve` to allow for external connections. ([#403][pr-403]) * Added `--address` flag to `rojo serve` to allow for external connections. ([#403][pr-403])
[pr-403]: https://github.com/rojo-rbx/rojo/pull/403 [pr-403]: https://github.com/rojo-rbx/rojo/pull/403

11
plugin/src/ServeSession.lua
View File

@@ -1,4 +1,5 @@
local StudioService = game:GetService("StudioService") local StudioService = game:GetService("StudioService")
local RunService = game:GetService("RunService")
local Log = require(script.Parent.Parent.Log) local Log = require(script.Parent.Parent.Log)
local Fmt = require(script.Parent.Parent.Fmt) local Fmt = require(script.Parent.Parent.Fmt)
@@ -150,10 +151,18 @@ function ServeSession:__onActiveScriptChanged(activeScript)
Log.debug("Trying to open script {} externally...", activeScript) Log.debug("Trying to open script {} externally...", activeScript)
-- Force-close the script inside Studio -- Force-close the script inside Studio... with a small delay in the middle
-- to prevent Studio from crashing.
spawn(function()
local existingParent = activeScript.Parent local existingParent = activeScript.Parent
activeScript.Parent = nil activeScript.Parent = nil
for i = 1, 3 do
RunService.Heartbeat:Wait()
end
activeScript.Parent = existingParent activeScript.Parent = existingParent
end)
-- Notify the Rojo server to open this script -- Notify the Rojo server to open this script
self.__apiContext:open(scriptId) self.__apiContext:open(scriptId)