forked from rojo-rbx/rojo
Compare commits
11 Commits
v6.2.0
...
v7.0.0-alp
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
98db3b4f08 | ||
|
|
0e7ba839ed | ||
|
|
2c27691e57 | ||
|
|
934506bdfd | ||
|
|
f313fa4ae1 | ||
|
|
78755b6130 | ||
|
|
8bf59e5cbb | ||
|
|
8f71d13714 | ||
|
|
f4a790eb50 | ||
|
|
0d951c8ad1 | ||
|
|
59ef5f05ea |
27
CHANGELOG.md
27
CHANGELOG.md
@@ -2,6 +2,33 @@
|
|||||||
|
|
||||||
## Unreleased Changes
|
## Unreleased Changes
|
||||||
|
|
||||||
|
## [7.0.0-alpha.3][7.0.0-alpha.3] (February 19, 2021)
|
||||||
|
* Updated dependencies, fixing `OptionalCoordinateFrame`-related issues.
|
||||||
|
* Added `--address` flag to `rojo serve` to allow for external connections. ([#403][pr-403])
|
||||||
|
|
||||||
|
[pr-403]: https://github.com/rojo-rbx/rojo/pull/403
|
||||||
|
[7.0.0-alpha.3]: https://github.com/rojo-rbx/rojo/releases/tag/v7.0.0-alpha.3
|
||||||
|
|
||||||
|
## [7.0.0-alpha.2][7.0.0-alpha.2] (February 19, 2021)
|
||||||
|
* Fixed incorrect protocol version between the client and server.
|
||||||
|
|
||||||
|
[7.0.0-alpha.2]: https://github.com/rojo-rbx/rojo/releases/tag/v7.0.0-alpha.2
|
||||||
|
|
||||||
|
## [7.0.0-alpha.1][7.0.0-alpha.1] (February 18, 2021)
|
||||||
|
This release includes a brand new implementation of the Roblox DOM. It brings performance improvements, much better support for `rbxl` and `rbxm` files, and a better internal API.
|
||||||
|
|
||||||
|
* Added support for all remaining property types.
|
||||||
|
* Added support for the entire Roblox binary model format.
|
||||||
|
* Changed `rojo upload` to upload binary places and models instead of XML.
|
||||||
|
* This should make using `rojo upload` much more feasible for large places.
|
||||||
|
* **Breaking**: Changed format of some types of values in `project.json`, `model.json`, and `meta.json` files.
|
||||||
|
* This should impact few projects. See [this file][allValues.json] for new examples of each property type.
|
||||||
|
|
||||||
|
Formatting of types will change more before the stable release of Rojo 7. We're hoping to use this opportunity to normalize some of the case inconsistency introduced in Rojo 0.5.
|
||||||
|
|
||||||
|
[7.0.0-alpha.1]: https://github.com/rojo-rbx/rojo/releases/tag/v7.0.0-alpha.1
|
||||||
|
[allValues.json]: https://github.com/rojo-rbx/rojo/blob/f4a790eb50b74e482000bad1dcfe22533992fb20/plugin/rbx_dom_lua/src/allValues.json
|
||||||
|
|
||||||
## [6.0.2](https://github.com/rojo-rbx/rojo/releases/tag/v6.0.2) (February 9, 2021)
|
## [6.0.2](https://github.com/rojo-rbx/rojo/releases/tag/v6.0.2) (February 9, 2021)
|
||||||
* Fixed `rojo upload` to handle CSRF challenges.
|
* Fixed `rojo upload` to handle CSRF challenges.
|
||||||
|
|
||||||
|
|||||||
@@ -41,9 +41,9 @@ The Rojo release process is pretty manual right now. If you need to do it, here'
|
|||||||
6. Tag the commit with the version from `Cargo.toml` prepended with a v, like `v0.4.13`
|
6. Tag the commit with the version from `Cargo.toml` prepended with a v, like `v0.4.13`
|
||||||
7. Publish the CLI
|
7. Publish the CLI
|
||||||
* `cargo publish`
|
* `cargo publish`
|
||||||
8. Build and upload the plugin
|
8. Publish the Plugin
|
||||||
|
* `rojo publish plugin --asset_id 6415005344`
|
||||||
* `rojo build plugin -o Rojo.rbxm`
|
* `rojo build plugin -o Rojo.rbxm`
|
||||||
* Upload `Rojo.rbxm` to Roblox.com, keep it for later
|
|
||||||
9. Push commits and tags
|
9. Push commits and tags
|
||||||
* `git push && git push --tags`
|
* `git push && git push --tags`
|
||||||
10. Copy GitHub release content from previous release
|
10. Copy GitHub release content from previous release
|
||||||
|
|||||||
721
Cargo.lock
generated
721
Cargo.lock
generated
File diff suppressed because it is too large
Load Diff
19
Cargo.toml
19
Cargo.toml
@@ -1,6 +1,6 @@
|
|||||||
[package]
|
[package]
|
||||||
name = "rojo"
|
name = "rojo"
|
||||||
version = "6.0.2"
|
version = "7.0.0-alpha.3"
|
||||||
authors = ["Lucien Greathouse <me@lpghatguy.com>"]
|
authors = ["Lucien Greathouse <me@lpghatguy.com>"]
|
||||||
description = "Enables professional-grade development tools for Roblox developers"
|
description = "Enables professional-grade development tools for Roblox developers"
|
||||||
license = "MPL-2.0"
|
license = "MPL-2.0"
|
||||||
@@ -47,6 +47,19 @@ harness = false
|
|||||||
[dependencies]
|
[dependencies]
|
||||||
memofs = { version = "0.1.2", path = "memofs" }
|
memofs = { version = "0.1.2", path = "memofs" }
|
||||||
|
|
||||||
|
# These dependencies can be uncommented when working on rbx-dom simultaneously
|
||||||
|
# rbx_binary = { path = "../rbx-dom/rbx_binary" }
|
||||||
|
# rbx_dom_weak = { path = "../rbx-dom/rbx_dom_weak" }
|
||||||
|
# rbx_reflection = { path = "../rbx-dom/rbx_reflection" }
|
||||||
|
# rbx_reflection_database = { path = "../rbx-dom/rbx_reflection_database" }
|
||||||
|
# rbx_xml = { path = "../rbx-dom/rbx_xml" }
|
||||||
|
|
||||||
|
rbx_binary = "0.6.0-alpha.1"
|
||||||
|
rbx_dom_weak = "2.0.0-alpha.1"
|
||||||
|
rbx_reflection = "4.0.0-alpha.1"
|
||||||
|
rbx_reflection_database = "0.1.0"
|
||||||
|
rbx_xml = "0.12.0-alpha.1"
|
||||||
|
|
||||||
anyhow = "1.0.27"
|
anyhow = "1.0.27"
|
||||||
backtrace = "0.3"
|
backtrace = "0.3"
|
||||||
bincode = "1.2.1"
|
bincode = "1.2.1"
|
||||||
@@ -64,10 +77,6 @@ log = "0.4.8"
|
|||||||
maplit = "1.0.1"
|
maplit = "1.0.1"
|
||||||
notify = "4.0.14"
|
notify = "4.0.14"
|
||||||
opener = "0.4.1"
|
opener = "0.4.1"
|
||||||
rbx_binary = "0.5.0"
|
|
||||||
rbx_dom_weak = "1.10.1"
|
|
||||||
rbx_reflection = "3.3.408"
|
|
||||||
rbx_xml = "0.11.3"
|
|
||||||
regex = "1.3.1"
|
regex = "1.3.1"
|
||||||
reqwest = "0.9.20"
|
reqwest = "0.9.20"
|
||||||
ritz = "0.1.0"
|
ritz = "0.1.0"
|
||||||
|
|||||||
1
plugin/rbx_dom_lua/run-tests.lua
Normal file
1
plugin/rbx_dom_lua/run-tests.lua
Normal file
@@ -0,0 +1 @@
|
|||||||
|
require(game.ReplicatedStorage.TestEZ).TestBootstrap:run({game.ReplicatedStorage.RbxDom})
|
||||||
@@ -20,223 +20,437 @@ local function serializeFloat(value)
|
|||||||
return value
|
return value
|
||||||
end
|
end
|
||||||
|
|
||||||
local encoders
|
local ALL_AXES = {"X", "Y", "Z"}
|
||||||
encoders = {
|
local ALL_FACES = {"Right", "Top", "Back", "Left", "Bottom", "Front"}
|
||||||
Bool = identity,
|
|
||||||
Content = identity,
|
|
||||||
Float32 = serializeFloat,
|
|
||||||
Float64 = serializeFloat,
|
|
||||||
Int32 = identity,
|
|
||||||
Int64 = identity,
|
|
||||||
String = identity,
|
|
||||||
|
|
||||||
BinaryString = base64.encode,
|
local types
|
||||||
SharedString = base64.encode,
|
types = {
|
||||||
|
Axes = {
|
||||||
|
fromPod = function(pod)
|
||||||
|
local axes = {}
|
||||||
|
|
||||||
BrickColor = function(value)
|
for index, axisName in ipairs(pod) do
|
||||||
return value.Number
|
axes[index] = Enum.Axis[axisName]
|
||||||
end,
|
end
|
||||||
|
|
||||||
CFrame = function(value)
|
return Axes.new(unpack(axes))
|
||||||
return {value:GetComponents()}
|
end,
|
||||||
end,
|
|
||||||
Color3 = function(value)
|
|
||||||
return {value.r, value.g, value.b}
|
|
||||||
end,
|
|
||||||
NumberRange = function(value)
|
|
||||||
return {value.Min, value.Max}
|
|
||||||
end,
|
|
||||||
NumberSequence = function(value)
|
|
||||||
local keypoints = {}
|
|
||||||
|
|
||||||
for index, keypoint in ipairs(value.Keypoints) do
|
toPod = function(roblox)
|
||||||
keypoints[index] = {
|
local json = {}
|
||||||
Time = keypoint.Time,
|
|
||||||
Value = keypoint.Value,
|
|
||||||
Envelope = keypoint.Envelope,
|
|
||||||
}
|
|
||||||
end
|
|
||||||
|
|
||||||
return {
|
for _, axis in ipairs(ALL_AXES) do
|
||||||
Keypoints = keypoints,
|
if roblox[axis] then
|
||||||
}
|
table.insert(json, axis)
|
||||||
end,
|
end
|
||||||
ColorSequence = function(value)
|
end
|
||||||
local keypoints = {}
|
|
||||||
|
|
||||||
for index, keypoint in ipairs(value.Keypoints) do
|
return json
|
||||||
keypoints[index] = {
|
end,
|
||||||
Time = keypoint.Time,
|
},
|
||||||
Color = encoders.Color3(keypoint.Value),
|
|
||||||
}
|
|
||||||
end
|
|
||||||
|
|
||||||
return {
|
BinaryString = {
|
||||||
Keypoints = keypoints,
|
fromPod = base64.decode,
|
||||||
}
|
toPod = base64.encode,
|
||||||
end,
|
},
|
||||||
Rect = function(value)
|
|
||||||
return {
|
Bool = {
|
||||||
Min = {value.Min.X, value.Min.Y},
|
fromPod = identity,
|
||||||
Max = {value.Max.X, value.Max.Y},
|
toPod = identity,
|
||||||
}
|
},
|
||||||
end,
|
|
||||||
UDim = function(value)
|
BrickColor = {
|
||||||
return {value.Scale, value.Offset}
|
fromPod = function(pod)
|
||||||
end,
|
return BrickColor.new(pod)
|
||||||
UDim2 = function(value)
|
end,
|
||||||
return {value.X.Scale, value.X.Offset, value.Y.Scale, value.Y.Offset}
|
|
||||||
end,
|
toPod = function(roblox)
|
||||||
Vector2 = function(value)
|
return roblox.Number
|
||||||
return {
|
end,
|
||||||
serializeFloat(value.X),
|
},
|
||||||
serializeFloat(value.Y),
|
|
||||||
}
|
CFrame = {
|
||||||
end,
|
fromPod = function(pod)
|
||||||
Vector2int16 = function(value)
|
local pos = pod.Position
|
||||||
return {value.X, value.Y}
|
local orient = pod.Orientation
|
||||||
end,
|
|
||||||
Vector3 = function(value)
|
return CFrame.new(
|
||||||
return {
|
pos[1], pos[2], pos[3],
|
||||||
serializeFloat(value.X),
|
orient[1][1], orient[1][2], orient[1][3],
|
||||||
serializeFloat(value.Y),
|
orient[2][1], orient[2][2], orient[2][3],
|
||||||
serializeFloat(value.Z),
|
orient[3][1], orient[3][2], orient[3][3]
|
||||||
}
|
)
|
||||||
end,
|
end,
|
||||||
Vector3int16 = function(value)
|
|
||||||
return {value.X, value.Y, value.Z}
|
toPod = function(roblox)
|
||||||
end,
|
local x, y, z,
|
||||||
|
r00, r01, r02,
|
||||||
|
r10, r11, r12,
|
||||||
|
r20, r21, r22 = roblox:GetComponents()
|
||||||
|
|
||||||
PhysicalProperties = function(value)
|
|
||||||
if value == nil then
|
|
||||||
return nil
|
|
||||||
else
|
|
||||||
return {
|
return {
|
||||||
Density = value.Density,
|
Position = {x, y, z},
|
||||||
Friction = value.Friction,
|
Orientation = {
|
||||||
Elasticity = value.Elasticity,
|
{r00, r01, r02},
|
||||||
FrictionWeight = value.FrictionWeight,
|
{r10, r11, r12},
|
||||||
ElasticityWeight = value.ElasticityWeight,
|
{r20, r21, r22},
|
||||||
|
},
|
||||||
}
|
}
|
||||||
end
|
end,
|
||||||
end,
|
},
|
||||||
|
|
||||||
Ref = function(value)
|
Color3 = {
|
||||||
return nil
|
fromPod = unpackDecoder(Color3.new),
|
||||||
end,
|
|
||||||
}
|
|
||||||
|
|
||||||
local decoders = {
|
toPod = function(roblox)
|
||||||
Bool = identity,
|
return {roblox.r, roblox.g, roblox.b}
|
||||||
Content = identity,
|
end,
|
||||||
Enum = identity,
|
},
|
||||||
Float32 = identity,
|
|
||||||
Float64 = identity,
|
|
||||||
Int32 = identity,
|
|
||||||
Int64 = identity,
|
|
||||||
String = identity,
|
|
||||||
|
|
||||||
BinaryString = base64.decode,
|
Color3uint8 = {
|
||||||
SharedString = base64.decode,
|
fromPod = unpackDecoder(Color3.fromRGB),
|
||||||
|
|
||||||
BrickColor = BrickColor.new,
|
toPod = function(roblox)
|
||||||
|
return {
|
||||||
|
math.round(roblox.R * 255),
|
||||||
|
math.round(roblox.G * 255),
|
||||||
|
math.round(roblox.B * 255),
|
||||||
|
}
|
||||||
|
end,
|
||||||
|
},
|
||||||
|
|
||||||
CFrame = unpackDecoder(CFrame.new),
|
ColorSequence = {
|
||||||
Color3 = unpackDecoder(Color3.new),
|
fromPod = function(pod)
|
||||||
Color3uint8 = unpackDecoder(Color3.fromRGB),
|
local keypoints = {}
|
||||||
NumberRange = unpackDecoder(NumberRange.new),
|
|
||||||
UDim = unpackDecoder(UDim.new),
|
|
||||||
UDim2 = unpackDecoder(UDim2.new),
|
|
||||||
Vector2 = unpackDecoder(Vector2.new),
|
|
||||||
Vector2int16 = unpackDecoder(Vector2int16.new),
|
|
||||||
Vector3 = unpackDecoder(Vector3.new),
|
|
||||||
Vector3int16 = unpackDecoder(Vector3int16.new),
|
|
||||||
|
|
||||||
Rect = function(value)
|
for index, keypoint in ipairs(pod.Keypoints) do
|
||||||
return Rect.new(value.Min[1], value.Min[2], value.Max[1], value.Max[2])
|
keypoints[index] = ColorSequenceKeypoint.new(
|
||||||
end,
|
keypoint.Time,
|
||||||
|
types.Color3.fromPod(keypoint.Color)
|
||||||
|
)
|
||||||
|
end
|
||||||
|
|
||||||
NumberSequence = function(value)
|
return ColorSequence.new(keypoints)
|
||||||
local keypoints = {}
|
end,
|
||||||
|
|
||||||
for index, keypoint in ipairs(value.Keypoints) do
|
toPod = function(roblox)
|
||||||
keypoints[index] = NumberSequenceKeypoint.new(
|
local keypoints = {}
|
||||||
keypoint.Time,
|
|
||||||
keypoint.Value,
|
for index, keypoint in ipairs(roblox.Keypoints) do
|
||||||
keypoint.Envelope
|
keypoints[index] = {
|
||||||
|
Time = keypoint.Time,
|
||||||
|
Color = types.Color3.toPod(keypoint.Value),
|
||||||
|
}
|
||||||
|
end
|
||||||
|
|
||||||
|
return {
|
||||||
|
Keypoints = keypoints,
|
||||||
|
}
|
||||||
|
end,
|
||||||
|
},
|
||||||
|
|
||||||
|
Content = {
|
||||||
|
fromPod = identity,
|
||||||
|
toPod = identity,
|
||||||
|
},
|
||||||
|
|
||||||
|
Enum = {
|
||||||
|
fromPod = identity,
|
||||||
|
|
||||||
|
toPod = function(roblox)
|
||||||
|
-- FIXME: More robust handling of enums
|
||||||
|
if typeof(roblox) == "number" then
|
||||||
|
return roblox
|
||||||
|
else
|
||||||
|
return roblox.Value
|
||||||
|
end
|
||||||
|
end,
|
||||||
|
},
|
||||||
|
|
||||||
|
Faces = {
|
||||||
|
fromPod = function(pod)
|
||||||
|
local faces = {}
|
||||||
|
|
||||||
|
for index, faceName in ipairs(pod) do
|
||||||
|
faces[index] = Enum.NormalId[faceName]
|
||||||
|
end
|
||||||
|
|
||||||
|
return Faces.new(unpack(faces))
|
||||||
|
end,
|
||||||
|
|
||||||
|
toPod = function(roblox)
|
||||||
|
local pod = {}
|
||||||
|
|
||||||
|
for _, face in ipairs(ALL_FACES) do
|
||||||
|
if roblox[face] then
|
||||||
|
table.insert(pod, face)
|
||||||
|
end
|
||||||
|
end
|
||||||
|
|
||||||
|
return pod
|
||||||
|
end,
|
||||||
|
},
|
||||||
|
|
||||||
|
Float32 = {
|
||||||
|
fromPod = identity,
|
||||||
|
toPod = serializeFloat,
|
||||||
|
},
|
||||||
|
|
||||||
|
Float64 = {
|
||||||
|
fromPod = identity,
|
||||||
|
toPod = serializeFloat,
|
||||||
|
},
|
||||||
|
|
||||||
|
Int32 = {
|
||||||
|
fromPod = identity,
|
||||||
|
toPod = identity,
|
||||||
|
},
|
||||||
|
|
||||||
|
Int64 = {
|
||||||
|
fromPod = identity,
|
||||||
|
toPod = identity,
|
||||||
|
},
|
||||||
|
|
||||||
|
NumberRange = {
|
||||||
|
fromPod = unpackDecoder(NumberRange.new),
|
||||||
|
|
||||||
|
toPod = function(roblox)
|
||||||
|
return {roblox.Min, roblox.Max}
|
||||||
|
end,
|
||||||
|
},
|
||||||
|
|
||||||
|
NumberSequence = {
|
||||||
|
fromPod = function(pod)
|
||||||
|
local keypoints = {}
|
||||||
|
|
||||||
|
for index, keypoint in ipairs(pod.Keypoints) do
|
||||||
|
keypoints[index] = NumberSequenceKeypoint.new(
|
||||||
|
keypoint.Time,
|
||||||
|
keypoint.Value,
|
||||||
|
keypoint.Envelope
|
||||||
|
)
|
||||||
|
end
|
||||||
|
|
||||||
|
return NumberSequence.new(keypoints)
|
||||||
|
end,
|
||||||
|
|
||||||
|
toPod = function(roblox)
|
||||||
|
local keypoints = {}
|
||||||
|
|
||||||
|
for index, keypoint in ipairs(roblox.Keypoints) do
|
||||||
|
keypoints[index] = {
|
||||||
|
Time = keypoint.Time,
|
||||||
|
Value = keypoint.Value,
|
||||||
|
Envelope = keypoint.Envelope,
|
||||||
|
}
|
||||||
|
end
|
||||||
|
|
||||||
|
return {
|
||||||
|
Keypoints = keypoints,
|
||||||
|
}
|
||||||
|
end,
|
||||||
|
},
|
||||||
|
|
||||||
|
PhysicalProperties = {
|
||||||
|
fromPod = function(pod)
|
||||||
|
if pod == "Default" then
|
||||||
|
return nil
|
||||||
|
else
|
||||||
|
return PhysicalProperties.new(
|
||||||
|
pod.Density,
|
||||||
|
pod.Friction,
|
||||||
|
pod.Elasticity,
|
||||||
|
pod.FrictionWeight,
|
||||||
|
pod.ElasticityWeight
|
||||||
|
)
|
||||||
|
end
|
||||||
|
end,
|
||||||
|
|
||||||
|
toPod = function(roblox)
|
||||||
|
if roblox == nil then
|
||||||
|
return "Default"
|
||||||
|
else
|
||||||
|
return {
|
||||||
|
Density = roblox.Density,
|
||||||
|
Friction = roblox.Friction,
|
||||||
|
Elasticity = roblox.Elasticity,
|
||||||
|
FrictionWeight = roblox.FrictionWeight,
|
||||||
|
ElasticityWeight = roblox.ElasticityWeight,
|
||||||
|
}
|
||||||
|
end
|
||||||
|
end,
|
||||||
|
},
|
||||||
|
|
||||||
|
Ray = {
|
||||||
|
fromPod = function(pod)
|
||||||
|
return Ray.new(
|
||||||
|
types.Vector3.fromPod(pod.Origin),
|
||||||
|
types.Vector3.fromPod(pod.Direction)
|
||||||
)
|
)
|
||||||
end
|
end,
|
||||||
|
|
||||||
return NumberSequence.new(keypoints)
|
toPod = function(roblox)
|
||||||
end,
|
return {
|
||||||
|
Origin = types.Vector3.toPod(roblox.Origin),
|
||||||
|
Direction = types.Vector3.toPod(roblox.Direction),
|
||||||
|
}
|
||||||
|
end,
|
||||||
|
},
|
||||||
|
|
||||||
ColorSequence = function(value)
|
Rect = {
|
||||||
local keypoints = {}
|
fromPod = function(pod)
|
||||||
|
return Rect.new(
|
||||||
for index, keypoint in ipairs(value.Keypoints) do
|
types.Vector2.fromPod(pod[1]),
|
||||||
keypoints[index] = ColorSequenceKeypoint.new(
|
types.Vector2.fromPod(pod[2])
|
||||||
keypoint.Time,
|
|
||||||
Color3.new(unpack(keypoint.Color))
|
|
||||||
)
|
)
|
||||||
end
|
end,
|
||||||
|
|
||||||
return ColorSequence.new(keypoints)
|
toPod = function(roblox)
|
||||||
end,
|
return {
|
||||||
|
types.Vector2.toPod(roblox.Min),
|
||||||
|
types.Vector2.toPod(roblox.Max),
|
||||||
|
}
|
||||||
|
end,
|
||||||
|
},
|
||||||
|
|
||||||
PhysicalProperties = function(properties)
|
Ref = {
|
||||||
if properties == nil then
|
fromPod = function(_pod)
|
||||||
return nil
|
error("Ref cannot be decoded on its own")
|
||||||
else
|
end,
|
||||||
return PhysicalProperties.new(
|
|
||||||
properties.Density,
|
toPod = function(_roblox)
|
||||||
properties.Friction,
|
error("Ref can not be encoded on its own")
|
||||||
properties.Elasticity,
|
end,
|
||||||
properties.FrictionWeight,
|
},
|
||||||
properties.ElasticityWeight
|
|
||||||
|
Region3 = {
|
||||||
|
fromPod = function(pod)
|
||||||
|
error("Region3 is not implemented")
|
||||||
|
end,
|
||||||
|
|
||||||
|
toPod = function(roblox)
|
||||||
|
error("Region3 is not implemented")
|
||||||
|
end,
|
||||||
|
},
|
||||||
|
|
||||||
|
Region3int16 = {
|
||||||
|
fromPod = function(pod)
|
||||||
|
return Region3int16.new(
|
||||||
|
types.Vector3int16.fromPod(pod[1]),
|
||||||
|
types.Vector3int16.fromPod(pod[2])
|
||||||
)
|
)
|
||||||
end
|
end,
|
||||||
end,
|
|
||||||
|
|
||||||
Ref = function()
|
toPod = function(roblox)
|
||||||
return nil
|
return {
|
||||||
end,
|
types.Vector3int16.toPod(roblox.Min),
|
||||||
|
types.Vector3int16.toPod(roblox.Max),
|
||||||
|
}
|
||||||
|
end,
|
||||||
|
},
|
||||||
|
|
||||||
|
SharedString = {
|
||||||
|
fromPod = function(pod)
|
||||||
|
error("SharedString is not supported")
|
||||||
|
end,
|
||||||
|
|
||||||
|
toPod = function(roblox)
|
||||||
|
error("SharedString is not supported")
|
||||||
|
end,
|
||||||
|
},
|
||||||
|
|
||||||
|
String = {
|
||||||
|
fromPod = identity,
|
||||||
|
toPod = identity,
|
||||||
|
},
|
||||||
|
|
||||||
|
UDim = {
|
||||||
|
fromPod = unpackDecoder(UDim.new),
|
||||||
|
|
||||||
|
toPod = function(roblox)
|
||||||
|
return {roblox.Scale, roblox.Offset}
|
||||||
|
end,
|
||||||
|
},
|
||||||
|
|
||||||
|
UDim2 = {
|
||||||
|
fromPod = function(pod)
|
||||||
|
return UDim2.new(
|
||||||
|
types.UDim.fromPod(pod[1]),
|
||||||
|
types.UDim.fromPod(pod[2])
|
||||||
|
)
|
||||||
|
end,
|
||||||
|
|
||||||
|
toPod = function(roblox)
|
||||||
|
return {
|
||||||
|
types.UDim.toPod(roblox.X),
|
||||||
|
types.UDim.toPod(roblox.Y),
|
||||||
|
}
|
||||||
|
end,
|
||||||
|
},
|
||||||
|
|
||||||
|
Vector2 = {
|
||||||
|
fromPod = unpackDecoder(Vector2.new),
|
||||||
|
|
||||||
|
toPod = function(roblox)
|
||||||
|
return {
|
||||||
|
serializeFloat(roblox.X),
|
||||||
|
serializeFloat(roblox.Y),
|
||||||
|
}
|
||||||
|
end,
|
||||||
|
},
|
||||||
|
|
||||||
|
Vector2int16 = {
|
||||||
|
fromPod = unpackDecoder(Vector2int16.new),
|
||||||
|
|
||||||
|
toPod = function(roblox)
|
||||||
|
return {roblox.X, roblox.Y}
|
||||||
|
end,
|
||||||
|
},
|
||||||
|
|
||||||
|
Vector3 = {
|
||||||
|
fromPod = unpackDecoder(Vector3.new),
|
||||||
|
|
||||||
|
toPod = function(roblox)
|
||||||
|
return {
|
||||||
|
serializeFloat(roblox.X),
|
||||||
|
serializeFloat(roblox.Y),
|
||||||
|
serializeFloat(roblox.Z),
|
||||||
|
}
|
||||||
|
end,
|
||||||
|
},
|
||||||
|
|
||||||
|
Vector3int16 = {
|
||||||
|
fromPod = unpackDecoder(Vector3int16.new),
|
||||||
|
|
||||||
|
toPod = function(roblox)
|
||||||
|
return {roblox.X, roblox.Y, roblox.Z}
|
||||||
|
end,
|
||||||
|
},
|
||||||
}
|
}
|
||||||
|
|
||||||
local EncodedValue = {}
|
local EncodedValue = {}
|
||||||
|
|
||||||
function EncodedValue.decode(encodedValue)
|
function EncodedValue.decode(encodedValue)
|
||||||
local decoder = decoders[encodedValue.Type]
|
local typeImpl = types[encodedValue.Type]
|
||||||
if decoder ~= nil then
|
if typeImpl == nil then
|
||||||
return true, decoder(encodedValue.Value)
|
return false, "Couldn't decode value " .. tostring(encodedValue.Type)
|
||||||
end
|
end
|
||||||
|
|
||||||
return false, "Couldn't decode value " .. tostring(encodedValue.Type)
|
return true, typeImpl.fromPod(encodedValue.Value)
|
||||||
end
|
end
|
||||||
|
|
||||||
function EncodedValue.encode(rbxValue, propertyType)
|
function EncodedValue.encode(rbxValue, propertyType)
|
||||||
assert(propertyType ~= nil, "Property type descriptor is required")
|
assert(propertyType ~= nil, "Property type descriptor is required")
|
||||||
|
|
||||||
if propertyType.type == "Data" then
|
local typeImpl = types[propertyType]
|
||||||
local encoder = encoders[propertyType.name]
|
if typeImpl == nil then
|
||||||
|
return false, ("Missing encoder for property type %q"):format(propertyType)
|
||||||
if encoder == nil then
|
|
||||||
return false, ("Missing encoder for property type %q"):format(propertyType.name)
|
|
||||||
end
|
|
||||||
|
|
||||||
if encoder ~= nil then
|
|
||||||
return true, {
|
|
||||||
Type = propertyType.name,
|
|
||||||
Value = encoder(rbxValue),
|
|
||||||
}
|
|
||||||
end
|
|
||||||
elseif propertyType.type == "Enum" then
|
|
||||||
return true, {
|
|
||||||
Type = "Enum",
|
|
||||||
Value = rbxValue.Value,
|
|
||||||
}
|
|
||||||
end
|
end
|
||||||
|
|
||||||
return false, ("Unknown property descriptor type %q"):format(tostring(propertyType.type))
|
return true, {
|
||||||
|
Type = propertyType,
|
||||||
|
Value = typeImpl.toPod(rbxValue),
|
||||||
|
}
|
||||||
end
|
end
|
||||||
|
|
||||||
return EncodedValue
|
return EncodedValue
|
||||||
|
|||||||
@@ -1,127 +1,72 @@
|
|||||||
return function()
|
return function()
|
||||||
local RbxDom = require(script.Parent)
|
local HttpService = game:GetService("HttpService")
|
||||||
|
|
||||||
local EncodedValue = require(script.Parent.EncodedValue)
|
local EncodedValue = require(script.Parent.EncodedValue)
|
||||||
|
local allValues = require(script.Parent.allValues)
|
||||||
|
|
||||||
it("should decode Rect values", function()
|
local function deepEq(a, b)
|
||||||
local input = {
|
if typeof(a) ~= typeof(b) then
|
||||||
Type = "Rect",
|
return false
|
||||||
Value = {
|
end
|
||||||
Min = {1, 2},
|
|
||||||
Max = {3, 4},
|
|
||||||
},
|
|
||||||
}
|
|
||||||
|
|
||||||
local output = Rect.new(1, 2, 3, 4)
|
local ty = typeof(a)
|
||||||
|
|
||||||
local ok, decoded = EncodedValue.decode(input)
|
if ty == "table" then
|
||||||
|
local visited = {}
|
||||||
|
|
||||||
|
for key, valueA in pairs(a) do
|
||||||
|
visited[key] = true
|
||||||
|
|
||||||
|
if not deepEq(valueA, b[key]) then
|
||||||
|
return false
|
||||||
|
end
|
||||||
|
end
|
||||||
|
|
||||||
assert(ok, decoded)
|
for key, valueB in pairs(b) do
|
||||||
expect(decoded).to.equal(output)
|
if visited[key] then
|
||||||
end)
|
continue
|
||||||
|
end
|
||||||
|
|
||||||
it("should decode ColorSequence values", function()
|
if not deepEq(valueB, a[key]) then
|
||||||
local input = {
|
return false
|
||||||
Type = "ColorSequence",
|
end
|
||||||
Value = {
|
end
|
||||||
Keypoints = {
|
|
||||||
{
|
|
||||||
Time = 0,
|
|
||||||
Color = { 0.12, 0.34, 0.56 },
|
|
||||||
},
|
|
||||||
|
|
||||||
{
|
return true
|
||||||
Time = 1,
|
else
|
||||||
Color = { 0.13, 0.33, 0.37 },
|
return a == b
|
||||||
},
|
end
|
||||||
}
|
end
|
||||||
},
|
|
||||||
}
|
|
||||||
|
|
||||||
local output = ColorSequence.new({
|
local extraAssertions = {
|
||||||
ColorSequenceKeypoint.new(0, Color3.new(0.12, 0.34, 0.56)),
|
CFrame = function(value)
|
||||||
ColorSequenceKeypoint.new(1, Color3.new(0.13, 0.33, 0.37)),
|
expect(value).to.equal(CFrame.new(1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12))
|
||||||
})
|
end,
|
||||||
|
}
|
||||||
|
|
||||||
local ok, decoded = EncodedValue.decode(input)
|
for testName, testEntry in pairs(allValues) do
|
||||||
assert(ok, decoded)
|
it("round trip " .. testName, function()
|
||||||
expect(decoded).to.equal(output)
|
local ok, decoded = EncodedValue.decode(testEntry.value)
|
||||||
end)
|
assert(ok, decoded)
|
||||||
|
|
||||||
it("should decode NumberSequence values", function()
|
if extraAssertions[testName] ~= nil then
|
||||||
local input = {
|
extraAssertions[testName](decoded)
|
||||||
Type = "NumberSequence",
|
end
|
||||||
Value = {
|
|
||||||
Keypoints = {
|
|
||||||
{
|
|
||||||
Time = 0,
|
|
||||||
Value = 0.5,
|
|
||||||
Envelope = 0,
|
|
||||||
},
|
|
||||||
|
|
||||||
{
|
local ok, encoded = EncodedValue.encode(decoded, testEntry.ty)
|
||||||
Time = 1,
|
assert(ok, encoded)
|
||||||
Value = 0.5,
|
|
||||||
Envelope = 0,
|
|
||||||
},
|
|
||||||
}
|
|
||||||
},
|
|
||||||
}
|
|
||||||
|
|
||||||
local output = NumberSequence.new({
|
if not deepEq(encoded, testEntry.value) then
|
||||||
NumberSequenceKeypoint.new(0, 0.5, 0),
|
local expected = HttpService:JSONEncode(testEntry.value)
|
||||||
NumberSequenceKeypoint.new(1, 0.5, 0),
|
local actual = HttpService:JSONEncode(encoded)
|
||||||
})
|
|
||||||
|
|
||||||
local ok, decoded = EncodedValue.decode(input)
|
local message = string.format(
|
||||||
assert(ok, decoded)
|
"Round-trip results did not match.\nExpected:\n%s\nActual:\n%s",
|
||||||
expect(decoded).to.equal(output)
|
expected, actual
|
||||||
end)
|
)
|
||||||
|
|
||||||
it("should decode PhysicalProperties values", function()
|
error(message)
|
||||||
local input = {
|
end
|
||||||
Type = "PhysicalProperties",
|
end)
|
||||||
Value = {
|
end
|
||||||
Density = 0.1,
|
end
|
||||||
Friction = 0.2,
|
|
||||||
Elasticity = 0.3,
|
|
||||||
FrictionWeight = 0.4,
|
|
||||||
ElasticityWeight = 0.5,
|
|
||||||
},
|
|
||||||
}
|
|
||||||
|
|
||||||
local output = PhysicalProperties.new(
|
|
||||||
0.1,
|
|
||||||
0.2,
|
|
||||||
0.3,
|
|
||||||
0.4,
|
|
||||||
0.5
|
|
||||||
)
|
|
||||||
|
|
||||||
local ok, decoded = EncodedValue.decode(input)
|
|
||||||
assert(ok, decoded)
|
|
||||||
expect(decoded).to.equal(output)
|
|
||||||
end)
|
|
||||||
|
|
||||||
-- This part of rbx_dom_lua needs some work still.
|
|
||||||
itSKIP("should encode Rect values", function()
|
|
||||||
local input = Rect.new(10, 20, 30, 40)
|
|
||||||
|
|
||||||
local output = {
|
|
||||||
Type = "Rect",
|
|
||||||
Value = {
|
|
||||||
Min = {10, 20},
|
|
||||||
Max = {30, 40},
|
|
||||||
},
|
|
||||||
}
|
|
||||||
|
|
||||||
local descriptor = RbxDom.findCanonicalPropertyDescriptor("ImageLabel", "SliceCenter")
|
|
||||||
local ok, encoded = EncodedValue.encode(input, descriptor)
|
|
||||||
|
|
||||||
assert(ok, encoded)
|
|
||||||
expect(encoded.Type).to.equal(output.Type)
|
|
||||||
expect(encoded.Value.Min[1]).to.equal(output.Value.Min[1])
|
|
||||||
expect(encoded.Value.Min[2]).to.equal(output.Value.Min[2])
|
|
||||||
expect(encoded.Value.Max[1]).to.equal(output.Value.Max[1])
|
|
||||||
expect(encoded.Value.Max[2]).to.equal(output.Value.Max[2])
|
|
||||||
end)
|
|
||||||
end
|
|
||||||
|
|||||||
@@ -21,7 +21,7 @@ end
|
|||||||
|
|
||||||
function PropertyDescriptor.fromRaw(data, className, propertyName)
|
function PropertyDescriptor.fromRaw(data, className, propertyName)
|
||||||
return setmetatable({
|
return setmetatable({
|
||||||
scriptability = data.scriptability,
|
scriptability = data.Scriptability,
|
||||||
className = className,
|
className = className,
|
||||||
name = propertyName,
|
name = propertyName,
|
||||||
}, PropertyDescriptor)
|
}, PropertyDescriptor)
|
||||||
|
|||||||
File diff suppressed because it is too large
Load Diff
@@ -1,3 +0,0 @@
|
|||||||
return {
|
|
||||||
classes = require(script.classes)
|
|
||||||
}
|
|
||||||
345
plugin/rbx_dom_lua/src/allValues.json
Normal file
345
plugin/rbx_dom_lua/src/allValues.json
Normal file
@@ -0,0 +1,345 @@
|
|||||||
|
{
|
||||||
|
"Axes": {
|
||||||
|
"value": {
|
||||||
|
"Type": "Axes",
|
||||||
|
"Value": [
|
||||||
|
"X",
|
||||||
|
"Y",
|
||||||
|
"Z"
|
||||||
|
]
|
||||||
|
},
|
||||||
|
"ty": "Axes"
|
||||||
|
},
|
||||||
|
"BinaryString": {
|
||||||
|
"value": {
|
||||||
|
"Type": "BinaryString",
|
||||||
|
"Value": "SGVsbG8h"
|
||||||
|
},
|
||||||
|
"ty": "BinaryString"
|
||||||
|
},
|
||||||
|
"Bool": {
|
||||||
|
"value": {
|
||||||
|
"Type": "Bool",
|
||||||
|
"Value": true
|
||||||
|
},
|
||||||
|
"ty": "Bool"
|
||||||
|
},
|
||||||
|
"BrickColor": {
|
||||||
|
"value": {
|
||||||
|
"Type": "BrickColor",
|
||||||
|
"Value": 1004
|
||||||
|
},
|
||||||
|
"ty": "BrickColor"
|
||||||
|
},
|
||||||
|
"CFrame": {
|
||||||
|
"value": {
|
||||||
|
"Type": "CFrame",
|
||||||
|
"Value": {
|
||||||
|
"Position": [
|
||||||
|
1.0,
|
||||||
|
2.0,
|
||||||
|
3.0
|
||||||
|
],
|
||||||
|
"Orientation": [
|
||||||
|
[
|
||||||
|
4.0,
|
||||||
|
5.0,
|
||||||
|
6.0
|
||||||
|
],
|
||||||
|
[
|
||||||
|
7.0,
|
||||||
|
8.0,
|
||||||
|
9.0
|
||||||
|
],
|
||||||
|
[
|
||||||
|
10.0,
|
||||||
|
11.0,
|
||||||
|
12.0
|
||||||
|
]
|
||||||
|
]
|
||||||
|
}
|
||||||
|
},
|
||||||
|
"ty": "CFrame"
|
||||||
|
},
|
||||||
|
"Color3": {
|
||||||
|
"value": {
|
||||||
|
"Type": "Color3",
|
||||||
|
"Value": [
|
||||||
|
1.0,
|
||||||
|
2.0,
|
||||||
|
3.0
|
||||||
|
]
|
||||||
|
},
|
||||||
|
"ty": "Color3"
|
||||||
|
},
|
||||||
|
"Color3uint8": {
|
||||||
|
"value": {
|
||||||
|
"Type": "Color3uint8",
|
||||||
|
"Value": [
|
||||||
|
0,
|
||||||
|
128,
|
||||||
|
255
|
||||||
|
]
|
||||||
|
},
|
||||||
|
"ty": "Color3uint8"
|
||||||
|
},
|
||||||
|
"ColorSequence": {
|
||||||
|
"value": {
|
||||||
|
"Type": "ColorSequence",
|
||||||
|
"Value": {
|
||||||
|
"Keypoints": [
|
||||||
|
{
|
||||||
|
"Time": 0.0,
|
||||||
|
"Color": [
|
||||||
|
1.0,
|
||||||
|
1.0,
|
||||||
|
0.5
|
||||||
|
]
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"Time": 1.0,
|
||||||
|
"Color": [
|
||||||
|
0.0,
|
||||||
|
0.0,
|
||||||
|
0.0
|
||||||
|
]
|
||||||
|
}
|
||||||
|
]
|
||||||
|
}
|
||||||
|
},
|
||||||
|
"ty": "ColorSequence"
|
||||||
|
},
|
||||||
|
"Content": {
|
||||||
|
"value": {
|
||||||
|
"Type": "Content",
|
||||||
|
"Value": "rbxassetid://12345"
|
||||||
|
},
|
||||||
|
"ty": "Content"
|
||||||
|
},
|
||||||
|
"Enum": {
|
||||||
|
"value": {
|
||||||
|
"Type": "Enum",
|
||||||
|
"Value": 1234
|
||||||
|
},
|
||||||
|
"ty": "Enum"
|
||||||
|
},
|
||||||
|
"Faces": {
|
||||||
|
"value": {
|
||||||
|
"Type": "Faces",
|
||||||
|
"Value": [
|
||||||
|
"Right",
|
||||||
|
"Top",
|
||||||
|
"Back",
|
||||||
|
"Left",
|
||||||
|
"Bottom",
|
||||||
|
"Front"
|
||||||
|
]
|
||||||
|
},
|
||||||
|
"ty": "Faces"
|
||||||
|
},
|
||||||
|
"Float32": {
|
||||||
|
"value": {
|
||||||
|
"Type": "Float32",
|
||||||
|
"Value": 15.0
|
||||||
|
},
|
||||||
|
"ty": "Float32"
|
||||||
|
},
|
||||||
|
"Float64": {
|
||||||
|
"value": {
|
||||||
|
"Type": "Float64",
|
||||||
|
"Value": 15123.0
|
||||||
|
},
|
||||||
|
"ty": "Float64"
|
||||||
|
},
|
||||||
|
"Int32": {
|
||||||
|
"value": {
|
||||||
|
"Type": "Int32",
|
||||||
|
"Value": 6014
|
||||||
|
},
|
||||||
|
"ty": "Int32"
|
||||||
|
},
|
||||||
|
"Int64": {
|
||||||
|
"value": {
|
||||||
|
"Type": "Int64",
|
||||||
|
"Value": 23491023
|
||||||
|
},
|
||||||
|
"ty": "Int64"
|
||||||
|
},
|
||||||
|
"NumberRange": {
|
||||||
|
"value": {
|
||||||
|
"Type": "NumberRange",
|
||||||
|
"Value": [
|
||||||
|
-36.0,
|
||||||
|
94.0
|
||||||
|
]
|
||||||
|
},
|
||||||
|
"ty": "NumberRange"
|
||||||
|
},
|
||||||
|
"NumberSequence": {
|
||||||
|
"value": {
|
||||||
|
"Type": "NumberSequence",
|
||||||
|
"Value": {
|
||||||
|
"Keypoints": [
|
||||||
|
{
|
||||||
|
"Time": 0.0,
|
||||||
|
"Value": 5.0,
|
||||||
|
"Envelope": 2.0
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"Time": 1.0,
|
||||||
|
"Value": 22.0,
|
||||||
|
"Envelope": 0.0
|
||||||
|
}
|
||||||
|
]
|
||||||
|
}
|
||||||
|
},
|
||||||
|
"ty": "NumberSequence"
|
||||||
|
},
|
||||||
|
"PhysicalProperties-Custom": {
|
||||||
|
"value": {
|
||||||
|
"Type": "PhysicalProperties",
|
||||||
|
"Value": {
|
||||||
|
"Density": 0.5,
|
||||||
|
"Friction": 1.0,
|
||||||
|
"Elasticity": 0.0,
|
||||||
|
"FrictionWeight": 50.0,
|
||||||
|
"ElasticityWeight": 25.0
|
||||||
|
}
|
||||||
|
},
|
||||||
|
"ty": "PhysicalProperties"
|
||||||
|
},
|
||||||
|
"PhysicalProperties-Default": {
|
||||||
|
"value": {
|
||||||
|
"Type": "PhysicalProperties",
|
||||||
|
"Value": "Default"
|
||||||
|
},
|
||||||
|
"ty": "PhysicalProperties"
|
||||||
|
},
|
||||||
|
"Ray": {
|
||||||
|
"value": {
|
||||||
|
"Type": "Ray",
|
||||||
|
"Value": {
|
||||||
|
"Origin": [
|
||||||
|
1.0,
|
||||||
|
2.0,
|
||||||
|
3.0
|
||||||
|
],
|
||||||
|
"Direction": [
|
||||||
|
4.0,
|
||||||
|
5.0,
|
||||||
|
6.0
|
||||||
|
]
|
||||||
|
}
|
||||||
|
},
|
||||||
|
"ty": "Ray"
|
||||||
|
},
|
||||||
|
"Rect": {
|
||||||
|
"value": {
|
||||||
|
"Type": "Rect",
|
||||||
|
"Value": [
|
||||||
|
[
|
||||||
|
0.0,
|
||||||
|
5.0
|
||||||
|
],
|
||||||
|
[
|
||||||
|
10.0,
|
||||||
|
15.0
|
||||||
|
]
|
||||||
|
]
|
||||||
|
},
|
||||||
|
"ty": "Rect"
|
||||||
|
},
|
||||||
|
"Region3int16": {
|
||||||
|
"value": {
|
||||||
|
"Type": "Region3int16",
|
||||||
|
"Value": [
|
||||||
|
[
|
||||||
|
-10,
|
||||||
|
-5,
|
||||||
|
0
|
||||||
|
],
|
||||||
|
[
|
||||||
|
5,
|
||||||
|
10,
|
||||||
|
15
|
||||||
|
]
|
||||||
|
]
|
||||||
|
},
|
||||||
|
"ty": "Region3int16"
|
||||||
|
},
|
||||||
|
"String": {
|
||||||
|
"value": {
|
||||||
|
"Type": "String",
|
||||||
|
"Value": "Hello, world!"
|
||||||
|
},
|
||||||
|
"ty": "String"
|
||||||
|
},
|
||||||
|
"UDim": {
|
||||||
|
"value": {
|
||||||
|
"Type": "UDim",
|
||||||
|
"Value": [
|
||||||
|
1.0,
|
||||||
|
32
|
||||||
|
]
|
||||||
|
},
|
||||||
|
"ty": "UDim"
|
||||||
|
},
|
||||||
|
"UDim2": {
|
||||||
|
"value": {
|
||||||
|
"Type": "UDim2",
|
||||||
|
"Value": [
|
||||||
|
[
|
||||||
|
-1.0,
|
||||||
|
100
|
||||||
|
],
|
||||||
|
[
|
||||||
|
1.0,
|
||||||
|
-100
|
||||||
|
]
|
||||||
|
]
|
||||||
|
},
|
||||||
|
"ty": "UDim2"
|
||||||
|
},
|
||||||
|
"Vector2": {
|
||||||
|
"value": {
|
||||||
|
"Type": "Vector2",
|
||||||
|
"Value": [
|
||||||
|
-50.0,
|
||||||
|
50.0
|
||||||
|
]
|
||||||
|
},
|
||||||
|
"ty": "Vector2"
|
||||||
|
},
|
||||||
|
"Vector2int16": {
|
||||||
|
"value": {
|
||||||
|
"Type": "Vector2int16",
|
||||||
|
"Value": [
|
||||||
|
-300,
|
||||||
|
300
|
||||||
|
]
|
||||||
|
},
|
||||||
|
"ty": "Vector2int16"
|
||||||
|
},
|
||||||
|
"Vector3": {
|
||||||
|
"value": {
|
||||||
|
"Type": "Vector3",
|
||||||
|
"Value": [
|
||||||
|
-300.0,
|
||||||
|
0.0,
|
||||||
|
1500.0
|
||||||
|
]
|
||||||
|
},
|
||||||
|
"ty": "Vector3"
|
||||||
|
},
|
||||||
|
"Vector3int16": {
|
||||||
|
"value": {
|
||||||
|
"Type": "Vector3int16",
|
||||||
|
"Value": [
|
||||||
|
60,
|
||||||
|
37,
|
||||||
|
-450
|
||||||
|
]
|
||||||
|
},
|
||||||
|
"ty": "Vector3int16"
|
||||||
|
}
|
||||||
|
}
|
||||||
44022
plugin/rbx_dom_lua/src/database.json
Normal file
44022
plugin/rbx_dom_lua/src/database.json
Normal file
File diff suppressed because it is too large
Load Diff
@@ -1,4 +1,4 @@
|
|||||||
local ReflectionDatabase = require(script.ReflectionDatabase)
|
local database = require(script.database)
|
||||||
local Error = require(script.Error)
|
local Error = require(script.Error)
|
||||||
local PropertyDescriptor = require(script.PropertyDescriptor)
|
local PropertyDescriptor = require(script.PropertyDescriptor)
|
||||||
|
|
||||||
@@ -6,29 +6,31 @@ local function findCanonicalPropertyDescriptor(className, propertyName)
|
|||||||
local currentClassName = className
|
local currentClassName = className
|
||||||
|
|
||||||
repeat
|
repeat
|
||||||
local currentClass = ReflectionDatabase.classes[currentClassName]
|
local currentClass = database.Classes[currentClassName]
|
||||||
|
|
||||||
if currentClass == nil then
|
if currentClass == nil then
|
||||||
return currentClass
|
return currentClass
|
||||||
end
|
end
|
||||||
|
|
||||||
local propertyData = currentClass.properties[propertyName]
|
local propertyData = currentClass.Properties[propertyName]
|
||||||
if propertyData ~= nil then
|
if propertyData ~= nil then
|
||||||
if propertyData.isCanonical then
|
local canonicalData = propertyData.Kind.Canonical
|
||||||
|
if canonicalData ~= nil then
|
||||||
return PropertyDescriptor.fromRaw(propertyData, currentClassName, propertyName)
|
return PropertyDescriptor.fromRaw(propertyData, currentClassName, propertyName)
|
||||||
end
|
end
|
||||||
|
|
||||||
if propertyData.canonicalName ~= nil then
|
local aliasData = propertyData.Kind.Alias
|
||||||
|
if aliasData ~= nil then
|
||||||
return PropertyDescriptor.fromRaw(
|
return PropertyDescriptor.fromRaw(
|
||||||
currentClass.properties[propertyData.canonicalName],
|
currentClass.properties[aliasData.AliasFor],
|
||||||
currentClassName,
|
currentClassName,
|
||||||
propertyData.canonicalName)
|
aliasData.AliasFor)
|
||||||
end
|
end
|
||||||
|
|
||||||
return nil
|
return nil
|
||||||
end
|
end
|
||||||
|
|
||||||
currentClassName = currentClass.superclass
|
currentClassName = currentClass.Superclass
|
||||||
until currentClassName == nil
|
until currentClassName == nil
|
||||||
|
|
||||||
return nil
|
return nil
|
||||||
|
|||||||
4
plugin/rbx_dom_lua/test
Normal file
4
plugin/rbx_dom_lua/test
Normal file
@@ -0,0 +1,4 @@
|
|||||||
|
#!/bin/sh
|
||||||
|
|
||||||
|
rojo build test-place.project.json -o TestPlace.rbxlx
|
||||||
|
run-in-roblox --script run-tests.lua --place TestPlace.rbxlx
|
||||||
@@ -16,7 +16,7 @@
|
|||||||
"$className": "ServerScriptService",
|
"$className": "ServerScriptService",
|
||||||
|
|
||||||
"Run Tests": {
|
"Run Tests": {
|
||||||
"$path": "test.server.lua"
|
"$path": "run-tests.lua"
|
||||||
}
|
}
|
||||||
},
|
},
|
||||||
"Players": {
|
"Players": {
|
||||||
|
|||||||
@@ -1,7 +0,0 @@
|
|||||||
local ReplicatedStorage = game:GetService("ReplicatedStorage")
|
|
||||||
|
|
||||||
local LIB_ROOT = ReplicatedStorage.RbxDom
|
|
||||||
|
|
||||||
local TestEZ = require(ReplicatedStorage.TestEZ)
|
|
||||||
|
|
||||||
TestEZ.TestBootstrap:run({LIB_ROOT})
|
|
||||||
@@ -5,9 +5,9 @@ local isDevBuild = script.Parent.Parent:FindFirstChild("ROJO_DEV_BUILD") ~= nil
|
|||||||
return strict("Config", {
|
return strict("Config", {
|
||||||
isDevBuild = isDevBuild,
|
isDevBuild = isDevBuild,
|
||||||
codename = "Epiphany",
|
codename = "Epiphany",
|
||||||
version = {6, 0, 2},
|
version = {7, 0, 0, "-alpha.2"},
|
||||||
expectedServerVersionString = "6.0 or newer",
|
expectedServerVersionString = "7.0 or newer",
|
||||||
protocolVersion = 3,
|
protocolVersion = 4,
|
||||||
defaultHost = "localhost",
|
defaultHost = "localhost",
|
||||||
defaultPort = 34872,
|
defaultPort = 34872,
|
||||||
})
|
})
|
||||||
@@ -10,7 +10,7 @@ expression: contents
|
|||||||
<Item class="IntValue" referent="1">
|
<Item class="IntValue" referent="1">
|
||||||
<Properties>
|
<Properties>
|
||||||
<string name="Name">simple-model</string>
|
<string name="Name">simple-model</string>
|
||||||
<int name="Value">5</int>
|
<int64 name="Value">5</int64>
|
||||||
</Properties>
|
</Properties>
|
||||||
<Item class="Folder" referent="2">
|
<Item class="Folder" referent="2">
|
||||||
<Properties>
|
<Properties>
|
||||||
|
|||||||
@@ -0,0 +1,55 @@
|
|||||||
|
---
|
||||||
|
source: tests/tests/build.rs
|
||||||
|
expression: contents
|
||||||
|
---
|
||||||
|
<roblox version="4">
|
||||||
|
<Item class="DataModel" referent="0">
|
||||||
|
<Properties>
|
||||||
|
<string name="Name">unresolved-values</string>
|
||||||
|
</Properties>
|
||||||
|
<Item class="Lighting" referent="1">
|
||||||
|
<Properties>
|
||||||
|
<string name="Name">Lighting</string>
|
||||||
|
<Color3 name="Ambient">
|
||||||
|
<R>1</R>
|
||||||
|
<G>0</G>
|
||||||
|
<B>0</B>
|
||||||
|
</Color3>
|
||||||
|
<token name="Technology">1</token>
|
||||||
|
</Properties>
|
||||||
|
</Item>
|
||||||
|
<Item class="Workspace" referent="2">
|
||||||
|
<Properties>
|
||||||
|
<string name="Name">Workspace</string>
|
||||||
|
</Properties>
|
||||||
|
<Item class="BoolValue" referent="3">
|
||||||
|
<Properties>
|
||||||
|
<string name="Name">Bool</string>
|
||||||
|
<bool name="Value">true</bool>
|
||||||
|
</Properties>
|
||||||
|
</Item>
|
||||||
|
<Item class="Part" referent="4">
|
||||||
|
<Properties>
|
||||||
|
<string name="Name">Color</string>
|
||||||
|
<Color3 name="Color3uint8">
|
||||||
|
<R>0.5</R>
|
||||||
|
<G>0.25</G>
|
||||||
|
<B>0</B>
|
||||||
|
</Color3>
|
||||||
|
</Properties>
|
||||||
|
</Item>
|
||||||
|
<Item class="NumberValue" referent="5">
|
||||||
|
<Properties>
|
||||||
|
<string name="Name">Float</string>
|
||||||
|
<double name="Value">123.5</double>
|
||||||
|
</Properties>
|
||||||
|
</Item>
|
||||||
|
<Item class="IntValue" referent="6">
|
||||||
|
<Properties>
|
||||||
|
<string name="Name">Int</string>
|
||||||
|
<int64 name="Value">65</int64>
|
||||||
|
</Properties>
|
||||||
|
</Item>
|
||||||
|
</Item>
|
||||||
|
</Item>
|
||||||
|
</roblox>
|
||||||
43
rojo-test/build-tests/unresolved_values/default.project.json
Normal file
43
rojo-test/build-tests/unresolved_values/default.project.json
Normal file
@@ -0,0 +1,43 @@
|
|||||||
|
{
|
||||||
|
"name": "unresolved-values",
|
||||||
|
"tree": {
|
||||||
|
"$className": "DataModel",
|
||||||
|
|
||||||
|
"Lighting": {
|
||||||
|
"$properties": {
|
||||||
|
"Technology": "Voxel",
|
||||||
|
"Ambient": [1, 0, 0]
|
||||||
|
}
|
||||||
|
},
|
||||||
|
|
||||||
|
"Workspace": {
|
||||||
|
"Color": {
|
||||||
|
"$className": "Part",
|
||||||
|
"$properties": {
|
||||||
|
"Color": [0.5, 0.25, 0]
|
||||||
|
}
|
||||||
|
},
|
||||||
|
|
||||||
|
"Bool": {
|
||||||
|
"$className": "BoolValue",
|
||||||
|
"$properties": {
|
||||||
|
"Value": true
|
||||||
|
}
|
||||||
|
},
|
||||||
|
|
||||||
|
"Int": {
|
||||||
|
"$className": "IntValue",
|
||||||
|
"$properties": {
|
||||||
|
"Value": 65
|
||||||
|
}
|
||||||
|
},
|
||||||
|
|
||||||
|
"Float": {
|
||||||
|
"$className": "NumberValue",
|
||||||
|
"$properties": {
|
||||||
|
"Value": 123.5
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -11,7 +11,7 @@ instances:
|
|||||||
Metadata:
|
Metadata:
|
||||||
ignoreUnknownInstances: false
|
ignoreUnknownInstances: false
|
||||||
Name: add_folder
|
Name: add_folder
|
||||||
Parent: ~
|
Parent: "00000000000000000000000000000000"
|
||||||
Properties: {}
|
Properties: {}
|
||||||
id-3:
|
id-3:
|
||||||
Children: []
|
Children: []
|
||||||
|
|||||||
@@ -10,7 +10,7 @@ instances:
|
|||||||
Metadata:
|
Metadata:
|
||||||
ignoreUnknownInstances: false
|
ignoreUnknownInstances: false
|
||||||
Name: add_folder
|
Name: add_folder
|
||||||
Parent: ~
|
Parent: "00000000000000000000000000000000"
|
||||||
Properties: {}
|
Properties: {}
|
||||||
messageCursor: 0
|
messageCursor: 0
|
||||||
sessionId: id-1
|
sessionId: id-1
|
||||||
|
|||||||
@@ -1,10 +1,12 @@
|
|||||||
---
|
---
|
||||||
source: tests/tests/serve.rs
|
source: tests/tests/serve.rs
|
||||||
expression: redactions.redacted_yaml(info)
|
expression: redactions.redacted_yaml(info)
|
||||||
|
|
||||||
---
|
---
|
||||||
expectedPlaceIds: ~
|
expectedPlaceIds: ~
|
||||||
projectName: add_folder
|
projectName: add_folder
|
||||||
protocolVersion: 3
|
protocolVersion: 4
|
||||||
rootInstanceId: id-2
|
rootInstanceId: id-2
|
||||||
serverVersion: "[server-version]"
|
serverVersion: "[server-version]"
|
||||||
sessionId: id-1
|
sessionId: id-1
|
||||||
|
|
||||||
|
|||||||
@@ -10,7 +10,7 @@ instances:
|
|||||||
Metadata:
|
Metadata:
|
||||||
ignoreUnknownInstances: false
|
ignoreUnknownInstances: false
|
||||||
Name: edit_init
|
Name: edit_init
|
||||||
Parent: ~
|
Parent: "00000000000000000000000000000000"
|
||||||
Properties:
|
Properties:
|
||||||
Source:
|
Source:
|
||||||
Type: String
|
Type: String
|
||||||
|
|||||||
@@ -10,7 +10,7 @@ instances:
|
|||||||
Metadata:
|
Metadata:
|
||||||
ignoreUnknownInstances: false
|
ignoreUnknownInstances: false
|
||||||
Name: edit_init
|
Name: edit_init
|
||||||
Parent: ~
|
Parent: "00000000000000000000000000000000"
|
||||||
Properties:
|
Properties:
|
||||||
Source:
|
Source:
|
||||||
Type: String
|
Type: String
|
||||||
|
|||||||
@@ -1,10 +1,12 @@
|
|||||||
---
|
---
|
||||||
source: tests/tests/serve.rs
|
source: tests/tests/serve.rs
|
||||||
expression: redactions.redacted_yaml(info)
|
expression: redactions.redacted_yaml(info)
|
||||||
|
|
||||||
---
|
---
|
||||||
expectedPlaceIds: ~
|
expectedPlaceIds: ~
|
||||||
projectName: edit_init
|
projectName: edit_init
|
||||||
protocolVersion: 3
|
protocolVersion: 4
|
||||||
rootInstanceId: id-2
|
rootInstanceId: id-2
|
||||||
serverVersion: "[server-version]"
|
serverVersion: "[server-version]"
|
||||||
sessionId: id-1
|
sessionId: id-1
|
||||||
|
|
||||||
|
|||||||
@@ -10,7 +10,7 @@ instances:
|
|||||||
Metadata:
|
Metadata:
|
||||||
ignoreUnknownInstances: true
|
ignoreUnknownInstances: true
|
||||||
Name: empty
|
Name: empty
|
||||||
Parent: ~
|
Parent: "00000000000000000000000000000000"
|
||||||
Properties: {}
|
Properties: {}
|
||||||
messageCursor: 0
|
messageCursor: 0
|
||||||
sessionId: id-1
|
sessionId: id-1
|
||||||
|
|||||||
@@ -1,10 +1,12 @@
|
|||||||
---
|
---
|
||||||
source: tests/tests/serve.rs
|
source: tests/tests/serve.rs
|
||||||
expression: redactions.redacted_yaml(info)
|
expression: redactions.redacted_yaml(info)
|
||||||
|
|
||||||
---
|
---
|
||||||
expectedPlaceIds: ~
|
expectedPlaceIds: ~
|
||||||
projectName: empty
|
projectName: empty
|
||||||
protocolVersion: 3
|
protocolVersion: 4
|
||||||
rootInstanceId: id-2
|
rootInstanceId: id-2
|
||||||
serverVersion: "[server-version]"
|
serverVersion: "[server-version]"
|
||||||
sessionId: id-1
|
sessionId: id-1
|
||||||
|
|
||||||
|
|||||||
@@ -59,7 +59,7 @@ instances:
|
|||||||
Metadata:
|
Metadata:
|
||||||
ignoreUnknownInstances: false
|
ignoreUnknownInstances: false
|
||||||
Name: move_folder_of_stuff
|
Name: move_folder_of_stuff
|
||||||
Parent: ~
|
Parent: "00000000000000000000000000000000"
|
||||||
Properties: {}
|
Properties: {}
|
||||||
id-3:
|
id-3:
|
||||||
Children:
|
Children:
|
||||||
|
|||||||
@@ -10,7 +10,7 @@ instances:
|
|||||||
Metadata:
|
Metadata:
|
||||||
ignoreUnknownInstances: false
|
ignoreUnknownInstances: false
|
||||||
Name: move_folder_of_stuff
|
Name: move_folder_of_stuff
|
||||||
Parent: ~
|
Parent: "00000000000000000000000000000000"
|
||||||
Properties: {}
|
Properties: {}
|
||||||
messageCursor: 0
|
messageCursor: 0
|
||||||
sessionId: id-1
|
sessionId: id-1
|
||||||
|
|||||||
@@ -1,10 +1,12 @@
|
|||||||
---
|
---
|
||||||
source: tests/tests/serve.rs
|
source: tests/tests/serve.rs
|
||||||
expression: redactions.redacted_yaml(info)
|
expression: redactions.redacted_yaml(info)
|
||||||
|
|
||||||
---
|
---
|
||||||
expectedPlaceIds: ~
|
expectedPlaceIds: ~
|
||||||
projectName: move_folder_of_stuff
|
projectName: move_folder_of_stuff
|
||||||
protocolVersion: 3
|
protocolVersion: 4
|
||||||
rootInstanceId: id-2
|
rootInstanceId: id-2
|
||||||
serverVersion: "[server-version]"
|
serverVersion: "[server-version]"
|
||||||
sessionId: id-1
|
sessionId: id-1
|
||||||
|
|
||||||
|
|||||||
@@ -10,7 +10,7 @@ instances:
|
|||||||
Metadata:
|
Metadata:
|
||||||
ignoreUnknownInstances: false
|
ignoreUnknownInstances: false
|
||||||
Name: remove_file
|
Name: remove_file
|
||||||
Parent: ~
|
Parent: "00000000000000000000000000000000"
|
||||||
Properties: {}
|
Properties: {}
|
||||||
messageCursor: 1
|
messageCursor: 1
|
||||||
sessionId: id-1
|
sessionId: id-1
|
||||||
|
|||||||
@@ -11,7 +11,7 @@ instances:
|
|||||||
Metadata:
|
Metadata:
|
||||||
ignoreUnknownInstances: false
|
ignoreUnknownInstances: false
|
||||||
Name: remove_file
|
Name: remove_file
|
||||||
Parent: ~
|
Parent: "00000000000000000000000000000000"
|
||||||
Properties: {}
|
Properties: {}
|
||||||
id-3:
|
id-3:
|
||||||
Children: []
|
Children: []
|
||||||
|
|||||||
@@ -1,10 +1,12 @@
|
|||||||
---
|
---
|
||||||
source: tests/tests/serve.rs
|
source: tests/tests/serve.rs
|
||||||
expression: redactions.redacted_yaml(info)
|
expression: redactions.redacted_yaml(info)
|
||||||
|
|
||||||
---
|
---
|
||||||
expectedPlaceIds: ~
|
expectedPlaceIds: ~
|
||||||
projectName: remove_file
|
projectName: remove_file
|
||||||
protocolVersion: 3
|
protocolVersion: 4
|
||||||
rootInstanceId: id-2
|
rootInstanceId: id-2
|
||||||
serverVersion: "[server-version]"
|
serverVersion: "[server-version]"
|
||||||
sessionId: id-1
|
sessionId: id-1
|
||||||
|
|
||||||
|
|||||||
@@ -12,7 +12,7 @@ instances:
|
|||||||
Metadata:
|
Metadata:
|
||||||
ignoreUnknownInstances: false
|
ignoreUnknownInstances: false
|
||||||
Name: scripts
|
Name: scripts
|
||||||
Parent: ~
|
Parent: "00000000000000000000000000000000"
|
||||||
Properties: {}
|
Properties: {}
|
||||||
id-3:
|
id-3:
|
||||||
Children: []
|
Children: []
|
||||||
|
|||||||
@@ -12,7 +12,7 @@ instances:
|
|||||||
Metadata:
|
Metadata:
|
||||||
ignoreUnknownInstances: false
|
ignoreUnknownInstances: false
|
||||||
Name: scripts
|
Name: scripts
|
||||||
Parent: ~
|
Parent: "00000000000000000000000000000000"
|
||||||
Properties: {}
|
Properties: {}
|
||||||
id-3:
|
id-3:
|
||||||
Children: []
|
Children: []
|
||||||
|
|||||||
@@ -1,10 +1,12 @@
|
|||||||
---
|
---
|
||||||
source: tests/tests/serve.rs
|
source: tests/tests/serve.rs
|
||||||
expression: redactions.redacted_yaml(info)
|
expression: redactions.redacted_yaml(info)
|
||||||
|
|
||||||
---
|
---
|
||||||
expectedPlaceIds: ~
|
expectedPlaceIds: ~
|
||||||
projectName: scripts
|
projectName: scripts
|
||||||
protocolVersion: 3
|
protocolVersion: 4
|
||||||
rootInstanceId: id-2
|
rootInstanceId: id-2
|
||||||
serverVersion: "[server-version]"
|
serverVersion: "[server-version]"
|
||||||
sessionId: id-1
|
sessionId: id-1
|
||||||
|
|
||||||
|
|||||||
@@ -6,7 +6,7 @@ use std::{
|
|||||||
use crossbeam_channel::{select, Receiver, RecvError, Sender};
|
use crossbeam_channel::{select, Receiver, RecvError, Sender};
|
||||||
use jod_thread::JoinHandle;
|
use jod_thread::JoinHandle;
|
||||||
use memofs::{IoResultExt, Vfs, VfsEvent};
|
use memofs::{IoResultExt, Vfs, VfsEvent};
|
||||||
use rbx_dom_weak::{RbxId, RbxValue};
|
use rbx_dom_weak::types::{Ref, Variant};
|
||||||
|
|
||||||
use crate::{
|
use crate::{
|
||||||
message_queue::MessageQueue,
|
message_queue::MessageQueue,
|
||||||
@@ -179,7 +179,7 @@ impl JobThreadContext {
|
|||||||
InstigatingSource::Path(path) => fs::remove_file(path).unwrap(),
|
InstigatingSource::Path(path) => fs::remove_file(path).unwrap(),
|
||||||
InstigatingSource::ProjectNode(_, _, _, _) => {
|
InstigatingSource::ProjectNode(_, _, _, _) => {
|
||||||
log::warn!(
|
log::warn!(
|
||||||
"Cannot remove instance {}, it's from a project file",
|
"Cannot remove instance {:?}, it's from a project file",
|
||||||
id
|
id
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
@@ -187,12 +187,12 @@ impl JobThreadContext {
|
|||||||
} else {
|
} else {
|
||||||
// TODO
|
// TODO
|
||||||
log::warn!(
|
log::warn!(
|
||||||
"Cannot remove instance {}, it is not an instigating source.",
|
"Cannot remove instance {:?}, it is not an instigating source.",
|
||||||
id
|
id
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
} else {
|
} else {
|
||||||
log::warn!("Cannot remove instance {}, it does not exist.", id);
|
log::warn!("Cannot remove instance {:?}, it does not exist.", id);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -219,7 +219,7 @@ impl JobThreadContext {
|
|||||||
{
|
{
|
||||||
match instigating_source {
|
match instigating_source {
|
||||||
InstigatingSource::Path(path) => {
|
InstigatingSource::Path(path) => {
|
||||||
if let Some(RbxValue::String { value }) = changed_value {
|
if let Some(Variant::String(value)) = changed_value {
|
||||||
fs::write(path, value).unwrap();
|
fs::write(path, value).unwrap();
|
||||||
} else {
|
} else {
|
||||||
log::warn!("Cannot change Source to non-string value.");
|
log::warn!("Cannot change Source to non-string value.");
|
||||||
@@ -227,14 +227,14 @@ impl JobThreadContext {
|
|||||||
}
|
}
|
||||||
InstigatingSource::ProjectNode(_, _, _, _) => {
|
InstigatingSource::ProjectNode(_, _, _, _) => {
|
||||||
log::warn!(
|
log::warn!(
|
||||||
"Cannot remove instance {}, it's from a project file",
|
"Cannot remove instance {:?}, it's from a project file",
|
||||||
id
|
id
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
} else {
|
} else {
|
||||||
log::warn!(
|
log::warn!(
|
||||||
"Cannot update instance {}, it is not an instigating source.",
|
"Cannot update instance {:?}, it is not an instigating source.",
|
||||||
id
|
id
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
@@ -243,7 +243,7 @@ impl JobThreadContext {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
} else {
|
} else {
|
||||||
log::warn!("Cannot update instance {}, it does not exist.", id);
|
log::warn!("Cannot update instance {:?}, it does not exist.", id);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -254,7 +254,7 @@ impl JobThreadContext {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
fn compute_and_apply_changes(tree: &mut RojoTree, vfs: &Vfs, id: RbxId) -> Option<AppliedPatchSet> {
|
fn compute_and_apply_changes(tree: &mut RojoTree, vfs: &Vfs, id: Ref) -> Option<AppliedPatchSet> {
|
||||||
let metadata = tree
|
let metadata = tree
|
||||||
.get_metadata(id)
|
.get_metadata(id)
|
||||||
.expect("metadata missing for instance present in tree");
|
.expect("metadata missing for instance present in tree");
|
||||||
@@ -263,7 +263,7 @@ fn compute_and_apply_changes(tree: &mut RojoTree, vfs: &Vfs, id: RbxId) -> Optio
|
|||||||
Some(path) => path,
|
Some(path) => path,
|
||||||
None => {
|
None => {
|
||||||
log::error!(
|
log::error!(
|
||||||
"Instance {} did not have an instigating source, but was considered for an update.",
|
"Instance {:?} did not have an instigating source, but was considered for an update.",
|
||||||
id
|
id
|
||||||
);
|
);
|
||||||
log::error!("This is a bug. Please file an issue!");
|
log::error!("This is a bug. Please file an issue!");
|
||||||
|
|||||||
@@ -88,7 +88,7 @@ fn write_model(tree: &RojoTree, options: &BuildCommand) -> Result<(), anyhow::Er
|
|||||||
}
|
}
|
||||||
OutputKind::Rbxlx => {
|
OutputKind::Rbxlx => {
|
||||||
// Place files don't contain an entry for the DataModel, but our
|
// Place files don't contain an entry for the DataModel, but our
|
||||||
// RbxTree representation does.
|
// WeakDom representation does.
|
||||||
|
|
||||||
let root_instance = tree.get_instance(root_id).unwrap();
|
let root_instance = tree.get_instance(root_id).unwrap();
|
||||||
let top_level_ids = root_instance.children();
|
let top_level_ids = root_instance.children();
|
||||||
@@ -96,17 +96,13 @@ fn write_model(tree: &RojoTree, options: &BuildCommand) -> Result<(), anyhow::Er
|
|||||||
rbx_xml::to_writer(&mut file, tree.inner(), top_level_ids, xml_encode_config())?;
|
rbx_xml::to_writer(&mut file, tree.inner(), top_level_ids, xml_encode_config())?;
|
||||||
}
|
}
|
||||||
OutputKind::Rbxm => {
|
OutputKind::Rbxm => {
|
||||||
rbx_binary::encode(tree.inner(), &[root_id], &mut file)?;
|
rbx_binary::to_writer_default(&mut file, tree.inner(), &[root_id])?;
|
||||||
}
|
}
|
||||||
OutputKind::Rbxl => {
|
OutputKind::Rbxl => {
|
||||||
log::warn!("Support for building binary places (rbxl) is still experimental.");
|
|
||||||
log::warn!("Using the XML place format (rbxlx) is recommended instead.");
|
|
||||||
log::warn!("For more info, see https://github.com/rojo-rbx/rojo/issues/180");
|
|
||||||
|
|
||||||
let root_instance = tree.get_instance(root_id).unwrap();
|
let root_instance = tree.get_instance(root_id).unwrap();
|
||||||
let top_level_ids = root_instance.children();
|
let top_level_ids = root_instance.children();
|
||||||
|
|
||||||
rbx_binary::encode(tree.inner(), top_level_ids, &mut file)?;
|
rbx_binary::to_writer_default(&mut file, tree.inner(), top_level_ids)?;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -12,6 +12,7 @@ use std::{
|
|||||||
env,
|
env,
|
||||||
error::Error,
|
error::Error,
|
||||||
fmt,
|
fmt,
|
||||||
|
net::IpAddr,
|
||||||
path::{Path, PathBuf},
|
path::{Path, PathBuf},
|
||||||
str::FromStr,
|
str::FromStr,
|
||||||
};
|
};
|
||||||
@@ -186,7 +187,11 @@ pub struct ServeCommand {
|
|||||||
#[structopt(default_value = "")]
|
#[structopt(default_value = "")]
|
||||||
pub project: PathBuf,
|
pub project: PathBuf,
|
||||||
|
|
||||||
/// The port to listen on. Defaults to the project's preference, or 34872 if
|
/// The IP address to listen on. Defaults to `127.0.0.1`.
|
||||||
|
#[structopt(long)]
|
||||||
|
pub address: Option<IpAddr>,
|
||||||
|
|
||||||
|
/// The port to listen on. Defaults to the project's preference, or `34872` if
|
||||||
/// it has none.
|
/// it has none.
|
||||||
#[structopt(long)]
|
#[structopt(long)]
|
||||||
pub port: Option<u16>,
|
pub port: Option<u16>,
|
||||||
|
|||||||
@@ -49,7 +49,7 @@ pub fn install_plugin() -> Result<()> {
|
|||||||
let tree = session.tree();
|
let tree = session.tree();
|
||||||
let root_id = tree.get_root_id();
|
let root_id = tree.get_root_id();
|
||||||
|
|
||||||
rbx_binary::encode(tree.inner(), &[root_id], &mut file)?;
|
rbx_binary::to_writer_default(&mut file, tree.inner(), &[root_id])?;
|
||||||
|
|
||||||
Ok(())
|
Ok(())
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -1,5 +1,7 @@
|
|||||||
use std::{
|
use std::{
|
||||||
io::{self, Write},
|
io::{self, Write},
|
||||||
|
net::IpAddr,
|
||||||
|
net::Ipv4Addr,
|
||||||
sync::Arc,
|
sync::Arc,
|
||||||
};
|
};
|
||||||
|
|
||||||
@@ -13,6 +15,7 @@ use crate::{
|
|||||||
web::LiveServer,
|
web::LiveServer,
|
||||||
};
|
};
|
||||||
|
|
||||||
|
const DEFAULT_BIND_ADDRESS: Ipv4Addr = Ipv4Addr::new(127, 0, 0, 1);
|
||||||
const DEFAULT_PORT: u16 = 34872;
|
const DEFAULT_PORT: u16 = 34872;
|
||||||
|
|
||||||
pub fn serve(global: GlobalOptions, options: ServeCommand) -> Result<()> {
|
pub fn serve(global: GlobalOptions, options: ServeCommand) -> Result<()> {
|
||||||
@@ -20,6 +23,8 @@ pub fn serve(global: GlobalOptions, options: ServeCommand) -> Result<()> {
|
|||||||
|
|
||||||
let session = Arc::new(ServeSession::new(vfs, &options.absolute_project())?);
|
let session = Arc::new(ServeSession::new(vfs, &options.absolute_project())?);
|
||||||
|
|
||||||
|
let ip = options.address.unwrap_or(DEFAULT_BIND_ADDRESS.into());
|
||||||
|
|
||||||
let port = options
|
let port = options
|
||||||
.port
|
.port
|
||||||
.or_else(|| session.project_port())
|
.or_else(|| session.project_port())
|
||||||
@@ -27,13 +32,13 @@ pub fn serve(global: GlobalOptions, options: ServeCommand) -> Result<()> {
|
|||||||
|
|
||||||
let server = LiveServer::new(session);
|
let server = LiveServer::new(session);
|
||||||
|
|
||||||
let _ = show_start_message(port, global.color.into());
|
let _ = show_start_message(ip, port, global.color.into());
|
||||||
server.start(port);
|
server.start((ip, port).into());
|
||||||
|
|
||||||
Ok(())
|
Ok(())
|
||||||
}
|
}
|
||||||
|
|
||||||
fn show_start_message(port: u16, color: ColorChoice) -> io::Result<()> {
|
fn show_start_message(bind_address: IpAddr, port: u16, color: ColorChoice) -> io::Result<()> {
|
||||||
let writer = BufferWriter::stdout(color);
|
let writer = BufferWriter::stdout(color);
|
||||||
let mut buffer = writer.buffer();
|
let mut buffer = writer.buffer();
|
||||||
|
|
||||||
@@ -41,7 +46,12 @@ fn show_start_message(port: u16, color: ColorChoice) -> io::Result<()> {
|
|||||||
|
|
||||||
write!(&mut buffer, " Address: ")?;
|
write!(&mut buffer, " Address: ")?;
|
||||||
buffer.set_color(ColorSpec::new().set_fg(Some(Color::Green)).set_bold(true))?;
|
buffer.set_color(ColorSpec::new().set_fg(Some(Color::Green)).set_bold(true))?;
|
||||||
writeln!(&mut buffer, "localhost")?;
|
|
||||||
|
if bind_address.is_loopback() {
|
||||||
|
writeln!(&mut buffer, "localhost")?;
|
||||||
|
} else {
|
||||||
|
writeln!(&mut buffer, "{}", bind_address)?;
|
||||||
|
}
|
||||||
|
|
||||||
buffer.set_color(&ColorSpec::new())?;
|
buffer.set_color(&ColorSpec::new())?;
|
||||||
write!(&mut buffer, " Port: ")?;
|
write!(&mut buffer, " Port: ")?;
|
||||||
|
|||||||
@@ -29,21 +29,17 @@ pub fn upload(options: UploadCommand) -> Result<(), anyhow::Error> {
|
|||||||
|
|
||||||
let tree = session.tree();
|
let tree = session.tree();
|
||||||
let inner_tree = tree.inner();
|
let inner_tree = tree.inner();
|
||||||
let root_id = inner_tree.get_root_id();
|
let root = inner_tree.root();
|
||||||
let root_instance = inner_tree.get_instance(root_id).unwrap();
|
|
||||||
|
|
||||||
let encode_ids = match root_instance.class_name.as_str() {
|
let encode_ids = match root.class.as_str() {
|
||||||
"DataModel" => root_instance.get_children_ids().to_vec(),
|
"DataModel" => root.children().to_vec(),
|
||||||
_ => vec![root_id],
|
_ => vec![root.referent()],
|
||||||
};
|
};
|
||||||
|
|
||||||
let mut buffer = Vec::new();
|
let mut buffer = Vec::new();
|
||||||
|
|
||||||
log::trace!("Encoding XML model");
|
log::trace!("Encoding binary model");
|
||||||
let config = rbx_xml::EncodeOptions::new()
|
rbx_binary::to_writer_default(&mut buffer, tree.inner(), &encode_ids)?;
|
||||||
.property_behavior(rbx_xml::EncodePropertyBehavior::WriteUnknown);
|
|
||||||
|
|
||||||
rbx_xml::to_writer(&mut buffer, tree.inner(), &encode_ids, config)?;
|
|
||||||
do_upload(buffer, options.asset_id, &cookie)
|
do_upload(buffer, options.asset_id, &cookie)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -15,6 +15,7 @@ mod message_queue;
|
|||||||
mod multimap;
|
mod multimap;
|
||||||
mod path_serializer;
|
mod path_serializer;
|
||||||
mod project;
|
mod project;
|
||||||
|
mod resolution;
|
||||||
mod serve_session;
|
mod serve_session;
|
||||||
mod session_id;
|
mod session_id;
|
||||||
mod snapshot;
|
mod snapshot;
|
||||||
|
|||||||
@@ -4,11 +4,10 @@ use std::{
|
|||||||
path::{Path, PathBuf},
|
path::{Path, PathBuf},
|
||||||
};
|
};
|
||||||
|
|
||||||
use rbx_dom_weak::UnresolvedRbxValue;
|
|
||||||
use serde::{Deserialize, Serialize};
|
use serde::{Deserialize, Serialize};
|
||||||
use thiserror::Error;
|
use thiserror::Error;
|
||||||
|
|
||||||
use crate::glob::Glob;
|
use crate::{glob::Glob, resolution::UnresolvedValue};
|
||||||
|
|
||||||
static PROJECT_FILENAME: &str = "default.project.json";
|
static PROJECT_FILENAME: &str = "default.project.json";
|
||||||
|
|
||||||
@@ -183,7 +182,7 @@ pub struct ProjectNode {
|
|||||||
default,
|
default,
|
||||||
skip_serializing_if = "HashMap::is_empty"
|
skip_serializing_if = "HashMap::is_empty"
|
||||||
)]
|
)]
|
||||||
pub properties: HashMap<String, UnresolvedRbxValue>,
|
pub properties: HashMap<String, UnresolvedValue>,
|
||||||
|
|
||||||
/// Defines the behavior when Rojo encounters unknown instances in Roblox
|
/// Defines the behavior when Rojo encounters unknown instances in Roblox
|
||||||
/// Studio during live sync. `$ignoreUnknownInstances` should be considered
|
/// Studio during live sync. `$ignoreUnknownInstances` should be considered
|
||||||
|
|||||||
157
src/resolution.rs
Normal file
157
src/resolution.rs
Normal file
@@ -0,0 +1,157 @@
|
|||||||
|
use anyhow::format_err;
|
||||||
|
use rbx_dom_weak::types::{
|
||||||
|
Color3, Color3uint8, Content, Enum, Variant, VariantType, Vector2, Vector3,
|
||||||
|
};
|
||||||
|
use rbx_reflection::{DataType, PropertyDescriptor};
|
||||||
|
use serde::{Deserialize, Serialize};
|
||||||
|
|
||||||
|
#[derive(Debug, Clone, PartialEq, Serialize, Deserialize)]
|
||||||
|
#[serde(untagged)]
|
||||||
|
pub enum UnresolvedValue {
|
||||||
|
FullyQualified(Variant),
|
||||||
|
Ambiguous(AmbiguousValue),
|
||||||
|
}
|
||||||
|
|
||||||
|
impl UnresolvedValue {
|
||||||
|
pub fn resolve(self, class_name: &str, prop_name: &str) -> anyhow::Result<Variant> {
|
||||||
|
match self {
|
||||||
|
UnresolvedValue::FullyQualified(full) => Ok(full),
|
||||||
|
UnresolvedValue::Ambiguous(partial) => partial.resolve(class_name, prop_name),
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
#[derive(Debug, Clone, PartialEq, Serialize, Deserialize)]
|
||||||
|
#[serde(untagged)]
|
||||||
|
pub enum AmbiguousValue {
|
||||||
|
Bool(bool),
|
||||||
|
String(String),
|
||||||
|
Number(f64),
|
||||||
|
Array2([f64; 2]),
|
||||||
|
Array3([f64; 3]),
|
||||||
|
Array4([f64; 4]),
|
||||||
|
}
|
||||||
|
|
||||||
|
impl AmbiguousValue {
|
||||||
|
pub fn resolve(self, class_name: &str, prop_name: &str) -> anyhow::Result<Variant> {
|
||||||
|
let property = find_descriptor(class_name, prop_name)
|
||||||
|
.ok_or_else(|| format_err!("Unknown property {}.{}", class_name, prop_name))?;
|
||||||
|
|
||||||
|
match &property.data_type {
|
||||||
|
DataType::Enum(enum_name) => {
|
||||||
|
let database = rbx_reflection_database::get();
|
||||||
|
|
||||||
|
let enum_descriptor = database.enums.get(enum_name).ok_or_else(|| {
|
||||||
|
format_err!("Unknown enum {}. This is a Rojo bug!", enum_name)
|
||||||
|
})?;
|
||||||
|
|
||||||
|
let error = |what: &str| {
|
||||||
|
let sample_values = enum_descriptor
|
||||||
|
.items
|
||||||
|
.keys()
|
||||||
|
.take(3)
|
||||||
|
.map(|name| format!(r#""{}""#, name))
|
||||||
|
.collect::<Vec<_>>()
|
||||||
|
.join(", ");
|
||||||
|
|
||||||
|
format_err!(
|
||||||
|
"Invalid value for property {}.{}. Got {} but \
|
||||||
|
expected a member of the {} enum such as {}",
|
||||||
|
class_name,
|
||||||
|
prop_name,
|
||||||
|
what,
|
||||||
|
enum_name,
|
||||||
|
sample_values
|
||||||
|
)
|
||||||
|
};
|
||||||
|
|
||||||
|
let value = match self {
|
||||||
|
AmbiguousValue::String(value) => value,
|
||||||
|
unresolved => return Err(error(unresolved.describe())),
|
||||||
|
};
|
||||||
|
|
||||||
|
let resolved = enum_descriptor
|
||||||
|
.items
|
||||||
|
.get(value.as_str())
|
||||||
|
.ok_or_else(|| error(value.as_str()))?;
|
||||||
|
|
||||||
|
Ok(Enum::from_u32(*resolved).into())
|
||||||
|
}
|
||||||
|
DataType::Value(variant_ty) => match (variant_ty, self) {
|
||||||
|
(VariantType::Bool, AmbiguousValue::Bool(value)) => Ok(value.into()),
|
||||||
|
|
||||||
|
(VariantType::Float32, AmbiguousValue::Number(value)) => Ok((value as f32).into()),
|
||||||
|
(VariantType::Float64, AmbiguousValue::Number(value)) => Ok(value.into()),
|
||||||
|
(VariantType::Int32, AmbiguousValue::Number(value)) => Ok((value as i32).into()),
|
||||||
|
(VariantType::Int64, AmbiguousValue::Number(value)) => Ok((value as i64).into()),
|
||||||
|
|
||||||
|
(VariantType::String, AmbiguousValue::String(value)) => Ok(value.into()),
|
||||||
|
(VariantType::Content, AmbiguousValue::String(value)) => {
|
||||||
|
Ok(Content::from(value).into())
|
||||||
|
}
|
||||||
|
|
||||||
|
(VariantType::Vector2, AmbiguousValue::Array2(value)) => {
|
||||||
|
Ok(Vector2::new(value[0] as f32, value[1] as f32).into())
|
||||||
|
}
|
||||||
|
|
||||||
|
(VariantType::Vector3, AmbiguousValue::Array3(value)) => {
|
||||||
|
Ok(Vector3::new(value[0] as f32, value[1] as f32, value[2] as f32).into())
|
||||||
|
}
|
||||||
|
|
||||||
|
(VariantType::Color3, AmbiguousValue::Array3(value)) => {
|
||||||
|
Ok(Color3::new(value[0] as f32, value[1] as f32, value[2] as f32).into())
|
||||||
|
}
|
||||||
|
(VariantType::Color3uint8, AmbiguousValue::Array3(value)) => {
|
||||||
|
let value = Color3uint8::new(
|
||||||
|
(value[0] / 255.0) as u8,
|
||||||
|
(value[1] / 255.0) as u8,
|
||||||
|
(value[2] / 255.0) as u8,
|
||||||
|
);
|
||||||
|
|
||||||
|
Ok(value.into())
|
||||||
|
}
|
||||||
|
|
||||||
|
(_, unresolved) => Err(format_err!(
|
||||||
|
"Wrong type of value for property {}.{}. Expected {:?}, got {}",
|
||||||
|
class_name,
|
||||||
|
prop_name,
|
||||||
|
variant_ty,
|
||||||
|
unresolved.describe(),
|
||||||
|
)),
|
||||||
|
},
|
||||||
|
_ => Err(format_err!(
|
||||||
|
"Unknown data type for property {}.{}",
|
||||||
|
class_name,
|
||||||
|
prop_name
|
||||||
|
)),
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
fn describe(&self) -> &'static str {
|
||||||
|
match self {
|
||||||
|
AmbiguousValue::Bool(_) => "a bool",
|
||||||
|
AmbiguousValue::String(_) => "a string",
|
||||||
|
AmbiguousValue::Number(_) => "a number",
|
||||||
|
AmbiguousValue::Array2(_) => "an array of two numbers",
|
||||||
|
AmbiguousValue::Array3(_) => "an array of three numbers",
|
||||||
|
AmbiguousValue::Array4(_) => "an array of four numbers",
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
fn find_descriptor(
|
||||||
|
class_name: &str,
|
||||||
|
prop_name: &str,
|
||||||
|
) -> Option<&'static PropertyDescriptor<'static>> {
|
||||||
|
let database = rbx_reflection_database::get();
|
||||||
|
let mut current_class_name = class_name;
|
||||||
|
|
||||||
|
loop {
|
||||||
|
let class = database.classes.get(current_class_name)?;
|
||||||
|
if let Some(descriptor) = class.properties.get(prop_name) {
|
||||||
|
return Some(descriptor);
|
||||||
|
}
|
||||||
|
|
||||||
|
current_class_name = class.superclass.as_deref()?;
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -10,7 +10,6 @@ use std::{
|
|||||||
use crossbeam_channel::Sender;
|
use crossbeam_channel::Sender;
|
||||||
use memofs::IoResultExt;
|
use memofs::IoResultExt;
|
||||||
use memofs::Vfs;
|
use memofs::Vfs;
|
||||||
use rbx_dom_weak::RbxInstanceProperties;
|
|
||||||
use thiserror::Error;
|
use thiserror::Error;
|
||||||
|
|
||||||
use crate::{
|
use crate::{
|
||||||
@@ -19,8 +18,8 @@ use crate::{
|
|||||||
project::{Project, ProjectError},
|
project::{Project, ProjectError},
|
||||||
session_id::SessionId,
|
session_id::SessionId,
|
||||||
snapshot::{
|
snapshot::{
|
||||||
apply_patch_set, compute_patch_set, AppliedPatchSet, InstanceContext,
|
apply_patch_set, compute_patch_set, AppliedPatchSet, InstanceContext, InstanceSnapshot,
|
||||||
InstancePropertiesWithMeta, PatchSet, RojoTree,
|
PatchSet, RojoTree,
|
||||||
},
|
},
|
||||||
snapshot_middleware::snapshot_from_vfs,
|
snapshot_middleware::snapshot_from_vfs,
|
||||||
};
|
};
|
||||||
@@ -118,14 +117,7 @@ impl ServeSession {
|
|||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
let mut tree = RojoTree::new(InstancePropertiesWithMeta {
|
let mut tree = RojoTree::new(InstanceSnapshot::new());
|
||||||
properties: RbxInstanceProperties {
|
|
||||||
name: "ROOT".to_owned(),
|
|
||||||
class_name: "Folder".to_owned(),
|
|
||||||
properties: Default::default(),
|
|
||||||
},
|
|
||||||
metadata: Default::default(),
|
|
||||||
});
|
|
||||||
|
|
||||||
let root_id = tree.get_root_id();
|
let root_id = tree.get_root_id();
|
||||||
|
|
||||||
|
|||||||
@@ -2,7 +2,10 @@
|
|||||||
|
|
||||||
use std::{borrow::Cow, collections::HashMap};
|
use std::{borrow::Cow, collections::HashMap};
|
||||||
|
|
||||||
use rbx_dom_weak::{RbxId, RbxTree, RbxValue};
|
use rbx_dom_weak::{
|
||||||
|
types::{Ref, Variant},
|
||||||
|
WeakDom,
|
||||||
|
};
|
||||||
use serde::{Deserialize, Serialize};
|
use serde::{Deserialize, Serialize};
|
||||||
|
|
||||||
use super::InstanceMetadata;
|
use super::InstanceMetadata;
|
||||||
@@ -11,11 +14,12 @@ use super::InstanceMetadata;
|
|||||||
///
|
///
|
||||||
// Possible future improvements:
|
// Possible future improvements:
|
||||||
// - Use refcounted/interned strings
|
// - Use refcounted/interned strings
|
||||||
// - Replace use of RbxValue with a sum of RbxValue + borrowed value
|
// - Replace use of Variant with a sum of Variant + borrowed value
|
||||||
#[derive(Debug, Clone, PartialEq, Serialize, Deserialize)]
|
#[derive(Debug, Clone, PartialEq, Serialize, Deserialize)]
|
||||||
pub struct InstanceSnapshot {
|
pub struct InstanceSnapshot {
|
||||||
|
// FIXME: Don't use Option<Ref> anymore!
|
||||||
/// A temporary ID applied to the snapshot that's used for Ref properties.
|
/// A temporary ID applied to the snapshot that's used for Ref properties.
|
||||||
pub snapshot_id: Option<RbxId>,
|
pub snapshot_id: Option<Ref>,
|
||||||
|
|
||||||
/// Rojo-specific metadata associated with the instance.
|
/// Rojo-specific metadata associated with the instance.
|
||||||
pub metadata: InstanceMetadata,
|
pub metadata: InstanceMetadata,
|
||||||
@@ -27,7 +31,7 @@ pub struct InstanceSnapshot {
|
|||||||
pub class_name: Cow<'static, str>,
|
pub class_name: Cow<'static, str>,
|
||||||
|
|
||||||
/// All other properties of the instance, weakly-typed.
|
/// All other properties of the instance, weakly-typed.
|
||||||
pub properties: HashMap<String, RbxValue>,
|
pub properties: HashMap<String, Variant>,
|
||||||
|
|
||||||
/// The children of the instance represented as more snapshots.
|
/// The children of the instance represented as more snapshots.
|
||||||
///
|
///
|
||||||
@@ -61,7 +65,16 @@ impl InstanceSnapshot {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
pub fn properties(self, properties: impl Into<HashMap<String, RbxValue>>) -> Self {
|
pub fn property<K, V>(mut self, key: K, value: V) -> Self
|
||||||
|
where
|
||||||
|
K: Into<String>,
|
||||||
|
V: Into<Variant>,
|
||||||
|
{
|
||||||
|
self.properties.insert(key.into(), value.into());
|
||||||
|
self
|
||||||
|
}
|
||||||
|
|
||||||
|
pub fn properties(self, properties: impl Into<HashMap<String, Variant>>) -> Self {
|
||||||
Self {
|
Self {
|
||||||
properties: properties.into(),
|
properties: properties.into(),
|
||||||
..self
|
..self
|
||||||
@@ -75,6 +88,13 @@ impl InstanceSnapshot {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
pub fn snapshot_id(self, snapshot_id: Option<Ref>) -> Self {
|
||||||
|
Self {
|
||||||
|
snapshot_id,
|
||||||
|
..self
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
pub fn metadata(self, metadata: impl Into<InstanceMetadata>) -> Self {
|
pub fn metadata(self, metadata: impl Into<InstanceMetadata>) -> Self {
|
||||||
Self {
|
Self {
|
||||||
metadata: metadata.into(),
|
metadata: metadata.into(),
|
||||||
@@ -82,15 +102,13 @@ impl InstanceSnapshot {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
pub fn from_tree(tree: &RbxTree, id: RbxId) -> Self {
|
pub fn from_tree(tree: &WeakDom, id: Ref) -> Self {
|
||||||
let instance = tree
|
let instance = tree.get_by_ref(id).expect("instance did not exist in tree");
|
||||||
.get_instance(id)
|
|
||||||
.expect("instance did not exist in tree");
|
|
||||||
|
|
||||||
let children = instance
|
let children = instance
|
||||||
.get_children_ids()
|
.children()
|
||||||
.iter()
|
.iter()
|
||||||
.cloned()
|
.copied()
|
||||||
.map(|id| Self::from_tree(tree, id))
|
.map(|id| Self::from_tree(tree, id))
|
||||||
.collect();
|
.collect();
|
||||||
|
|
||||||
@@ -98,7 +116,7 @@ impl InstanceSnapshot {
|
|||||||
snapshot_id: Some(id),
|
snapshot_id: Some(id),
|
||||||
metadata: InstanceMetadata::default(),
|
metadata: InstanceMetadata::default(),
|
||||||
name: Cow::Owned(instance.name.clone()),
|
name: Cow::Owned(instance.name.clone()),
|
||||||
class_name: Cow::Owned(instance.class_name.clone()),
|
class_name: Cow::Owned(instance.class.clone()),
|
||||||
properties: instance.properties.clone(),
|
properties: instance.properties.clone(),
|
||||||
children,
|
children,
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -2,19 +2,19 @@
|
|||||||
|
|
||||||
use std::collections::HashMap;
|
use std::collections::HashMap;
|
||||||
|
|
||||||
use rbx_dom_weak::{RbxId, RbxValue};
|
use rbx_dom_weak::types::{Ref, Variant};
|
||||||
use serde::{Deserialize, Serialize};
|
use serde::{Deserialize, Serialize};
|
||||||
|
|
||||||
use super::{InstanceMetadata, InstanceSnapshot};
|
use super::{InstanceMetadata, InstanceSnapshot};
|
||||||
|
|
||||||
/// A set of different kinds of patches that can be applied to an RbxTree.
|
/// A set of different kinds of patches that can be applied to an WeakDom.
|
||||||
///
|
///
|
||||||
/// These patches shouldn't be persisted: there's no mechanism in place to make
|
/// These patches shouldn't be persisted: there's no mechanism in place to make
|
||||||
/// sure that another patch wasn't applied before this one that could cause a
|
/// sure that another patch wasn't applied before this one that could cause a
|
||||||
/// conflict!
|
/// conflict!
|
||||||
#[derive(Debug, Default, Clone, PartialEq, Serialize, Deserialize)]
|
#[derive(Debug, Default, Clone, PartialEq, Serialize, Deserialize)]
|
||||||
pub struct PatchSet {
|
pub struct PatchSet {
|
||||||
pub removed_instances: Vec<RbxId>,
|
pub removed_instances: Vec<Ref>,
|
||||||
pub added_instances: Vec<PatchAdd>,
|
pub added_instances: Vec<PatchAdd>,
|
||||||
pub updated_instances: Vec<PatchUpdate>,
|
pub updated_instances: Vec<PatchUpdate>,
|
||||||
}
|
}
|
||||||
@@ -32,20 +32,20 @@ impl<'a> PatchSet {
|
|||||||
/// A patch containing an instance that was added to the tree.
|
/// A patch containing an instance that was added to the tree.
|
||||||
#[derive(Debug, Clone, PartialEq, Serialize, Deserialize)]
|
#[derive(Debug, Clone, PartialEq, Serialize, Deserialize)]
|
||||||
pub struct PatchAdd {
|
pub struct PatchAdd {
|
||||||
pub parent_id: RbxId,
|
pub parent_id: Ref,
|
||||||
pub instance: InstanceSnapshot,
|
pub instance: InstanceSnapshot,
|
||||||
}
|
}
|
||||||
|
|
||||||
/// A patch indicating that properties of an instance changed.
|
/// A patch indicating that properties of an instance changed.
|
||||||
#[derive(Debug, Clone, PartialEq, Serialize, Deserialize)]
|
#[derive(Debug, Clone, PartialEq, Serialize, Deserialize)]
|
||||||
pub struct PatchUpdate {
|
pub struct PatchUpdate {
|
||||||
pub id: RbxId,
|
pub id: Ref,
|
||||||
pub changed_name: Option<String>,
|
pub changed_name: Option<String>,
|
||||||
pub changed_class_name: Option<String>,
|
pub changed_class_name: Option<String>,
|
||||||
|
|
||||||
/// Contains all changed properties. If a property is assigned to `None`,
|
/// Contains all changed properties. If a property is assigned to `None`,
|
||||||
/// then that property has been removed.
|
/// then that property has been removed.
|
||||||
pub changed_properties: HashMap<String, Option<RbxValue>>,
|
pub changed_properties: HashMap<String, Option<Variant>>,
|
||||||
|
|
||||||
/// Changed Rojo-specific metadata, if any of it changed.
|
/// Changed Rojo-specific metadata, if any of it changed.
|
||||||
pub changed_metadata: Option<InstanceMetadata>,
|
pub changed_metadata: Option<InstanceMetadata>,
|
||||||
@@ -63,8 +63,8 @@ pub struct PatchUpdate {
|
|||||||
// current values in all fields.
|
// current values in all fields.
|
||||||
#[derive(Debug, Clone, Default, Serialize, Deserialize)]
|
#[derive(Debug, Clone, Default, Serialize, Deserialize)]
|
||||||
pub struct AppliedPatchSet {
|
pub struct AppliedPatchSet {
|
||||||
pub removed: Vec<RbxId>,
|
pub removed: Vec<Ref>,
|
||||||
pub added: Vec<RbxId>,
|
pub added: Vec<Ref>,
|
||||||
pub updated: Vec<AppliedPatchUpdate>,
|
pub updated: Vec<AppliedPatchUpdate>,
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -80,17 +80,17 @@ impl AppliedPatchSet {
|
|||||||
|
|
||||||
#[derive(Debug, Clone, Serialize, Deserialize)]
|
#[derive(Debug, Clone, Serialize, Deserialize)]
|
||||||
pub struct AppliedPatchUpdate {
|
pub struct AppliedPatchUpdate {
|
||||||
pub id: RbxId,
|
pub id: Ref,
|
||||||
|
|
||||||
// TODO: Store previous values in order to detect application conflicts
|
// TODO: Store previous values in order to detect application conflicts
|
||||||
pub changed_name: Option<String>,
|
pub changed_name: Option<String>,
|
||||||
pub changed_class_name: Option<String>,
|
pub changed_class_name: Option<String>,
|
||||||
pub changed_properties: HashMap<String, Option<RbxValue>>,
|
pub changed_properties: HashMap<String, Option<Variant>>,
|
||||||
pub changed_metadata: Option<InstanceMetadata>,
|
pub changed_metadata: Option<InstanceMetadata>,
|
||||||
}
|
}
|
||||||
|
|
||||||
impl AppliedPatchUpdate {
|
impl AppliedPatchUpdate {
|
||||||
pub fn new(id: RbxId) -> Self {
|
pub fn new(id: Ref) -> Self {
|
||||||
Self {
|
Self {
|
||||||
id,
|
id,
|
||||||
changed_name: None,
|
changed_name: None,
|
||||||
|
|||||||
@@ -2,11 +2,11 @@
|
|||||||
|
|
||||||
use std::collections::HashMap;
|
use std::collections::HashMap;
|
||||||
|
|
||||||
use rbx_dom_weak::{RbxId, RbxInstanceProperties, RbxValue};
|
use rbx_dom_weak::types::{Ref, Variant};
|
||||||
|
|
||||||
use super::{
|
use super::{
|
||||||
patch::{AppliedPatchSet, AppliedPatchUpdate, PatchSet, PatchUpdate},
|
patch::{AppliedPatchSet, AppliedPatchUpdate, PatchSet, PatchUpdate},
|
||||||
InstancePropertiesWithMeta, InstanceSnapshot, RojoTree,
|
InstanceSnapshot, RojoTree,
|
||||||
};
|
};
|
||||||
|
|
||||||
/// Consumes the input `PatchSet`, applying all of its prescribed changes to the
|
/// Consumes the input `PatchSet`, applying all of its prescribed changes to the
|
||||||
@@ -37,7 +37,7 @@ pub fn apply_patch_set(tree: &mut RojoTree, patch_set: PatchSet) -> AppliedPatch
|
|||||||
struct PatchApplyContext {
|
struct PatchApplyContext {
|
||||||
/// A map from transient snapshot IDs (generated by snapshot middleware) to
|
/// A map from transient snapshot IDs (generated by snapshot middleware) to
|
||||||
/// instance IDs in the actual tree. These are both the same data type so
|
/// instance IDs in the actual tree. These are both the same data type so
|
||||||
/// that they fit into the same `RbxValue::Ref` type.
|
/// that they fit into the same `Variant::Ref` type.
|
||||||
///
|
///
|
||||||
/// At this point in the patch process, IDs in instance properties have been
|
/// At this point in the patch process, IDs in instance properties have been
|
||||||
/// partially translated from 'snapshot space' into 'tree space' by the
|
/// partially translated from 'snapshot space' into 'tree space' by the
|
||||||
@@ -53,7 +53,7 @@ struct PatchApplyContext {
|
|||||||
/// #2 should not occur in well-formed projects, but is indistinguishable
|
/// #2 should not occur in well-formed projects, but is indistinguishable
|
||||||
/// from #1 right now. It could happen if two model files try to reference
|
/// from #1 right now. It could happen if two model files try to reference
|
||||||
/// eachother.
|
/// eachother.
|
||||||
snapshot_id_to_instance_id: HashMap<RbxId, RbxId>,
|
snapshot_id_to_instance_id: HashMap<Ref, Ref>,
|
||||||
|
|
||||||
/// The properties of instances added by the current `PatchSet`.
|
/// The properties of instances added by the current `PatchSet`.
|
||||||
///
|
///
|
||||||
@@ -68,7 +68,7 @@ struct PatchApplyContext {
|
|||||||
///
|
///
|
||||||
/// This doesn't affect updated instances, since they're always applied
|
/// This doesn't affect updated instances, since they're always applied
|
||||||
/// after we've added all the instances from the patch.
|
/// after we've added all the instances from the patch.
|
||||||
added_instance_properties: HashMap<RbxId, HashMap<String, RbxValue>>,
|
added_instance_properties: HashMap<Ref, HashMap<String, Variant>>,
|
||||||
|
|
||||||
/// The current applied patch result, describing changes made to the tree.
|
/// The current applied patch result, describing changes made to the tree.
|
||||||
applied_patch_set: AppliedPatchSet,
|
applied_patch_set: AppliedPatchSet,
|
||||||
@@ -93,11 +93,10 @@ fn finalize_patch_application(context: PatchApplyContext, tree: &mut RojoTree) -
|
|||||||
.expect("Invalid instance ID in deferred property map");
|
.expect("Invalid instance ID in deferred property map");
|
||||||
|
|
||||||
for (key, mut property_value) in properties {
|
for (key, mut property_value) in properties {
|
||||||
if let RbxValue::Ref { value: Some(id) } = property_value {
|
if let Variant::Ref(referent) = property_value {
|
||||||
if let Some(&instance_id) = context.snapshot_id_to_instance_id.get(&id) {
|
if let Some(&instance_referent) = context.snapshot_id_to_instance_id.get(&referent)
|
||||||
property_value = RbxValue::Ref {
|
{
|
||||||
value: Some(instance_id),
|
property_value = Variant::Ref(instance_referent);
|
||||||
};
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -108,50 +107,40 @@ fn finalize_patch_application(context: PatchApplyContext, tree: &mut RojoTree) -
|
|||||||
context.applied_patch_set
|
context.applied_patch_set
|
||||||
}
|
}
|
||||||
|
|
||||||
fn apply_remove_instance(context: &mut PatchApplyContext, tree: &mut RojoTree, removed_id: RbxId) {
|
fn apply_remove_instance(context: &mut PatchApplyContext, tree: &mut RojoTree, removed_id: Ref) {
|
||||||
match tree.remove_instance(removed_id) {
|
tree.remove(removed_id);
|
||||||
Some(_) => context.applied_patch_set.removed.push(removed_id),
|
context.applied_patch_set.removed.push(removed_id);
|
||||||
None => {
|
|
||||||
log::warn!(
|
|
||||||
"Patch misapplication: Tried to remove instance {} but it did not exist.",
|
|
||||||
removed_id
|
|
||||||
);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
||||||
fn apply_add_child(
|
fn apply_add_child(
|
||||||
context: &mut PatchApplyContext,
|
context: &mut PatchApplyContext,
|
||||||
tree: &mut RojoTree,
|
tree: &mut RojoTree,
|
||||||
parent_id: RbxId,
|
parent_id: Ref,
|
||||||
snapshot: InstanceSnapshot,
|
snapshot: InstanceSnapshot,
|
||||||
) {
|
) {
|
||||||
let properties = InstancePropertiesWithMeta {
|
let snapshot_id = snapshot.snapshot_id;
|
||||||
properties: RbxInstanceProperties {
|
let properties = snapshot.properties;
|
||||||
name: snapshot.name.into_owned(),
|
let children = snapshot.children;
|
||||||
class_name: snapshot.class_name.into_owned(),
|
|
||||||
|
|
||||||
// Property assignment is deferred until after we know about all
|
// Property application is deferred until after all children
|
||||||
// instances in this patch. See `PatchApplyContext` for details.
|
// are constructed. This helps apply referents correctly.
|
||||||
properties: HashMap::new(),
|
let remaining_snapshot = InstanceSnapshot::new()
|
||||||
},
|
.name(snapshot.name)
|
||||||
metadata: snapshot.metadata,
|
.class_name(snapshot.class_name)
|
||||||
};
|
.metadata(snapshot.metadata)
|
||||||
|
.snapshot_id(snapshot.snapshot_id);
|
||||||
let id = tree.insert_instance(properties, parent_id);
|
|
||||||
|
|
||||||
|
let id = tree.insert_instance(parent_id, remaining_snapshot);
|
||||||
context.applied_patch_set.added.push(id);
|
context.applied_patch_set.added.push(id);
|
||||||
|
|
||||||
context
|
context.added_instance_properties.insert(id, properties);
|
||||||
.added_instance_properties
|
|
||||||
.insert(id, snapshot.properties);
|
|
||||||
|
|
||||||
if let Some(snapshot_id) = snapshot.snapshot_id {
|
if let Some(snapshot_id) = snapshot_id {
|
||||||
context.snapshot_id_to_instance_id.insert(snapshot_id, id);
|
context.snapshot_id_to_instance_id.insert(snapshot_id, id);
|
||||||
}
|
}
|
||||||
|
|
||||||
for child_snapshot in snapshot.children {
|
for child in children {
|
||||||
apply_add_child(context, tree, id, child_snapshot);
|
apply_add_child(context, tree, id, child);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -167,7 +156,7 @@ fn apply_update_child(context: &mut PatchApplyContext, tree: &mut RojoTree, patc
|
|||||||
Some(instance) => instance,
|
Some(instance) => instance,
|
||||||
None => {
|
None => {
|
||||||
log::warn!(
|
log::warn!(
|
||||||
"Patch misapplication: Instance {}, referred to by update patch, did not exist.",
|
"Patch misapplication: Instance {:?}, referred to by update patch, did not exist.",
|
||||||
patch.id
|
patch.id
|
||||||
);
|
);
|
||||||
return;
|
return;
|
||||||
@@ -189,23 +178,24 @@ fn apply_update_child(context: &mut PatchApplyContext, tree: &mut RojoTree, patc
|
|||||||
// Ref values need to be potentially rewritten from snapshot IDs to
|
// Ref values need to be potentially rewritten from snapshot IDs to
|
||||||
// instance IDs if they referred to an instance that was created as
|
// instance IDs if they referred to an instance that was created as
|
||||||
// part of this patch.
|
// part of this patch.
|
||||||
Some(RbxValue::Ref { value: Some(id) }) => {
|
Some(Variant::Ref(referent)) => {
|
||||||
|
if referent.is_none() {
|
||||||
|
continue;
|
||||||
|
}
|
||||||
|
|
||||||
// If our ID is not found in this map, then it either refers to
|
// If our ID is not found in this map, then it either refers to
|
||||||
// an existing instance NOT added by this patch, or there was an
|
// an existing instance NOT added by this patch, or there was an
|
||||||
// error. See `PatchApplyContext::snapshot_id_to_instance_id`
|
// error. See `PatchApplyContext::snapshot_id_to_instance_id`
|
||||||
// for more info.
|
// for more info.
|
||||||
let new_id = context
|
let new_referent = context
|
||||||
.snapshot_id_to_instance_id
|
.snapshot_id_to_instance_id
|
||||||
.get(&id)
|
.get(&referent)
|
||||||
.copied()
|
.copied()
|
||||||
.unwrap_or(id);
|
.unwrap_or(referent);
|
||||||
|
|
||||||
instance.properties_mut().insert(
|
instance
|
||||||
key.clone(),
|
.properties_mut()
|
||||||
RbxValue::Ref {
|
.insert(key.clone(), Variant::Ref(new_referent));
|
||||||
value: Some(new_id),
|
|
||||||
},
|
|
||||||
);
|
|
||||||
}
|
}
|
||||||
Some(ref value) => {
|
Some(ref value) => {
|
||||||
instance.properties_mut().insert(key.clone(), value.clone());
|
instance.properties_mut().insert(key.clone(), value.clone());
|
||||||
@@ -225,10 +215,10 @@ fn apply_update_child(context: &mut PatchApplyContext, tree: &mut RojoTree, patc
|
|||||||
mod test {
|
mod test {
|
||||||
use super::*;
|
use super::*;
|
||||||
|
|
||||||
use std::{borrow::Cow, collections::HashMap};
|
use std::borrow::Cow;
|
||||||
|
|
||||||
use maplit::hashmap;
|
use maplit::hashmap;
|
||||||
use rbx_dom_weak::RbxValue;
|
use rbx_dom_weak::types::Variant;
|
||||||
|
|
||||||
use super::super::PatchAdd;
|
use super::super::PatchAdd;
|
||||||
|
|
||||||
@@ -236,14 +226,7 @@ mod test {
|
|||||||
fn add_from_empty() {
|
fn add_from_empty() {
|
||||||
let _ = env_logger::try_init();
|
let _ = env_logger::try_init();
|
||||||
|
|
||||||
let mut tree = RojoTree::new(InstancePropertiesWithMeta {
|
let mut tree = RojoTree::new(InstanceSnapshot::new());
|
||||||
properties: RbxInstanceProperties {
|
|
||||||
name: "Folder".to_owned(),
|
|
||||||
class_name: "Folder".to_owned(),
|
|
||||||
properties: HashMap::new(),
|
|
||||||
},
|
|
||||||
metadata: Default::default(),
|
|
||||||
});
|
|
||||||
|
|
||||||
let root_id = tree.get_root_id();
|
let root_id = tree.get_root_id();
|
||||||
|
|
||||||
@@ -253,7 +236,7 @@ mod test {
|
|||||||
name: Cow::Borrowed("Foo"),
|
name: Cow::Borrowed("Foo"),
|
||||||
class_name: Cow::Borrowed("Bar"),
|
class_name: Cow::Borrowed("Bar"),
|
||||||
properties: hashmap! {
|
properties: hashmap! {
|
||||||
"Baz".to_owned() => RbxValue::Int32 { value: 5 },
|
"Baz".to_owned() => Variant::Int32(5),
|
||||||
},
|
},
|
||||||
children: Vec::new(),
|
children: Vec::new(),
|
||||||
};
|
};
|
||||||
@@ -282,18 +265,14 @@ mod test {
|
|||||||
fn update_existing() {
|
fn update_existing() {
|
||||||
let _ = env_logger::try_init();
|
let _ = env_logger::try_init();
|
||||||
|
|
||||||
let mut tree = RojoTree::new(InstancePropertiesWithMeta {
|
let mut tree = RojoTree::new(
|
||||||
properties: RbxInstanceProperties {
|
InstanceSnapshot::new()
|
||||||
name: "OldName".to_owned(),
|
.class_name("OldClassName")
|
||||||
class_name: "OldClassName".to_owned(),
|
.name("OldName")
|
||||||
properties: hashmap! {
|
.property("Foo", 7i32)
|
||||||
"Foo".to_owned() => RbxValue::Int32 { value: 7 },
|
.property("Bar", 3i32)
|
||||||
"Bar".to_owned() => RbxValue::Int32 { value: 3 },
|
.property("Unchanged", -5i32),
|
||||||
"Unchanged".to_owned() => RbxValue::Int32 { value: -5 },
|
);
|
||||||
},
|
|
||||||
},
|
|
||||||
metadata: Default::default(),
|
|
||||||
});
|
|
||||||
|
|
||||||
let root_id = tree.get_root_id();
|
let root_id = tree.get_root_id();
|
||||||
|
|
||||||
@@ -303,13 +282,13 @@ mod test {
|
|||||||
changed_class_name: Some("NewClassName".to_owned()),
|
changed_class_name: Some("NewClassName".to_owned()),
|
||||||
changed_properties: hashmap! {
|
changed_properties: hashmap! {
|
||||||
// The value of Foo has changed
|
// The value of Foo has changed
|
||||||
"Foo".to_owned() => Some(RbxValue::Int32 { value: 8 }),
|
"Foo".to_owned() => Some(Variant::Int32(8)),
|
||||||
|
|
||||||
// Bar has been deleted
|
// Bar has been deleted
|
||||||
"Bar".to_owned() => None,
|
"Bar".to_owned() => None,
|
||||||
|
|
||||||
// Baz has been added
|
// Baz has been added
|
||||||
"Baz".to_owned() => Some(RbxValue::Int32 { value: 10 }),
|
"Baz".to_owned() => Some(Variant::Int32(10)),
|
||||||
},
|
},
|
||||||
changed_metadata: None,
|
changed_metadata: None,
|
||||||
};
|
};
|
||||||
@@ -322,9 +301,9 @@ mod test {
|
|||||||
apply_patch_set(&mut tree, patch_set);
|
apply_patch_set(&mut tree, patch_set);
|
||||||
|
|
||||||
let expected_properties = hashmap! {
|
let expected_properties = hashmap! {
|
||||||
"Foo".to_owned() => RbxValue::Int32 { value: 8 },
|
"Foo".to_owned() => Variant::Int32(8),
|
||||||
"Baz".to_owned() => RbxValue::Int32 { value: 10 },
|
"Baz".to_owned() => Variant::Int32(10),
|
||||||
"Unchanged".to_owned() => RbxValue::Int32 { value: -5 },
|
"Unchanged".to_owned() => Variant::Int32(-5),
|
||||||
};
|
};
|
||||||
|
|
||||||
let root_instance = tree.get_instance(root_id).unwrap();
|
let root_instance = tree.get_instance(root_id).unwrap();
|
||||||
|
|||||||
@@ -3,14 +3,14 @@
|
|||||||
|
|
||||||
use std::collections::{HashMap, HashSet};
|
use std::collections::{HashMap, HashSet};
|
||||||
|
|
||||||
use rbx_dom_weak::{RbxId, RbxValue};
|
use rbx_dom_weak::types::{Ref, Variant};
|
||||||
|
|
||||||
use super::{
|
use super::{
|
||||||
patch::{PatchAdd, PatchSet, PatchUpdate},
|
patch::{PatchAdd, PatchSet, PatchUpdate},
|
||||||
InstanceSnapshot, InstanceWithMeta, RojoTree,
|
InstanceSnapshot, InstanceWithMeta, RojoTree,
|
||||||
};
|
};
|
||||||
|
|
||||||
pub fn compute_patch_set(snapshot: &InstanceSnapshot, tree: &RojoTree, id: RbxId) -> PatchSet {
|
pub fn compute_patch_set(snapshot: &InstanceSnapshot, tree: &RojoTree, id: Ref) -> PatchSet {
|
||||||
let mut patch_set = PatchSet::new();
|
let mut patch_set = PatchSet::new();
|
||||||
let mut context = ComputePatchContext::default();
|
let mut context = ComputePatchContext::default();
|
||||||
|
|
||||||
@@ -26,17 +26,15 @@ pub fn compute_patch_set(snapshot: &InstanceSnapshot, tree: &RojoTree, id: RbxId
|
|||||||
|
|
||||||
#[derive(Default)]
|
#[derive(Default)]
|
||||||
struct ComputePatchContext {
|
struct ComputePatchContext {
|
||||||
snapshot_id_to_instance_id: HashMap<RbxId, RbxId>,
|
snapshot_id_to_instance_id: HashMap<Ref, Ref>,
|
||||||
}
|
}
|
||||||
|
|
||||||
fn rewrite_refs_in_updates(context: &ComputePatchContext, updates: &mut [PatchUpdate]) {
|
fn rewrite_refs_in_updates(context: &ComputePatchContext, updates: &mut [PatchUpdate]) {
|
||||||
for update in updates {
|
for update in updates {
|
||||||
for property_value in update.changed_properties.values_mut() {
|
for property_value in update.changed_properties.values_mut() {
|
||||||
if let Some(RbxValue::Ref { value: Some(id) }) = property_value {
|
if let Some(Variant::Ref(referent)) = property_value {
|
||||||
if let Some(&instance_id) = context.snapshot_id_to_instance_id.get(id) {
|
if let Some(&instance_ref) = context.snapshot_id_to_instance_id.get(referent) {
|
||||||
*property_value = Some(RbxValue::Ref {
|
*property_value = Some(Variant::Ref(instance_ref));
|
||||||
value: Some(instance_id),
|
|
||||||
});
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -51,11 +49,9 @@ fn rewrite_refs_in_additions(context: &ComputePatchContext, additions: &mut [Pat
|
|||||||
|
|
||||||
fn rewrite_refs_in_snapshot(context: &ComputePatchContext, snapshot: &mut InstanceSnapshot) {
|
fn rewrite_refs_in_snapshot(context: &ComputePatchContext, snapshot: &mut InstanceSnapshot) {
|
||||||
for property_value in snapshot.properties.values_mut() {
|
for property_value in snapshot.properties.values_mut() {
|
||||||
if let RbxValue::Ref { value: Some(id) } = property_value {
|
if let Variant::Ref(referent) = property_value {
|
||||||
if let Some(&instance_id) = context.snapshot_id_to_instance_id.get(id) {
|
if let Some(&instance_referent) = context.snapshot_id_to_instance_id.get(referent) {
|
||||||
*property_value = RbxValue::Ref {
|
*property_value = Variant::Ref(instance_referent);
|
||||||
value: Some(instance_id),
|
|
||||||
};
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -69,7 +65,7 @@ fn compute_patch_set_internal(
|
|||||||
context: &mut ComputePatchContext,
|
context: &mut ComputePatchContext,
|
||||||
snapshot: &InstanceSnapshot,
|
snapshot: &InstanceSnapshot,
|
||||||
tree: &RojoTree,
|
tree: &RojoTree,
|
||||||
id: RbxId,
|
id: Ref,
|
||||||
patch_set: &mut PatchSet,
|
patch_set: &mut PatchSet,
|
||||||
) {
|
) {
|
||||||
if let Some(snapshot_id) = snapshot.snapshot_id {
|
if let Some(snapshot_id) = snapshot.snapshot_id {
|
||||||
@@ -154,7 +150,7 @@ fn compute_children_patches(
|
|||||||
context: &mut ComputePatchContext,
|
context: &mut ComputePatchContext,
|
||||||
snapshot: &InstanceSnapshot,
|
snapshot: &InstanceSnapshot,
|
||||||
tree: &RojoTree,
|
tree: &RojoTree,
|
||||||
id: RbxId,
|
id: Ref,
|
||||||
patch_set: &mut PatchSet,
|
patch_set: &mut PatchSet,
|
||||||
) {
|
) {
|
||||||
let instance = tree
|
let instance = tree
|
||||||
@@ -224,9 +220,6 @@ mod test {
|
|||||||
use std::borrow::Cow;
|
use std::borrow::Cow;
|
||||||
|
|
||||||
use maplit::hashmap;
|
use maplit::hashmap;
|
||||||
use rbx_dom_weak::RbxInstanceProperties;
|
|
||||||
|
|
||||||
use super::super::InstancePropertiesWithMeta;
|
|
||||||
|
|
||||||
/// This test makes sure that rewriting refs in instance update patches to
|
/// This test makes sure that rewriting refs in instance update patches to
|
||||||
/// instances that already exists works. We should be able to correlate the
|
/// instances that already exists works. We should be able to correlate the
|
||||||
@@ -234,26 +227,17 @@ mod test {
|
|||||||
/// value before returning from compute_patch_set.
|
/// value before returning from compute_patch_set.
|
||||||
#[test]
|
#[test]
|
||||||
fn rewrite_ref_existing_instance_update() {
|
fn rewrite_ref_existing_instance_update() {
|
||||||
let tree = RojoTree::new(InstancePropertiesWithMeta {
|
let tree = RojoTree::new(InstanceSnapshot::new().name("foo").class_name("foo"));
|
||||||
properties: RbxInstanceProperties {
|
|
||||||
name: "foo".to_owned(),
|
|
||||||
class_name: "foo".to_owned(),
|
|
||||||
properties: HashMap::new(),
|
|
||||||
},
|
|
||||||
metadata: Default::default(),
|
|
||||||
});
|
|
||||||
|
|
||||||
let root_id = tree.get_root_id();
|
let root_id = tree.get_root_id();
|
||||||
|
|
||||||
// This snapshot should be identical to the existing tree except for the
|
// This snapshot should be identical to the existing tree except for the
|
||||||
// addition of a prop named Self, which is a self-referential Ref.
|
// addition of a prop named Self, which is a self-referential Ref.
|
||||||
let snapshot_id = RbxId::new();
|
let snapshot_id = Ref::new();
|
||||||
let snapshot = InstanceSnapshot {
|
let snapshot = InstanceSnapshot {
|
||||||
snapshot_id: Some(snapshot_id),
|
snapshot_id: Some(snapshot_id),
|
||||||
properties: hashmap! {
|
properties: hashmap! {
|
||||||
"Self".to_owned() => RbxValue::Ref {
|
"Self".to_owned() => Variant::Ref(snapshot_id),
|
||||||
value: Some(snapshot_id),
|
|
||||||
}
|
|
||||||
},
|
},
|
||||||
|
|
||||||
metadata: Default::default(),
|
metadata: Default::default(),
|
||||||
@@ -270,9 +254,7 @@ mod test {
|
|||||||
changed_name: None,
|
changed_name: None,
|
||||||
changed_class_name: None,
|
changed_class_name: None,
|
||||||
changed_properties: hashmap! {
|
changed_properties: hashmap! {
|
||||||
"Self".to_owned() => Some(RbxValue::Ref {
|
"Self".to_owned() => Some(Variant::Ref(root_id)),
|
||||||
value: Some(root_id),
|
|
||||||
}),
|
|
||||||
},
|
},
|
||||||
changed_metadata: None,
|
changed_metadata: None,
|
||||||
}],
|
}],
|
||||||
@@ -288,26 +270,17 @@ mod test {
|
|||||||
/// one.
|
/// one.
|
||||||
#[test]
|
#[test]
|
||||||
fn rewrite_ref_existing_instance_addition() {
|
fn rewrite_ref_existing_instance_addition() {
|
||||||
let tree = RojoTree::new(InstancePropertiesWithMeta {
|
let tree = RojoTree::new(InstanceSnapshot::new().name("foo").class_name("foo"));
|
||||||
properties: RbxInstanceProperties {
|
|
||||||
name: "foo".to_owned(),
|
|
||||||
class_name: "foo".to_owned(),
|
|
||||||
properties: HashMap::new(),
|
|
||||||
},
|
|
||||||
metadata: Default::default(),
|
|
||||||
});
|
|
||||||
|
|
||||||
let root_id = tree.get_root_id();
|
let root_id = tree.get_root_id();
|
||||||
|
|
||||||
// This patch describes the existing instance with a new child added.
|
// This patch describes the existing instance with a new child added.
|
||||||
let snapshot_id = RbxId::new();
|
let snapshot_id = Ref::new();
|
||||||
let snapshot = InstanceSnapshot {
|
let snapshot = InstanceSnapshot {
|
||||||
snapshot_id: Some(snapshot_id),
|
snapshot_id: Some(snapshot_id),
|
||||||
children: vec![InstanceSnapshot {
|
children: vec![InstanceSnapshot {
|
||||||
properties: hashmap! {
|
properties: hashmap! {
|
||||||
"Self".to_owned() => RbxValue::Ref {
|
"Self".to_owned() => Variant::Ref(snapshot_id),
|
||||||
value: Some(snapshot_id),
|
|
||||||
},
|
|
||||||
},
|
},
|
||||||
|
|
||||||
snapshot_id: None,
|
snapshot_id: None,
|
||||||
@@ -332,9 +305,7 @@ mod test {
|
|||||||
snapshot_id: None,
|
snapshot_id: None,
|
||||||
metadata: Default::default(),
|
metadata: Default::default(),
|
||||||
properties: hashmap! {
|
properties: hashmap! {
|
||||||
"Self".to_owned() => RbxValue::Ref {
|
"Self".to_owned() => Variant::Ref(root_id),
|
||||||
value: Some(root_id),
|
|
||||||
},
|
|
||||||
},
|
},
|
||||||
name: Cow::Borrowed("child"),
|
name: Cow::Borrowed("child"),
|
||||||
class_name: Cow::Borrowed("child"),
|
class_name: Cow::Borrowed("child"),
|
||||||
|
|||||||
@@ -1,11 +1,10 @@
|
|||||||
use insta::assert_yaml_snapshot;
|
use insta::assert_yaml_snapshot;
|
||||||
use maplit::hashmap;
|
use maplit::hashmap;
|
||||||
use rbx_dom_weak::{RbxInstanceProperties, RbxValue};
|
|
||||||
|
|
||||||
use rojo_insta_ext::RedactionMap;
|
use rojo_insta_ext::RedactionMap;
|
||||||
|
|
||||||
use crate::{
|
use crate::{
|
||||||
snapshot::{apply_patch_set, InstancePropertiesWithMeta, PatchSet, PatchUpdate, RojoTree},
|
snapshot::{apply_patch_set, InstanceSnapshot, PatchSet, PatchUpdate, RojoTree},
|
||||||
tree_view::{intern_tree, view_tree},
|
tree_view::{intern_tree, view_tree},
|
||||||
};
|
};
|
||||||
|
|
||||||
@@ -49,9 +48,7 @@ fn add_property() {
|
|||||||
changed_name: None,
|
changed_name: None,
|
||||||
changed_class_name: None,
|
changed_class_name: None,
|
||||||
changed_properties: hashmap! {
|
changed_properties: hashmap! {
|
||||||
"Foo".to_owned() => Some(RbxValue::String {
|
"Foo".to_owned() => Some("Value of Foo".into()),
|
||||||
value: "Value of Foo".to_owned(),
|
|
||||||
}),
|
|
||||||
},
|
},
|
||||||
changed_metadata: None,
|
changed_metadata: None,
|
||||||
}],
|
}],
|
||||||
@@ -78,12 +75,9 @@ fn remove_property() {
|
|||||||
let root_id = tree.get_root_id();
|
let root_id = tree.get_root_id();
|
||||||
let mut root_instance = tree.get_instance_mut(root_id).unwrap();
|
let mut root_instance = tree.get_instance_mut(root_id).unwrap();
|
||||||
|
|
||||||
root_instance.properties_mut().insert(
|
root_instance
|
||||||
"Foo".to_owned(),
|
.properties_mut()
|
||||||
RbxValue::String {
|
.insert("Foo".to_owned(), "Should be removed".into());
|
||||||
value: "Should be removed".to_owned(),
|
|
||||||
},
|
|
||||||
);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
let tree_view = view_tree(&tree, &mut redactions);
|
let tree_view = view_tree(&tree, &mut redactions);
|
||||||
@@ -112,12 +106,5 @@ fn remove_property() {
|
|||||||
}
|
}
|
||||||
|
|
||||||
fn empty_tree() -> RojoTree {
|
fn empty_tree() -> RojoTree {
|
||||||
RojoTree::new(InstancePropertiesWithMeta {
|
RojoTree::new(InstanceSnapshot::new().name("ROOT").class_name("ROOT"))
|
||||||
properties: RbxInstanceProperties {
|
|
||||||
name: "ROOT".to_owned(),
|
|
||||||
class_name: "ROOT".to_owned(),
|
|
||||||
properties: Default::default(),
|
|
||||||
},
|
|
||||||
metadata: Default::default(),
|
|
||||||
})
|
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -2,11 +2,10 @@ use std::borrow::Cow;
|
|||||||
|
|
||||||
use insta::assert_yaml_snapshot;
|
use insta::assert_yaml_snapshot;
|
||||||
use maplit::hashmap;
|
use maplit::hashmap;
|
||||||
use rbx_dom_weak::{RbxInstanceProperties, RbxValue};
|
|
||||||
|
|
||||||
use rojo_insta_ext::RedactionMap;
|
use rojo_insta_ext::RedactionMap;
|
||||||
|
|
||||||
use crate::snapshot::{compute_patch_set, InstancePropertiesWithMeta, InstanceSnapshot, RojoTree};
|
use crate::snapshot::{compute_patch_set, InstanceSnapshot, RojoTree};
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn set_name_and_class_name() {
|
fn set_name_and_class_name() {
|
||||||
@@ -43,9 +42,7 @@ fn set_property() {
|
|||||||
name: Cow::Borrowed("ROOT"),
|
name: Cow::Borrowed("ROOT"),
|
||||||
class_name: Cow::Borrowed("ROOT"),
|
class_name: Cow::Borrowed("ROOT"),
|
||||||
properties: hashmap! {
|
properties: hashmap! {
|
||||||
"PropertyName".to_owned() => RbxValue::String {
|
"PropertyName".to_owned() => "Hello, world!".into(),
|
||||||
value: "Hello, world!".to_owned(),
|
|
||||||
},
|
|
||||||
},
|
},
|
||||||
children: Vec::new(),
|
children: Vec::new(),
|
||||||
};
|
};
|
||||||
@@ -68,9 +65,7 @@ fn remove_property() {
|
|||||||
let mut root_instance = tree.get_instance_mut(root_id).unwrap();
|
let mut root_instance = tree.get_instance_mut(root_id).unwrap();
|
||||||
root_instance.properties_mut().insert(
|
root_instance.properties_mut().insert(
|
||||||
"Foo".to_owned(),
|
"Foo".to_owned(),
|
||||||
RbxValue::String {
|
"This should be removed by the patch.".into(),
|
||||||
value: "This should be removed by the patch.".to_owned(),
|
|
||||||
},
|
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -128,15 +123,8 @@ fn remove_child() {
|
|||||||
{
|
{
|
||||||
let root_id = tree.get_root_id();
|
let root_id = tree.get_root_id();
|
||||||
let new_id = tree.insert_instance(
|
let new_id = tree.insert_instance(
|
||||||
InstancePropertiesWithMeta {
|
|
||||||
properties: RbxInstanceProperties {
|
|
||||||
name: "Should not appear in snapshot".to_owned(),
|
|
||||||
class_name: "Folder".to_owned(),
|
|
||||||
properties: Default::default(),
|
|
||||||
},
|
|
||||||
metadata: Default::default(),
|
|
||||||
},
|
|
||||||
root_id,
|
root_id,
|
||||||
|
InstanceSnapshot::new().name("Should not appear in snapshot"),
|
||||||
);
|
);
|
||||||
|
|
||||||
redactions.intern(new_id);
|
redactions.intern(new_id);
|
||||||
@@ -158,12 +146,5 @@ fn remove_child() {
|
|||||||
}
|
}
|
||||||
|
|
||||||
fn empty_tree() -> RojoTree {
|
fn empty_tree() -> RojoTree {
|
||||||
RojoTree::new(InstancePropertiesWithMeta {
|
RojoTree::new(InstanceSnapshot::new().name("ROOT").class_name("ROOT"))
|
||||||
properties: RbxInstanceProperties {
|
|
||||||
name: "ROOT".to_owned(),
|
|
||||||
class_name: "ROOT".to_owned(),
|
|
||||||
properties: Default::default(),
|
|
||||||
},
|
|
||||||
metadata: Default::default(),
|
|
||||||
})
|
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -1,26 +1,29 @@
|
|||||||
use std::{
|
use std::{
|
||||||
collections::HashMap,
|
collections::{HashMap, VecDeque},
|
||||||
path::{Path, PathBuf},
|
path::{Path, PathBuf},
|
||||||
};
|
};
|
||||||
|
|
||||||
use rbx_dom_weak::{Descendants, RbxId, RbxInstance, RbxInstanceProperties, RbxTree, RbxValue};
|
use rbx_dom_weak::{
|
||||||
|
types::{Ref, Variant},
|
||||||
|
Instance, InstanceBuilder, WeakDom,
|
||||||
|
};
|
||||||
|
|
||||||
use crate::multimap::MultiMap;
|
use crate::multimap::MultiMap;
|
||||||
|
|
||||||
use super::InstanceMetadata;
|
use super::{InstanceMetadata, InstanceSnapshot};
|
||||||
|
|
||||||
/// An expanded variant of rbx_dom_weak's `RbxTree` that tracks additional
|
/// An expanded variant of rbx_dom_weak's `WeakDom` that tracks additional
|
||||||
/// metadata per instance that's Rojo-specific.
|
/// metadata per instance that's Rojo-specific.
|
||||||
///
|
///
|
||||||
/// This tree is also optimized for doing fast incremental updates and patches.
|
/// This tree is also optimized for doing fast incremental updates and patches.
|
||||||
#[derive(Debug)]
|
#[derive(Debug)]
|
||||||
pub struct RojoTree {
|
pub struct RojoTree {
|
||||||
/// Contains the instances without their Rojo-specific metadata.
|
/// Contains the instances without their Rojo-specific metadata.
|
||||||
inner: RbxTree,
|
inner: WeakDom,
|
||||||
|
|
||||||
/// Metadata associated with each instance that is kept up-to-date with the
|
/// Metadata associated with each instance that is kept up-to-date with the
|
||||||
/// set of actual instances.
|
/// set of actual instances.
|
||||||
metadata_map: HashMap<RbxId, InstanceMetadata>,
|
metadata_map: HashMap<Ref, InstanceMetadata>,
|
||||||
|
|
||||||
/// A multimap from source paths to all of the root instances that were
|
/// A multimap from source paths to all of the root instances that were
|
||||||
/// constructed from that path.
|
/// constructed from that path.
|
||||||
@@ -29,31 +32,42 @@ pub struct RojoTree {
|
|||||||
/// value portion of the map is also a set in order to support the same path
|
/// value portion of the map is also a set in order to support the same path
|
||||||
/// appearing multiple times in the same Rojo project. This is sometimes
|
/// appearing multiple times in the same Rojo project. This is sometimes
|
||||||
/// called "path aliasing" in various Rojo documentation.
|
/// called "path aliasing" in various Rojo documentation.
|
||||||
path_to_ids: MultiMap<PathBuf, RbxId>,
|
path_to_ids: MultiMap<PathBuf, Ref>,
|
||||||
}
|
}
|
||||||
|
|
||||||
impl RojoTree {
|
impl RojoTree {
|
||||||
pub fn new(root: InstancePropertiesWithMeta) -> RojoTree {
|
pub fn new(snapshot: InstanceSnapshot) -> RojoTree {
|
||||||
|
let root_builder = InstanceBuilder::new(snapshot.class_name.to_owned())
|
||||||
|
.with_name(snapshot.name.to_owned())
|
||||||
|
.with_properties(snapshot.properties);
|
||||||
|
|
||||||
let mut tree = RojoTree {
|
let mut tree = RojoTree {
|
||||||
inner: RbxTree::new(root.properties),
|
inner: WeakDom::new(root_builder),
|
||||||
metadata_map: HashMap::new(),
|
metadata_map: HashMap::new(),
|
||||||
path_to_ids: MultiMap::new(),
|
path_to_ids: MultiMap::new(),
|
||||||
};
|
};
|
||||||
|
|
||||||
tree.insert_metadata(tree.inner.get_root_id(), root.metadata);
|
let root_ref = tree.inner.root_ref();
|
||||||
|
|
||||||
|
tree.insert_metadata(root_ref, snapshot.metadata);
|
||||||
|
|
||||||
|
for child in snapshot.children {
|
||||||
|
tree.insert_instance(root_ref, child);
|
||||||
|
}
|
||||||
|
|
||||||
tree
|
tree
|
||||||
}
|
}
|
||||||
|
|
||||||
pub fn inner(&self) -> &RbxTree {
|
pub fn inner(&self) -> &WeakDom {
|
||||||
&self.inner
|
&self.inner
|
||||||
}
|
}
|
||||||
|
|
||||||
pub fn get_root_id(&self) -> RbxId {
|
pub fn get_root_id(&self) -> Ref {
|
||||||
self.inner.get_root_id()
|
self.inner.root_ref()
|
||||||
}
|
}
|
||||||
|
|
||||||
pub fn get_instance(&self, id: RbxId) -> Option<InstanceWithMeta> {
|
pub fn get_instance(&self, id: Ref) -> Option<InstanceWithMeta> {
|
||||||
if let Some(instance) = self.inner.get_instance(id) {
|
if let Some(instance) = self.inner.get_by_ref(id) {
|
||||||
let metadata = self.metadata_map.get(&id).unwrap();
|
let metadata = self.metadata_map.get(&id).unwrap();
|
||||||
|
|
||||||
Some(InstanceWithMeta { instance, metadata })
|
Some(InstanceWithMeta { instance, metadata })
|
||||||
@@ -62,8 +76,8 @@ impl RojoTree {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
pub fn get_instance_mut(&mut self, id: RbxId) -> Option<InstanceWithMetaMut> {
|
pub fn get_instance_mut(&mut self, id: Ref) -> Option<InstanceWithMetaMut> {
|
||||||
if let Some(instance) = self.inner.get_instance_mut(id) {
|
if let Some(instance) = self.inner.get_by_ref_mut(id) {
|
||||||
let metadata = self.metadata_map.get_mut(&id).unwrap();
|
let metadata = self.metadata_map.get_mut(&id).unwrap();
|
||||||
|
|
||||||
Some(InstanceWithMetaMut { instance, metadata })
|
Some(InstanceWithMetaMut { instance, metadata })
|
||||||
@@ -72,38 +86,38 @@ impl RojoTree {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
pub fn insert_instance(
|
pub fn insert_instance(&mut self, parent_ref: Ref, snapshot: InstanceSnapshot) -> Ref {
|
||||||
&mut self,
|
let builder = InstanceBuilder::new(snapshot.class_name.to_owned())
|
||||||
properties: InstancePropertiesWithMeta,
|
.with_name(snapshot.name.to_owned())
|
||||||
parent_id: RbxId,
|
.with_properties(snapshot.properties);
|
||||||
) -> RbxId {
|
|
||||||
let id = self.inner.insert_instance(properties.properties, parent_id);
|
let referent = self.inner.insert(parent_ref, builder);
|
||||||
self.insert_metadata(id, properties.metadata);
|
self.insert_metadata(referent, snapshot.metadata);
|
||||||
id
|
|
||||||
|
for child in snapshot.children {
|
||||||
|
self.insert_instance(referent, child);
|
||||||
|
}
|
||||||
|
|
||||||
|
referent
|
||||||
}
|
}
|
||||||
|
|
||||||
pub fn remove_instance(&mut self, id: RbxId) -> Option<RojoTree> {
|
pub fn remove(&mut self, id: Ref) {
|
||||||
if let Some(inner) = self.inner.remove_instance(id) {
|
let mut to_move = VecDeque::new();
|
||||||
let mut metadata_map = HashMap::new();
|
to_move.push_back(id);
|
||||||
let mut path_to_ids = MultiMap::new();
|
|
||||||
|
|
||||||
self.move_metadata(id, &mut metadata_map, &mut path_to_ids);
|
while let Some(id) = to_move.pop_front() {
|
||||||
for instance in inner.descendants(id) {
|
self.remove_metadata(id);
|
||||||
self.move_metadata(instance.get_id(), &mut metadata_map, &mut path_to_ids);
|
|
||||||
|
if let Some(instance) = self.inner.get_by_ref(id) {
|
||||||
|
to_move.extend(instance.children().iter().copied());
|
||||||
}
|
}
|
||||||
|
|
||||||
Some(RojoTree {
|
|
||||||
inner,
|
|
||||||
metadata_map,
|
|
||||||
path_to_ids,
|
|
||||||
})
|
|
||||||
} else {
|
|
||||||
None
|
|
||||||
}
|
}
|
||||||
|
|
||||||
|
self.inner.destroy(id);
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Replaces the metadata associated with the given instance ID.
|
/// Replaces the metadata associated with the given instance ID.
|
||||||
pub fn update_metadata(&mut self, id: RbxId, metadata: InstanceMetadata) {
|
pub fn update_metadata(&mut self, id: Ref, metadata: InstanceMetadata) {
|
||||||
use std::collections::hash_map::Entry;
|
use std::collections::hash_map::Entry;
|
||||||
|
|
||||||
match self.metadata_map.entry(id) {
|
match self.metadata_map.entry(id) {
|
||||||
@@ -131,22 +145,22 @@ impl RojoTree {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
pub fn descendants(&self, id: RbxId) -> RojoDescendants<'_> {
|
pub fn descendants(&self, id: Ref) -> RojoDescendants<'_> {
|
||||||
RojoDescendants {
|
let mut queue = VecDeque::new();
|
||||||
inner: self.inner.descendants(id),
|
queue.push_back(id);
|
||||||
tree: self,
|
|
||||||
}
|
RojoDescendants { queue, tree: self }
|
||||||
}
|
}
|
||||||
|
|
||||||
pub fn get_ids_at_path(&self, path: &Path) -> &[RbxId] {
|
pub fn get_ids_at_path(&self, path: &Path) -> &[Ref] {
|
||||||
self.path_to_ids.get(path)
|
self.path_to_ids.get(path)
|
||||||
}
|
}
|
||||||
|
|
||||||
pub fn get_metadata(&self, id: RbxId) -> Option<&InstanceMetadata> {
|
pub fn get_metadata(&self, id: Ref) -> Option<&InstanceMetadata> {
|
||||||
self.metadata_map.get(&id)
|
self.metadata_map.get(&id)
|
||||||
}
|
}
|
||||||
|
|
||||||
fn insert_metadata(&mut self, id: RbxId, metadata: InstanceMetadata) {
|
fn insert_metadata(&mut self, id: Ref, metadata: InstanceMetadata) {
|
||||||
for path in &metadata.relevant_paths {
|
for path in &metadata.relevant_paths {
|
||||||
self.path_to_ids.insert(path.clone(), id);
|
self.path_to_ids.insert(path.clone(), id);
|
||||||
}
|
}
|
||||||
@@ -156,25 +170,17 @@ impl RojoTree {
|
|||||||
|
|
||||||
/// Moves the Rojo metadata from the instance with the given ID from this
|
/// Moves the Rojo metadata from the instance with the given ID from this
|
||||||
/// tree into some loose maps.
|
/// tree into some loose maps.
|
||||||
fn move_metadata(
|
fn remove_metadata(&mut self, id: Ref) {
|
||||||
&mut self,
|
|
||||||
id: RbxId,
|
|
||||||
metadata_map: &mut HashMap<RbxId, InstanceMetadata>,
|
|
||||||
path_to_ids: &mut MultiMap<PathBuf, RbxId>,
|
|
||||||
) {
|
|
||||||
let metadata = self.metadata_map.remove(&id).unwrap();
|
let metadata = self.metadata_map.remove(&id).unwrap();
|
||||||
|
|
||||||
for path in &metadata.relevant_paths {
|
for path in &metadata.relevant_paths {
|
||||||
self.path_to_ids.remove(path, id);
|
self.path_to_ids.remove(path, id);
|
||||||
path_to_ids.insert(path.clone(), id);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
metadata_map.insert(id, metadata);
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
pub struct RojoDescendants<'a> {
|
pub struct RojoDescendants<'a> {
|
||||||
inner: Descendants<'a>,
|
queue: VecDeque<Ref>,
|
||||||
tree: &'a RojoTree,
|
tree: &'a RojoTree,
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -182,50 +188,43 @@ impl<'a> Iterator for RojoDescendants<'a> {
|
|||||||
type Item = InstanceWithMeta<'a>;
|
type Item = InstanceWithMeta<'a>;
|
||||||
|
|
||||||
fn next(&mut self) -> Option<Self::Item> {
|
fn next(&mut self) -> Option<Self::Item> {
|
||||||
let instance = self.inner.next()?;
|
let id = self.queue.pop_front()?;
|
||||||
|
|
||||||
|
let instance = self
|
||||||
|
.tree
|
||||||
|
.inner
|
||||||
|
.get_by_ref(id)
|
||||||
|
.expect("Instance did not exist");
|
||||||
|
|
||||||
let metadata = self
|
let metadata = self
|
||||||
.tree
|
.tree
|
||||||
.get_metadata(instance.get_id())
|
.get_metadata(instance.referent())
|
||||||
.expect("Metadata did not exist for instance");
|
.expect("Metadata did not exist for instance");
|
||||||
|
|
||||||
|
self.queue.extend(instance.children().iter().copied());
|
||||||
|
|
||||||
Some(InstanceWithMeta { instance, metadata })
|
Some(InstanceWithMeta { instance, metadata })
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
/// RojoTree's equivalent of `RbxInstanceProperties`.
|
/// RojoTree's equivalent of `&'a Instance`.
|
||||||
#[derive(Debug, Clone)]
|
|
||||||
pub struct InstancePropertiesWithMeta {
|
|
||||||
pub properties: RbxInstanceProperties,
|
|
||||||
pub metadata: InstanceMetadata,
|
|
||||||
}
|
|
||||||
|
|
||||||
impl InstancePropertiesWithMeta {
|
|
||||||
pub fn new(properties: RbxInstanceProperties, metadata: InstanceMetadata) -> Self {
|
|
||||||
InstancePropertiesWithMeta {
|
|
||||||
properties,
|
|
||||||
metadata,
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
/// RojoTree's equivalent of `&'a RbxInstance`.
|
|
||||||
///
|
///
|
||||||
/// This has to be a value type for RojoTree because the instance and metadata
|
/// This has to be a value type for RojoTree because the instance and metadata
|
||||||
/// are stored in different places. The mutable equivalent is
|
/// are stored in different places. The mutable equivalent is
|
||||||
/// `InstanceWithMetaMut`.
|
/// `InstanceWithMetaMut`.
|
||||||
#[derive(Debug, Clone, Copy)]
|
#[derive(Debug, Clone, Copy)]
|
||||||
pub struct InstanceWithMeta<'a> {
|
pub struct InstanceWithMeta<'a> {
|
||||||
instance: &'a RbxInstance,
|
instance: &'a Instance,
|
||||||
metadata: &'a InstanceMetadata,
|
metadata: &'a InstanceMetadata,
|
||||||
}
|
}
|
||||||
|
|
||||||
impl<'a> InstanceWithMeta<'a> {
|
impl<'a> InstanceWithMeta<'a> {
|
||||||
pub fn id(&self) -> RbxId {
|
pub fn id(&self) -> Ref {
|
||||||
self.instance.get_id()
|
self.instance.referent()
|
||||||
}
|
}
|
||||||
|
|
||||||
pub fn parent(&self) -> Option<RbxId> {
|
pub fn parent(&self) -> Ref {
|
||||||
self.instance.get_parent_id()
|
self.instance.parent()
|
||||||
}
|
}
|
||||||
|
|
||||||
pub fn name(&self) -> &'a str {
|
pub fn name(&self) -> &'a str {
|
||||||
@@ -233,15 +232,15 @@ impl<'a> InstanceWithMeta<'a> {
|
|||||||
}
|
}
|
||||||
|
|
||||||
pub fn class_name(&self) -> &'a str {
|
pub fn class_name(&self) -> &'a str {
|
||||||
&self.instance.class_name
|
&self.instance.class
|
||||||
}
|
}
|
||||||
|
|
||||||
pub fn properties(&self) -> &'a HashMap<String, RbxValue> {
|
pub fn properties(&self) -> &'a HashMap<String, Variant> {
|
||||||
&self.instance.properties
|
&self.instance.properties
|
||||||
}
|
}
|
||||||
|
|
||||||
pub fn children(&self) -> &'a [RbxId] {
|
pub fn children(&self) -> &'a [Ref] {
|
||||||
self.instance.get_children_ids()
|
self.instance.children()
|
||||||
}
|
}
|
||||||
|
|
||||||
pub fn metadata(&self) -> &'a InstanceMetadata {
|
pub fn metadata(&self) -> &'a InstanceMetadata {
|
||||||
@@ -249,20 +248,20 @@ impl<'a> InstanceWithMeta<'a> {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
/// RojoTree's equivalent of `&'a mut RbxInstance`.
|
/// RojoTree's equivalent of `&'a mut Instance`.
|
||||||
///
|
///
|
||||||
/// This has to be a value type for RojoTree because the instance and metadata
|
/// This has to be a value type for RojoTree because the instance and metadata
|
||||||
/// are stored in different places. The immutable equivalent is
|
/// are stored in different places. The immutable equivalent is
|
||||||
/// `InstanceWithMeta`.
|
/// `InstanceWithMeta`.
|
||||||
#[derive(Debug)]
|
#[derive(Debug)]
|
||||||
pub struct InstanceWithMetaMut<'a> {
|
pub struct InstanceWithMetaMut<'a> {
|
||||||
instance: &'a mut RbxInstance,
|
instance: &'a mut Instance,
|
||||||
metadata: &'a mut InstanceMetadata,
|
metadata: &'a mut InstanceMetadata,
|
||||||
}
|
}
|
||||||
|
|
||||||
impl InstanceWithMetaMut<'_> {
|
impl InstanceWithMetaMut<'_> {
|
||||||
pub fn id(&self) -> RbxId {
|
pub fn id(&self) -> Ref {
|
||||||
self.instance.get_id()
|
self.instance.referent()
|
||||||
}
|
}
|
||||||
|
|
||||||
pub fn name(&self) -> &str {
|
pub fn name(&self) -> &str {
|
||||||
@@ -274,23 +273,23 @@ impl InstanceWithMetaMut<'_> {
|
|||||||
}
|
}
|
||||||
|
|
||||||
pub fn class_name(&self) -> &str {
|
pub fn class_name(&self) -> &str {
|
||||||
&self.instance.class_name
|
&self.instance.class
|
||||||
}
|
}
|
||||||
|
|
||||||
pub fn class_name_mut(&mut self) -> &mut String {
|
pub fn class_name_mut(&mut self) -> &mut String {
|
||||||
&mut self.instance.class_name
|
&mut self.instance.class
|
||||||
}
|
}
|
||||||
|
|
||||||
pub fn properties(&self) -> &HashMap<String, RbxValue> {
|
pub fn properties(&self) -> &HashMap<String, Variant> {
|
||||||
&self.instance.properties
|
&self.instance.properties
|
||||||
}
|
}
|
||||||
|
|
||||||
pub fn properties_mut(&mut self) -> &mut HashMap<String, RbxValue> {
|
pub fn properties_mut(&mut self) -> &mut HashMap<String, Variant> {
|
||||||
&mut self.instance.properties
|
&mut self.instance.properties
|
||||||
}
|
}
|
||||||
|
|
||||||
pub fn children(&self) -> &[RbxId] {
|
pub fn children(&self) -> &[Ref] {
|
||||||
self.instance.get_children_ids()
|
self.instance.children()
|
||||||
}
|
}
|
||||||
|
|
||||||
pub fn metadata(&self) -> &InstanceMetadata {
|
pub fn metadata(&self) -> &InstanceMetadata {
|
||||||
|
|||||||
@@ -3,7 +3,6 @@ use std::{collections::BTreeMap, path::Path};
|
|||||||
use anyhow::Context;
|
use anyhow::Context;
|
||||||
use maplit::hashmap;
|
use maplit::hashmap;
|
||||||
use memofs::{IoResultExt, Vfs};
|
use memofs::{IoResultExt, Vfs};
|
||||||
use rbx_dom_weak::RbxValue;
|
|
||||||
use serde::Serialize;
|
use serde::Serialize;
|
||||||
|
|
||||||
use crate::snapshot::{InstanceContext, InstanceMetadata, InstanceSnapshot};
|
use crate::snapshot::{InstanceContext, InstanceMetadata, InstanceSnapshot};
|
||||||
@@ -30,9 +29,7 @@ pub fn snapshot_csv(
|
|||||||
.name(instance_name)
|
.name(instance_name)
|
||||||
.class_name("LocalizationTable")
|
.class_name("LocalizationTable")
|
||||||
.properties(hashmap! {
|
.properties(hashmap! {
|
||||||
"Contents".to_owned() => RbxValue::String {
|
"Contents".to_owned() => table_contents.into(),
|
||||||
value: table_contents,
|
|
||||||
},
|
|
||||||
})
|
})
|
||||||
.metadata(
|
.metadata(
|
||||||
InstanceMetadata::new()
|
InstanceMetadata::new()
|
||||||
@@ -41,8 +38,8 @@ pub fn snapshot_csv(
|
|||||||
);
|
);
|
||||||
|
|
||||||
if let Some(meta_contents) = vfs.read(&meta_path).with_not_found()? {
|
if let Some(meta_contents) = vfs.read(&meta_path).with_not_found()? {
|
||||||
let mut metadata = AdjacentMetadata::from_slice(&meta_contents, &meta_path)?;
|
let mut metadata = AdjacentMetadata::from_slice(&meta_contents, meta_path)?;
|
||||||
metadata.apply_all(&mut snapshot);
|
metadata.apply_all(&mut snapshot)?;
|
||||||
}
|
}
|
||||||
|
|
||||||
Ok(Some(snapshot))
|
Ok(Some(snapshot))
|
||||||
|
|||||||
@@ -60,8 +60,8 @@ pub fn snapshot_dir(context: &InstanceContext, vfs: &Vfs, path: &Path) -> Snapsh
|
|||||||
);
|
);
|
||||||
|
|
||||||
if let Some(meta_contents) = vfs.read(&meta_path).with_not_found()? {
|
if let Some(meta_contents) = vfs.read(&meta_path).with_not_found()? {
|
||||||
let mut metadata = DirectoryMetadata::from_slice(&meta_contents, &meta_path)?;
|
let mut metadata = DirectoryMetadata::from_slice(&meta_contents, meta_path)?;
|
||||||
metadata.apply_all(&mut snapshot);
|
metadata.apply_all(&mut snapshot)?;
|
||||||
}
|
}
|
||||||
|
|
||||||
Ok(Some(snapshot))
|
Ok(Some(snapshot))
|
||||||
|
|||||||
@@ -3,7 +3,6 @@ use std::path::Path;
|
|||||||
use anyhow::Context;
|
use anyhow::Context;
|
||||||
use maplit::hashmap;
|
use maplit::hashmap;
|
||||||
use memofs::{IoResultExt, Vfs};
|
use memofs::{IoResultExt, Vfs};
|
||||||
use rbx_dom_weak::RbxValue;
|
|
||||||
|
|
||||||
use crate::{
|
use crate::{
|
||||||
lua_ast::{Expression, Statement},
|
lua_ast::{Expression, Statement},
|
||||||
@@ -26,9 +25,7 @@ pub fn snapshot_json(
|
|||||||
let as_lua = json_to_lua(value).to_string();
|
let as_lua = json_to_lua(value).to_string();
|
||||||
|
|
||||||
let properties = hashmap! {
|
let properties = hashmap! {
|
||||||
"Source".to_owned() => RbxValue::String {
|
"Source".to_owned() => as_lua.into(),
|
||||||
value: as_lua,
|
|
||||||
},
|
|
||||||
};
|
};
|
||||||
|
|
||||||
let meta_path = path.with_file_name(format!("{}.meta.json", instance_name));
|
let meta_path = path.with_file_name(format!("{}.meta.json", instance_name));
|
||||||
@@ -45,8 +42,8 @@ pub fn snapshot_json(
|
|||||||
);
|
);
|
||||||
|
|
||||||
if let Some(meta_contents) = vfs.read(&meta_path).with_not_found()? {
|
if let Some(meta_contents) = vfs.read(&meta_path).with_not_found()? {
|
||||||
let mut metadata = AdjacentMetadata::from_slice(&meta_contents, &meta_path)?;
|
let mut metadata = AdjacentMetadata::from_slice(&meta_contents, meta_path)?;
|
||||||
metadata.apply_all(&mut snapshot);
|
metadata.apply_all(&mut snapshot)?;
|
||||||
}
|
}
|
||||||
|
|
||||||
Ok(Some(snapshot))
|
Ok(Some(snapshot))
|
||||||
|
|||||||
@@ -2,11 +2,12 @@ use std::{borrow::Cow, collections::HashMap, path::Path};
|
|||||||
|
|
||||||
use anyhow::Context;
|
use anyhow::Context;
|
||||||
use memofs::Vfs;
|
use memofs::Vfs;
|
||||||
use rbx_dom_weak::UnresolvedRbxValue;
|
|
||||||
use rbx_reflection::try_resolve_value;
|
|
||||||
use serde::Deserialize;
|
use serde::Deserialize;
|
||||||
|
|
||||||
use crate::snapshot::{InstanceContext, InstanceSnapshot};
|
use crate::{
|
||||||
|
resolution::UnresolvedValue,
|
||||||
|
snapshot::{InstanceContext, InstanceSnapshot},
|
||||||
|
};
|
||||||
|
|
||||||
use super::middleware::SnapshotInstanceResult;
|
use super::middleware::SnapshotInstanceResult;
|
||||||
|
|
||||||
@@ -20,7 +21,10 @@ pub fn snapshot_json_model(
|
|||||||
let instance: JsonModel = serde_json::from_slice(&contents)
|
let instance: JsonModel = serde_json::from_slice(&contents)
|
||||||
.with_context(|| format!("File is not a valid JSON model: {}", path.display()))?;
|
.with_context(|| format!("File is not a valid JSON model: {}", path.display()))?;
|
||||||
|
|
||||||
let mut snapshot = instance.core.into_snapshot(instance_name.to_owned());
|
let mut snapshot = instance
|
||||||
|
.core
|
||||||
|
.into_snapshot(instance_name.to_owned())
|
||||||
|
.with_context(|| format!("Could not load JSON model: {}", path.display()))?;
|
||||||
|
|
||||||
snapshot.metadata = snapshot
|
snapshot.metadata = snapshot
|
||||||
.metadata
|
.metadata
|
||||||
@@ -58,36 +62,32 @@ struct JsonModelCore {
|
|||||||
children: Vec<JsonModelInstance>,
|
children: Vec<JsonModelInstance>,
|
||||||
|
|
||||||
#[serde(default = "HashMap::new", skip_serializing_if = "HashMap::is_empty")]
|
#[serde(default = "HashMap::new", skip_serializing_if = "HashMap::is_empty")]
|
||||||
properties: HashMap<String, UnresolvedRbxValue>,
|
properties: HashMap<String, UnresolvedValue>,
|
||||||
}
|
}
|
||||||
|
|
||||||
impl JsonModelCore {
|
impl JsonModelCore {
|
||||||
fn into_snapshot(self, name: String) -> InstanceSnapshot {
|
fn into_snapshot(self, name: String) -> anyhow::Result<InstanceSnapshot> {
|
||||||
let class_name = self.class_name;
|
let class_name = self.class_name;
|
||||||
|
|
||||||
let children = self
|
let mut children = Vec::with_capacity(self.children.len());
|
||||||
.children
|
for child in self.children {
|
||||||
.into_iter()
|
children.push(child.core.into_snapshot(child.name)?);
|
||||||
.map(|child| child.core.into_snapshot(child.name))
|
}
|
||||||
.collect();
|
|
||||||
|
|
||||||
let properties = self
|
let mut properties = HashMap::with_capacity(self.properties.len());
|
||||||
.properties
|
for (key, unresolved) in self.properties {
|
||||||
.into_iter()
|
let value = unresolved.resolve(&class_name, &key)?;
|
||||||
.map(|(key, value)| {
|
properties.insert(key, value);
|
||||||
try_resolve_value(&class_name, &key, &value).map(|resolved| (key, resolved))
|
}
|
||||||
})
|
|
||||||
.collect::<Result<HashMap<_, _>, _>>()
|
|
||||||
.expect("TODO: Handle rbx_reflection errors");
|
|
||||||
|
|
||||||
InstanceSnapshot {
|
Ok(InstanceSnapshot {
|
||||||
snapshot_id: None,
|
snapshot_id: None,
|
||||||
metadata: Default::default(),
|
metadata: Default::default(),
|
||||||
name: Cow::Owned(name),
|
name: Cow::Owned(name),
|
||||||
class_name: Cow::Owned(class_name),
|
class_name: Cow::Owned(class_name),
|
||||||
properties,
|
properties,
|
||||||
children,
|
children,
|
||||||
}
|
})
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -3,7 +3,6 @@ use std::{path::Path, str};
|
|||||||
use anyhow::Context;
|
use anyhow::Context;
|
||||||
use maplit::hashmap;
|
use maplit::hashmap;
|
||||||
use memofs::{IoResultExt, Vfs};
|
use memofs::{IoResultExt, Vfs};
|
||||||
use rbx_dom_weak::RbxValue;
|
|
||||||
|
|
||||||
use crate::snapshot::{InstanceContext, InstanceMetadata, InstanceSnapshot};
|
use crate::snapshot::{InstanceContext, InstanceMetadata, InstanceSnapshot};
|
||||||
|
|
||||||
@@ -38,9 +37,7 @@ pub fn snapshot_lua(context: &InstanceContext, vfs: &Vfs, path: &Path) -> Snapsh
|
|||||||
.name(instance_name)
|
.name(instance_name)
|
||||||
.class_name(class_name)
|
.class_name(class_name)
|
||||||
.properties(hashmap! {
|
.properties(hashmap! {
|
||||||
"Source".to_owned() => RbxValue::String {
|
"Source".to_owned() => contents_str.into(),
|
||||||
value: contents_str,
|
|
||||||
},
|
|
||||||
})
|
})
|
||||||
.metadata(
|
.metadata(
|
||||||
InstanceMetadata::new()
|
InstanceMetadata::new()
|
||||||
@@ -50,8 +47,8 @@ pub fn snapshot_lua(context: &InstanceContext, vfs: &Vfs, path: &Path) -> Snapsh
|
|||||||
);
|
);
|
||||||
|
|
||||||
if let Some(meta_contents) = vfs.read(&meta_path).with_not_found()? {
|
if let Some(meta_contents) = vfs.read(&meta_path).with_not_found()? {
|
||||||
let mut metadata = AdjacentMetadata::from_slice(&meta_contents, &meta_path)?;
|
let mut metadata = AdjacentMetadata::from_slice(&meta_contents, meta_path)?;
|
||||||
metadata.apply_all(&mut snapshot);
|
metadata.apply_all(&mut snapshot)?;
|
||||||
}
|
}
|
||||||
|
|
||||||
Ok(Some(snapshot))
|
Ok(Some(snapshot))
|
||||||
|
|||||||
@@ -1,11 +1,9 @@
|
|||||||
use std::{borrow::Cow, collections::HashMap, path::Path};
|
use std::{borrow::Cow, collections::HashMap, path::PathBuf};
|
||||||
|
|
||||||
use anyhow::Context;
|
use anyhow::{format_err, Context};
|
||||||
use rbx_dom_weak::UnresolvedRbxValue;
|
|
||||||
use rbx_reflection::try_resolve_value;
|
|
||||||
use serde::{Deserialize, Serialize};
|
use serde::{Deserialize, Serialize};
|
||||||
|
|
||||||
use crate::snapshot::InstanceSnapshot;
|
use crate::{resolution::UnresolvedValue, snapshot::InstanceSnapshot};
|
||||||
|
|
||||||
/// Represents metadata in a sibling file with the same basename.
|
/// Represents metadata in a sibling file with the same basename.
|
||||||
///
|
///
|
||||||
@@ -18,17 +16,23 @@ pub struct AdjacentMetadata {
|
|||||||
pub ignore_unknown_instances: Option<bool>,
|
pub ignore_unknown_instances: Option<bool>,
|
||||||
|
|
||||||
#[serde(default, skip_serializing_if = "HashMap::is_empty")]
|
#[serde(default, skip_serializing_if = "HashMap::is_empty")]
|
||||||
pub properties: HashMap<String, UnresolvedRbxValue>,
|
pub properties: HashMap<String, UnresolvedValue>,
|
||||||
|
|
||||||
|
#[serde(skip)]
|
||||||
|
pub path: PathBuf,
|
||||||
}
|
}
|
||||||
|
|
||||||
impl AdjacentMetadata {
|
impl AdjacentMetadata {
|
||||||
pub fn from_slice(slice: &[u8], path: &Path) -> anyhow::Result<Self> {
|
pub fn from_slice(slice: &[u8], path: PathBuf) -> anyhow::Result<Self> {
|
||||||
serde_json::from_slice(slice).with_context(|| {
|
let mut meta: Self = serde_json::from_slice(slice).with_context(|| {
|
||||||
format!(
|
format!(
|
||||||
"File contained malformed .meta.json data: {}",
|
"File contained malformed .meta.json data: {}",
|
||||||
path.display()
|
path.display()
|
||||||
)
|
)
|
||||||
})
|
})?;
|
||||||
|
|
||||||
|
meta.path = path;
|
||||||
|
Ok(meta)
|
||||||
}
|
}
|
||||||
|
|
||||||
pub fn apply_ignore_unknown_instances(&mut self, snapshot: &mut InstanceSnapshot) {
|
pub fn apply_ignore_unknown_instances(&mut self, snapshot: &mut InstanceSnapshot) {
|
||||||
@@ -37,23 +41,24 @@ impl AdjacentMetadata {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
pub fn apply_properties(&mut self, snapshot: &mut InstanceSnapshot) {
|
pub fn apply_properties(&mut self, snapshot: &mut InstanceSnapshot) -> anyhow::Result<()> {
|
||||||
let class_name = &snapshot.class_name;
|
let path = &self.path;
|
||||||
|
|
||||||
let source_properties = self.properties.drain().map(|(key, value)| {
|
for (key, unresolved) in self.properties.drain() {
|
||||||
try_resolve_value(class_name, &key, &value)
|
let value = unresolved
|
||||||
.map(|resolved| (key, resolved))
|
.resolve(&snapshot.class_name, &key)
|
||||||
.expect("TODO: Handle rbx_reflection errors")
|
.with_context(|| format!("error applying meta file {}", path.display()))?;
|
||||||
});
|
|
||||||
|
|
||||||
for (key, value) in source_properties {
|
|
||||||
snapshot.properties.insert(key, value);
|
snapshot.properties.insert(key, value);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
Ok(())
|
||||||
}
|
}
|
||||||
|
|
||||||
pub fn apply_all(&mut self, snapshot: &mut InstanceSnapshot) {
|
pub fn apply_all(&mut self, snapshot: &mut InstanceSnapshot) -> anyhow::Result<()> {
|
||||||
self.apply_ignore_unknown_instances(snapshot);
|
self.apply_ignore_unknown_instances(snapshot);
|
||||||
self.apply_properties(snapshot);
|
self.apply_properties(snapshot)?;
|
||||||
|
Ok(())
|
||||||
}
|
}
|
||||||
|
|
||||||
// TODO: Add method to allow selectively applying parts of metadata and
|
// TODO: Add method to allow selectively applying parts of metadata and
|
||||||
@@ -71,37 +76,50 @@ pub struct DirectoryMetadata {
|
|||||||
pub ignore_unknown_instances: Option<bool>,
|
pub ignore_unknown_instances: Option<bool>,
|
||||||
|
|
||||||
#[serde(default, skip_serializing_if = "HashMap::is_empty")]
|
#[serde(default, skip_serializing_if = "HashMap::is_empty")]
|
||||||
pub properties: HashMap<String, UnresolvedRbxValue>,
|
pub properties: HashMap<String, UnresolvedValue>,
|
||||||
|
|
||||||
#[serde(skip_serializing_if = "Option::is_none")]
|
#[serde(skip_serializing_if = "Option::is_none")]
|
||||||
pub class_name: Option<String>,
|
pub class_name: Option<String>,
|
||||||
|
|
||||||
|
#[serde(skip)]
|
||||||
|
pub path: PathBuf,
|
||||||
}
|
}
|
||||||
|
|
||||||
impl DirectoryMetadata {
|
impl DirectoryMetadata {
|
||||||
pub fn from_slice(slice: &[u8], path: &Path) -> anyhow::Result<Self> {
|
pub fn from_slice(slice: &[u8], path: PathBuf) -> anyhow::Result<Self> {
|
||||||
serde_json::from_slice(slice).with_context(|| {
|
let mut meta: Self = serde_json::from_slice(slice).with_context(|| {
|
||||||
format!(
|
format!(
|
||||||
"File contained malformed init.meta.json data: {}",
|
"File contained malformed init.meta.json data: {}",
|
||||||
path.display()
|
path.display()
|
||||||
)
|
)
|
||||||
})
|
})?;
|
||||||
|
|
||||||
|
meta.path = path;
|
||||||
|
Ok(meta)
|
||||||
}
|
}
|
||||||
|
|
||||||
pub fn apply_all(&mut self, snapshot: &mut InstanceSnapshot) {
|
pub fn apply_all(&mut self, snapshot: &mut InstanceSnapshot) -> anyhow::Result<()> {
|
||||||
self.apply_ignore_unknown_instances(snapshot);
|
self.apply_ignore_unknown_instances(snapshot);
|
||||||
self.apply_class_name(snapshot);
|
self.apply_class_name(snapshot)?;
|
||||||
self.apply_properties(snapshot);
|
self.apply_properties(snapshot)?;
|
||||||
|
|
||||||
|
Ok(())
|
||||||
}
|
}
|
||||||
|
|
||||||
fn apply_class_name(&mut self, snapshot: &mut InstanceSnapshot) {
|
fn apply_class_name(&mut self, snapshot: &mut InstanceSnapshot) -> anyhow::Result<()> {
|
||||||
if let Some(class_name) = self.class_name.take() {
|
if let Some(class_name) = self.class_name.take() {
|
||||||
if snapshot.class_name != "Folder" {
|
if snapshot.class_name != "Folder" {
|
||||||
// TODO: Turn into error type
|
// TODO: Turn into error type
|
||||||
panic!("className in init.meta.json can only be specified if the affected directory would turn into a Folder instance.");
|
return Err(format_err!(
|
||||||
|
"className in init.meta.json can only be specified if the \
|
||||||
|
affected directory would turn into a Folder instance."
|
||||||
|
));
|
||||||
}
|
}
|
||||||
|
|
||||||
snapshot.class_name = Cow::Owned(class_name);
|
snapshot.class_name = Cow::Owned(class_name);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
Ok(())
|
||||||
}
|
}
|
||||||
|
|
||||||
fn apply_ignore_unknown_instances(&mut self, snapshot: &mut InstanceSnapshot) {
|
fn apply_ignore_unknown_instances(&mut self, snapshot: &mut InstanceSnapshot) {
|
||||||
@@ -110,17 +128,17 @@ impl DirectoryMetadata {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
fn apply_properties(&mut self, snapshot: &mut InstanceSnapshot) {
|
fn apply_properties(&mut self, snapshot: &mut InstanceSnapshot) -> anyhow::Result<()> {
|
||||||
let class_name = &snapshot.class_name;
|
let path = &self.path;
|
||||||
|
|
||||||
let source_properties = self.properties.drain().map(|(key, value)| {
|
for (key, unresolved) in self.properties.drain() {
|
||||||
try_resolve_value(class_name, &key, &value)
|
let value = unresolved
|
||||||
.map(|resolved| (key, resolved))
|
.resolve(&snapshot.class_name, &key)
|
||||||
.expect("TODO: Handle rbx_reflection errors")
|
.with_context(|| format!("error applying meta file {}", path.display()))?;
|
||||||
});
|
|
||||||
|
|
||||||
for (key, value) in source_properties {
|
|
||||||
snapshot.properties.insert(key, value);
|
snapshot.properties.insert(key, value);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
Ok(())
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -2,7 +2,7 @@ use std::{borrow::Cow, collections::HashMap, path::Path};
|
|||||||
|
|
||||||
use anyhow::Context;
|
use anyhow::Context;
|
||||||
use memofs::Vfs;
|
use memofs::Vfs;
|
||||||
use rbx_reflection::{get_class_descriptor, try_resolve_value};
|
use rbx_reflection::ClassTag;
|
||||||
|
|
||||||
use crate::{
|
use crate::{
|
||||||
project::{Project, ProjectNode},
|
project::{Project, ProjectNode},
|
||||||
@@ -140,9 +140,9 @@ pub fn snapshot_project_node(
|
|||||||
// Members of DataModel with names that match known services are
|
// Members of DataModel with names that match known services are
|
||||||
// probably supposed to be those services.
|
// probably supposed to be those services.
|
||||||
|
|
||||||
let descriptor = get_class_descriptor(&name)?;
|
let descriptor = rbx_reflection_database::get().classes.get(&name)?;
|
||||||
|
|
||||||
if descriptor.is_service() {
|
if descriptor.tags.contains(&ClassTag::Service) {
|
||||||
return Some(name.clone());
|
return Some(name.clone());
|
||||||
}
|
}
|
||||||
} else if parent_class == "StarterPlayer" {
|
} else if parent_class == "StarterPlayer" {
|
||||||
@@ -171,11 +171,18 @@ pub fn snapshot_project_node(
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
for (key, value) in &node.properties {
|
for (key, unresolved) in &node.properties {
|
||||||
let resolved_value = try_resolve_value(&class_name, key, value)
|
let value = unresolved
|
||||||
.expect("TODO: Properly handle value resolution errors");
|
.clone()
|
||||||
|
.resolve(&class_name, key)
|
||||||
|
.with_context(|| {
|
||||||
|
format!(
|
||||||
|
"Unresolvable property in project at path {}",
|
||||||
|
project_path.display()
|
||||||
|
)
|
||||||
|
})?;
|
||||||
|
|
||||||
properties.insert(key.clone(), resolved_value);
|
properties.insert(key.clone(), value);
|
||||||
}
|
}
|
||||||
|
|
||||||
// If the user specified $ignoreUnknownInstances, overwrite the existing
|
// If the user specified $ignoreUnknownInstances, overwrite the existing
|
||||||
|
|||||||
@@ -1,8 +1,7 @@
|
|||||||
use std::{collections::HashMap, path::Path};
|
use std::path::Path;
|
||||||
|
|
||||||
use anyhow::Context;
|
use anyhow::Context;
|
||||||
use memofs::Vfs;
|
use memofs::Vfs;
|
||||||
use rbx_dom_weak::{RbxInstanceProperties, RbxTree};
|
|
||||||
|
|
||||||
use crate::snapshot::{InstanceContext, InstanceMetadata, InstanceSnapshot};
|
use crate::snapshot::{InstanceContext, InstanceMetadata, InstanceSnapshot};
|
||||||
|
|
||||||
@@ -14,18 +13,11 @@ pub fn snapshot_rbxm(
|
|||||||
path: &Path,
|
path: &Path,
|
||||||
instance_name: &str,
|
instance_name: &str,
|
||||||
) -> SnapshotInstanceResult {
|
) -> SnapshotInstanceResult {
|
||||||
let mut temp_tree = RbxTree::new(RbxInstanceProperties {
|
let temp_tree = rbx_binary::from_reader_default(vfs.read(path)?.as_slice())
|
||||||
name: "DataModel".to_owned(),
|
|
||||||
class_name: "DataModel".to_owned(),
|
|
||||||
properties: HashMap::new(),
|
|
||||||
});
|
|
||||||
|
|
||||||
let root_id = temp_tree.get_root_id();
|
|
||||||
rbx_binary::decode(&mut temp_tree, root_id, vfs.read(path)?.as_slice())
|
|
||||||
.with_context(|| format!("Malformed rbxm file: {}", path.display()))?;
|
.with_context(|| format!("Malformed rbxm file: {}", path.display()))?;
|
||||||
|
|
||||||
let root_instance = temp_tree.get_instance(root_id).unwrap();
|
let root_instance = temp_tree.root();
|
||||||
let children = root_instance.get_children_ids();
|
let children = root_instance.children();
|
||||||
|
|
||||||
if children.len() == 1 {
|
if children.len() == 1 {
|
||||||
let snapshot = InstanceSnapshot::from_tree(&temp_tree, children[0])
|
let snapshot = InstanceSnapshot::from_tree(&temp_tree, children[0])
|
||||||
|
|||||||
@@ -19,8 +19,8 @@ pub fn snapshot_rbxmx(
|
|||||||
let temp_tree = rbx_xml::from_reader(vfs.read(path)?.as_slice(), options)
|
let temp_tree = rbx_xml::from_reader(vfs.read(path)?.as_slice(), options)
|
||||||
.with_context(|| format!("Malformed rbxm file: {}", path.display()))?;
|
.with_context(|| format!("Malformed rbxm file: {}", path.display()))?;
|
||||||
|
|
||||||
let root_instance = temp_tree.get_instance(temp_tree.get_root_id()).unwrap();
|
let root_instance = temp_tree.root();
|
||||||
let children = root_instance.get_children_ids();
|
let children = root_instance.children();
|
||||||
|
|
||||||
if children.len() == 1 {
|
if children.len() == 1 {
|
||||||
let snapshot = InstanceSnapshot::from_tree(&temp_tree, children[0])
|
let snapshot = InstanceSnapshot::from_tree(&temp_tree, children[0])
|
||||||
|
|||||||
@@ -14,7 +14,7 @@ name: foo
|
|||||||
class_name: IntValue
|
class_name: IntValue
|
||||||
properties:
|
properties:
|
||||||
Value:
|
Value:
|
||||||
Type: Int32
|
Type: Int64
|
||||||
Value: 5
|
Value: 5
|
||||||
children:
|
children:
|
||||||
- snapshot_id: ~
|
- snapshot_id: ~
|
||||||
|
|||||||
@@ -3,7 +3,6 @@ use std::{path::Path, str};
|
|||||||
use anyhow::Context;
|
use anyhow::Context;
|
||||||
use maplit::hashmap;
|
use maplit::hashmap;
|
||||||
use memofs::{IoResultExt, Vfs};
|
use memofs::{IoResultExt, Vfs};
|
||||||
use rbx_dom_weak::RbxValue;
|
|
||||||
|
|
||||||
use crate::snapshot::{InstanceContext, InstanceMetadata, InstanceSnapshot};
|
use crate::snapshot::{InstanceContext, InstanceMetadata, InstanceSnapshot};
|
||||||
|
|
||||||
@@ -21,9 +20,7 @@ pub fn snapshot_txt(
|
|||||||
.to_owned();
|
.to_owned();
|
||||||
|
|
||||||
let properties = hashmap! {
|
let properties = hashmap! {
|
||||||
"Value".to_owned() => RbxValue::String {
|
"Value".to_owned() => contents_str.into(),
|
||||||
value: contents_str,
|
|
||||||
},
|
|
||||||
};
|
};
|
||||||
|
|
||||||
let meta_path = path.with_file_name(format!("{}.meta.json", instance_name));
|
let meta_path = path.with_file_name(format!("{}.meta.json", instance_name));
|
||||||
@@ -40,8 +37,8 @@ pub fn snapshot_txt(
|
|||||||
);
|
);
|
||||||
|
|
||||||
if let Some(meta_contents) = vfs.read(&meta_path).with_not_found()? {
|
if let Some(meta_contents) = vfs.read(&meta_path).with_not_found()? {
|
||||||
let mut metadata = AdjacentMetadata::from_slice(&meta_contents, &meta_path)?;
|
let mut metadata = AdjacentMetadata::from_slice(&meta_contents, meta_path)?;
|
||||||
metadata.apply_all(&mut snapshot);
|
metadata.apply_all(&mut snapshot)?;
|
||||||
}
|
}
|
||||||
|
|
||||||
Ok(Some(snapshot))
|
Ok(Some(snapshot))
|
||||||
|
|||||||
@@ -1,6 +1,6 @@
|
|||||||
use std::collections::HashMap;
|
use std::collections::HashMap;
|
||||||
|
|
||||||
use rbx_dom_weak::{RbxId, RbxValue};
|
use rbx_dom_weak::types::{Ref, Variant};
|
||||||
use rojo_insta_ext::RedactionMap;
|
use rojo_insta_ext::RedactionMap;
|
||||||
use serde::Serialize;
|
use serde::Serialize;
|
||||||
|
|
||||||
@@ -29,15 +29,15 @@ pub fn intern_tree(tree: &RojoTree, redactions: &mut RedactionMap) {
|
|||||||
/// Copy of data from RojoTree in the right shape to have useful snapshots.
|
/// Copy of data from RojoTree in the right shape to have useful snapshots.
|
||||||
#[derive(Debug, Serialize)]
|
#[derive(Debug, Serialize)]
|
||||||
struct InstanceView {
|
struct InstanceView {
|
||||||
id: RbxId,
|
id: Ref,
|
||||||
name: String,
|
name: String,
|
||||||
class_name: String,
|
class_name: String,
|
||||||
properties: HashMap<String, RbxValue>,
|
properties: HashMap<String, Variant>,
|
||||||
metadata: InstanceMetadata,
|
metadata: InstanceMetadata,
|
||||||
children: Vec<InstanceView>,
|
children: Vec<InstanceView>,
|
||||||
}
|
}
|
||||||
|
|
||||||
fn extract_instance_view(tree: &RojoTree, id: RbxId) -> InstanceView {
|
fn extract_instance_view(tree: &RojoTree, id: Ref) -> InstanceView {
|
||||||
let instance = tree.get_instance(id).unwrap();
|
let instance = tree.get_instance(id).unwrap();
|
||||||
|
|
||||||
InstanceView {
|
InstanceView {
|
||||||
|
|||||||
@@ -1,12 +1,12 @@
|
|||||||
//! Defines Rojo's HTTP API, all under /api. These endpoints generally return
|
//! Defines Rojo's HTTP API, all under /api. These endpoints generally return
|
||||||
//! JSON.
|
//! JSON.
|
||||||
|
|
||||||
use std::{collections::HashMap, fs, path::PathBuf, sync::Arc};
|
use std::{collections::HashMap, fs, path::PathBuf, str::FromStr, sync::Arc};
|
||||||
|
|
||||||
use futures::{Future, Stream};
|
use futures::{Future, Stream};
|
||||||
|
|
||||||
use hyper::{service::Service, Body, Method, Request, StatusCode};
|
use hyper::{service::Service, Body, Method, Request, StatusCode};
|
||||||
use rbx_dom_weak::RbxId;
|
use rbx_dom_weak::types::Ref;
|
||||||
|
|
||||||
use crate::{
|
use crate::{
|
||||||
serve_session::ServeSession,
|
serve_session::ServeSession,
|
||||||
@@ -200,11 +200,11 @@ impl ApiService {
|
|||||||
|
|
||||||
fn handle_api_read(&self, request: Request<Body>) -> <Self as Service>::Future {
|
fn handle_api_read(&self, request: Request<Body>) -> <Self as Service>::Future {
|
||||||
let argument = &request.uri().path()["/api/read/".len()..];
|
let argument = &request.uri().path()["/api/read/".len()..];
|
||||||
let requested_ids: Option<Vec<RbxId>> = argument.split(',').map(RbxId::parse_str).collect();
|
let requested_ids: Result<Vec<Ref>, _> = argument.split(',').map(Ref::from_str).collect();
|
||||||
|
|
||||||
let requested_ids = match requested_ids {
|
let requested_ids = match requested_ids {
|
||||||
Some(ids) => ids,
|
Ok(ids) => ids,
|
||||||
None => {
|
Err(_) => {
|
||||||
return json(
|
return json(
|
||||||
ErrorResponse::bad_request("Malformed ID list"),
|
ErrorResponse::bad_request("Malformed ID list"),
|
||||||
StatusCode::BAD_REQUEST,
|
StatusCode::BAD_REQUEST,
|
||||||
@@ -239,9 +239,9 @@ impl ApiService {
|
|||||||
/// Open a script with the given ID in the user's default text editor.
|
/// Open a script with the given ID in the user's default text editor.
|
||||||
fn handle_api_open(&self, request: Request<Body>) -> <Self as Service>::Future {
|
fn handle_api_open(&self, request: Request<Body>) -> <Self as Service>::Future {
|
||||||
let argument = &request.uri().path()["/api/open/".len()..];
|
let argument = &request.uri().path()["/api/open/".len()..];
|
||||||
let requested_id = match RbxId::parse_str(argument) {
|
let requested_id = match Ref::from_str(argument) {
|
||||||
Some(id) => id,
|
Ok(id) => id,
|
||||||
None => {
|
Err(_) => {
|
||||||
return json(
|
return json(
|
||||||
ErrorResponse::bad_request("Invalid instance ID"),
|
ErrorResponse::bad_request("Invalid instance ID"),
|
||||||
StatusCode::BAD_REQUEST,
|
StatusCode::BAD_REQUEST,
|
||||||
|
|||||||
@@ -5,7 +5,7 @@ use std::{
|
|||||||
collections::{HashMap, HashSet},
|
collections::{HashMap, HashSet},
|
||||||
};
|
};
|
||||||
|
|
||||||
use rbx_dom_weak::{RbxId, RbxValue};
|
use rbx_dom_weak::types::{Ref, Variant};
|
||||||
use serde::{Deserialize, Serialize};
|
use serde::{Deserialize, Serialize};
|
||||||
|
|
||||||
use crate::{
|
use crate::{
|
||||||
@@ -17,28 +17,28 @@ use crate::{
|
|||||||
pub(crate) const SERVER_VERSION: &str = env!("CARGO_PKG_VERSION");
|
pub(crate) const SERVER_VERSION: &str = env!("CARGO_PKG_VERSION");
|
||||||
|
|
||||||
/// Current protocol version, which is required to match.
|
/// Current protocol version, which is required to match.
|
||||||
pub const PROTOCOL_VERSION: u64 = 3;
|
pub const PROTOCOL_VERSION: u64 = 4;
|
||||||
|
|
||||||
/// Message returned by Rojo API when a change has occurred.
|
/// Message returned by Rojo API when a change has occurred.
|
||||||
#[derive(Debug, Serialize, Deserialize)]
|
#[derive(Debug, Serialize, Deserialize)]
|
||||||
#[serde(rename_all = "camelCase")]
|
#[serde(rename_all = "camelCase")]
|
||||||
pub struct SubscribeMessage<'a> {
|
pub struct SubscribeMessage<'a> {
|
||||||
pub removed: Vec<RbxId>,
|
pub removed: Vec<Ref>,
|
||||||
pub added: HashMap<RbxId, Instance<'a>>,
|
pub added: HashMap<Ref, Instance<'a>>,
|
||||||
pub updated: Vec<InstanceUpdate>,
|
pub updated: Vec<InstanceUpdate>,
|
||||||
}
|
}
|
||||||
|
|
||||||
#[derive(Debug, Serialize, Deserialize)]
|
#[derive(Debug, Serialize, Deserialize)]
|
||||||
#[serde(rename_all = "camelCase")]
|
#[serde(rename_all = "camelCase")]
|
||||||
pub struct InstanceUpdate {
|
pub struct InstanceUpdate {
|
||||||
pub id: RbxId,
|
pub id: Ref,
|
||||||
pub changed_name: Option<String>,
|
pub changed_name: Option<String>,
|
||||||
pub changed_class_name: Option<String>,
|
pub changed_class_name: Option<String>,
|
||||||
|
|
||||||
// TODO: Transform from HashMap<String, Option<_>> to something else, since
|
// TODO: Transform from HashMap<String, Option<_>> to something else, since
|
||||||
// null will get lost when decoding from JSON in some languages.
|
// null will get lost when decoding from JSON in some languages.
|
||||||
#[serde(default)]
|
#[serde(default)]
|
||||||
pub changed_properties: HashMap<String, Option<RbxValue>>,
|
pub changed_properties: HashMap<String, Option<Variant>>,
|
||||||
pub changed_metadata: Option<InstanceMetadata>,
|
pub changed_metadata: Option<InstanceMetadata>,
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -59,23 +59,36 @@ impl InstanceMetadata {
|
|||||||
#[derive(Debug, Serialize, Deserialize)]
|
#[derive(Debug, Serialize, Deserialize)]
|
||||||
#[serde(rename_all = "PascalCase")]
|
#[serde(rename_all = "PascalCase")]
|
||||||
pub struct Instance<'a> {
|
pub struct Instance<'a> {
|
||||||
pub id: RbxId,
|
pub id: Ref,
|
||||||
pub parent: Option<RbxId>,
|
pub parent: Ref,
|
||||||
pub name: Cow<'a, str>,
|
pub name: Cow<'a, str>,
|
||||||
pub class_name: Cow<'a, str>,
|
pub class_name: Cow<'a, str>,
|
||||||
pub properties: Cow<'a, HashMap<String, RbxValue>>,
|
pub properties: HashMap<String, Cow<'a, Variant>>,
|
||||||
pub children: Cow<'a, [RbxId]>,
|
pub children: Cow<'a, [Ref]>,
|
||||||
pub metadata: Option<InstanceMetadata>,
|
pub metadata: Option<InstanceMetadata>,
|
||||||
}
|
}
|
||||||
|
|
||||||
impl<'a> Instance<'a> {
|
impl<'a> Instance<'a> {
|
||||||
pub(crate) fn from_rojo_instance(source: InstanceWithMeta<'_>) -> Instance<'_> {
|
pub(crate) fn from_rojo_instance(source: InstanceWithMeta<'_>) -> Instance<'_> {
|
||||||
|
let properties = source
|
||||||
|
.properties()
|
||||||
|
.iter()
|
||||||
|
.filter_map(|(key, value)| {
|
||||||
|
// SharedString values can't be serialized via Serde
|
||||||
|
if matches!(value, Variant::SharedString(_)) {
|
||||||
|
return None;
|
||||||
|
}
|
||||||
|
|
||||||
|
Some((key.clone(), Cow::Borrowed(value)))
|
||||||
|
})
|
||||||
|
.collect();
|
||||||
|
|
||||||
Instance {
|
Instance {
|
||||||
id: source.id(),
|
id: source.id(),
|
||||||
parent: source.parent(),
|
parent: source.parent(),
|
||||||
name: Cow::Borrowed(source.name()),
|
name: Cow::Borrowed(source.name()),
|
||||||
class_name: Cow::Borrowed(source.class_name()),
|
class_name: Cow::Borrowed(source.class_name()),
|
||||||
properties: Cow::Borrowed(source.properties()),
|
properties,
|
||||||
children: Cow::Borrowed(source.children()),
|
children: Cow::Borrowed(source.children()),
|
||||||
metadata: Some(InstanceMetadata::from_rojo_metadata(source.metadata())),
|
metadata: Some(InstanceMetadata::from_rojo_metadata(source.metadata())),
|
||||||
}
|
}
|
||||||
@@ -91,7 +104,7 @@ pub struct ServerInfoResponse {
|
|||||||
pub protocol_version: u64,
|
pub protocol_version: u64,
|
||||||
pub project_name: String,
|
pub project_name: String,
|
||||||
pub expected_place_ids: Option<HashSet<u64>>,
|
pub expected_place_ids: Option<HashSet<u64>>,
|
||||||
pub root_instance_id: RbxId,
|
pub root_instance_id: Ref,
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Response body from /api/read/{id}
|
/// Response body from /api/read/{id}
|
||||||
@@ -100,17 +113,17 @@ pub struct ServerInfoResponse {
|
|||||||
pub struct ReadResponse<'a> {
|
pub struct ReadResponse<'a> {
|
||||||
pub session_id: SessionId,
|
pub session_id: SessionId,
|
||||||
pub message_cursor: u32,
|
pub message_cursor: u32,
|
||||||
pub instances: HashMap<RbxId, Instance<'a>>,
|
pub instances: HashMap<Ref, Instance<'a>>,
|
||||||
}
|
}
|
||||||
|
|
||||||
#[derive(Debug, Serialize, Deserialize)]
|
#[derive(Debug, Serialize, Deserialize)]
|
||||||
#[serde(rename_all = "camelCase")]
|
#[serde(rename_all = "camelCase")]
|
||||||
pub struct WriteRequest {
|
pub struct WriteRequest {
|
||||||
pub session_id: SessionId,
|
pub session_id: SessionId,
|
||||||
pub removed: Vec<RbxId>,
|
pub removed: Vec<Ref>,
|
||||||
|
|
||||||
#[serde(default)]
|
#[serde(default)]
|
||||||
pub added: HashMap<RbxId, ()>,
|
pub added: HashMap<Ref, ()>,
|
||||||
pub updated: Vec<InstanceUpdate>,
|
pub updated: Vec<InstanceUpdate>,
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -4,7 +4,7 @@ pub mod interface;
|
|||||||
mod ui;
|
mod ui;
|
||||||
mod util;
|
mod util;
|
||||||
|
|
||||||
use std::sync::Arc;
|
use std::{net::SocketAddr, sync::Arc};
|
||||||
|
|
||||||
use futures::{
|
use futures::{
|
||||||
future::{self, FutureResult},
|
future::{self, FutureResult},
|
||||||
@@ -57,9 +57,7 @@ impl LiveServer {
|
|||||||
LiveServer { serve_session }
|
LiveServer { serve_session }
|
||||||
}
|
}
|
||||||
|
|
||||||
pub fn start(self, port: u16) {
|
pub fn start(self, address: SocketAddr) {
|
||||||
let address = ([127, 0, 0, 1], port).into();
|
|
||||||
|
|
||||||
let server = Server::bind(&address)
|
let server = Server::bind(&address)
|
||||||
.serve(move || {
|
.serve(move || {
|
||||||
let service: FutureResult<_, hyper::Error> =
|
let service: FutureResult<_, hyper::Error> =
|
||||||
|
|||||||
@@ -5,7 +5,7 @@ use std::{borrow::Cow, sync::Arc, time::Duration};
|
|||||||
use futures::{future, Future};
|
use futures::{future, Future};
|
||||||
use hyper::{header, service::Service, Body, Method, Request, Response, StatusCode};
|
use hyper::{header, service::Service, Body, Method, Request, Response, StatusCode};
|
||||||
use maplit::hashmap;
|
use maplit::hashmap;
|
||||||
use rbx_dom_weak::{RbxId, RbxValue};
|
use rbx_dom_weak::types::{Ref, Variant};
|
||||||
use ritz::{html, Fragment, HtmlContent, HtmlSelfClosingTag};
|
use ritz::{html, Fragment, HtmlContent, HtmlSelfClosingTag};
|
||||||
|
|
||||||
use crate::{
|
use crate::{
|
||||||
@@ -93,7 +93,7 @@ impl UiService {
|
|||||||
.unwrap()
|
.unwrap()
|
||||||
}
|
}
|
||||||
|
|
||||||
fn instance(tree: &RojoTree, id: RbxId) -> HtmlContent<'_> {
|
fn instance(tree: &RojoTree, id: Ref) -> HtmlContent<'_> {
|
||||||
let instance = tree.get_instance(id).unwrap();
|
let instance = tree.get_instance(id).unwrap();
|
||||||
let children_list: Vec<_> = instance
|
let children_list: Vec<_> = instance
|
||||||
.children()
|
.children()
|
||||||
@@ -126,7 +126,7 @@ impl UiService {
|
|||||||
.map(|(key, value)| {
|
.map(|(key, value)| {
|
||||||
html! {
|
html! {
|
||||||
<div class="instance-property" title={ Self::display_value(value) }>
|
<div class="instance-property" title={ Self::display_value(value) }>
|
||||||
{ key.clone() } ": " { format!("{:?}", value.get_type()) }
|
{ key.clone() } ": " { format!("{:?}", value.ty()) }
|
||||||
</div>
|
</div>
|
||||||
}
|
}
|
||||||
})
|
})
|
||||||
@@ -198,7 +198,7 @@ impl UiService {
|
|||||||
|
|
||||||
html! {
|
html! {
|
||||||
<div class="instance">
|
<div class="instance">
|
||||||
<label class="instance-title" for={ format!("instance-{}", id) }>
|
<label class="instance-title" for={ format!("instance-{:?}", id) }>
|
||||||
{ instance.name().to_owned() }
|
{ instance.name().to_owned() }
|
||||||
{ class_name_specifier }
|
{ class_name_specifier }
|
||||||
</label>
|
</label>
|
||||||
@@ -209,10 +209,10 @@ impl UiService {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
fn display_value(value: &RbxValue) -> String {
|
fn display_value(value: &Variant) -> String {
|
||||||
match value {
|
match value {
|
||||||
RbxValue::String { value } => value.clone(),
|
Variant::String(value) => value.clone(),
|
||||||
RbxValue::Bool { value } => value.to_string(),
|
Variant::Bool(value) => value.to_string(),
|
||||||
_ => format!("{:?}", value),
|
_ => format!("{:?}", value),
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -288,14 +288,14 @@ impl UiService {
|
|||||||
struct ExpandableSection<'a> {
|
struct ExpandableSection<'a> {
|
||||||
title: &'a str,
|
title: &'a str,
|
||||||
class_name: &'a str,
|
class_name: &'a str,
|
||||||
id: RbxId,
|
id: Ref,
|
||||||
expanded: bool,
|
expanded: bool,
|
||||||
content: HtmlContent<'a>,
|
content: HtmlContent<'a>,
|
||||||
}
|
}
|
||||||
|
|
||||||
impl<'a> ExpandableSection<'a> {
|
impl<'a> ExpandableSection<'a> {
|
||||||
fn render(self) -> HtmlContent<'a> {
|
fn render(self) -> HtmlContent<'a> {
|
||||||
let input_id = format!("{}-{}", self.class_name, self.id);
|
let input_id = format!("{}-{:?}", self.class_name, self.id);
|
||||||
|
|
||||||
// We need to specify this input manually because Ritz doesn't have
|
// We need to specify this input manually because Ritz doesn't have
|
||||||
// support for conditional attributes like `checked`.
|
// support for conditional attributes like `checked`.
|
||||||
|
|||||||
12
test-projects/enums/default.project.json
Normal file
12
test-projects/enums/default.project.json
Normal file
@@ -0,0 +1,12 @@
|
|||||||
|
{
|
||||||
|
"name": "enums",
|
||||||
|
"tree": {
|
||||||
|
"$className": "DataModel",
|
||||||
|
|
||||||
|
"Lighting": {
|
||||||
|
"$properties": {
|
||||||
|
"Technology": "Voxel"
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -1,6 +1,12 @@
|
|||||||
{
|
{
|
||||||
"name": "unions",
|
"name": "unions",
|
||||||
"tree": {
|
"tree": {
|
||||||
"$path": "src"
|
"$className": "DataModel",
|
||||||
|
|
||||||
|
"Workspace": {
|
||||||
|
"TwoParts": {
|
||||||
|
"$path": "src"
|
||||||
|
}
|
||||||
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -1,6 +1,6 @@
|
|||||||
use std::collections::HashMap;
|
use std::collections::HashMap;
|
||||||
|
|
||||||
use rbx_dom_weak::RbxId;
|
use rbx_dom_weak::types::Ref;
|
||||||
use serde::Serialize;
|
use serde::Serialize;
|
||||||
|
|
||||||
use librojo::web_api::{Instance, InstanceUpdate, ReadResponse, SubscribeResponse};
|
use librojo::web_api::{Instance, InstanceUpdate, ReadResponse, SubscribeResponse};
|
||||||
@@ -31,8 +31,8 @@ pub trait Internable<T> {
|
|||||||
fn intern(&self, redactions: &mut RedactionMap, extra: T);
|
fn intern(&self, redactions: &mut RedactionMap, extra: T);
|
||||||
}
|
}
|
||||||
|
|
||||||
impl Internable<RbxId> for ReadResponse<'_> {
|
impl Internable<Ref> for ReadResponse<'_> {
|
||||||
fn intern(&self, redactions: &mut RedactionMap, root_id: RbxId) {
|
fn intern(&self, redactions: &mut RedactionMap, root_id: Ref) {
|
||||||
redactions.intern(root_id);
|
redactions.intern(root_id);
|
||||||
|
|
||||||
let root_instance = self.instances.get(&root_id).unwrap();
|
let root_instance = self.instances.get(&root_id).unwrap();
|
||||||
@@ -43,12 +43,8 @@ impl Internable<RbxId> for ReadResponse<'_> {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
impl<'a> Internable<&'a HashMap<RbxId, Instance<'_>>> for Instance<'a> {
|
impl<'a> Internable<&'a HashMap<Ref, Instance<'_>>> for Instance<'a> {
|
||||||
fn intern(
|
fn intern(&self, redactions: &mut RedactionMap, other_instances: &HashMap<Ref, Instance<'_>>) {
|
||||||
&self,
|
|
||||||
redactions: &mut RedactionMap,
|
|
||||||
other_instances: &HashMap<RbxId, Instance<'_>>,
|
|
||||||
) {
|
|
||||||
redactions.intern(self.id);
|
redactions.intern(self.id);
|
||||||
|
|
||||||
for child_id in self.children.iter() {
|
for child_id in self.children.iter() {
|
||||||
@@ -75,7 +71,7 @@ fn intern_instance_updates(redactions: &mut RedactionMap, updates: &[InstanceUpd
|
|||||||
|
|
||||||
fn intern_instance_additions(
|
fn intern_instance_additions(
|
||||||
redactions: &mut RedactionMap,
|
redactions: &mut RedactionMap,
|
||||||
additions: &HashMap<RbxId, Instance<'_>>,
|
additions: &HashMap<Ref, Instance<'_>>,
|
||||||
) {
|
) {
|
||||||
// This method redacts in a deterministic order from a HashMap by collecting
|
// This method redacts in a deterministic order from a HashMap by collecting
|
||||||
// all of the instances that are direct children of instances we've already
|
// all of the instances that are direct children of instances we've already
|
||||||
@@ -83,7 +79,7 @@ fn intern_instance_additions(
|
|||||||
let mut added_roots = Vec::new();
|
let mut added_roots = Vec::new();
|
||||||
|
|
||||||
for (id, added) in additions {
|
for (id, added) in additions {
|
||||||
let parent_id = added.parent.unwrap();
|
let parent_id = added.parent;
|
||||||
let parent_redacted = redactions.get_redacted_value(parent_id);
|
let parent_redacted = redactions.get_redacted_value(parent_id);
|
||||||
|
|
||||||
// Here, we assume that instances are only added to other instances that
|
// Here, we assume that instances are only added to other instances that
|
||||||
|
|||||||
@@ -7,7 +7,7 @@ use std::{
|
|||||||
time::Duration,
|
time::Duration,
|
||||||
};
|
};
|
||||||
|
|
||||||
use rbx_dom_weak::RbxId;
|
use rbx_dom_weak::types::Ref;
|
||||||
|
|
||||||
use tempfile::{tempdir, TempDir};
|
use tempfile::{tempdir, TempDir};
|
||||||
|
|
||||||
@@ -146,7 +146,7 @@ impl TestServeSession {
|
|||||||
Ok(serde_json::from_str(&body).expect("Server returned malformed response"))
|
Ok(serde_json::from_str(&body).expect("Server returned malformed response"))
|
||||||
}
|
}
|
||||||
|
|
||||||
pub fn get_api_read(&self, id: RbxId) -> Result<ReadResponse, reqwest::Error> {
|
pub fn get_api_read(&self, id: Ref) -> Result<ReadResponse, reqwest::Error> {
|
||||||
let url = format!("http://localhost:{}/api/read/{}", self.port, id);
|
let url = format!("http://localhost:{}/api/read/{}", self.port, id);
|
||||||
let body = reqwest::get(&url)?.text()?;
|
let body = reqwest::get(&url)?.text()?;
|
||||||
|
|
||||||
|
|||||||
@@ -49,6 +49,7 @@ gen_build_tests! {
|
|||||||
server_init,
|
server_init,
|
||||||
txt,
|
txt,
|
||||||
txt_in_folder,
|
txt_in_folder,
|
||||||
|
unresolved_values,
|
||||||
}
|
}
|
||||||
|
|
||||||
fn run_build_test(test_name: &str) {
|
fn run_build_test(test_name: &str) {
|
||||||
|
|||||||
Reference in New Issue
Block a user