More consistent handling of non-Unicode file names (should be rare)

This commit is contained in:
Lucien Greathouse
2019-10-09 17:15:34 -07:00
parent dca88e8272
commit dfabc07044
4 changed files with 46 additions and 11 deletions

View File

@@ -9,7 +9,10 @@ use crate::{
snapshot::InstanceSnapshot,
};
use super::middleware::{SnapshotFileResult, SnapshotInstanceResult, SnapshotMiddleware};
use super::{
error::SnapshotError,
middleware::{SnapshotFileResult, SnapshotInstanceResult, SnapshotMiddleware},
};
pub struct SnapshotJsonModel;
@@ -22,7 +25,12 @@ impl SnapshotMiddleware for SnapshotJsonModel {
return Ok(None);
}
let file_name = entry.path().file_name().unwrap().to_string_lossy();
let file_name = entry
.path()
.file_name()
.unwrap()
.to_str()
.ok_or_else(|| SnapshotError::file_name_bad_unicode(entry.path()))?;
let instance_name = match match_trailing(&file_name, ".model.json") {
Some(name) => name.to_owned(),