Switch plugin packages back to git submodules (#678)

Alright, so I hate to be the one to do this, but #584 broke crates.io
publishing and also caused librojo to be unusable. I see that there was
some discussion on Discord shortly after the problem was realized, but
there was no action taken.

I think keeping librojo and publishing working far, far outweigh any
convenience added by Wally.

I've kept the same `Packages` naming convention to keep the diff
minimal.

.github/workflows/ci.yml

@@ -20,6 +20,8 @@ jobs:
 
     steps:
     - uses: actions/checkout@v3
+      with:
+        submodules: true
 
     - name: Install Rust
       uses: actions-rs/toolchain@v1
@@ -33,12 +35,6 @@ jobs:
       with:
         version: 'v0.2.7'
 
-    - name: Install packages
-      run: |
-        cd plugin
-        wally install
-        cd ..
-
     - name: Build
       run: cargo build --locked --verbose
 
@@ -51,6 +47,8 @@ jobs:
 
     steps:
     - uses: actions/checkout@v3
+      with:
+        submodules: true
 
     - name: Install Rust
       uses: actions-rs/toolchain@v1
@@ -64,14 +62,8 @@ jobs:
       with:
         version: 'v0.2.7'
 
-    - name: Install packages
-      run: |
-        cd plugin
-        wally install
-        cd ..
-
     - name: Rustfmt
       run: cargo fmt -- --check
 
     - name: Clippy
-      run: cargo clippy
+      run: cargo clippy

.github/workflows/release.yml

@@ -28,6 +28,8 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
+        with:
+          submodules: true
 
       - name: Setup Aftman
         uses: ok-nick/setup-aftman@v0.1.0
@@ -36,12 +38,6 @@ jobs:
           trust-check: false
           version: 'v0.2.6'
 
-      - name: Install packages
-        run: |
-          cd plugin
-          wally install
-          cd ..
-
       - name: Build Plugin
         run: rojo build plugin --output Rojo.rbxm
 
@@ -94,6 +90,8 @@ jobs:
       BIN: rojo
     steps:
       - uses: actions/checkout@v3
+        with:
+          submodules: true
 
       - name: Get Version from Tag
         shell: bash
@@ -117,13 +115,6 @@ jobs:
           trust-check: false
           version: 'v0.2.6'
 
-      - name: Install packages
-        run: |
-          cd plugin
-          wally install
-          cd ..
-        shell: bash
-
       - name: Build Release
         run: cargo build --release --locked --verbose
         env:

.gitignore

@@ -13,9 +13,6 @@
 # Test places for the Roblox Studio Plugin
 /plugin/*.rbxlx
 
-# Packages for the Roblox Studio Plugin
-/plugin/*Packages
-
 # Roblox Studio holds 'lock' files on places
 *.rbxl.lock
 *.rbxlx.lock

.gitmodules

@@ -0,0 +1,15 @@
+[submodule "plugin/Packages/Roact"]
+	path = plugin/Packages/Roact
+	url = git@github.com:roblox/roact
+[submodule "plugin/Packages/Flipper"]
+	path = plugin/Packages/Flipper
+	url = git@github.com:reselim/flipper
+[submodule "plugin/Packages/Promise"]
+	path = plugin/Packages/Promise
+	url = git@github.com:evaera/roblox-lua-promise
+[submodule "plugin/Packages/t"]
+	path = plugin/Packages/t
+	url = git@github.com:osyrisrblx/t
+[submodule "plugin/Packages/TestEZ"]
+	path = plugin/Packages/TestEZ
+	url = git@github.com:roblox/testez

aftman.toml

@@ -1,5 +1,4 @@
 [tools]
-wally = "UpliftGames/wally@0.3.1"
 rojo = "rojo-rbx/rojo@7.3.0"
 selene = "Kampfkarren/selene@0.20.0"
 run-in-roblox = "rojo-rbx/run-in-roblox@0.3.0"

plugin/test-place.project.json

@@ -9,7 +9,7 @@
       },
 
       "Packages": {
-        "$path": "DevPackages"
+        "$path": "Packages"
       }
     },
 

plugin/wally.lock

@@ -1,33 +0,0 @@
-# This file is automatically @generated by Wally.
-# It is not intended for manual editing.
-registry = "test"
-
-[[package]]
-name = "evaera/promise"
-version = "4.0.0"
-dependencies = []
-
-[[package]]
-name = "osyrisrblx/t"
-version = "3.0.0"
-dependencies = []
-
-[[package]]
-name = "reselim/flipper"
-version = "2.0.0"
-dependencies = []
-
-[[package]]
-name = "roblox/roact"
-version = "1.4.4"
-dependencies = []
-
-[[package]]
-name = "roblox/testez"
-version = "0.4.1"
-dependencies = []
-
-[[package]]
-name = "rojo-rbx/rojo"
-version = "7.3.0"
-dependencies = [["Flipper", "reselim/flipper@2.0.0"], ["Promise", "evaera/promise@4.0.0"], ["Roact", "roblox/roact@1.4.4"], ["t", "osyrisrblx/t@3.0.0"]]

plugin/wally.toml

@@ -1,17 +0,0 @@
-[package]
-name = "rojo-rbx/rojo"
-description = "Rojo enables Roblox developers to use professional-grade software engineering tools"
-version = "7.3.0"
-license = "MPL-2.0"
-authors = ["LPGhatguy (https://lpg.space/)"]
-registry = "https://github.com/upliftgames/wally-index"
-realm = "shared"
-
-[dependencies]
-Flipper = "reselim/flipper@2.0.0"
-Promise = "evaera/promise@4.0.0"
-Roact = "roblox/roact@1.4.4"
-t = "osyrisrblx/t@3.0.0"
-
-[dev-dependencies]
-TestEZ = "roblox/testez@0.4.1"