ari-party/rojo
1
0
Fork 0
forked from rojo-rbx/rojo
Code Pull Requests Activity

Migrate DevSettings to PluginSettings for much better config flow (#572)

Browse Source 
* Add the devsetting config options into settings

* Create dropdown component and add setting controls

* Static dropdwon width and spin arrow

* Improve dropdown option contrast and border

* Forgot to make the settings page respect the static spacing, oops

* Smaller arrow

* Vert padding

* Reset option for settings

* Hide reset button when on default

* Respect the logLevel setting

* Portal settings out to external typechecking module

* Implement new configs using the new singleton Settings

* Remove DevSettings

* Update test runner to use new settings

* More helpful test failure output

* Support non-plugin environment

* Migrate dropdown to new packages system

* Clean up components a tad
This commit is contained in:
boatbomber
2022-08-20 19:39:34 -07:00
committed by GitHub
parent 17de912608
commit cdc972a5ce
12 changed files with 309 additions and 167 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
plugin/src/Types.lua
View File

@@ -1,6 +1,6 @@
local Packages = script.Parent.Parent.Packages
local t = require(Packages.t)
local DevSettings = require(script.Parent.DevSettings)
local Settings = require(script.Parent.Settings)
local strict = require(script.Parent.strict)
local RbxId = t.string
@@ -66,7 +66,7 @@ local ApiError = t.interface({
local function ifEnabled(innerCheck)
return function(...)
if DevSettings:shouldTypecheck() then
if Settings:get("typecheckingEnabled") then
return innerCheck(...)
else
return true