ari-party/rojo
1
0
Fork 0
forked from rojo-rbx/rojo
Code Pull Requests Activity

Improve error when file is not found

Browse Source
This commit is contained in:
Lucien Greathouse
2021-11-20 17:15:58 -05:00
parent 173dc12cb3
commit 8b54bf0ba1
1 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/snapshot_middleware/project.rs
View File

@@ -80,13 +80,13 @@ pub fn snapshot_project_node(
if let Some(path) = &node.path { if let Some(path) = &node.path {
// If the path specified in the project is relative, we assume it's // If the path specified in the project is relative, we assume it's
// relative to the folder that the project is in, project_folder. // relative to the folder that the project is in, project_folder.
let path = if path.is_relative() { let full_path = if path.is_relative() {
Cow::Owned(project_folder.join(path)) Cow::Owned(project_folder.join(path))
} else { } else {
Cow::Borrowed(path) Cow::Borrowed(path)
}; };
if let Some(snapshot) = snapshot_from_vfs(context, vfs, &path)? { if let Some(snapshot) = snapshot_from_vfs(context, vfs, &full_path)? {
class_name_from_path = Some(snapshot.class_name); class_name_from_path = Some(snapshot.class_name);
// Properties from the snapshot are pulled in unchanged, and // Properties from the snapshot are pulled in unchanged, and
@@ -107,9 +107,14 @@ pub fn snapshot_project_node(
// on. // on.
metadata = snapshot.metadata; metadata = snapshot.metadata;
} else { } else {
// TODO: Should this issue an error instead? anyhow::bail!(
log::warn!( "Rojo project referred to a file using $path that could not be turned into a Roblox Instance by Rojo.\n\
"$path referred to a path that could not be turned into an instance by Rojo" Check that the file exists and is a file type known by Rojo.\n\
\n\
Project path: {}\n\
File $path: {}",
project_path.display(),
path.display(),
); );
} }
} }