From 82ba583fa0ece1099cf15d14111c745841862e6c Mon Sep 17 00:00:00 2001 From: Lucien Greathouse Date: Sun, 10 Jun 2018 15:13:49 -0700 Subject: [PATCH] Fix incorrect synchronization for Plugin:_pull that would make polling flaky --- plugin/src/Plugin.lua | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/plugin/src/Plugin.lua b/plugin/src/Plugin.lua index 89c88117..11a65eac 100644 --- a/plugin/src/Plugin.lua +++ b/plugin/src/Plugin.lua @@ -289,9 +289,14 @@ function Plugin:syncIn() table.insert(routes, {name}) end - self:_pull(api, info.project, routes) + local pullSuccess, pullResult = self:_pull(api, info.project, routes):await() self._syncInProgress = false + + if not pullSuccess then + return Promise.reject(pullResult) + end + print("Rojo: Sync successful!") end) :catch(function(err)