diff --git a/CHANGELOG.md b/CHANGELOG.md index efc9405a..a18a3ab9 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,7 @@ # Rojo Changelog ## Unreleased Changes +* Fixed Rojo plugin failing to connect when project contains certain unreadable properties ([#848]) * Added popout diff visualizer for table properties like Attributes and Tags ([#834]) * Updated Theme to use Studio colors ([#838]) * Added experimental setting for Auto Connect in playtests ([#840]) @@ -55,6 +56,7 @@ [#834]: https://github.com/rojo-rbx/rojo/pull/834 [#838]: https://github.com/rojo-rbx/rojo/pull/838 [#840]: https://github.com/rojo-rbx/rojo/pull/840 +[#848]: https://github.com/rojo-rbx/rojo/pull/848 ## [7.4.0] - January 16, 2024 * Improved the visualization for array properties like Tags ([#829]) diff --git a/plugin/src/Reconciler/diff.lua b/plugin/src/Reconciler/diff.lua index e13b05c8..c87f899c 100644 --- a/plugin/src/Reconciler/diff.lua +++ b/plugin/src/Reconciler/diff.lua @@ -177,10 +177,8 @@ local function diff(instanceMap, virtualInstances, rootId) if err.kind == Error.UnknownProperty then Log.trace("Skipping unknown property {}.{}", err.details.className, err.details.propertyName) - elseif err.kind == Error.UnreadableProperty then - Log.trace("Skipping unreadable property {}.{}", err.details.className, err.details.propertyName) else - return false, err + Log.trace("Skipping unreadable property {}.{}", err.details.className, err.details.propertyName) end end end