From 5b22ef192e048d3ff8f542cbfeec786cb8f816f8 Mon Sep 17 00:00:00 2001 From: Micah Date: Tue, 1 Aug 2023 09:33:06 -0700 Subject: [PATCH] Don't override initial state for source diff view (#760) --- CHANGELOG.md | 2 ++ plugin/src/App/StatusPages/Confirming.lua | 2 +- plugin/src/App/StatusPages/Connected.lua | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index a4e2803a..0d4de214 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -23,6 +23,7 @@ * Add new plugin template to the `init` command ([#738]) * Added rich Source diffs in patch visualizer ([#748]) * Fix PatchTree performance issues ([#755]) +* Don't override the initial enabled state for source diffing ([#760]) [#745]: https://github.com/rojo-rbx/rojo/pull/745 [#668]: https://github.com/rojo-rbx/rojo/pull/668 @@ -46,6 +47,7 @@ [#738]: https://github.com/rojo-rbx/rojo/pull/738 [#748]: https://github.com/rojo-rbx/rojo/pull/748 [#755]: https://github.com/rojo-rbx/rojo/pull/755 +[#760]: https://github.com/rojo-rbx/rojo/pull/760 ## [7.3.0] - April 22, 2023 * Added `$attributes` to project format. ([#574]) diff --git a/plugin/src/App/StatusPages/Confirming.lua b/plugin/src/App/StatusPages/Confirming.lua index 4a258bbd..74c814a1 100644 --- a/plugin/src/App/StatusPages/Confirming.lua +++ b/plugin/src/App/StatusPages/Confirming.lua @@ -184,7 +184,7 @@ function ConfirmingPage:render() active = true, initDockState = Enum.InitialDockState.Float, - overridePreviousState = true, + overridePreviousState = false, floatingSize = Vector2.new(500, 350), minimumSize = Vector2.new(400, 250), diff --git a/plugin/src/App/StatusPages/Connected.lua b/plugin/src/App/StatusPages/Connected.lua index 12ba2fc1..27f4e7ca 100644 --- a/plugin/src/App/StatusPages/Connected.lua +++ b/plugin/src/App/StatusPages/Connected.lua @@ -400,7 +400,7 @@ function ConnectedPage:render() active = self.state.showingSourceDiff, initDockState = Enum.InitialDockState.Float, - overridePreviousState = true, + overridePreviousState = false, floatingSize = Vector2.new(500, 350), minimumSize = Vector2.new(400, 250),