ari-party/rojo
1
0
Fork 0
forked from rojo-rbx/rojo
Code Pull Requests Activity

Re-add the hack to write NeedsPivotMigration as false for models (#1027)

Browse Source
This commit is contained in:
Micah
2025-04-16 15:03:09 -07:00
committed by GitHub
parent a7a4f6d8f2
commit 3bac38ee34
21 changed files with 360 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
rojo-test/build-test-snapshots/end_to_end__tests__build__init_meta_class_name.snap
View File

@@ -6,6 +6,7 @@ expression: contents
<Item class="Model" referent="0">
<Properties>
<string name="Name">init_meta_class_name</string>
<bool name="NeedsPivotMigration">false</bool>
</Properties>
</Item>
</roblox>

2
rojo-test/build-test-snapshots/end_to_end__tests__build__rbxmx_in_folder.snap
View File

@@ -1,7 +1,6 @@
---
source: tests/tests/build.rs
expression: contents
---
<roblox version="4">
<Item class="Folder" referent="0">
@@ -25,6 +24,7 @@ expression: contents
<R21>0</R21>
<R22>1</R22>
</CoordinateFrame>
<bool name="NeedsPivotMigration">false</bool>
<Ref name="PrimaryPart">null</Ref>
<BinaryString name="Tags"></BinaryString>
</Properties>

2
rojo-test/build-test-snapshots/end_to_end__tests__build__unresolved_values.snap
View File

@@ -1,7 +1,6 @@
---
source: tests/tests/build.rs
expression: contents
---
<roblox version="4">
<Item class="DataModel" referent="0">
@@ -22,6 +21,7 @@ expression: contents
<Item class="Workspace" referent="2">
<Properties>
<string name="Name">Workspace</string>
<bool name="NeedsPivotMigration">false</bool>
</Properties>
<Item class="BoolValue" referent="3">
<Properties>

6
rojo-test/serve-test-snapshots/end_to_end__tests__serve__empty_json_model_all-2.snap
View File

@@ -1,7 +1,6 @@
---
source: tests/tests/serve.rs
expression: "read_response.intern_and_redact(&mut redactions, root_id)"
---
instances:
id-2:
@@ -22,7 +21,8 @@ instances:
ignoreUnknownInstances: false
Name: test
Parent: id-2
Properties: {}
Properties:
NeedsPivotMigration:
Bool: false
messageCursor: 1
sessionId: id-1

6
rojo-test/serve-test-snapshots/end_to_end__tests__serve__empty_json_model_subscribe.snap
View File

@@ -1,7 +1,6 @@
---
source: tests/tests/serve.rs
expression: "subscribe_response.intern_and_redact(&mut redactions, ())"
---
messageCursor: 1
messages:
@@ -14,8 +13,9 @@ messages:
ignoreUnknownInstances: false
Name: test
Parent: id-2
Properties: {}
Properties:
NeedsPivotMigration:
Bool: false
removed: []
updated: []
sessionId: id-1

64
rojo-test/serve-test-snapshots/end_to_end__tests__serve__model_pivot_migration_all-2.snap Normal file
View File

@@ -0,0 +1,64 @@
---
source: tests/tests/serve.rs
expression: "read_response.intern_and_redact(&mut redactions, root_id)"
---
instances:
id-2:
Children:
- id-3
ClassName: DataModel
Id: id-2
Metadata:
ignoreUnknownInstances: true
Name: pivot_migration
Parent: "00000000000000000000000000000000"
Properties: {}
id-3:
Children:
- id-4
- id-5
- id-6
ClassName: Workspace
Id: id-3
Metadata:
ignoreUnknownInstances: true
Name: Workspace
Parent: id-2
Properties:
NeedsPivotMigration:
Bool: false
id-4:
Children: []
ClassName: Model
Id: id-4
Metadata:
ignoreUnknownInstances: true
Name: Model
Parent: id-3
Properties:
NeedsPivotMigration:
Bool: false
id-5:
Children: []
ClassName: Tool
Id: id-5
Metadata:
ignoreUnknownInstances: false
Name: Tool
Parent: id-3
Properties:
NeedsPivotMigration:
Bool: false
id-6:
Children: []
ClassName: Actor
Id: id-6
Metadata:
ignoreUnknownInstances: true
Name: Actor
Parent: id-3
Properties:
NeedsPivotMigration:
Bool: false
messageCursor: 1
sessionId: id-1

27
rojo-test/serve-test-snapshots/end_to_end__tests__serve__model_pivot_migration_all.snap Normal file
View File

@@ -0,0 +1,27 @@
---
source: tests/tests/serve.rs
expression: "subscribe_response.intern_and_redact(&mut redactions, ())"
---
messageCursor: 1
messages:
- added:
id-6:
Children: []
ClassName: Actor
Id: id-6
Metadata:
ignoreUnknownInstances: true
Name: Actor
Parent: id-3
Properties:
NeedsPivotMigration:
Bool: false
removed: []
updated:
- changedClassName: ~
changedMetadata:
ignoreUnknownInstances: true
changedName: ~
changedProperties: {}
id: id-3
sessionId: id-1

52
rojo-test/serve-test-snapshots/end_to_end__tests__serve__pivot_migration_all.snap Normal file
View File

@@ -0,0 +1,52 @@
---
source: tests/tests/serve.rs
expression: "read_response.intern_and_redact(&mut redactions, root_id)"
---
instances:
id-2:
Children:
- id-3
ClassName: DataModel
Id: id-2
Metadata:
ignoreUnknownInstances: true
Name: pivot_migration
Parent: "00000000000000000000000000000000"
Properties: {}
id-3:
Children:
- id-4
- id-5
ClassName: Workspace
Id: id-3
Metadata:
ignoreUnknownInstances: true
Name: Workspace
Parent: id-2
Properties:
NeedsPivotMigration:
Bool: false
id-4:
Children: []
ClassName: Model
Id: id-4
Metadata:
ignoreUnknownInstances: true
Name: Model
Parent: id-3
Properties:
NeedsPivotMigration:
Bool: false
id-5:
Children: []
ClassName: Tool
Id: id-5
Metadata:
ignoreUnknownInstances: false
Name: Tool
Parent: id-3
Properties:
NeedsPivotMigration:
Bool: false
messageCursor: 0
sessionId: id-1

13
rojo-test/serve-test-snapshots/end_to_end__tests__serve__pivot_migration_info.snap Normal file
View File

@@ -0,0 +1,13 @@
---
source: tests/tests/serve.rs
expression: redactions.redacted_yaml(info)
---
expectedPlaceIds: ~
gameId: ~
placeId: ~
projectName: pivot_migration
protocolVersion: 4
rootInstanceId: id-2
serverVersion: "[server-version]"
sessionId: id-1
unexpectedPlaceIds: ~

9
rojo-test/serve-test-snapshots/end_to_end__tests__serve__ref_properties_all-2.snap
View File

@@ -31,6 +31,8 @@ instances:
Attributes:
Rojo_Target_PrimaryPart:
String: project target
NeedsPivotMigration:
Bool: false
PrimaryPart:
Ref: id-9
id-2:
@@ -55,7 +57,9 @@ instances:
ignoreUnknownInstances: true
Name: Workspace
Parent: id-2
Properties: {}
Properties:
NeedsPivotMigration:
Bool: false
id-4:
Children: []
ClassName: ObjectValue
@@ -124,6 +128,8 @@ instances:
Attributes:
Rojo_Target_PrimaryPart:
String: model target 2
NeedsPivotMigration:
Bool: false
PrimaryPart:
Ref: id-7
id-9:
@@ -138,4 +144,3 @@ instances:
Properties: {}
messageCursor: 1
sessionId: id-1

7
rojo-test/serve-test-snapshots/end_to_end__tests__serve__ref_properties_all.snap
View File

@@ -40,7 +40,9 @@ instances:
ignoreUnknownInstances: true
Name: Workspace
Parent: id-2
Properties: {}
Properties:
NeedsPivotMigration:
Bool: false
id-4:
Children: []
ClassName: ObjectValue
@@ -104,6 +106,8 @@ instances:
Attributes:
Rojo_Target_PrimaryPart:
String: model target
NeedsPivotMigration:
Bool: false
PrimaryPart:
Ref: id-7
id-9:
@@ -118,4 +122,3 @@ instances:
Properties: {}
messageCursor: 0
sessionId: id-1

10
rojo-test/serve-test-snapshots/end_to_end__tests__serve__ref_properties_patch_update_all-2.snap
View File

@@ -40,7 +40,9 @@ instances:
ignoreUnknownInstances: true
Name: Workspace
Parent: id-2
Properties: {}
Properties:
NeedsPivotMigration:
Bool: false
id-4:
Children: []
ClassName: ObjectValue
@@ -104,8 +106,12 @@ instances:
Attributes:
Rojo_Target_PrimaryPart:
String: model target
NeedsPivotMigration:
Bool: false
PrimaryPart:
Ref: id-7
Scale:
Float32: 1
id-9:
Children:
- id-10
@@ -116,5 +122,5 @@ instances:
Name: ProjectTarget
Parent: id-3
Properties: {}
messageCursor: 0
messageCursor: 1
sessionId: id-1

6
rojo-test/serve-test-snapshots/end_to_end__tests__serve__ref_properties_patch_update_all.snap
View File

@@ -40,7 +40,9 @@ instances:
ignoreUnknownInstances: true
Name: Workspace
Parent: id-2
Properties: {}
Properties:
NeedsPivotMigration:
Bool: false
id-4:
Children: []
ClassName: ObjectValue
@@ -104,6 +106,8 @@ instances:
Attributes:
Rojo_Target_PrimaryPart:
String: model target
NeedsPivotMigration:
Bool: false
PrimaryPart:
Ref: id-7
id-9:

17
rojo-test/serve-test-snapshots/end_to_end__tests__serve__ref_properties_patch_update_subscribe.snap Normal file
View File

@@ -0,0 +1,17 @@
---
source: tests/tests/serve.rs
expression: "subscribe_response.intern_and_redact(&mut redactions, ())"
---
messageCursor: 1
messages:
- added: {}
removed: []
updated:
- changedClassName: ~
changedMetadata: ~
changedName: ~
changedProperties:
Scale:
Float32: 1
id: id-8
sessionId: id-1

3
rojo-test/serve-test-snapshots/end_to_end__tests__serve__ref_properties_subscribe.snap
View File

@@ -18,6 +18,8 @@ messages:
Attributes:
Rojo_Target_PrimaryPart:
String: project target
NeedsPivotMigration:
Bool: false
PrimaryPart:
Ref: id-9
removed: []
@@ -43,4 +45,3 @@ messages:
PrimaryPart: ~
id: id-8
sessionId: id-1

3
rojo-test/serve-tests/pivot_migration/Tool.model.json Normal file
View File

@@ -0,0 +1,3 @@
{
"className": "Tool"
}

14
rojo-test/serve-tests/pivot_migration/default.project.json Normal file
View File

@@ -0,0 +1,14 @@
{
"name": "pivot_migration",
"tree": {
"$className": "DataModel",
"Workspace": {
"Model": {
"$className": "Model"
},
"Tool": {
"$path": "Tool.model.json"
}
}
}
}