From 31ec216a95ccae1080ca1211e0370a72f3748e81 Mon Sep 17 00:00:00 2001
From: quaywinn <62822174+gaymeowing@users.noreply.github.com>
Date: Tue, 18 Nov 2025 21:49:52 -0500
Subject: [PATCH] Remove pairs() and ipairs() (#1150)

---
 plugin/fmt/init.lua                            | 4 ++--
 plugin/src/App/bindingUtil.lua                 | 2 +-
 plugin/src/Assets.lua                          | 2 +-
 plugin/src/ChangeBatcher/createPatchSet.lua    | 2 +-
 plugin/src/ChangeBatcher/encodePatchUpdate.lua | 2 +-
 plugin/src/Dictionary.lua                      | 2 +-
 plugin/src/InstanceMap.lua                     | 6 +++---
 plugin/src/Reconciler/diff.lua                 | 4 ++--
 plugin/src/Reconciler/diff.spec.lua            | 2 +-
 plugin/src/Reconciler/hydrate.lua              | 2 +-
 plugin/src/Reconciler/reify.lua                | 2 +-
 plugin/src/Reconciler/reify.spec.lua           | 2 +-
 plugin/src/preloadAssets.lua                   | 2 +-
 13 files changed, 17 insertions(+), 17 deletions(-)

diff --git a/plugin/fmt/init.lua b/plugin/fmt/init.lua
index 7ef24d8e..403538f4 100644
--- a/plugin/fmt/init.lua
+++ b/plugin/fmt/init.lua
@@ -25,7 +25,7 @@
 local function defaultTableDebug(buffer, input)
 	buffer:writeRaw("{")
 
-	for key, value in pairs(input) do
+	for key, value in input do
 		buffer:write("[{:?}] = {:?}", key, value)
 
 		if next(input, key) ~= nil then
@@ -50,7 +50,7 @@ local function defaultTableDebugExtended(buffer, input)
 	buffer:writeLineRaw("{")
 	buffer:indent()
 
-	for key, value in pairs(input) do
+	for key, value in input do
 		buffer:writeLine("[{:?}] = {:#?},", key, value)
 	end
 
diff --git a/plugin/src/App/bindingUtil.lua b/plugin/src/App/bindingUtil.lua
index 3797871e..60d3876f 100644
--- a/plugin/src/App/bindingUtil.lua
+++ b/plugin/src/App/bindingUtil.lua
@@ -44,7 +44,7 @@ end
 local function blendAlpha(alphaValues)
 	local alpha = 0
 
-	for _, value in pairs(alphaValues) do
+	for _, value in alphaValues do
 		alpha = alpha + (1 - alpha) * value
 	end
 
diff --git a/plugin/src/Assets.lua b/plugin/src/Assets.lua
index e48c1217..c2c168ee 100644
--- a/plugin/src/Assets.lua
+++ b/plugin/src/Assets.lua
@@ -74,7 +74,7 @@ local Assets = {
 local function guardForTypos(name, map)
 	strict(name, map)
 
-	for key, child in pairs(map) do
+	for key, child in map do
 		if type(child) == "table" then
 			guardForTypos(("%s.%s"):format(name, key), child)
 		end
diff --git a/plugin/src/ChangeBatcher/createPatchSet.lua b/plugin/src/ChangeBatcher/createPatchSet.lua
index d418bb4d..5502d0d6 100644
--- a/plugin/src/ChangeBatcher/createPatchSet.lua
+++ b/plugin/src/ChangeBatcher/createPatchSet.lua
@@ -15,7 +15,7 @@ local encodePatchUpdate = require(script.Parent.encodePatchUpdate)
 return function(instanceMap, propertyChanges)
 	local patch = PatchSet.newEmpty()
 
-	for instance, properties in pairs(propertyChanges) do
+	for instance, properties in propertyChanges do
 		local instanceId = instanceMap.fromInstances[instance]
 
 		if instanceId == nil then
diff --git a/plugin/src/ChangeBatcher/encodePatchUpdate.lua b/plugin/src/ChangeBatcher/encodePatchUpdate.lua
index 36888a88..5076fea2 100644
--- a/plugin/src/ChangeBatcher/encodePatchUpdate.lua
+++ b/plugin/src/ChangeBatcher/encodePatchUpdate.lua
@@ -10,7 +10,7 @@ return function(instance, instanceId, properties)
 		changedProperties = {},
 	}
 
-	for propertyName in pairs(properties) do
+	for propertyName in properties do
 		if propertyName == "Name" then
 			update.changedName = instance.Name
 		else
diff --git a/plugin/src/Dictionary.lua b/plugin/src/Dictionary.lua
index 93d4ad91..09b878a6 100644
--- a/plugin/src/Dictionary.lua
+++ b/plugin/src/Dictionary.lua
@@ -14,7 +14,7 @@ local function merge(...)
 		local source = select(i, ...)
 
 		if source ~= nil then
-			for key, value in pairs(source) do
+			for key, value in source do
 				if value == None then
 					output[key] = nil
 				else
diff --git a/plugin/src/InstanceMap.lua b/plugin/src/InstanceMap.lua
index 76754fef..250f41e6 100644
--- a/plugin/src/InstanceMap.lua
+++ b/plugin/src/InstanceMap.lua
@@ -63,7 +63,7 @@ function InstanceMap:__fmtDebug(output)
 	-- Collect all of the entries in the InstanceMap and sort them by their
 	-- label, which helps make our output deterministic.
 	local entries = {}
-	for id, instance in pairs(self.fromIds) do
+	for id, instance in self.fromIds do
 		local label = string.format("%s (%s)", instance:GetFullName(), instance.ClassName)
 
 		table.insert(entries, { id, label })
@@ -73,7 +73,7 @@ function InstanceMap:__fmtDebug(output)
 		return a[2] < b[2]
 	end)
 
-	for _, entry in ipairs(entries) do
+	for _, entry in entries do
 		output:writeLine("{}: {}", entry[1], entry[2])
 	end
 
@@ -227,7 +227,7 @@ function InstanceMap:__disconnectSignals(instance)
 		-- around the extra table. ValueBase objects force us to use multiple
 		-- signals to emulate the Instance.Changed event, however.
 		if typeof(signals) == "table" then
-			for _, signal in ipairs(signals) do
+			for _, signal in signals do
 				signal:Disconnect()
 			end
 		else
diff --git a/plugin/src/Reconciler/diff.lua b/plugin/src/Reconciler/diff.lua
index 4a1d9361..fb4c79d0 100644
--- a/plugin/src/Reconciler/diff.lua
+++ b/plugin/src/Reconciler/diff.lua
@@ -38,13 +38,13 @@ local function trueEquals(a, b): boolean
 	-- For tables, try recursive deep equality
 	if typeA == "table" and typeB == "table" then
 		local checkedKeys = {}
-		for key, value in pairs(a) do
+		for key, value in a do
 			checkedKeys[key] = true
 			if not trueEquals(value, b[key]) then
 				return false
 			end
 		end
-		for key, value in pairs(b) do
+		for key, value in b do
 			if checkedKeys[key] then
 				continue
 			end
diff --git a/plugin/src/Reconciler/diff.spec.lua b/plugin/src/Reconciler/diff.spec.lua
index 451540b3..69279ef5 100644
--- a/plugin/src/Reconciler/diff.spec.lua
+++ b/plugin/src/Reconciler/diff.spec.lua
@@ -14,7 +14,7 @@ return function()
 	local function size(dict)
 		local len = 0
 
-		for _ in pairs(dict) do
+		for _ in dict do
 			len = len + 1
 		end
 
diff --git a/plugin/src/Reconciler/hydrate.lua b/plugin/src/Reconciler/hydrate.lua
index 353e7366..d7798160 100644
--- a/plugin/src/Reconciler/hydrate.lua
+++ b/plugin/src/Reconciler/hydrate.lua
@@ -26,7 +26,7 @@ local function hydrate(instanceMap, virtualInstances, rootId, rootInstance)
 	for _, childId in ipairs(virtualInstance.Children) do
 		local virtualChild = virtualInstances[childId]
 
-		for childIndex, childInstance in ipairs(existingChildren) do
+		for childIndex, childInstance in existingChildren do
 			if not isExistingChildVisited[childIndex] then
 				-- We guard accessing Name and ClassName in order to avoid
 				-- tripping over children of DataModel that Rojo won't have
diff --git a/plugin/src/Reconciler/reify.lua b/plugin/src/Reconciler/reify.lua
index 586dd342..de7725ce 100644
--- a/plugin/src/Reconciler/reify.lua
+++ b/plugin/src/Reconciler/reify.lua
@@ -126,7 +126,7 @@ function applyDeferredRefs(instanceMap, deferredRefs, unappliedPatch)
 		})
 	end
 
-	for _, entry in ipairs(deferredRefs) do
+	for _, entry in deferredRefs do
 		local _, refId = next(entry.virtualValue)
 
 		if refId == nil then
diff --git a/plugin/src/Reconciler/reify.spec.lua b/plugin/src/Reconciler/reify.spec.lua
index 3c8750fa..20f363d7 100644
--- a/plugin/src/Reconciler/reify.spec.lua
+++ b/plugin/src/Reconciler/reify.spec.lua
@@ -12,7 +12,7 @@ return function()
 	local function size(dict)
 		local len = 0
 
-		for _ in pairs(dict) do
+		for _ in dict do
 			len = len + 1
 		end
 
diff --git a/plugin/src/preloadAssets.lua b/plugin/src/preloadAssets.lua
index 1cf9b2d8..47c6d40b 100644
--- a/plugin/src/preloadAssets.lua
+++ b/plugin/src/preloadAssets.lua
@@ -9,7 +9,7 @@ local gatherAssetUrlsRecursive
 function gatherAssetUrlsRecursive(currentTable, currentUrls)
 	currentUrls = currentUrls or {}
 
-	for _, value in pairs(currentTable) do
+	for _, value in currentTable do
 		if typeof(value) == "string" then
 			table.insert(currentUrls, value)
 		elseif typeof(value) == "table" then